Feed Advanced Search

Jul 4 2023

waqar added a comment to T12103: KTextEditor.

There are some minor TODOs here and there still left. I will try addressing some of those this week.

Jul 4 2023, 5:57 AM · KF6

Mar 22 2022

waqar closed T10863: When writing in Kate in a RTL language, Kate acts weird as Resolved.
Mar 22 2022, 6:07 PM · KTextEditor, Kate

Feb 10 2021

waqar added a comment to T9986: Delete "What's This" inline help functionality.

Thanks! I might have already done more work in that direction if there wasn't this task with many comments pushing towards removing contextual help in general

Feb 10 2021, 7:18 PM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG
waqar added a comment to T9986: Delete "What's This" inline help functionality.

The UI, yes, to the extent possible. Which is often not the case because there is simply no place for additional text (if that's what you were suggesting) and even if there were it would lead to a lot of visual clutter.

Feb 10 2021, 12:20 PM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG

Feb 6 2021

waqar added a comment to T9986: Delete "What's This" inline help functionality.

I think a solution like https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/51 would be a good fit for the Kate/KTextEditor config dialog.

Feb 6 2021, 8:41 PM · Goal: Consistency, KDE Applications, Plasma, KF6, VDG

Jan 2 2021

waqar added a watcher for Kate: waqar.
Jan 2 2021, 6:56 PM

Dec 11 2020

waqar added a comment to T10863: When writing in Kate in a RTL language, Kate acts weird.
Dec 11 2020, 10:48 AM · KTextEditor, Kate
waqar added a project to T10863: When writing in Kate in a RTL language, Kate acts weird: KTextEditor.
Dec 11 2020, 10:25 AM · KTextEditor, Kate
waqar updated subscribers of T10863: When writing in Kate in a RTL language, Kate acts weird.
Dec 11 2020, 10:25 AM · KTextEditor, Kate
waqar added a comment to T10863: When writing in Kate in a RTL language, Kate acts weird.

I just stumbled upon this bug (issue #1) recently and it is quite annoying. I believe this is a bug in Kate, and not in Qt and it triggers with the space character. So, if you are writing a line which hits the border and wraps, it wont have this issue unless the last character before the wrap was a space.

Dec 11 2020, 10:24 AM · KTextEditor, Kate

Apr 11 2020

waqar added a comment to D28406: Fix sonnet autodetect test failure.

@waqar ping? What do you think about my suggestion? If you agree, can you update the patch?

Apr 11 2020, 12:09 PM · Frameworks

Mar 29 2020

waqar added a comment to D28406: Fix sonnet autodetect test failure.

I'm no expert in this stuff, but here's my feedback

  1. on my own system (!= CI), all three tests were failing before, due to finding en_AU-variant_1, en_AU-variant_1 and "".
  2. now the test passes locally, but because all tests are skipped SKIP : SonnetAutoDetectTest::autodetect(English) en_US-large not available SKIP : SonnetAutoDetectTest::autodetect(German) de_DE_frami not available SKIP : SonnetAutoDetectTest::autodetect(Malayam) ml_IN not available What's en_US-large? Can we at least check that we get en_US-*?
Mar 29 2020, 7:41 PM · Frameworks
waqar added inline comments to D28406: Fix sonnet autodetect test failure.
Mar 29 2020, 7:30 PM · Frameworks
waqar added a comment to D25495: Fix Sonnet autodetect failing on Indian langs.

Please have a look and submit fixes.

Mar 29 2020, 1:52 PM · Frameworks
waqar requested review of D28406: Fix sonnet autodetect test failure.
Mar 29 2020, 1:50 PM · Frameworks
waqar added a comment to D25495: Fix Sonnet autodetect failing on Indian langs.
Mar 29 2020, 12:32 PM · Frameworks

Mar 24 2020

waqar added a comment to D25495: Fix Sonnet autodetect failing on Indian langs.

I tried but I don't have the access.

Mar 24 2020, 3:17 PM · Frameworks
waqar added a comment to D25495: Fix Sonnet autodetect failing on Indian langs.
In D25495#633551, @apol wrote:

Whatever, let's go with this and we can learn along the way.

Sorry it took so long.

Mar 24 2020, 2:55 PM · Frameworks
waqar added inline comments to D25495: Fix Sonnet autodetect failing on Indian langs.
Mar 24 2020, 2:52 PM · Frameworks

Feb 10 2020

waqar added a comment to D25495: Fix Sonnet autodetect failing on Indian langs.
In D25495#608582, @apol wrote:

This patch makes it do all the languages identified by identify + all the languages supported by the script. This could mean lots of languages for some scripts...

Feb 10 2020, 5:36 AM · Frameworks
waqar added inline comments to D25495: Fix Sonnet autodetect failing on Indian langs.
Feb 10 2020, 5:23 AM · Frameworks

Feb 7 2020

waqar added a comment to D25495: Fix Sonnet autodetect failing on Indian langs.

ping

Feb 7 2020, 4:39 PM · Frameworks

Jan 26 2020

waqar added inline comments to D26346: Sonnet: Fix returning from GuessLanguagePrivate::guessFromTrigrams.
Jan 26 2020, 4:24 PM · Frameworks

Jan 3 2020

waqar added inline comments to D25495: Fix Sonnet autodetect failing on Indian langs.
Jan 3 2020, 4:27 PM · Frameworks
waqar updated the diff for D25495: Fix Sonnet autodetect failing on Indian langs.

Apply requested changes

Jan 3 2020, 1:22 PM · Frameworks

Jan 1 2020

waqar updated the diff for D25495: Fix Sonnet autodetect failing on Indian langs.

Apply requested changes

Jan 1 2020, 4:26 PM · Frameworks
waqar added a comment to D25495: Fix Sonnet autodetect failing on Indian langs.

Hi,
First of all thanks for reviewing.

Jan 1 2020, 3:58 PM · Frameworks

Dec 16 2019

waqar abandoned D25530: Sonnet: Add locales that are missing in QLocale.
Dec 16 2019, 6:30 PM · Frameworks
waqar added a comment to D25495: Fix Sonnet autodetect failing on Indian langs.

ping

Dec 16 2019, 6:22 PM · Frameworks

Nov 30 2019

waqar added a comment to D25530: Sonnet: Add locales that are missing in QLocale.
Nov 30 2019, 10:13 AM · Frameworks

Nov 29 2019

waqar added a comment to D25530: Sonnet: Add locales that are missing in QLocale.

Yes, I think so too.

Nov 29 2019, 5:14 PM · Frameworks

Nov 28 2019

waqar added a comment to D25530: Sonnet: Add locales that are missing in QLocale.

With no respect for your lack of being subtle

Nov 28 2019, 7:25 AM · Frameworks

Nov 27 2019

waqar updated the diff for D25530: Sonnet: Add locales that are missing in QLocale.

Add test for iso code to language names

Nov 27 2019, 8:32 AM · Frameworks
waqar added a comment to D25530: Sonnet: Add locales that are missing in QLocale.

Sorry but i don't think this is an acceptable solution,

Nov 27 2019, 5:06 AM · Frameworks

Nov 26 2019

waqar added inline comments to D25530: Sonnet: Add locales that are missing in QLocale.
Nov 26 2019, 3:37 PM · Frameworks
waqar added inline comments to D25530: Sonnet: Add locales that are missing in QLocale.
Nov 26 2019, 6:59 AM · Frameworks
waqar added a comment to D25530: Sonnet: Add locales that are missing in QLocale.

Any reason we particularly need this here instead of improving Qt?

Nov 26 2019, 4:31 AM · Frameworks

Nov 25 2019

waqar updated the diff for D25530: Sonnet: Add locales that are missing in QLocale.

Remove accent from Росси́я

Nov 25 2019, 6:06 PM · Frameworks
waqar requested review of D25530: Sonnet: Add locales that are missing in QLocale.
Nov 25 2019, 4:46 PM · Frameworks
waqar updated the diff for D25495: Fix Sonnet autodetect failing on Indian langs.

Remove unused includes

Nov 25 2019, 1:58 PM · Frameworks
waqar updated the diff for D25495: Fix Sonnet autodetect failing on Indian langs.

Update copyright

Nov 25 2019, 1:54 PM · Frameworks
waqar updated the diff for D25495: Fix Sonnet autodetect failing on Indian langs.

Add Test for autodetection

Nov 25 2019, 1:50 PM · Frameworks
waqar updated the diff for D25495: Fix Sonnet autodetect failing on Indian langs.

Add test for autodetection

Nov 25 2019, 1:47 PM · Frameworks

Nov 24 2019

waqar updated the diff for D25495: Fix Sonnet autodetect failing on Indian langs.

Revert a change, as autodetection fails for languages with similar scripts

Nov 24 2019, 3:11 PM · Frameworks
waqar updated the summary of D25495: Fix Sonnet autodetect failing on Indian langs.
Nov 24 2019, 7:47 AM · Frameworks

Nov 23 2019

waqar updated the diff for D25495: Fix Sonnet autodetect failing on Indian langs.

Fix Sonnet autodetect completely failing when no trigrams found

Nov 23 2019, 6:48 PM · Frameworks
waqar updated the summary of D25495: Fix Sonnet autodetect failing on Indian langs.
Nov 23 2019, 6:25 PM · Frameworks
waqar requested review of D25495: Fix Sonnet autodetect failing on Indian langs.
Nov 23 2019, 6:22 PM · Frameworks
waqar requested review of D25492: Remove a redundant check.
Nov 23 2019, 4:21 PM · Frameworks