Please call the functions AutoRotate. I failed to name it consistently in the code until now but let's go with AutoRotate from now on (and I will try to rename it where I accidentally said AutoRotation in some form). Reasons are that it's shorter and when I googled it I found only one technical document. Was for Android and called the feature that way.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Mar 22 2020
Do you have a script you run for that? Can you share it? Thanks.
Mar 19 2020
Mar 18 2020
So I think of two things to consider:
- How is the overall interaction? Do we want something in line with other systems? Then we should have a lock/unlock rotation workflow where the current rotation orientation is made permanent until the icon is tapped again. Android and GNOME do it like this.
- To make this consistent with the KScreen KCM the values should be written to the control file. I.e. your KScreenDaemon::setAutoRotation method should call into ControlConfig::setAutoRotate. Then it would just change for example when you lock the rotation from auto to manual and the current rotation value is set anyway.
Mar 17 2020
In D28081#628985, @davidedmundson wrote:Can we use categorised logging please.
Yea, but I haven't seen any categorized logging in KScreenLocker so I opted for now with non-categorized logging as the rest of the code does. The category logging should be introduced for sure in another patch though (and then all debug messages converted to categorized logging at once).
But general +1
In D27675#629182, @dvratil wrote:As you described, the system makes sense on X11 where you get something like HDMI-1 (Sony GigaTV-12345) so you see which device it is and what physical output it's connected to. Since KWin does not use to output names but only the names of the actually connected devices, the needed behavior is different.
I don't know if it's safe/feasible to change this on KWin side or not.
Thanks, so I'm talking about this line:
[15:31:16.521] kscreen-console(422251:422251) unknown: Device ID: "xrandr-Eizo Nanao Corporation-DP-7-EV2736W/96211045"
Mar 16 2020
Rebase
else case
Mar 8 2020
Ok, I see the issue. The question is if Vendor Model is not a bit stupid as a name for an output and if KWin/KWayland should not be a bit more intelligent about choosing a name. Then it could make sense again to have (Vendor model) appended afterwards. For example I have here a monitor for testing which is called on the website: PROLITE XUB2395WSU-B1. But KWin returns as Vendor "IVM" and as name "DP-1-PL2395W/11638JJ60250".
Is this now a bug fix or a feature? I would call it a refactor since there is no regression or prior bug and neither does it add a new feature. The feature was added in libkscreen. And please don't say refactor: fix... How about refactor: incorporate prior libkscreen EDID changes?
The idea to parse on the backend side is sound. Can you paste the output you get in a Wayland session? For me it shows the XWayland EDID of the outputs.
Mar 4 2020
Depends on if you use in the end arc. Then it's given by the Phab diff title.
Mar 3 2020
I am currently working on some projects. But if you don't hear till Sunday from me about this, ping me.
Feb 28 2020
Feb 26 2020
Do you have an example? Name the product. I know it should be easy technically, but my question is if it makes sense.
Do you have an example in the wild where the "default resolution" should be something else than the one with highest pixel count?
Can you give an explicit example?
Nice tight implementation.
Feb 25 2020
Feb 24 2020
Thanks. This m_isValid variable was really uselsess. ;)
Feb 21 2020
Thanks, but the commit message in wrong as the type must be test since this is a fix to an autotest. And the scope autotest does not exist. See https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md
Please follow commit message guideline.
It would be nice if I get at least 24 hours to review patches in KScreen/libkscreen. Thanks for the patch.
Feb 17 2020
Feb 13 2020
Yea, but sadly I have already committed it: https://cgit.kde.org/libkscreen.git/commit/?id=274d94ed645387b29386daa077b2cb6a3dafbeff
True, thanks anyway. You can ask for commit rights by https://community.kde.org/Infrastructure/Get_a_Developer_Account
Do you have commit rights? Otherwise I need your name and email for author information.
In D27383#611101, @z3ntu wrote:Of the four scopes (api, kwayland, qscreen & randr) I have no idea where to put this in. If you have a suggestion, I can update the commit message.
Please respect the Commit Message Guideline when pushing the change:
https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md#n22
Jan 16 2020
Jan 15 2020
- Init tablet before starting KWayland timer