Feed Advanced Search

Mar 22 2020

romangg requested changes to D28115: feat(kded): add a dbus method to lock current rotation.

Please call the functions AutoRotate. I failed to name it consistently in the code until now but let's go with AutoRotate from now on (and I will try to rename it where I accidentally said AutoRotation in some form). Reasons are that it's shorter and when I googled it I found only one technical document. Was for Android and called the feature that way.

Mar 22 2020, 2:55 PM · Plasma
romangg committed R104:d6d02319b172: build: ignore clang-format file (authored by romangg).
build: ignore clang-format file
Mar 22 2020, 1:55 PM
romangg added a comment to T11550: Add SPDX License markers.

Do you have a script you run for that? Can you share it? Thanks.

Mar 22 2020, 1:34 PM · KF6

Mar 19 2020

romangg committed R104:951f6bc4703d: docs: update commit message guideline version (authored by romangg).
docs: update commit message guideline version
Mar 19 2020, 2:47 PM
romangg committed R110:990a50c80e83: docs: update commit message guideline version (authored by romangg).
docs: update commit message guideline version
Mar 19 2020, 2:46 PM
romangg committed R104:a4f71462f40a: Revert "GIT_SILENT: Ignore some autogenerate files + build dir" (authored by romangg).
Revert "GIT_SILENT: Ignore some autogenerate files + build dir"
Mar 19 2020, 2:26 PM
romangg added a reverting change for R104:d48d3c787316: GIT_SILENT: Ignore some autogenerate files + build dir: R104:a4f71462f40a: Revert "GIT_SILENT: Ignore some autogenerate files + build dir".
Mar 19 2020, 2:26 PM
romangg added a reverting change for R110:75797e162b4c: GIT_SILENT: Ignore some autogenerate files + build dir: R110:9fd1f8d44455: Revert "GIT_SILENT: Ignore some autogenerate files + build dir".
Mar 19 2020, 2:25 PM
romangg committed R110:9fd1f8d44455: Revert "GIT_SILENT: Ignore some autogenerate files + build dir" (authored by romangg).
Revert "GIT_SILENT: Ignore some autogenerate files + build dir"
Mar 19 2020, 2:25 PM

Mar 18 2020

romangg added inline comments to D28085: Adapt to new KScreenLocker API.
Mar 18 2020, 11:10 PM · KWin
romangg awarded D28033: Create ExpandableListItem a Like token.
Mar 18 2020, 3:19 PM · Frameworks
romangg added a comment to D28115: feat(kded): add a dbus method to lock current rotation.

So I think of two things to consider:

  • How is the overall interaction? Do we want something in line with other systems? Then we should have a lock/unlock rotation workflow where the current rotation orientation is made permanent until the icon is tapped again. Android and GNOME do it like this.
  • To make this consistent with the KScreen KCM the values should be written to the control file. I.e. your KScreenDaemon::setAutoRotation method should call into ControlConfig::setAutoRotate. Then it would just change for example when you lock the rotation from auto to manual and the current rotation value is set anyway.
Mar 18 2020, 8:32 AM · Plasma
romangg committed R110:6ba447e9e59d: fix: transfer tablet mode properties (authored by romangg).
fix: transfer tablet mode properties
Mar 18 2020, 1:40 AM
romangg closed D28106: fix: transfer tablet mode properties.
Mar 18 2020, 1:40 AM · Plasma

Mar 17 2020

romangg requested review of D28106: fix: transfer tablet mode properties.
Mar 17 2020, 6:08 PM · Plasma
romangg added a comment to D28081: Populate Greeter process exit stderr.

Can we use categorised logging please.

Yea, but I haven't seen any categorized logging in KScreenLocker so I opted for now with non-categorized logging as the rest of the code does. The category logging should be introduced for sure in another patch though (and then all debug messages converted to categorized logging at once).

But general +1

Mar 17 2020, 3:14 PM · Plasma
romangg added a comment to D27675: feat: avoid duplicated text when assembling user-facing output names.

As you described, the system makes sense on X11 where you get something like HDMI-1 (Sony GigaTV-12345) so you see which device it is and what physical output it's connected to. Since KWin does not use to output names but only the names of the actually connected devices, the needed behavior is different.

I don't know if it's safe/feasible to change this on KWin side or not.

Mar 17 2020, 3:06 PM · Plasma
romangg accepted D27677: refactor: incorporate prior libkscreen EDID changes.
Mar 17 2020, 3:01 PM · Plasma
romangg added a comment to D10042: feat: parse EDID on the backend side.

Thanks, so I'm talking about this line:

[15:31:16.521] kscreen-console(422251:422251) unknown: 	Device ID:  "xrandr-Eizo Nanao Corporation-DP-7-EV2736W/96211045"
Mar 17 2020, 3:00 PM · Plasma
romangg added inline comments to D28082: Take file descriptor only instead of whole KWayland Display.
Mar 17 2020, 3:26 AM · Plasma
romangg added inline comments to D28082: Take file descriptor only instead of whole KWayland Display.
Mar 17 2020, 3:23 AM · Plasma
romangg added inline comments to D28085: Adapt to new KScreenLocker API.
Mar 17 2020, 12:48 AM · KWin
romangg added inline comments to D28082: Take file descriptor only instead of whole KWayland Display.
Mar 17 2020, 12:41 AM · Plasma

Mar 16 2020

romangg added a dependency for D28085: Adapt to new KScreenLocker API: D28082: Take file descriptor only instead of whole KWayland Display.
Mar 16 2020, 10:03 PM · KWin
romangg added a dependent revision for D28082: Take file descriptor only instead of whole KWayland Display: D28085: Adapt to new KScreenLocker API.
Mar 16 2020, 10:03 PM · Plasma
romangg added a reviewer for D28085: Adapt to new KScreenLocker API: KWin.
Mar 16 2020, 10:03 PM · KWin
romangg requested review of D28085: Adapt to new KScreenLocker API.
Mar 16 2020, 10:02 PM · KWin
romangg updated the diff for D28082: Take file descriptor only instead of whole KWayland Display.

Rebase

Mar 16 2020, 9:53 PM · Plasma
romangg updated the diff for D28081: Populate Greeter process exit stderr.

else case

Mar 16 2020, 9:49 PM · Plasma
romangg added inline comments to D28081: Populate Greeter process exit stderr.
Mar 16 2020, 8:32 PM · Plasma
romangg added a dependency for D28082: Take file descriptor only instead of whole KWayland Display: D28081: Populate Greeter process exit stderr.
Mar 16 2020, 7:52 PM · Plasma
romangg added a dependent revision for D28081: Populate Greeter process exit stderr: D28082: Take file descriptor only instead of whole KWayland Display.
Mar 16 2020, 7:52 PM · Plasma
romangg requested review of D28082: Take file descriptor only instead of whole KWayland Display.
Mar 16 2020, 7:51 PM · Plasma
romangg added a reviewer for D28081: Populate Greeter process exit stderr: Plasma.
Mar 16 2020, 7:45 PM · Plasma
romangg requested review of D28081: Populate Greeter process exit stderr.
Mar 16 2020, 7:45 PM · Plasma

Mar 8 2020

romangg requested changes to D27675: feat: avoid duplicated text when assembling user-facing output names.

Ok, I see the issue. The question is if Vendor Model is not a bit stupid as a name for an output and if KWin/KWayland should not be a bit more intelligent about choosing a name. Then it could make sense again to have (Vendor model) appended afterwards. For example I have here a monitor for testing which is called on the website: PROLITE XUB2395WSU-B1. But KWin returns as Vendor "IVM" and as name "DP-1-PL2395W/11638JJ60250".

Mar 8 2020, 8:30 PM · Plasma
romangg added a comment to D27677: refactor: incorporate prior libkscreen EDID changes.

Is this now a bug fix or a feature? I would call it a refactor since there is no regression or prior bug and neither does it add a new feature. The feature was added in libkscreen. And please don't say refactor: fix... How about refactor: incorporate prior libkscreen EDID changes?

Mar 8 2020, 8:19 PM · Plasma
romangg added a comment to D10042: feat: parse EDID on the backend side.

The idea to parse on the backend side is sound. Can you paste the output you get in a Wayland session? For me it shows the XWayland EDID of the outputs.

Mar 8 2020, 8:15 PM · Plasma

Mar 4 2020

romangg accepted D26945: fix(plasmoid): add smallSpacing to leftMargin.

Depends on if you use in the end arc. Then it's given by the Phab diff title.

Mar 4 2020, 10:57 AM · Plasma
romangg retitled D26945: fix(plasmoid): add smallSpacing to leftMargin from fix(plasmoid): Added smallSpacing to leftMargin to fix(plasmoid): add smallSpacing to leftMargin.
Mar 4 2020, 10:53 AM · Plasma

Mar 3 2020

romangg added a reviewer for D27675: feat: avoid duplicated text when assembling user-facing output names: romangg.

I am currently working on some projects. But if you don't hear till Sunday from me about this, ping me.

Mar 3 2020, 5:10 PM · Plasma

Feb 28 2020

romangg accepted D27723: feat(kwayland): enable the auto-rotation and tablet mode.
Feb 28 2020, 4:57 PM · Plasma

Feb 26 2020

romangg added a comment to D27674: feat(kcm): show resolution aspect ratio.

Do you have an example? Name the product. I know it should be easy technically, but my question is if it makes sense.

Feb 26 2020, 2:31 PM · Plasma
romangg added a comment to D27674: feat(kcm): show resolution aspect ratio.

Do you have an example in the wild where the "default resolution" should be something else than the one with highest pixel count?

Feb 26 2020, 2:24 PM · Plasma
romangg retitled D27675: feat: avoid duplicated text when assembling user-facing output names from feat: Avoid duplicated text when assembling user-facing output names to feat: avoid duplicated text when assembling user-facing output names.
Feb 26 2020, 12:03 PM · Plasma
romangg added a comment to D27675: feat: avoid duplicated text when assembling user-facing output names.

Can you give an explicit example?

Feb 26 2020, 12:02 PM · Plasma
romangg accepted D27674: feat(kcm): show resolution aspect ratio.

Nice tight implementation.

Feb 26 2020, 12:02 PM · Plasma
romangg retitled D27674: feat(kcm): show resolution aspect ratio from feat(kcm): Show resolution aspect ratio to feat(kcm): show resolution aspect ratio.
Feb 26 2020, 12:00 PM · Plasma

Feb 25 2020

romangg added inline comments to D27626: refactor: fix various compiler warnings.
Feb 25 2020, 2:47 PM · Plasma
romangg accepted D27626: refactor: fix various compiler warnings.
Feb 25 2020, 2:42 PM · Plasma
romangg added inline comments to D27626: refactor: fix various compiler warnings.
Feb 25 2020, 3:31 AM · Plasma
romangg accepted D27625: fix: handle when backend fails to load/initialize.
Feb 25 2020, 3:22 AM · Plasma

Feb 24 2020

romangg accepted D27618: fix(kwayland): wait longer for connection timeout and retry.

Thanks. This m_isValid variable was really uselsess. ;)

Feb 24 2020, 1:00 PM · Plasma
romangg retitled D27618: fix(kwayland): wait longer for connection timeout and retry from fix(kwayland): fix crash when KWayland connection times out to fix(kwayland): wait longer for connection timeout and retry.
Feb 24 2020, 1:00 PM · Plasma

Feb 21 2020

romangg committed R110:ba4b0d579585: Revert "fix(autotests): fix simpleWrite test in kwaylandbackendtest" (authored by romangg).
Revert "fix(autotests): fix simpleWrite test in kwaylandbackendtest"
Feb 21 2020, 1:13 PM
romangg added a reverting change for R110:2fcd093919b8: fix(autotests): fix simpleWrite test in kwaylandbackendtest: R110:ba4b0d579585: Revert "fix(autotests): fix simpleWrite test in kwaylandbackendtest".
Feb 21 2020, 1:13 PM
romangg added a comment to D27537: Fix simpleWrite test in kwaylandbackendtest.

Thanks, but the commit message in wrong as the type must be test since this is a fix to an autotest. And the scope autotest does not exist. See https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md

Feb 21 2020, 1:12 PM · Plasma
romangg accepted D27537: Fix simpleWrite test in kwaylandbackendtest.

Please follow commit message guideline.

Feb 21 2020, 12:02 PM · Plasma
romangg added a comment to D27536: fix(kwayland): remove code with side-effects from Q_ASSERT.

It would be nice if I get at least 24 hours to review patches in KScreen/libkscreen. Thanks for the patch.

Feb 21 2020, 12:00 PM · Plasma

Feb 17 2020

romangg accepted D27442: fix(kcm): use explicit Kirigami.Units over singleton from a theme.
Feb 17 2020, 12:33 AM · Plasma
romangg retitled D27442: fix(kcm): use explicit Kirigami.Units over singleton from a theme from fix(kcm): Use explicit Kirigami.Units over singleton from a theme to fix(kcm): use explicit Kirigami.Units over singleton from a theme.
Feb 17 2020, 12:33 AM · Plasma

Feb 13 2020

romangg committed R110:274d94ed6453: fix: reset doctor output color before exiting (authored by z3ntu).
fix: reset doctor output color before exiting
Feb 13 2020, 10:09 PM
romangg closed D27383: fix: reset doctor output color before exiting.
Feb 13 2020, 10:09 PM · Plasma
romangg added a comment to D27383: fix: reset doctor output color before exiting.

Yea, but sadly I have already committed it: https://cgit.kde.org/libkscreen.git/commit/?id=274d94ed645387b29386daa077b2cb6a3dafbeff

Feb 13 2020, 9:43 PM · Plasma
romangg added a comment to D27383: fix: reset doctor output color before exiting.

True, thanks anyway. You can ask for commit rights by https://community.kde.org/Infrastructure/Get_a_Developer_Account

Feb 13 2020, 9:24 PM · Plasma
romangg added a comment to D27383: fix: reset doctor output color before exiting.

Do you have commit rights? Otherwise I need your name and email for author information.

Feb 13 2020, 9:07 PM · Plasma
romangg retitled D27383: fix: reset doctor output color before exiting from kscreen-doctor: reset color before exiting to fix: reset doctor output color before exiting.
Feb 13 2020, 9:06 PM · Plasma
romangg added a comment to D27383: fix: reset doctor output color before exiting.

Of the four scopes (api, kwayland, qscreen & randr) I have no idea where to put this in. If you have a suggestion, I can update the commit message.

Feb 13 2020, 8:57 PM · Plasma
romangg added a comment to D27383: fix: reset doctor output color before exiting.

Please respect the Commit Message Guideline when pushing the change:
https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md#n22

Feb 13 2020, 8:38 PM · Plasma

Jan 16 2020

romangg committed R110:8cd7ff9f06be: Merge branch 'Plasma/5.18' (authored by romangg).
Merge branch 'Plasma/5.18'
Jan 16 2020, 1:26 PM
romangg committed R110:13b631eabb98: fix(kwayland): move blocking tablet init before timer start (authored by romangg).
fix(kwayland): move blocking tablet init before timer start
Jan 16 2020, 1:23 PM
romangg closed D26658: fix(kwayland): move blocking tablet init before timer start.
Jan 16 2020, 1:23 PM · Plasma
romangg committed R108:b8b9f78b37d7: Revert "[platforms/x11] Remove triple buffering detection" (authored by romangg).
Revert "[platforms/x11] Remove triple buffering detection"
Jan 16 2020, 9:07 AM
romangg added a reverting change for R108:ad892ce3a65e: [platforms/x11] Remove triple buffering detection: R108:b8b9f78b37d7: Revert "[platforms/x11] Remove triple buffering detection".
Jan 16 2020, 9:07 AM
romangg added a reverting change for R108:285adc1950c9: [platforms/x11/standalone] Remove SGI swap control and video sync: R108:a15624dcc5fe: Revert "[platforms/x11/standalone] Remove SGI swap control and video sync".
Jan 16 2020, 9:07 AM
romangg committed R108:a15624dcc5fe: Revert "[platforms/x11/standalone] Remove SGI swap control and video sync" (authored by romangg).
Revert "[platforms/x11/standalone] Remove SGI swap control and video sync"
Jan 16 2020, 9:07 AM
romangg added a reverting change for R108:b3a19f9e5b77: Remove vsync detection and configurability: R108:bcf64af49bd9: Revert "Remove vsync detection and configurability".
Jan 16 2020, 9:07 AM
romangg committed R108:bcf64af49bd9: Revert "Remove vsync detection and configurability" (authored by romangg).
Revert "Remove vsync detection and configurability"
Jan 16 2020, 9:07 AM
romangg committed R108:ac05dd01c84a: Revert "[platforms/x11] Never block on retrace, always present after paint" (authored by romangg).
Revert "[platforms/x11] Never block on retrace, always present after paint"
Jan 16 2020, 9:07 AM
romangg added a reverting change for R108:8d137290317a: [platforms/x11] Never block on retrace, always present after paint: R108:ac05dd01c84a: Revert "[platforms/x11] Never block on retrace, always present after paint".
Jan 16 2020, 9:07 AM
romangg committed R108:b972159ddfa6: Revert "Add hasSwapEvent getter" (authored by romangg).
Revert "Add hasSwapEvent getter"
Jan 16 2020, 9:07 AM
romangg added a reverting change for R108:a55dee3bd329: Add hasSwapEvent getter: R108:b972159ddfa6: Revert "Add hasSwapEvent getter".
Jan 16 2020, 9:07 AM
romangg committed R108:fbb7c241c748: Revert "Composite without timer on swap events" (authored by romangg).
Revert "Composite without timer on swap events"
Jan 16 2020, 9:07 AM
romangg added a reverting change for R108:00bf75d06e67: Composite without timer on swap events: R108:fbb7c241c748: Revert "Composite without timer on swap events".
Jan 16 2020, 9:07 AM
romangg added a reverting change for R108:e7da4d65ecbd: [platforms/x11/standalone] Use intel swap events by default: R108:14702651b37e: Revert "[platforms/x11/standalone] Use intel swap events by default".
Jan 16 2020, 9:07 AM
romangg committed R108:14702651b37e: Revert "[platforms/x11/standalone] Use intel swap events by default" (authored by romangg).
Revert "[platforms/x11/standalone] Use intel swap events by default"
Jan 16 2020, 9:07 AM
romangg committed R108:63898fc5698d: Revert "Reset buffer swap state on stop" (authored by romangg).
Revert "Reset buffer swap state on stop"
Jan 16 2020, 9:07 AM
romangg added a reverting change for R108:ba2c0324d2ef: Reset buffer swap state on stop: R108:63898fc5698d: Revert "Reset buffer swap state on stop".
Jan 16 2020, 9:07 AM
romangg committed R108:2dabd0b11261: Revert "Fix buffer swap assert" (authored by romangg).
Revert "Fix buffer swap assert"
Jan 16 2020, 9:07 AM
romangg added a reverting change for R108:be01ba0ae7c6: Fix buffer swap assert: R108:2dabd0b11261: Revert "Fix buffer swap assert".
Jan 16 2020, 9:07 AM
romangg committed R108:a5c2f23e92b1: Revert "Flexible composite swap and timer events" (authored by romangg).
Revert "Flexible composite swap and timer events"
Jan 16 2020, 9:07 AM
romangg added a reverting change for R108:1e3128b0db89: Flexible composite swap and timer events: R108:a5c2f23e92b1: Revert "Flexible composite swap and timer events".
Jan 16 2020, 9:07 AM
romangg added a reverting change for R108:af3fbf343bb2: Remove buffer flip pending assert for now: R108:396ef7100ea3: Revert "Remove buffer flip pending assert for now".
Jan 16 2020, 9:07 AM
romangg committed R108:396ef7100ea3: Revert "Remove buffer flip pending assert for now" (authored by romangg).
Revert "Remove buffer flip pending assert for now"
Jan 16 2020, 9:07 AM

Jan 15 2020

romangg accepted D26681: [TabBox] Thumbnail Grid window switcher.
Jan 15 2020, 11:53 PM · Plasma
romangg updated the summary of D26658: fix(kwayland): move blocking tablet init before timer start.
Jan 15 2020, 3:55 PM · Plasma
romangg updated the diff for D26658: fix(kwayland): move blocking tablet init before timer start.
  • Init tablet before starting KWayland timer
Jan 15 2020, 3:50 PM · Plasma
romangg committed R104:039337cd3b1a: feat(kcm): add option for auto rotation (authored by romangg).
feat(kcm): add option for auto rotation
Jan 15 2020, 2:38 PM
romangg closed D26038: feat(kcm): add option for auto rotation.
Jan 15 2020, 2:38 PM · Plasma
romangg committed R104:8032881459d1: feat(kded): add orientation sensor (authored by romangg).
feat(kded): add orientation sensor
Jan 15 2020, 2:38 PM