- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Oct 20 2019
Oct 20 2019
shentey committed R34:80f5e9e31672: Resolve compiler warning "break will never be executed" (authored by shentey).
Resolve compiler warning "break will never be executed"
shentey committed R34:b37b00e07389: Have separate test cases for both if-branches (authored by shentey).
Have separate test cases for both if-branches
Remove redundant reimplementations
Reduce scope of local variable
Const'ify local variable
Fix building of examples
May 1 2019
May 1 2019
shentey committed R34:8c99d467e783: Introduce GeoDataCoordinates::rotateAround() overload (authored by shentey).
Introduce GeoDataCoordinates::rotateAround() overload
shentey committed R34:2d8494993db9: Simplify normalized linear interpolation between two GeoDataCoordinates (authored by shentey).
Simplify normalized linear interpolation between two GeoDataCoordinates
Prefer geodata_cast<> to dynamic_cast<>
Flatten nested if-statements
shentey committed R34:0ec6f2962191: Eliminate normGlobalHeight for more mathematical beauty (authored by shentey).
Eliminate normGlobalHeight for more mathematical beauty
Dec 9 2018
Dec 9 2018
Use geodata_cast<>
shentey committed R34:668ecb4b4163: Have geodata_cast<> only be implemented for KML types (authored by shentey).
Have geodata_cast<> only be implemented for KML types
shentey committed R34:073e866c446c: Follow KML spec more closely by not deriving GeoDataExtendedData from… (authored by shentey).
Follow KML spec more closely by not deriving GeoDataExtendedData from…
shentey committed R34:6d0c21c46e94: Be more specific as to what the parent of a GeoDataSchemaData is (authored by shentey).
Be more specific as to what the parent of a GeoDataSchemaData is
Use more specific type
Cleanup includes of GeoDataTypes.h
Cleanup includes of MarbleColors.h
Jul 22 2018
Jul 22 2018
shentey committed R34:f9a5e809b09a: latitudes must be normalized with normalizeLat (authored by shentey).
latitudes must be normalized with normalizeLat
Jul 1 2018
Jul 1 2018
fix accidental use of comma operator
modernize-use-using
Let Magrathea become a myth
modernize-use-equals-delete
Add even more override specifiers
Mar 31 2018
Mar 31 2018
shentey committed R34:68e6f6c1e16d: modernize code to use nullptr (clang-tidy) (authored by shentey).
modernize code to use nullptr (clang-tidy)
Mar 25 2018
Mar 25 2018
must be 180 (two times right angle)
x in tan(x) must be radian, not degree
remove unused toString() methods
const'ify, use geodata_cast<>
shentey committed R34:db34672b8a60: avoid detour through QString when hashing (authored by shentey).
avoid detour through QString when hashing
Mar 22 2018
Mar 22 2018
reuse GeoDataCoordinates::interpolate()
reuse GeoDataCoordinates::interpolate()
shentey committed R34:bf497dc56143: no need for using GeoDataLineString when calculating distance between just two… (authored by shentey).
no need for using GeoDataLineString when calculating distance between just two…
reuse RouteSegment::projected()
no need for #including MarbleMath.h here
get rid of (heap allocated) coef vector
shentey committed R34:5cdc9ddcb453: GeoDataLatLonBox::{north(),south(),east(),west()} are already normalized (authored by shentey).
GeoDataLatLonBox::{north(),south(),east(),west()} are already normalized
shentey committed R34:615548542a2e: use GeoDataLatLonBox, just like in GeoGraphicsScene::items() (authored by shentey).
use GeoDataLatLonBox, just like in GeoGraphicsScene::items()
Mar 3 2018
Mar 3 2018
Jan 20 2018
Jan 20 2018
shentey committed R34:ec1f7f554e9f: use dedicated type rather than low level types (authored by shentey).
use dedicated type rather than low level types
remove unneeded method overload
shentey committed R34:bc6ad5457cba: move distanceSphere() overload to GeoDataCoordinates and rename to… (authored by shentey).
move distanceSphere() overload to GeoDataCoordinates and rename to…
shentey committed R34:67ca45fb2901: realize that Marble::Dimension is specific to LatLonEdit (authored by shentey).
realize that Marble::Dimension is specific to LatLonEdit
shentey committed R34:59a0534252f7: move constant definitions to central place (authored by shentey).
move constant definitions to central place
shentey committed R34:2066735cb5bb: move sunPosition() calculation to Planet to have planet logic in one place (authored by shentey).
move sunPosition() calculation to Planet to have planet logic in one place
shentey committed R34:5c3536574eef: have a twilightZone attribute in Planet to keep planet knowledge in one place (authored by shentey).
have a twilightZone attribute in Planet to keep planet knowledge in one place
Oct 30 2017
Oct 30 2017
declare some methods as static
declare some methods as const
no need to forward to private method
move attributes to private class
Aug 17 2017
Aug 17 2017
Merge branch 'Applications/17.08'
shentey committed R34:758ebe8b2d72: fix bug introduced in b5d1987f74814ccdd7560a79eff2ae35f4631464 (authored by shentey).
fix bug introduced in b5d1987f74814ccdd7560a79eff2ae35f4631464
Aug 8 2017
Aug 8 2017
shentey committed R40:f4228cec1275: use only one UserRole to store the error category (which is mutually exclusive… (authored by shentey).
use only one UserRole to store the error category (which is mutually exclusive…
shentey committed R40:ddde8bcf8166: create a QRegularExpressionMatch here as well (follow-up on… (authored by shentey).
create a QRegularExpressionMatch here as well (follow-up on…
shentey committed R40:c115234574e0: prepare for tools providing column information: fix off-by-one error (authored by shentey).
prepare for tools providing column information: fix off-by-one error
Aug 5 2017
Aug 5 2017
remove unused method
port to QRegularExpression
Aug 4 2017
Aug 4 2017
keep stdout and stderr buffers separated
rename for more clarity
Jul 31 2017
Jul 31 2017
mark methods as const
reduce scope of variable
Jul 28 2017
Jul 28 2017
initialize in ctor's initializer list
convert attribute from pointer to value
add some icons
shentey committed R40:a39516e910a3: no need for overriding hasChildren(); rely on rowCount() instead (authored by shentey).
no need for overriding hasChildren(); rely on rowCount() instead
Merge branch 'Applications/17.08'
shentey committed R40:7a6b3478aa35: the root index only hasChildren() if there are targets (authored by shentey).
the root index only hasChildren() if there are targets
May 26 2017
May 26 2017
shentey committed R34:207423a8a104: restore address in GeoDataFeatures when parsing KML (authored by shentey).
restore address in GeoDataFeatures when parsing KML
May 20 2017
May 20 2017
shentey committed R34:82a06cce291f: rename method and make static for more clarity (authored by shentey).
rename method and make static for more clarity
Apr 30 2017
Apr 30 2017
translate user visible string
shentey committed R34:57adaf8c8b9a: remove FileManager::saveFile() wich was only used once (authored by shentey).
remove FileManager::saveFile() wich was only used once
use for loop
Apr 23 2017
Apr 23 2017
Apr 17 2017
Apr 17 2017
shentey added a comment to D5396: Mismatch in parsed GeoDataDocument and GeoSceneGeodata in MarbleModelPrivate::assignFillColors(const QString &filePath).
Good catch!
Apr 8 2017
Apr 8 2017
shentey committed R34:237585ec99be: keep documents requested by the map theme (authored by shentey).
keep documents requested by the map theme
shentey committed R34:d9423173c04f: remove assignNewStyle(), which is redundant to the colors.isEmpty() branch of… (authored by shentey).
remove assignNewStyle(), which is redundant to the colors.isEmpty() branch of…
reduce indentation levels
split method
fix padding warnings
reduce scope of variables
silence debug spam
no Doxygen comments in method bodies
assignment is never used
make attributes private
Mar 25 2017
Mar 25 2017
shentey committed R34:0efc24bee9ea: AlternativeRoutesModel: expose GeoDataDocument routes const'ified (authored by shentey).
AlternativeRoutesModel: expose GeoDataDocument routes const'ified
shentey committed R34:2a6bb562e8b6: handle case "document == nullptr" gracefully (authored by shentey).
handle case "document == nullptr" gracefully
shentey committed R34:97bbae032248: don't repeat yourself, no else after return (authored by shentey).
don't repeat yourself, no else after return
const'ify parameter
shentey committed R34:69963d8cc539: no need to override QAbstractItemModel::hasChildren() (authored by shentey).
no need to override QAbstractItemModel::hasChildren()
Mar 23 2017
Mar 23 2017
avoid redundant parameter
Mar 19 2017
Mar 19 2017
shentey committed R34:4eb1b47c0f53: reduce number of QPainter state changes by drawing pixmaps rather than ellipses (authored by shentey).
reduce number of QPainter state changes by drawing pixmaps rather than ellipses
Mar 18 2017
Mar 18 2017
shentey committed R34:4f7abf3a48d1: no need to pass a MarbleModel; PositionTracking is sufficient (authored by shentey).
no need to pass a MarbleModel; PositionTracking is sufficient
resolve padding warning
shentey committed R34:2ca24c123aa9: assume that routing takes place only for planet earth (authored by shentey).
assume that routing takes place only for planet earth
shentey committed R34:e71d7edd26eb: add and use GeoDataContainer::isEmpty() method (authored by shentey).
add and use GeoDataContainer::isEmpty() method