Feed Advanced Search

Oct 20 2019

shentey committed R34:80f5e9e31672: Resolve compiler warning "break will never be executed" (authored by shentey).
Resolve compiler warning "break will never be executed"
Oct 20 2019, 9:00 PM
shentey committed R34:b37b00e07389: Have separate test cases for both if-branches (authored by shentey).
Have separate test cases for both if-branches
Oct 20 2019, 9:00 PM
shentey committed R34:168f23c877fb: Remove redundant reimplementations (authored by shentey).
Remove redundant reimplementations
Oct 20 2019, 9:00 PM
shentey committed R34:dcfbc44cb273: Reduce scope of local variable (authored by shentey).
Reduce scope of local variable
Oct 20 2019, 9:00 PM
shentey committed R34:4e8115ab0a7f: Const'ify local variable (authored by shentey).
Const'ify local variable
Oct 20 2019, 9:00 PM
shentey committed R34:c60a6162d8b1: Fix building of examples (authored by shentey).
Fix building of examples
Oct 20 2019, 9:00 PM

May 1 2019

shentey committed R34:8c99d467e783: Introduce GeoDataCoordinates::rotateAround() overload (authored by shentey).
Introduce GeoDataCoordinates::rotateAround() overload
May 1 2019, 2:08 PM
shentey committed R34:2d8494993db9: Simplify normalized linear interpolation between two GeoDataCoordinates (authored by shentey).
Simplify normalized linear interpolation between two GeoDataCoordinates
May 1 2019, 2:08 PM
shentey committed R34:8701f99d83d2: Prefer geodata_cast<> to dynamic_cast<> (authored by shentey).
Prefer geodata_cast<> to dynamic_cast<>
May 1 2019, 2:08 PM
shentey committed R34:7c910b510387: Flatten nested if-statements (authored by shentey).
Flatten nested if-statements
May 1 2019, 2:08 PM
shentey committed R34:0ec6f2962191: Eliminate normGlobalHeight for more mathematical beauty (authored by shentey).
Eliminate normGlobalHeight for more mathematical beauty
May 1 2019, 2:08 PM

Dec 9 2018

shentey committed R34:9a7c581008f1: Use geodata_cast<> (authored by shentey).
Use geodata_cast<>
Dec 9 2018, 1:50 PM
shentey committed R34:668ecb4b4163: Have geodata_cast<> only be implemented for KML types (authored by shentey).
Have geodata_cast<> only be implemented for KML types
Dec 9 2018, 1:50 PM
shentey committed R34:073e866c446c: Follow KML spec more closely by not deriving GeoDataExtendedData from… (authored by shentey).
Follow KML spec more closely by not deriving GeoDataExtendedData from…
Dec 9 2018, 1:50 PM
shentey committed R34:6d0c21c46e94: Be more specific as to what the parent of a GeoDataSchemaData is (authored by shentey).
Be more specific as to what the parent of a GeoDataSchemaData is
Dec 9 2018, 1:50 PM
shentey committed R34:3d9b833412a9: Use more specific type (authored by shentey).
Use more specific type
Dec 9 2018, 1:50 PM
shentey committed R34:030c21b70fb4: Cleanup includes of GeoDataTypes.h (authored by shentey).
Cleanup includes of GeoDataTypes.h
Dec 9 2018, 1:50 PM
shentey committed R34:8adc7df842f1: Cleanup includes of MarbleColors.h (authored by shentey).
Cleanup includes of MarbleColors.h
Dec 9 2018, 1:50 PM

Jul 22 2018

shentey committed R34:f9a5e809b09a: latitudes must be normalized with normalizeLat (authored by shentey).
latitudes must be normalized with normalizeLat
Jul 22 2018, 2:12 PM

Jul 1 2018

shentey committed R34:297f3d206a3d: fix accidental use of comma operator (authored by shentey).
fix accidental use of comma operator
Jul 1 2018, 2:10 PM
shentey committed R34:fee92fed8fc3: modernize-use-using (authored by shentey).
modernize-use-using
Jul 1 2018, 2:10 PM
shentey committed R34:6277a3a23b7b: Let Magrathea become a myth (authored by shentey).
Let Magrathea become a myth
Jul 1 2018, 2:10 PM
shentey committed R34:dcebe6b58b3e: modernize-use-equals-delete (authored by shentey).
modernize-use-equals-delete
Jul 1 2018, 2:09 PM
shentey committed R34:f82ec54b392c: Add even more override specifiers (authored by shentey).
Add even more override specifiers
Jul 1 2018, 2:09 PM

Mar 31 2018

shentey committed R34:68e6f6c1e16d: modernize code to use nullptr (clang-tidy) (authored by shentey).
modernize code to use nullptr (clang-tidy)
Mar 31 2018, 3:41 PM

Mar 25 2018

shentey committed R34:b62592565a2b: must be 180 (two times right angle) (authored by shentey).
must be 180 (two times right angle)
Mar 25 2018, 3:51 PM
shentey committed R34:19dbd3f1a480: x in tan(x) must be radian, not degree (authored by shentey).
x in tan(x) must be radian, not degree
Mar 25 2018, 3:51 PM
shentey committed R34:5103cf0bcd82: remove unused toString() methods (authored by shentey).
remove unused toString() methods
Mar 25 2018, 3:51 PM
shentey committed R34:64c32ef522ce: const'ify, use geodata_cast<> (authored by shentey).
const'ify, use geodata_cast<>
Mar 25 2018, 3:51 PM
shentey committed R34:db34672b8a60: avoid detour through QString when hashing (authored by shentey).
avoid detour through QString when hashing
Mar 25 2018, 3:51 PM

Mar 22 2018

shentey committed R34:522779b11194: reuse GeoDataCoordinates::interpolate() (authored by shentey).
reuse GeoDataCoordinates::interpolate()
Mar 22 2018, 9:14 PM
shentey committed R34:ad3e84f86a34: reuse GeoDataCoordinates::interpolate() (authored by shentey).
reuse GeoDataCoordinates::interpolate()
Mar 22 2018, 9:09 PM
shentey committed R34:bf497dc56143: no need for using GeoDataLineString when calculating distance between just two… (authored by shentey).
no need for using GeoDataLineString when calculating distance between just two…
Mar 22 2018, 9:09 PM
shentey committed R34:618626a9ed42: reuse RouteSegment::projected() (authored by shentey).
reuse RouteSegment::projected()
Mar 22 2018, 9:09 PM
shentey committed R34:349706e10c1a: no need for #including MarbleMath.h here (authored by shentey).
no need for #including MarbleMath.h here
Mar 22 2018, 7:57 PM
shentey committed R34:1cd4a1ac9858: get rid of (heap allocated) coef vector (authored by shentey).
get rid of (heap allocated) coef vector
Mar 22 2018, 7:49 PM
shentey committed R34:5cdc9ddcb453: GeoDataLatLonBox::{north(),south(),east(),west()} are already normalized (authored by shentey).
GeoDataLatLonBox::{north(),south(),east(),west()} are already normalized
Mar 22 2018, 7:45 PM
shentey committed R34:615548542a2e: use GeoDataLatLonBox, just like in GeoGraphicsScene::items() (authored by shentey).
use GeoDataLatLonBox, just like in GeoGraphicsScene::items()
Mar 22 2018, 7:37 PM

Mar 3 2018

shentey committed R34:85fcfcc17311: fix typo (authored by shentey).
fix typo
Mar 3 2018, 11:20 AM

Jan 20 2018

shentey committed R34:ec1f7f554e9f: use dedicated type rather than low level types (authored by shentey).
use dedicated type rather than low level types
Jan 20 2018, 4:17 PM
shentey committed R34:7f729155713b: remove unneeded method overload (authored by shentey).
remove unneeded method overload
Jan 20 2018, 4:17 PM
shentey committed R34:bc6ad5457cba: move distanceSphere() overload to GeoDataCoordinates and rename to… (authored by shentey).
move distanceSphere() overload to GeoDataCoordinates and rename to…
Jan 20 2018, 4:17 PM
shentey committed R34:67ca45fb2901: realize that Marble::Dimension is specific to LatLonEdit (authored by shentey).
realize that Marble::Dimension is specific to LatLonEdit
Jan 20 2018, 4:17 PM
shentey committed R34:59a0534252f7: move constant definitions to central place (authored by shentey).
move constant definitions to central place
Jan 20 2018, 4:17 PM
shentey committed R34:2066735cb5bb: move sunPosition() calculation to Planet to have planet logic in one place (authored by shentey).
move sunPosition() calculation to Planet to have planet logic in one place
Jan 20 2018, 4:17 PM
shentey committed R34:5c3536574eef: have a twilightZone attribute in Planet to keep planet knowledge in one place (authored by shentey).
have a twilightZone attribute in Planet to keep planet knowledge in one place
Jan 20 2018, 4:17 PM

Oct 30 2017

shentey committed R34:643e85c5373b: declare some methods as static (authored by shentey).
declare some methods as static
Oct 30 2017, 9:26 PM
shentey committed R34:bffd0dcee412: declare some methods as const (authored by shentey).
declare some methods as const
Oct 30 2017, 9:26 PM
shentey committed R34:bd6e567a91e3: no need to forward to private method (authored by shentey).
no need to forward to private method
Oct 30 2017, 9:26 PM
shentey committed R34:be1aa2575bb5: move attributes to private class (authored by shentey).
move attributes to private class
Oct 30 2017, 9:26 PM

Aug 17 2017

shentey committed R34:7179e74fbb20: Merge branch 'Applications/17.08' (authored by shentey).
Merge branch 'Applications/17.08'
Aug 17 2017, 6:32 PM
shentey committed R34:758ebe8b2d72: fix bug introduced in b5d1987f74814ccdd7560a79eff2ae35f4631464 (authored by shentey).
fix bug introduced in b5d1987f74814ccdd7560a79eff2ae35f4631464
Aug 17 2017, 6:29 PM

Aug 8 2017

shentey committed R40:f4228cec1275: use only one UserRole to store the error category (which is mutually exclusive… (authored by shentey).
use only one UserRole to store the error category (which is mutually exclusive…
Aug 8 2017, 5:42 PM
shentey committed R40:ddde8bcf8166: create a QRegularExpressionMatch here as well (follow-up on… (authored by shentey).
create a QRegularExpressionMatch here as well (follow-up on…
Aug 8 2017, 5:42 PM
shentey committed R40:c115234574e0: prepare for tools providing column information: fix off-by-one error (authored by shentey).
prepare for tools providing column information: fix off-by-one error
Aug 8 2017, 5:42 PM

Aug 5 2017

shentey committed R40:352ae374967a: remove unused method (authored by shentey).
remove unused method
Aug 5 2017, 5:08 PM
shentey committed R40:41538cd3b973: port to QRegularExpression (authored by shentey).
port to QRegularExpression
Aug 5 2017, 5:08 PM

Aug 4 2017

shentey committed R40:b2bff6560a4b: keep stdout and stderr buffers separated (authored by shentey).
keep stdout and stderr buffers separated
Aug 4 2017, 3:46 PM
shentey committed R40:b1dfabea1d2f: const'ify (authored by shentey).
const'ify
Aug 4 2017, 3:46 PM
shentey committed R40:0e4d7ac2e496: rename for more clarity (authored by shentey).
rename for more clarity
Aug 4 2017, 3:46 PM

Jul 31 2017

shentey committed R34:c983b20132d0: mark methods as const (authored by shentey).
mark methods as const
Jul 31 2017, 5:04 PM
shentey committed R34:c111f3c2d8ed: reduce scope of variable (authored by shentey).
reduce scope of variable
Jul 31 2017, 5:04 PM
shentey committed R34:e413643876c8: simplify (authored by shentey).
simplify
Jul 31 2017, 5:04 PM

Jul 28 2017

shentey committed R40:2de179c8c51b: initialize in ctor's initializer list (authored by shentey).
initialize in ctor's initializer list
Jul 28 2017, 4:46 PM
shentey committed R40:8e9511527da7: convert attribute from pointer to value (authored by shentey).
convert attribute from pointer to value
Jul 28 2017, 4:46 PM
shentey committed R40:91adc4785420: add some icons (authored by shentey).
add some icons
Jul 28 2017, 4:32 PM
shentey committed R40:a39516e910a3: no need for overriding hasChildren(); rely on rowCount() instead (authored by shentey).
no need for overriding hasChildren(); rely on rowCount() instead
Jul 28 2017, 4:28 PM
shentey committed R40:6ce56e28cf0c: Merge branch 'Applications/17.08' (authored by shentey).
Merge branch 'Applications/17.08'
Jul 28 2017, 4:28 PM
shentey committed R40:7a6b3478aa35: the root index only hasChildren() if there are targets (authored by shentey).
the root index only hasChildren() if there are targets
Jul 28 2017, 4:25 PM

May 26 2017

shentey committed R34:207423a8a104: restore address in GeoDataFeatures when parsing KML (authored by shentey).
restore address in GeoDataFeatures when parsing KML
May 26 2017, 3:58 PM

May 20 2017

shentey committed R34:82a06cce291f: rename method and make static for more clarity (authored by shentey).
rename method and make static for more clarity
May 20 2017, 12:18 PM

Apr 30 2017

shentey committed R34:9298fbff1724: translate user visible string (authored by shentey).
translate user visible string
Apr 30 2017, 12:19 PM
shentey committed R34:57adaf8c8b9a: remove FileManager::saveFile() wich was only used once (authored by shentey).
remove FileManager::saveFile() wich was only used once
Apr 30 2017, 12:19 PM
shentey committed R34:e41a094fd4d0: use for loop (authored by shentey).
use for loop
Apr 30 2017, 12:01 PM

Apr 23 2017

shentey added inline comments to D5396: Mismatch in parsed GeoDataDocument and GeoSceneGeodata in MarbleModelPrivate::assignFillColors(const QString &filePath).
Apr 23 2017, 11:09 AM · Marble

Apr 17 2017

shentey added a comment to D5396: Mismatch in parsed GeoDataDocument and GeoSceneGeodata in MarbleModelPrivate::assignFillColors(const QString &filePath).

Good catch!

Apr 17 2017, 6:02 PM · Marble
shentey committed R34:fdd68588e299: const'ify (authored by shentey).
const'ify
Apr 17 2017, 5:19 PM

Apr 8 2017

shentey committed R34:237585ec99be: keep documents requested by the map theme (authored by shentey).
keep documents requested by the map theme
Apr 8 2017, 3:59 PM
shentey committed R34:d9423173c04f: remove assignNewStyle(), which is redundant to the colors.isEmpty() branch of… (authored by shentey).
remove assignNewStyle(), which is redundant to the colors.isEmpty() branch of…
Apr 8 2017, 3:59 PM
shentey committed R34:39936c4e781b: reduce indentation levels (authored by shentey).
reduce indentation levels
Apr 8 2017, 3:59 PM
shentey committed R34:ce27896d1460: split method (authored by shentey).
split method
Apr 8 2017, 3:59 PM
shentey committed R34:fe934200ea8a: fix padding warnings (authored by shentey).
fix padding warnings
Apr 8 2017, 3:59 PM
shentey committed R34:0a88f528a44d: reduce scope of variables (authored by shentey).
reduce scope of variables
Apr 8 2017, 3:59 PM
shentey committed R34:1b1f249fdf26: silence debug spam (authored by shentey).
silence debug spam
Apr 8 2017, 3:58 PM
shentey committed R34:db41a303729f: no Doxygen comments in method bodies (authored by shentey).
no Doxygen comments in method bodies
Apr 8 2017, 3:58 PM
shentey committed R34:3323be9490b5: assignment is never used (authored by shentey).
assignment is never used
Apr 8 2017, 3:58 PM
shentey committed R34:52740484505e: make attributes private (authored by shentey).
make attributes private
Apr 8 2017, 3:58 PM

Mar 25 2017

shentey committed R34:0efc24bee9ea: AlternativeRoutesModel: expose GeoDataDocument routes const'ified (authored by shentey).
AlternativeRoutesModel: expose GeoDataDocument routes const'ified
Mar 25 2017, 11:18 AM
shentey committed R34:2a6bb562e8b6: handle case "document == nullptr" gracefully (authored by shentey).
handle case "document == nullptr" gracefully
Mar 25 2017, 11:18 AM
shentey committed R34:97bbae032248: don't repeat yourself, no else after return (authored by shentey).
don't repeat yourself, no else after return
Mar 25 2017, 10:26 AM
shentey committed R34:12f4946394b5: const'ify parameter (authored by shentey).
const'ify parameter
Mar 25 2017, 10:21 AM
shentey committed R34:69963d8cc539: no need to override QAbstractItemModel::hasChildren() (authored by shentey).
no need to override QAbstractItemModel::hasChildren()
Mar 25 2017, 10:21 AM

Mar 23 2017

shentey committed R34:d74d365df135: avoid redundant parameter (authored by shentey).
avoid redundant parameter
Mar 23 2017, 8:44 PM

Mar 19 2017

shentey committed R34:4eb1b47c0f53: reduce number of QPainter state changes by drawing pixmaps rather than ellipses (authored by shentey).
reduce number of QPainter state changes by drawing pixmaps rather than ellipses
Mar 19 2017, 2:33 PM
shentey committed R34:94d4fc7bfb4d: simplify (authored by shentey).
simplify
Mar 19 2017, 12:49 PM

Mar 18 2017

shentey committed R34:4f7abf3a48d1: no need to pass a MarbleModel; PositionTracking is sufficient (authored by shentey).
no need to pass a MarbleModel; PositionTracking is sufficient
Mar 18 2017, 1:27 PM
shentey committed R34:2dd0f483c8bc: const'ify (authored by shentey).
const'ify
Mar 18 2017, 1:27 PM
shentey committed R34:bbe59d36380c: resolve padding warning (authored by shentey).
resolve padding warning
Mar 18 2017, 1:27 PM
shentey committed R34:2ca24c123aa9: assume that routing takes place only for planet earth (authored by shentey).
assume that routing takes place only for planet earth
Mar 18 2017, 1:27 PM
shentey committed R34:e71d7edd26eb: add and use GeoDataContainer::isEmpty() method (authored by shentey).
add and use GeoDataContainer::isEmpty() method
Mar 18 2017, 1:17 PM