In D22617#500369, @davidhurka wrote:Making the parts with background color transparent would be better, right? That would even work on systems which don’t access the stylesheet.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Jul 22 2019
Jul 22 2019
ndavis added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
ndavis added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
In D22617#500346, @davidhurka wrote:By the way, the suggested stylesheet in https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze does not follow https://hig.kde.org/style/icon.html as far as I can understand it.
Hi! Thanks for the patch. There are few things I'd like you to change before I accept this.
Fix typo in stylesheets
ndavis committed R266:822b3ae3f88a: Change Highlight to ButtonFocus in stylesheets (authored by ndavis).
Change Highlight to ButtonFocus in stylesheets
ndavis added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
In D22617#500168, @davidhurka wrote:Other icons with fold in the bottom I could find:
- document-duplicate
- document-revert-symbolic[-rtl]
- kt-restore-defaults
- password-copy
- viewpdf
- xml-node-duplicate
- user-desktop-symbolic
- document-multiple
- folder-documents[-symbolic]
- emblem-documents-symbolic
Most icons indeed have the fold at the top, especially Mimetypes icons look great. :)
ndavis added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
In D22617#500031, @davidhurka wrote:Makes sense, so I’m flipping snap-page now. Is that written down somewhere?
In D22647#500137, @ngraham wrote:Right, I see that there's actually no regression. In principle, can you describe what a color scheme needs to do to avoid this situation?
In D22647#500117, @ngraham wrote:Whoa, huge diff. All the more reason why we need to find a way to have all the icons use a single external stylesheet.
This will require documentation changes as well on https://hig.kde.org/style/icon.html and https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips
As for the change itself, this is what happens when using the light color scheme:
Seems like this change just shifts the problem from Breeze Dark to regular Breeze.
ndavis added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
I'll give the latest changes a proper review in a little while.
ndavis retitled D22647: Change Highlight to ButtonFocus in stylesheets from Change Highlight to ViewFocus in stylesheets to Change Highlight to ButtonFocus in stylesheets.
Change ViewFocus to ButtonFocus to match some elements in the Breeze desktop theme
ndavis requested changes to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.
Nice work!
Jul 21 2019
Jul 21 2019
ndavis committed R242:249365e327fa: Remove hardcoded colors (view.svg, system.svg) (authored by ndavis).
Remove hardcoded colors (view.svg, system.svg)
Jul 19 2019
Jul 19 2019
In T11247#192423, @KonqiDragon wrote:In T11247#192402, @ngraham wrote:LXQt's biggest problem is that Plasma itself is now so lightweight that it infringes on LXQt's stated reason for existence. Accordingly, I don't really think it would make sense for LXQt to join KDE; rather, LXQt will probably die off naturally due to lack of a real niche it can sustainably inhabit, and hopefully we can recruit its refugee developers to KDE-land. I think they're already using some KDE Frameworks, right? If so, they're already gaining some familiarity with our technology stack. All we need to do is encourage that.
Maybe then add a lite/hight performance mode to Plasma in settings? In Windows there is something like this, but it doesn't work.
I think it looks pretty cool!
In T11124#191774, @hpereiradacosta wrote:Finally there is still the issue of the HighlightedText foreground color in the palette. It is chosen to have high contrast against the highligh (=focus) color background. This is why it is white in the default color scheme. You should not change this, if you do not want to break other widget themes, or break text selection. If you want to manually lighten the focus/highlight color, by adding some translucency, so that you do not have to change the text color, you must make sure to use the QPalette::Text or QPalette::WindowText role, rather than modifying the palette's HighlightedText role. For monochrome icons there is the extra complication that the QIcon::Selected state will by default use the HighlightedText role for its main color. So what you would then need is to use the QIcon::Normal state instead of ::Selected, everywhere you do not want this color change to happen.
Jul 18 2019
Jul 18 2019
Looks good!
Looks good!
Jul 17 2019
Jul 17 2019
In D22493#496618, @broulik wrote:Is it just me or does vertical alignment look off now? How does it affect the popup layout?
Jul 15 2019
Jul 15 2019
I'm willing to do work on this, but I'd like to say that I think there is room for some variety.
The latest version of this patch is better because it works well for people using the Breeze GTK theme with the Breeze colorscheme and it doesn't make the Breeze Dark GTK theme worse when combined with the Breeze Dark colorscheme. However, it does cause Breeze GTK to look odd when used with the Breeze Dark colorscheme:
Can I change the selection background color and use the selection color for the background of highlights? Then the regular highlight color could be used mainly for line highlights and outlines.
Abandoning because it can negatively affect other widget styles.
Abandoning because it can negatively affect other widget styles.
Thanks for the color overview. I'll avoid changing the highlighted text color in the colorscheme.
In T11124#191744, @ngraham wrote:...Which reminds me, these QStyle changes are going to need to be replicated in qqc2-desktop-style too. And maybe also Kirigami in some places.
Jul 14 2019
Jul 14 2019
In T11124#191725, @hpereiradacosta wrote:
- For the record: toolbar buttons (or rather QToolButtons) can have focus too, when they are used outside of toolbars (and there are examples of such everywhere, for instance when you have an "open" button next to a text entry for selecting a file.
This causes a problem with Breeze and Breeze Dark when the titlebar is enabled.
In T10997#191697, @mglb wrote:
I need some help coming up with a consistent way of showing a distinct difference between mouse hover, keyboard focus and the sunken state. Here's what I know about how different widget types use these.
In D22452#495224, @zzag wrote:I'm not a Breeze GTK maintainer or developer
There is currently no maintainer of breeze-gtk
Looks good to me.
Can you post a picture of what this change is supposed to do?
Jul 9 2019
Jul 9 2019
ndavis requested review of D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size".
Jul 6 2019
Jul 6 2019
LGTM
Jul 5 2019
Jul 5 2019
ndavis added a comment to D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background.
Works for me. Tested RTL with kate --reverse.
ndavis requested changes to D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background.
Actually, I did find one problem that I missed from before:
ndavis accepted D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background.
As far as I can tell, there aren't any problems with this patch. Some apps like Spectacle and the system tray settings don't follow the new style, but they don't use Qt Widgets for the sidebar.
In D22147#491119, @apol wrote:In D22147#490887, @ndavis wrote:I've compiled this with the latest commits, but the problem hasn't gone away.
Try removing .cache/plasma-svgelements-default_v5.60.0 and .cache/plasma_theme_default_v5.60.0.kcache.
Jul 4 2019
Jul 4 2019
ndavis committed R296:f18d43b7ffd8: [GridDelegate] Fix gaps in corners of thumbnailArea highlight (authored by ndavis).
[GridDelegate] Fix gaps in corners of thumbnailArea highlight
ndavis added a comment to D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background.
In D22138#491018, @hpereiradacosta wrote:In D22138#490967, @ndavis wrote:Since this apparently doesn't need review,
This is not what I said. What I said is "thanks, it looks fantastic" is not a proper review and hence irrelevant. What I expect for a proper review is
- does the patch achieve the behavior matching its title, and is it the intended behavior
- does the code look legit (compiles, properly formatted, etc.)
- is there a better way to achieve the same
- does the patch break other things, and how can it be improved so that it doesn't If you can provide such a review I'd be happy to modify the patch accordingly.
I'll resign.
Anyone want to approve or request changes? It's not perfect, but it's a simple improvement. The ideal solution would require me to work around a problem with QML where images can't have their corners rounded by a parent object's border radius.
- Remove radius when thumbnail is present
ndavis resigned from D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background.
Since this apparently doesn't need review, I'll resign.
In D22259#490892, @stevenv wrote:In D22259#490551, @ndavis wrote:I like the idea of having a thinner sidebar, but I don't like the idea of having unlabelled views by default. I think hiding labels would hurt usability for first time users.
I was on the fence about hiding the text for exactly that reason. But since the text is so wide it keeps the sidebar huge too. From a usability standpoint I think the tooltips might be enough, but I'm not a designer.
I can confirm this fixes the problem here: https://phabricator.kde.org/D22147#490563
I've compiled this with the latest commits, but the problem hasn't gone away.
@apol This patch seems to have caused a bug in the way icons are loaded for the system tray:
I like the idea of having a thinner sidebar, but I don't like the idea of having unlabelled views by default. I think hiding labels would hurt usability for first time users.
Are we sure Breeze doesn't already have a maintainer? It would be good not to offend the existing one by implying that he will be replaced. Although I guess it's possible for more than one person to be a maintainer. I believe that is the case with KWin since Martin stepped down.
Jul 3 2019
Jul 3 2019
In D22191#489958, @filipf wrote:In D22191#489925, @ndavis wrote:In D22191#489915, @GB_2 wrote:I think then you would have to type in your password every time you change a setting.
Would you really? There couldn't be a service running with the right permissions that automatically synchronizes settings on logout/user switch/shutdown/when a change is detected? It seems like it should be possible, but I don't know what the security implications would be.
It's copying to sddm owned directories so it does need root permissions... something would have to be worked out, not sure what the possibilities are though. Also this would have to be enabled by default solely for single user systems, otherwise you run the risk of the login screen always changing appearance based on the user that was last logged in.
Add highlightBackgroundColor()
Change QListView style
Add renderTableItemSelection
Fix frame sides
Remove qtquickcontrols dir
ndavis committed R31:107577271a40: - fixed "missing override" warnings - removed useless "virtual" specifications… (authored by hpereiradacosta).
- fixed "missing override" warnings - removed useless "virtual" specifications…
In D22191#489915, @GB_2 wrote:I think then you would have to type in your password every time you change a setting.
Jul 2 2019
Jul 2 2019
Jul 1 2019
Jul 1 2019
In T11124#190163, @filipf wrote:For tool buttons it might be nice to use the Kickoff effect (when pressed). When hovered over they can look the same as they do now = only show a border.
Jun 30 2019
Jun 30 2019
In D22102#487806, @ngraham wrote:Maybe I should move back and examine the rationale for the proposal.
Right now, I find it *extremely* annoying, slow, and frustrating to test new themes, colors, icons, wallpapers, etc. The workflow is to click on the delegate, and then click on the Apply button in the corner of the window, or use its hidden Alt accelerator. If I want to see 5 items, I do this five times. If I want to look through 20 items, I do this 20 times. Every time I do this, I get frustrated and feel like it should be doable in a faster way.
This proposal is one way to resolve the issue. I don't personally see a problem with the hidden double-click accelerator (obviously, or else I wouldn't have submitted the patch :) ), but if people don't like this approach, I hope we can have a conversation about alternative approaches to resolve the underlying issue of the test-multiple-items-in-a-grid-view-KCM workflow being quite slow. I can think of a few:
- Move to the instant apply paradigm
- Add Preview buttons to all delegates that "virtually" apply the item to everything visible on screen
- Do the above, but on hover or selection, with a visible message that says "this is just a preview", click Apply to apply these settings"
- Probably way more
In D10362#488389, @ngraham wrote:I think the idea is that you're not supposed to be typing with the characters visible as you type because then anyone else who might be around could just see your password.
-1 for the current version
Jun 29 2019
Jun 29 2019
I'm accepting this, but make sure you don't land this until you've submitted the other patches.
Nice job!
Jun 28 2019
Jun 28 2019
Sorry, my bad once again. I hadn't actually applied D22108. It works for me now. The tab highlight width problem must be somewhere else since this patch didn't introduce that bug.
whoops, didn't mean to accept
In D22128#487943, @ngraham wrote:Even after also applying D22108 it's better but still not quite touching the line for me (1x scale, 1080p screen):
Remove qtquickcontrols dir
Since these seem to be scaled 2x, the thicker 6px highlight is more desirable. At 1x, the highlight should be 3px.
Jun 27 2019
Jun 27 2019
Why is the tab highlight thicker in these
Add snoretoast icon
The WhatsApp icon seems to be about 96px, if it has margins.