Feed Advanced Search

Jun 27 2019

ndavis added a comment to D22126: Add snoretoast icon.

I think a bigger one than 265 could be used here (windows start menu)

Jun 27 2019, 8:19 PM
ndavis added a comment to D22126: Add snoretoast icon.
Jun 27 2019, 7:52 PM
ndavis added a comment to D22126: Add snoretoast icon.

You don't actually need the 22px version for Windows, but since KDE Applications use that size, I figured I should put it in the SVG in case you ever need it.

Jun 27 2019, 7:45 PM
ndavis updated the diff for D22126: Add snoretoast icon.
  • Add pngs
Jun 27 2019, 7:43 PM
ndavis updated the summary of D22126: Add snoretoast icon.
Jun 27 2019, 7:16 PM
ndavis updated the test plan for D22126: Add snoretoast icon.
Jun 27 2019, 6:52 PM
ndavis added a reviewer for D22126: Add snoretoast icon: vonreth.
Jun 27 2019, 6:51 PM
ndavis requested review of D22126: Add snoretoast icon.
Jun 27 2019, 6:51 PM
ndavis added a comment to D22106: [Separator] Match Breeze borders' color.

+1 visually, but I agree that the Breeze Widget theme should be the part that provides the theming, if possible.

Jun 27 2019, 4:55 PM · Kirigami
ndavis accepted D22108: [TabBar] Remove exterior margins.

1+ visually. How does it look with a vertical panel?

Still not gliding on the line, but that should be resolved in Kickoff somehow:

Jun 27 2019, 4:52 PM · Frameworks
ndavis added a comment to D22108: [TabBar] Remove exterior margins.

1+ visually. How does it look with a vertical panel?

Jun 27 2019, 12:05 PM · Frameworks

Jun 25 2019

ndavis added a comment to D19471: Middle-elide file/folder labels so the extension is always visible.

It feels strange at first, but I think it's a good idea.

Jun 25 2019, 9:33 PM · Dolphin
ndavis added a comment to D18571: Add "apply on double-click" feature to most other recent ported KCMs.

Agreed

Jun 25 2019, 9:30 PM · Plasma
ndavis committed R31:fdee0cbe3e97: Add RTL support to renderSidePanelItem (authored by ndavis).
Add RTL support to renderSidePanelItem
Jun 25 2019, 2:52 PM
ndavis committed R31:e4be7270a94b: Fix radius (authored by ndavis).
Fix radius
Jun 25 2019, 1:18 PM
ndavis added a comment to T11124: Unify highlight effect style.

As soon as the official highlight effect(s) are defined, they need to be added to the HIG https://invent.kde.org/websites/hig-kde-org/issues/10

Jun 25 2019, 8:00 AM · Plasma, Breeze, Consistency, VDG

Jun 24 2019

ndavis committed R31:5a14790a412e: Nicer table view (authored by ndavis).
Nicer table view
Jun 24 2019, 6:02 PM
ndavis committed R31:4f09c0bd5365: squaaaash (authored by ndavis).
squaaaash
Jun 24 2019, 2:31 PM
ndavis committed R31:85466bfadf8f: Adjust MenuBarItem highlight radius (authored by ndavis).
Adjust MenuBarItem highlight radius
Jun 24 2019, 2:23 PM
ndavis committed R31:4ff7f67a12e3: Add MenuBarItem highlights (authored by ndavis).
Add MenuBarItem highlights
Jun 24 2019, 2:19 PM
ndavis committed R31:d5f012671e12: So many things, I'll end up squashing this anyway (authored by ndavis).
So many things, I'll end up squashing this anyway
Jun 24 2019, 1:35 PM

Jun 23 2019

ndavis committed R31:345f0e14b2ce: Make highlights similar to Kickoff highlight (authored by ndavis).
Make highlights similar to Kickoff highlight
Jun 23 2019, 2:34 PM
ndavis committed R31:df5ab1bfa328: Make context menu highlight similar to Kickoff highlight (authored by ndavis).
Make context menu highlight similar to Kickoff highlight
Jun 23 2019, 2:28 PM
ndavis closed D21999: [WIP] Make highlights similar to Kickoff highlight.
Jun 23 2019, 2:28 PM · Plasma
ndavis retitled D21999: [WIP] Make highlights similar to Kickoff highlight from [WIP] Make context menu highlight similar to Kickoff highlight to [WIP] Make highlights similar to Kickoff highlight.
Jun 23 2019, 1:11 PM · Plasma
ndavis accepted D22041: [Avatar Gallery] Increase minimum width.
Jun 23 2019, 12:46 PM · Plasma

Jun 22 2019

ndavis added a comment to T11124: Unify highlight effect style.
In T11124#189782, @mglb wrote:

Another thing to consider is how it looks with a scrollbar and with a dock placed on window right side.

Jun 22 2019, 11:42 PM · Plasma, Breeze, Consistency, VDG
ndavis added a comment to D22000: [colors/Breeze] Change selected text color to black.

Looks fine in the menu, but black on bright blue in the list model below is just wrong now.

Jun 22 2019, 3:48 PM · Plasma
ndavis updated the summary of D22000: [colors/Breeze] Change selected text color to black.
Jun 22 2019, 3:31 PM · Plasma
ndavis added a dependency for D22003: Change selected text color to black: D22000: [colors/Breeze] Change selected text color to black.
Jun 22 2019, 3:31 PM · Frameworks
ndavis added a dependent revision for D22000: [colors/Breeze] Change selected text color to black: D22003: Change selected text color to black.
Jun 22 2019, 3:31 PM · Plasma
ndavis requested review of D22003: Change selected text color to black.
Jun 22 2019, 3:30 PM · Frameworks
ndavis added a dependent revision for D21999: [WIP] Make highlights similar to Kickoff highlight: D22003: Change selected text color to black.
Jun 22 2019, 3:30 PM · Plasma
ndavis updated the test plan for D22000: [colors/Breeze] Change selected text color to black.
Jun 22 2019, 3:10 PM · Plasma
ndavis retitled D22000: [colors/Breeze] Change selected text color to black from Change selected text color to black to [colors/Breeze] Change selected text color to black.
Jun 22 2019, 2:50 PM · Plasma
ndavis accepted D22002: [Look and Feel KCM] Use view-preview for preview button.
Jun 22 2019, 2:46 PM · Plasma
ndavis added a revision to T11124: Unify highlight effect style: D22000: [colors/Breeze] Change selected text color to black.
Jun 22 2019, 2:44 PM · Plasma, Breeze, Consistency, VDG
ndavis added a task to D22000: [colors/Breeze] Change selected text color to black: T11124: Unify highlight effect style.
Jun 22 2019, 2:44 PM · Plasma
ndavis updated the summary of D22000: [colors/Breeze] Change selected text color to black.
Jun 22 2019, 2:44 PM · Plasma
ndavis requested review of D22000: [colors/Breeze] Change selected text color to black.
Jun 22 2019, 2:43 PM · Plasma
ndavis updated the diff for D21999: [WIP] Make highlights similar to Kickoff highlight.

Remove unnecessary if statement

Jun 22 2019, 2:32 PM · Plasma
ndavis added a comment to T11124: Unify highlight effect style.

I think adding highlights to panel widgets might be a good idea. Right now, the only indication that a panel widget might be clickable is that it gets slightly brighter, but that doesn't work with Breeze dark because the icons are already bright.

Jun 22 2019, 2:27 PM · Plasma, Breeze, Consistency, VDG
ndavis retitled D21999: [WIP] Make highlights similar to Kickoff highlight from Make context menu highlight similar to Kickoff highlight to [WIP] Make context menu highlight similar to Kickoff highlight.
Jun 22 2019, 2:00 PM · Plasma
ndavis updated the summary of D21999: [WIP] Make highlights similar to Kickoff highlight.
Jun 22 2019, 1:50 PM · Plasma
ndavis updated the test plan for D21999: [WIP] Make highlights similar to Kickoff highlight.
Jun 22 2019, 1:48 PM · Plasma
ndavis requested review of D21999: [WIP] Make highlights similar to Kickoff highlight.
Jun 22 2019, 1:46 PM · Plasma

Jun 21 2019

ndavis edited reviewers for D21969: Remove qtquickcontrols dir, added: Plasma; removed: mart.
Jun 21 2019, 5:30 PM · Plasma
ndavis added a reviewer for D21969: Remove qtquickcontrols dir: mart.
Jun 21 2019, 3:42 PM · Plasma
ndavis requested review of D21969: Remove qtquickcontrols dir.
Jun 21 2019, 3:40 PM · Plasma
ndavis accepted D21926: Have more contrast in circle-style user avatars.
Jun 21 2019, 3:23 PM · Plasma
ndavis accepted D21966: Add disk-quota icons.
Jun 21 2019, 2:27 PM · Frameworks
ndavis accepted D21958: [quota] Use new breeze icons.
Jun 21 2019, 2:26 PM · Plasma
ndavis accepted D21958: [quota] Use new breeze icons.
Jun 21 2019, 12:35 PM · Plasma
ndavis accepted D21957: Add disk-quota icons.
Jun 21 2019, 10:34 AM · Frameworks
ndavis added a comment to T11124: Unify highlight effect style.

Here's what I imagine context menus would look like with Effect 1:

Jun 21 2019, 9:43 AM · Plasma, Breeze, Consistency, VDG
ndavis committed R128:8be2414e1012: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars (authored by ndavis).
Add new Konqi avatars & remove classic, bluestyle, old konqi avatars
Jun 21 2019, 9:00 AM
ndavis closed D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
Jun 21 2019, 8:59 AM · Plasma
ndavis updated the test plan for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
Jun 21 2019, 8:50 AM · Plasma
ndavis updated the diff for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.

Add Musician Konqi

Jun 21 2019, 8:48 AM · Plasma
ndavis committed R119:750343bd0263: Update joystick kcm documentation for game controllers (authored by ndavis).
Update joystick kcm documentation for game controllers
Jun 21 2019, 8:43 AM
ndavis closed D21925: Update joystick kcm documentation for game controllers.
Jun 21 2019, 8:43 AM · Documentation, Plasma
ndavis updated the diff for D21925: Update joystick kcm documentation for game controllers.

Add suggested change

Jun 21 2019, 8:41 AM · Documentation, Plasma
ndavis added a comment to D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.

I feel like these names should be localized, but the gallery gets the names from the file names. No translations unless that gets fixed.

Jun 21 2019, 5:40 AM · Plasma
ndavis added a comment to D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.

Agreed with all the removals.

New ones should be sufficient for just about any screen and they look great. I'm okay with the namings. Good work!

If it's doable, I would only possibly consider replacing PC Builder Konqi with Guitar Player Konqi. It's might not be super clear what's happening in the former, but that latter is pretty obvious.

Jun 21 2019, 5:36 AM · Plasma

Jun 20 2019

ndavis added a comment to D21926: Have more contrast in circle-style user avatars.

Unless you want to get rid of the SVG these avatars were created from, you should also update pics_sources/avatar.svg.

Jun 20 2019, 6:05 PM · Plasma
ndavis added a comment to D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
In D21939#482800, @GB_2 wrote:

Great! I'd only change the name of these avatars:
Boss Konqi -> Banker Konqi
Hacker Konqi -> Developer Konqi / Programmer Konqi

Jun 20 2019, 5:54 PM · Plasma
ndavis updated the diff for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.

Rename duelist to card shark

Jun 20 2019, 5:49 PM · Plasma
ndavis added a comment to D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.

Saying i

Jun 20 2019, 5:47 PM · Plasma
ndavis updated the diff for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.

Fix spelling of dualist

Jun 20 2019, 5:43 PM · Plasma
ndavis updated the test plan for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
Jun 20 2019, 5:42 PM · Plasma
ndavis updated the diff for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.

Change names of Bugcatcher and Officeworker to be more grammatically correct

Jun 20 2019, 5:41 PM · Plasma
ndavis updated the test plan for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
Jun 20 2019, 4:44 PM · Plasma
ndavis updated the test plan for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
Jun 20 2019, 4:44 PM · Plasma
ndavis requested review of D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
Jun 20 2019, 4:40 PM · Plasma
ndavis updated the summary of D21925: Update joystick kcm documentation for game controllers.
Jun 20 2019, 12:51 PM · Documentation, Plasma
ndavis updated the summary of D21925: Update joystick kcm documentation for game controllers.
Jun 20 2019, 12:50 PM · Documentation, Plasma
ndavis requested review of D21925: Update joystick kcm documentation for game controllers.
Jun 20 2019, 12:47 PM · Documentation, Plasma
ndavis committed R266:7ef3c35c7ed6: Change joystick settings icon to game controller (authored by ndavis).
Change joystick settings icon to game controller
Jun 20 2019, 11:46 AM
ndavis closed D21919: Change joystick settings icon to game controller.
Jun 20 2019, 11:46 AM · Frameworks
ndavis committed R119:1c24138b481a: Rename Joystick KCM to Game Controller (authored by ndavis).
Rename Joystick KCM to Game Controller
Jun 20 2019, 11:01 AM
ndavis closed D21922: Rename Joystick KCM to Game Controller.
Jun 20 2019, 11:01 AM · Plasma
ndavis requested review of D21922: Rename Joystick KCM to Game Controller.
Jun 20 2019, 10:44 AM · Plasma
ndavis updated the summary of D21919: Change joystick settings icon to game controller.
Jun 20 2019, 9:51 AM · Frameworks
ndavis updated the test plan for D21919: Change joystick settings icon to game controller.
Jun 20 2019, 9:49 AM · Frameworks
ndavis requested review of D21919: Change joystick settings icon to game controller.
Jun 20 2019, 9:47 AM · Frameworks

Jun 18 2019

ndavis added a comment to T10870: Consider using colorful rather than monochrome icons for small places, devices, and mimetype icons.

About 190 files would need to be changed for 16px and 22px for a total of about 380, but most of it is just very repetitive (Add background, move symbol down a bit) and at least we don't need to worry about stylesheets. If I cleaned and autoformatted all of the SVGs, I could script a lot of the background changes, but I think I'd need to manually move the symbols.

Jun 18 2019, 6:44 PM · VDG

Jun 17 2019

ndavis added a comment to T10201: Window titlebars.

What do you think of: (opaque on the left, transparent on the right)

Jun 17 2019, 11:58 PM · KDE Applications, VDG

Jun 16 2019

ndavis added a comment to D18377: [effects/blur] Update blur to be more natural.
In D18377#480824, @zzag wrote:

I just downloaded the KDE Neon 5.16 iso from the website, installed it and updated it

You need an Intel graphics card to reproduce this bug.

Jun 16 2019, 7:37 PM · KWin
ndavis added a comment to D18377: [effects/blur] Update blur to be more natural.

Jun 16 2019, 5:40 PM · KWin
ndavis added a comment to D18377: [effects/blur] Update blur to be more natural.

I am using Plasma 5.16, this patch probably can create TOO DARKISH results so the natural part of the commit is not valid and probably breaks users experience also:

Konsole fully transparent:

Jun 16 2019, 5:29 PM · KWin
ndavis added a comment to T10046: Improve the colors, color consistency and colorscheme compatibility of Breeze.

[...] I like what Deepin does with its deepin-dark icon theme, it mutes icons as well:

Jun 16 2019, 1:40 AM · KDE Human Interface Guidelines, VDG, Plasma, Breeze
ndavis added a comment to T10046: Improve the colors, color consistency and colorscheme compatibility of Breeze.

I don't think it's a particularly good thing to have the folder colors the same color as the highlight color because the contrast would be (and currently is) poor. Also, if we are going to make the folder color match the highlight color, it would make sense to make the folder color change with the colorscheme. People have requested that and I tried that already, but it just doesn't work well. Folders end up looking way too dark on colorschemes with dark highlights and dark background colors.

Jun 16 2019, 1:36 AM · KDE Human Interface Guidelines, VDG, Plasma, Breeze

Jun 15 2019

ndavis added a comment to D21813: RFC: Consider adding more padding to the desktop theme.

Hmm. I don't think we should increase the padding on the desktop theme. That kind of approach seems like it would work best once we know the contents of notifications and OSDs are aligned how we want them to be in the code.

Jun 15 2019, 12:46 AM · Frameworks
ndavis added a comment to D21813: RFC: Consider adding more padding to the desktop theme.

I like the rounder corners! :)

Jun 15 2019, 12:12 AM · Frameworks
ndavis added a comment to D21813: RFC: Consider adding more padding to the desktop theme.

Besides the notifications, where does this add padding?

Jun 15 2019, 12:09 AM · Frameworks

Jun 13 2019

ndavis requested changes to D21656: Create a breeze icon for kfourinline.
Jun 13 2019, 11:08 PM · Frameworks
ndavis added a comment to D21656: Create a breeze icon for kfourinline.

I just tried the patch on my own computer and I noticed a few more things that need to be changed:

Jun 13 2019, 11:08 PM · Frameworks

Jun 12 2019

ndavis updated the description for M151: Dynamic Locally Integrated Menu.
Jun 12 2019, 10:05 PM · Breeze, VDG, KWin
ndavis added a project to M151: Dynamic Locally Integrated Menu: Breeze.
Jun 12 2019, 9:25 PM · Breeze, VDG, KWin
ndavis updated the description for M151: Dynamic Locally Integrated Menu.
Jun 12 2019, 9:06 PM · Breeze, VDG, KWin