In D22126#487441, @vonreth wrote:
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Jun 27 2019
Jun 27 2019
In D22126#487438, @vonreth wrote:I had a look at https://github.com/KDE/extra-cmake-modules/blob/master/modules/ECMAddAppIcon.cmake#L221 a 1024 icon could also be useful.
You don't actually need the 22px version for Windows, but since KDE Applications use that size, I figured I should put it in the SVG in case you ever need it.
+1 visually, but I agree that the Breeze Widget theme should be the part that provides the theming, if possible.
In D22108#487329, @filipf wrote:In D22108#487218, @ndavis wrote:1+ visually. How does it look with a vertical panel?
Still not gliding on the line, but that should be resolved in Kickoff somehow:
1+ visually. How does it look with a vertical panel?
Jun 25 2019
Jun 25 2019
ndavis added a comment to D19471: Middle-elide file/folder labels so the extension is always visible.
It feels strange at first, but I think it's a good idea.
ndavis added a comment to D18571: Add "apply on double-click" feature to most other recent ported KCMs.
Agreed
Add RTL support to renderSidePanelItem
In T11124#189927, @fabianr wrote:As soon as the official highlight effect(s) are defined, they need to be added to the HIG https://invent.kde.org/websites/hig-kde-org/issues/10
Jun 24 2019
Jun 24 2019
Nicer table view
Adjust MenuBarItem highlight radius
Add MenuBarItem highlights
ndavis committed R31:d5f012671e12: So many things, I'll end up squashing this anyway (authored by ndavis).
So many things, I'll end up squashing this anyway
Jun 23 2019
Jun 23 2019
ndavis committed R31:345f0e14b2ce: Make highlights similar to Kickoff highlight (authored by ndavis).
Make highlights similar to Kickoff highlight
ndavis committed R31:df5ab1bfa328: Make context menu highlight similar to Kickoff highlight (authored by ndavis).
Make context menu highlight similar to Kickoff highlight
ndavis retitled D21999: [WIP] Make highlights similar to Kickoff highlight from [WIP] Make context menu highlight similar to Kickoff highlight to [WIP] Make highlights similar to Kickoff highlight.
Jun 22 2019
Jun 22 2019
In T11124#189782, @mglb wrote:Another thing to consider is how it looks with a scrollbar and with a dock placed on window right side.
In D22000#484409, @IlyaBizyaev wrote:Looks fine in the menu, but black on bright blue in the list model below is just wrong now.
ndavis added a dependency for D22003: Change selected text color to black: D22000: [colors/Breeze] Change selected text color to black.
ndavis added a dependent revision for D22000: [colors/Breeze] Change selected text color to black: D22003: Change selected text color to black.
ndavis added a dependent revision for D21999: [WIP] Make highlights similar to Kickoff highlight: D22003: Change selected text color to black.
ndavis retitled D22000: [colors/Breeze] Change selected text color to black from Change selected text color to black to [colors/Breeze] Change selected text color to black.
Remove unnecessary if statement
I think adding highlights to panel widgets might be a good idea. Right now, the only indication that a panel widget might be clickable is that it gets slightly brighter, but that doesn't work with Breeze dark because the icons are already bright.
ndavis retitled D21999: [WIP] Make highlights similar to Kickoff highlight from Make context menu highlight similar to Kickoff highlight to [WIP] Make context menu highlight similar to Kickoff highlight.
Jun 21 2019
Jun 21 2019
ndavis committed R128:8be2414e1012: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars (authored by ndavis).
Add new Konqi avatars & remove classic, bluestyle, old konqi avatars
ndavis updated the test plan for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
ndavis updated the diff for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
Add Musician Konqi
ndavis committed R119:750343bd0263: Update joystick kcm documentation for game controllers (authored by ndavis).
Update joystick kcm documentation for game controllers
Add suggested change
ndavis added a comment to D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
I feel like these names should be localized, but the gallery gets the names from the file names. No translations unless that gets fixed.
ndavis added a comment to D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
In D21939#482934, @filipf wrote:Agreed with all the removals.
New ones should be sufficient for just about any screen and they look great. I'm okay with the namings. Good work!
If it's doable, I would only possibly consider replacing PC Builder Konqi with Guitar Player Konqi. It's might not be super clear what's happening in the former, but that latter is pretty obvious.
Jun 20 2019
Jun 20 2019
Unless you want to get rid of the SVG these avatars were created from, you should also update pics_sources/avatar.svg.
ndavis added a comment to D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
In D21939#482800, @GB_2 wrote:Great! I'd only change the name of these avatars:
Boss Konqi -> Banker Konqi
Hacker Konqi -> Developer Konqi / Programmer Konqi
ndavis updated the diff for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
Rename duelist to card shark
ndavis added a comment to D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
Saying i
ndavis updated the diff for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
Fix spelling of dualist
ndavis updated the test plan for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
ndavis updated the diff for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
Change names of Bugcatcher and Officeworker to be more grammatically correct
ndavis updated the test plan for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
ndavis updated the test plan for D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
ndavis requested review of D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars.
ndavis committed R266:7ef3c35c7ed6: Change joystick settings icon to game controller (authored by ndavis).
Change joystick settings icon to game controller
Rename Joystick KCM to Game Controller
Jun 18 2019
Jun 18 2019
ndavis added a comment to T10870: Consider using colorful rather than monochrome icons for small places, devices, and mimetype icons.
About 190 files would need to be changed for 16px and 22px for a total of about 380, but most of it is just very repetitive (Add background, move symbol down a bit) and at least we don't need to worry about stylesheets. If I cleaned and autoformatted all of the SVGs, I could script a lot of the background changes, but I think I'd need to manually move the symbols.
Jun 17 2019
Jun 17 2019
In T10201#189212, @niccolove wrote:
Jun 16 2019
Jun 16 2019
In D18377#480824, @zzag wrote:In D18377#480776, @anemeth wrote:I just downloaded the KDE Neon 5.16 iso from the website, installed it and updated it
You need an Intel graphics card to reproduce this bug.
In D18377#480678, @mvourlakos wrote:
ndavis added a comment to T10046: Improve the colors, color consistency and colorscheme compatibility of Breeze.
In T10046#189036, @filipf wrote:
ndavis added a comment to T10046: Improve the colors, color consistency and colorscheme compatibility of Breeze.
I don't think it's a particularly good thing to have the folder colors the same color as the highlight color because the contrast would be (and currently is) poor. Also, if we are going to make the folder color match the highlight color, it would make sense to make the folder color change with the colorscheme. People have requested that and I tried that already, but it just doesn't work well. Folders end up looking way too dark on colorschemes with dark highlights and dark background colors.
Jun 15 2019
Jun 15 2019
Hmm. I don't think we should increase the padding on the desktop theme. That kind of approach seems like it would work best once we know the contents of notifications and OSDs are aligned how we want them to be in the code.
In D21813#479952, @ngraham wrote:I like the rounder corners! :)
Besides the notifications, where does this add padding?
Jun 13 2019
Jun 13 2019
I just tried the patch on my own computer and I noticed a few more things that need to be changed:
Jun 12 2019
Jun 12 2019