In D17595#473825, @meven wrote:

I guess we need now to reach to schwarzerf@gmail.com romaninflianskas mfuchs chinmoyr mitchell emateli emmanuelp freininghaus to have lgplv2+ approval.

You shouldn't depend on the implementation details of ioslaves. KIO has a well-defined interface to determine if an protocol can be handled.
And if the implementation of this interface is not good enough, then it needs to be improved (e.g. decrease number of file system look-ups, better cache invalidation, ...).

A better fix is https://git.reviewboard.kde.org/r/123253/

In D7700#144819, @nicolasfella wrote:

What do you think would be a reasonable number of tags? 5, 10, 20, ..? Make it configurable?

(I'll commit your patches in the evening)

Thanks for the patch!

In D7690#144674, @ngraham wrote:

@emmanuelp Does this look commitable now?

In D7440#138187, @broulik wrote:

-1 Urgh. Can we perhaps have a static QStringList KIO::PreviewJob::defaultPlugins()? It's not just Dolphin that has a copy of this (file dialog et al). And this way we could have flip it around to whitelist all plugins (find them through KService) and then have a user blacklist and perhaps by default blacklist stupid thumbnailers like "plain text".

In D7655#143872, @elvisangelaccio wrote:

3. This patch.

In D7571#142637, @dfaure wrote:

An application copying some config file in the background (or any other internal file operation) shouldn't bother the user with prompts.

Hmm I don't think that we should add additional shortcuts to user-defined shortcuts. What if the user assigned {Shift, Del} to something different?

Some nitpicks, looks good otherwise!

Nice work! Thanks!

Last round

Nice work! :)

LGTM!

Nice work!

Nice addition :)

In D6269#117847, @broulik wrote:

• Adjust timeRoleGroups so it takes a lambda where we can then return the proper timestamp (either from KFileItem or a role)

Special handling of DeletionDateRole is missing in:

• KFileItemModel::sortRoleCompare (see ModificationTimeRole for an example)
• KFileItemModel::groups -> requires that timeRoleGroups() uses the sort role instead of KFileItem::FileTimes

In D6269#117553, @cfeck wrote:

If trash KIO is already inconsistent we can indeed pick being inconsistent with either it or with the rest of Dolphin.

But I am concerned about the UI string.

Oh thanks! Totally missed it during review :/

In D4134#98027, @broulik wrote:

Given PreviewJob now does the "right thing" by default, I think we can discard this.

In D5138#97024, @adridg wrote:

So, Linux, sort out your *stat(2) interfaces first and we'll get back to you.

Thanks!

Nice!

Nice work! :)

Nice feature :)

Nice, thanks!

Can you please add a new function to global.h which encapsulates all this?
Maybe "Dolphin::openNewWindow(urls, flags = None)"

Do you have commit access?

In D4560#87675, @vishalrao wrote:

I guess, yeah 300 ms and InOutQuart would look good to me too.

Thanks for the patch!

Nice!

Thanks for the adjustments, looks good!

Looks good otherwise!

Nice, thanks!

I'm wondering if we should make this the default in PreviewJob

Ah ok submitting my previous comment fixed it (don't know what happened) :)

The diff is somehow corrupted ...

I see some potential problems with the QPalette key approach. The key only covers some parts of the palette, so it is not really future proof when colors different than text, highlight or highlighted text are used in future. It also requires more memory because the cache still holds old unused pixmaps (only true if number of used pixmaps doesn't exceed the cache limit). Also the keys are much longer which requires more work when generating and hashing the keys.

Wouldn't it be easier if you just clear the pixmap cache on palette change? e.g. in MainWindow?
A palette change basically invalidates all cached icons, so I don't see any advantage in adding the palette information to the key (... use cases like frequently toggling between two palettes are not supported).