Do I have to reset something on my machine after this?
Jul 19 2019
Jun 23 2019
No problem! I noticed 2 other things:
Looks like a copy-paste bug.
Jun 1 2019
I took another look. As I already mentioned, there seems to be a difference between how onLoginFailed signals work in both.
In the lock screen:
- the onLoginFailed signal is delivered as soon as the password is detected to be incorrec. I use this signal to selectAll() the password text so the user can start editing.
- The grace timeout is a separate signal onGraceLockedChanged, which is used to clear the "Login failed" message.
To summarize, the flow is: (enter password) --> (loginFailed) --[authenticator timeout expires]--> (graceLockedChanged).
May 31 2019
Friendly ping! Since the behaviour is already different, can we merge this one and work on the SDDM part in a later PR?
May 13 2019
This one was easy enough. I definitely liked the fact that I could edit the qml files directly and test it live without going through a compilation step. I especially enjoyed it after I managed to crash the lock screen with a typo but was able to fix the stuck lock screen by editing the qml file in a tty and killing the lockscreen process to make it reload. On the other hand, a compilation step here would've prevented this in the first place!
Cool! Thank you for the pointers to the correct place. It was much easier than I thought once I looked at the code.
That's correct. 2 points however:
- I think the detection of a wrong password is very fast and at least on my system I immediately get the highlighted focus. When you say muted, is it slow to do this for you?
- We probably can't do the immediate focus because of the bug mentioned on line 49: https://cgit.kde.org/plasma-workspace.git/tree/lookandfeel/contents/lockscreen/MainBlock.qml#n47. It seems if the password was entered correctly and the textbox has focus, the app would crash.
Update diff to master.
Jul 16 2018
Thank you for the clarification @bcooksley. I wonder if there is a way to enforce compilation of certain parts single threaded in make. Or some other way to ensure testing these components.
Jul 15 2018
Hi. This commit seems to have introduced a build failure when the optional component PythonModuleGeneration is enabled: https://paste.kde.org/pvh0kutbq/5jo1sl