In D19090#413998, @bruns wrote:

Nitpick - "Hardcoding ..." -> "Hardcode" or better "Use a fixed interval for updating the Remaining Time"

In D18021#389167, @apol wrote:

Good catch!

Is there an artwork for this? Something like a konqi, a 22, the KDE logo and "happy birthday". I would like to put this on a cake.

In D12913#268181, @paolini wrote:

About the crash above: the problem resides in AbstractLineImp::isPropertyDefinedOnOrThroughThisImp...
However it involves more than the new Golden Point. Perhaps the right action should be to file a bug
report.

Thanks for the patch, looks good.

Thanks for the patch, @bourquin, please fix the casing issue I pointed out and I think it is ready for landing. From what I can tell, this is not addressing any particular bug or wish so I would say this (or any convention) is a good start and if uses want to change/extend it we will see a bug report in the wishlist.

In D9057#173505, @apol wrote:

Please next time use a more descriptive commit message. ;)

• Restore the buttons property of KEditListWidget

In D8389#157950, @tfry wrote:

I made this patch against the frameworks branch,

I see. Is there any way to see this in phabricator?

• Also remove the set_package_properties code, since it is not optional

ping?

ping?

I made this patch against the frameworks branch, so now the question is whether you want me to commit it to master and then merge it into frameworks or to just commit it to frameworks.

ping?

• Since KCoreAddons is required, the migration is not optional

• Making the Dependency to KF5CoreAddons REQUIRED

I did not land this correctly, it is commit 349f32199228fd44989f0ba44514dc166cee2929

In D7717#143787, @dvratil wrote:

Akonadi will automatically create all missing tables, columns, and indices on start if they are missing - so the question is not why you did not have the column, but how is it possible that the revision 35 upgrade was executed on your system, if you did not have the commit that introduced it (which was also R165:859382)