Feed Advanced Search

May 6 2019

volden committed R32:610c3094eee4: revert commit 75af18814c05861697184acda9775dad9313c3bd. Besides having some bad… (authored by volden).
revert commit 75af18814c05861697184acda9775dad9313c3bd. Besides having some bad…
May 6 2019, 5:04 PM
volden added a reverting change for R32:75af18814c05: Fix annoying assert on Windows. When a new document is created…: R32:610c3094eee4: revert commit 75af18814c05861697184acda9775dad9313c3bd. Besides having some bad….
May 6 2019, 5:04 PM

Mar 11 2019

volden committed R32:75af18814c05: Fix annoying assert on Windows. When a new document is created… (authored by volden).
Fix annoying assert on Windows. When a new document is created…
Mar 11 2019, 3:12 AM

Jan 20 2019

volden abandoned D18326: Fix compilation on Windows.

Already fixed.

Jan 20 2019, 6:01 PM · KDevelop

Jan 17 2019

volden added a reviewer for D18326: Fix compilation on Windows: kdevelop-devel.
Jan 17 2019, 5:43 PM · KDevelop
volden requested review of D18326: Fix compilation on Windows.
Jan 17 2019, 5:37 PM · KDevelop

Nov 26 2018

volden committed R32:2529d4c77349: Merge branch '5.3' (authored by volden).
Merge branch '5.3'
Nov 26 2018, 4:05 PM
volden committed R32:22c9a57f3b72: Use qCWarning in path.cpp. (authored by volden).
Use qCWarning in path.cpp.
Nov 26 2018, 4:02 PM
volden closed D17174: Use qCWarning in path.cpp..
Nov 26 2018, 4:02 PM · KDevelop
volden requested review of D17174: Use qCWarning in path.cpp..
Nov 26 2018, 3:36 PM · KDevelop
volden committed R32:ca603a5e2491: Fix build of test_projectmodel (authored by volden).
Fix build of test_projectmodel
Nov 26 2018, 1:44 PM
volden added inline comments to D17130: Fix projectmodel unittest to work on Windows..
Nov 26 2018, 12:37 PM · KDevelop
volden committed R32:f62d6adb0b1f: Merge branch '5.3' (authored by volden).
Merge branch '5.3'
Nov 26 2018, 12:24 PM
volden committed R32:e3de595335ed: Fix qmakeproject unittest to work on Windows. (authored by volden).
Fix qmakeproject unittest to work on Windows.
Nov 26 2018, 12:23 PM
volden closed D17158: Fix qmakeproject unittest to work on Windows..
Nov 26 2018, 12:23 PM · KDevelop
volden committed R32:b2a629b3a0ee: Merge branch '5.3' (authored by volden).
Merge branch '5.3'
Nov 26 2018, 12:21 PM
volden committed R32:b1ba6403454a: Fix defines and includes test to run on Windows. (authored by volden).
Fix defines and includes test to run on Windows.
Nov 26 2018, 12:20 PM
volden closed D17156: Fix defines and includes test to run on Windows..
Nov 26 2018, 12:20 PM · KDevelop
volden committed R32:ea1a04358769: Merge branch 'master' of git://anongit.kde.org/kdevelop (authored by volden).
Merge branch 'master' of git://anongit.kde.org/kdevelop
Nov 26 2018, 12:15 PM
volden committed R32:901f4239fc0d: Merge branch '5.3' (authored by volden).
Merge branch '5.3'
Nov 26 2018, 12:15 PM
volden committed R32:de81ab5c5b48: Fix projectmodel unittest to work on Windows. (authored by volden).
Fix projectmodel unittest to work on Windows.
Nov 26 2018, 12:11 PM
volden closed D17130: Fix projectmodel unittest to work on Windows..
Nov 26 2018, 12:11 PM · KDevelop
volden added a comment to D17130: Fix projectmodel unittest to work on Windows..

@kfunk Land on 5.3 and merge to master? (For this and the other ones?)

Nov 26 2018, 11:38 AM · KDevelop

Nov 25 2018

volden requested review of D17158: Fix qmakeproject unittest to work on Windows..
Nov 25 2018, 6:03 PM · KDevelop
volden updated the diff for D17130: Fix projectmodel unittest to work on Windows..

Prefer QDir::rootPath() to poluting our files with define macros

Nov 25 2018, 4:35 PM · KDevelop
volden updated the diff for D17156: Fix defines and includes test to run on Windows..

Remove unneeded whitespace change

Nov 25 2018, 4:17 PM · KDevelop
volden added a reviewer for D17156: Fix defines and includes test to run on Windows.: KDevelop.
Nov 25 2018, 4:11 PM · KDevelop
volden requested review of D17156: Fix defines and includes test to run on Windows..
Nov 25 2018, 4:07 PM · KDevelop

Nov 24 2018

volden committed R32:12034dbdd98f: Fix problem model test on Windows. Make sure that when we create a path the… (authored by volden).
Fix problem model test on Windows. Make sure that when we create a path the…
Nov 24 2018, 3:50 PM
volden committed R32:436303a96e42: Fix problem model test on Windows. Make sure that when we create a path the… (authored by volden).
Fix problem model test on Windows. Make sure that when we create a path the…
Nov 24 2018, 2:22 PM
volden closed D17131: Fix problem model test on Windows. Make sure that when we create a path the root of that path is created according to what is expected on the current platform. E.g. C: on Windows..
Nov 24 2018, 2:22 PM · KDevelop
volden added a comment to D17131: Fix problem model test on Windows. Make sure that when we create a path the root of that path is created according to what is expected on the current platform. E.g. C: on Windows..

@brauch Since this is a fairly simple patch. I'm thinking push to 5.3 and merge into master. Agree?

Nov 24 2018, 1:57 PM · KDevelop
volden requested review of D17131: Fix problem model test on Windows. Make sure that when we create a path the root of that path is created according to what is expected on the current platform. E.g. C: on Windows..
Nov 24 2018, 8:34 AM · KDevelop
volden updated the diff for D17130: Fix projectmodel unittest to work on Windows..

Renaming to prependPathRoot

Nov 24 2018, 8:18 AM · KDevelop
volden requested review of D17130: Fix projectmodel unittest to work on Windows..
Nov 24 2018, 5:47 AM · KDevelop

Nov 22 2018

volden committed R32:35026c0881b5: Make the filteringstrategy test work on Windows as well. (authored by volden).
Make the filteringstrategy test work on Windows as well.
Nov 22 2018, 1:34 PM
volden closed D17098: Make the filteringstrategy test work on Windows as well..
Nov 22 2018, 1:34 PM · KDevelop
volden requested review of D17098: Make the filteringstrategy test work on Windows as well..
Nov 22 2018, 11:58 AM · KDevelop

Nov 21 2018

volden committed R32:10760f1c7fb0: Merge branch '5.3' (authored by volden).
Merge branch '5.3'
Nov 21 2018, 5:44 PM
volden committed R32:3dae49147893: Make test outputmodel pass on windows. (authored by volden).
Make test outputmodel pass on windows.
Nov 21 2018, 5:25 PM
volden closed D17077: Make test outputmodel pass on windows..
Nov 21 2018, 5:25 PM · KDevelop
volden requested review of D17077: Make test outputmodel pass on windows..
Nov 21 2018, 4:05 PM · KDevelop

Aug 26 2018

volden added a comment to D14929: Default to QT_NO_CAST_FROM_ASCII/QT_NO_CAST_TO_ASCII/QT_NO_CAST_FROM_BYTEARRAY.

As discussed on IRC with Kevin, have now worked on fixing this right away, and this can go in now without all the temporary remove_definitions.
@volden Given you have mentioned you have a series of patches for the perforce plugin, I left that plugin out for now, so you do not run into conflicts. We would then complete the explicit-cast work here later :)

@kossebau I actually played around a little with the cast stuff myself. I now have it in a compiling/tests passing condition. Be happy to make a review request of that if you like.

Aug 26 2018, 11:45 AM · KDevelop
volden added a comment to D14929: Default to QT_NO_CAST_FROM_ASCII/QT_NO_CAST_TO_ASCII/QT_NO_CAST_FROM_BYTEARRAY.

As discussed on IRC with Kevin, have now worked on fixing this right away, and this can go in now without all the temporary remove_definitions.
@volden Given you have mentioned you have a series of patches for the perforce plugin, I left that plugin out for now, so you do not run into conflicts. We would then complete the explicit-cast work here later :)

Aug 26 2018, 11:27 AM · KDevelop

Aug 23 2018

volden committed R32:c3dcc938bf49: Fix kdev_perforce unittest to run on kde windows CI and everywhere else. (authored by volden).
Fix kdev_perforce unittest to run on kde windows CI and everywhere else.
Aug 23 2018, 6:00 PM
volden closed D14958: Fix kdev_perforce unittest to run on kde windows CI and everywhere else..
Aug 23 2018, 6:00 PM · KDevelop
volden added inline comments to D14958: Fix kdev_perforce unittest to run on kde windows CI and everywhere else..
Aug 23 2018, 1:15 PM · KDevelop

Aug 21 2018

volden added a comment to D14432: Appwizard plugin. Add more repository information in the project file. .

Perforce clients can access that metadata in two ways.

Aug 21 2018, 7:17 PM · KDevelop
volden added a comment to D14432: Appwizard plugin. Add more repository information in the project file. .

I should probably also mention that the diff is one in a series that should get the perforceImportMetadataWidget fully functional.

Aug 21 2018, 7:00 PM · KDevelop
volden added a comment to D14432: Appwizard plugin. Add more repository information in the project file. .

This is for centralized version control. e.g. Perforce. So since the actual VCS resides on a server we need to know which one to contact and with what user etc.

Aug 21 2018, 6:55 PM · KDevelop
volden updated the diff for D14958: Fix kdev_perforce unittest to run on kde windows CI and everywhere else..
  • Implemented Kevins review comments
Aug 21 2018, 1:29 PM · KDevelop
volden added inline comments to D14958: Fix kdev_perforce unittest to run on kde windows CI and everywhere else..
Aug 21 2018, 1:09 PM · KDevelop
volden added inline comments to D14958: Fix kdev_perforce unittest to run on kde windows CI and everywhere else..
Aug 21 2018, 12:56 PM · KDevelop
volden updated the diff for D14958: Fix kdev_perforce unittest to run on kde windows CI and everywhere else..
  • Merge master properly this time
Aug 21 2018, 11:02 AM · KDevelop
volden updated the diff for D14958: Fix kdev_perforce unittest to run on kde windows CI and everywhere else..
  • Merged master
Aug 21 2018, 10:42 AM · KDevelop
volden committed R32:2e98de947feb: Cleanup Perforce test case, and thereby its output a little. (authored by volden).
Cleanup Perforce test case, and thereby its output a little.
Aug 21 2018, 9:10 AM
volden closed D14959: Cleanup Perforce test case, and thereby its output a little..
Aug 21 2018, 9:10 AM · KDevelop

Aug 20 2018

volden requested review of D14959: Cleanup Perforce test case, and thereby its output a little..
Aug 20 2018, 9:44 PM · KDevelop
volden added a comment to D14432: Appwizard plugin. Add more repository information in the project file. .

Ping! Anyone?

Aug 20 2018, 9:03 PM · KDevelop
volden updated the summary of D14958: Fix kdev_perforce unittest to run on kde windows CI and everywhere else..
Aug 20 2018, 9:02 PM · KDevelop
volden requested review of D14958: Fix kdev_perforce unittest to run on kde windows CI and everywhere else..
Aug 20 2018, 8:59 PM · KDevelop

Aug 13 2018

volden committed R32:e632d27c8eef: Fix all MSBuild Warnings - Category C4138: '*/' found outside of comment (authored by volden).
Fix all MSBuild Warnings - Category C4138: '*/' found outside of comment
Aug 13 2018, 12:36 PM
volden closed D14776: Fix all MSBuild Warnings - Category C4138: '*/' found outside of comment.
Aug 13 2018, 12:36 PM · KDevelop
volden updated the diff for D14776: Fix all MSBuild Warnings - Category C4138: '*/' found outside of comment.

Updating D14776: Fix all MSBuild Warnings - Category C4138: '*/' found outside of comment

Aug 13 2018, 12:35 PM · KDevelop

Aug 12 2018

volden requested review of D14776: Fix all MSBuild Warnings - Category C4138: '*/' found outside of comment.
Aug 12 2018, 6:47 PM · KDevelop

Aug 9 2018

volden added a comment to D14678: Fix GCC warning.

@aaronpuchert I can certainly look into it. But if I remember correctly, there are a massive amount of deprecated warnings coming from the subversion code. More specifically svncpp library. So i doubt that it would be possible.

Aug 9 2018, 7:20 AM · KDevelop

Aug 8 2018

volden committed R32:48e2d83c6239: Fix GCC warning (authored by volden).
Fix GCC warning
Aug 8 2018, 2:55 AM
volden closed D14678: Fix GCC warning.
Aug 8 2018, 2:55 AM · KDevelop

Aug 7 2018

volden requested review of D14678: Fix GCC warning.
Aug 7 2018, 7:31 PM · KDevelop
volden committed R32:8293bfe43a7e: Fix perforce unittest on Windows CI (authored by volden).
Fix perforce unittest on Windows CI
Aug 7 2018, 6:58 PM
volden closed D14657: Fix perforce unittest on Windows CI.
Aug 7 2018, 6:58 PM · KDevelop

Aug 6 2018

volden committed R32:d6299984010c: Fix MSVC warning (authored by volden).
Fix MSVC warning
Aug 6 2018, 6:19 PM
volden requested review of D14657: Fix perforce unittest on Windows CI.
Aug 6 2018, 5:51 PM · KDevelop

Jul 31 2018

volden added a comment to D14372: Add IBasicVersionControl and ICentralizedVersionControl to Perforce plugin.

@kossebau: Yes, that is because I suck at arc and that particular commit was done by hand :-)

Jul 31 2018, 11:23 AM · KDevelop

Jul 27 2018

volden updated the diff for D14432: Appwizard plugin. Add more repository information in the project file. .
Jul 27 2018, 8:41 PM · KDevelop
volden requested review of D14432: Appwizard plugin. Add more repository information in the project file. .
Jul 27 2018, 8:34 PM · KDevelop
volden committed R32:11946ea953db: Add PerforceImportMetadataWidget. (authored by volden).
Add PerforceImportMetadataWidget.
Jul 27 2018, 6:37 PM
volden closed D14382: Add PerforceImportMetadataWidget.
Jul 27 2018, 6:37 PM · KDevelop
volden committed R32:6b11d1ba56cf: First step: Add PerforceImportMetadataWidget. Not all functionality is… (authored by volden).
First step: Add PerforceImportMetadataWidget. Not all functionality is…
Jul 27 2018, 6:37 PM
volden committed R32:ebb4350ac764: Add IBasicVersionControl and ICentralizedVersionControl to Perforce plugin (authored by volden).
Add IBasicVersionControl and ICentralizedVersionControl to Perforce plugin
Jul 27 2018, 6:07 PM
volden committed R32:fd0d83162ff2: Add IBasicVersionControl and ICentralizedVersionConrol as interfaces (authored by volden).
Add IBasicVersionControl and ICentralizedVersionConrol as interfaces
Jul 27 2018, 6:06 PM

Jul 26 2018

volden added a dependency for D14382: Add PerforceImportMetadataWidget: D14372: Add IBasicVersionControl and ICentralizedVersionControl to Perforce plugin.
Jul 26 2018, 6:36 PM · KDevelop
volden added a dependent revision for D14372: Add IBasicVersionControl and ICentralizedVersionControl to Perforce plugin: D14382: Add PerforceImportMetadataWidget.
Jul 26 2018, 6:36 PM · KDevelop
volden updated the summary of D14382: Add PerforceImportMetadataWidget.
Jul 26 2018, 6:36 PM · KDevelop

Jul 25 2018

volden requested review of D14382: Add PerforceImportMetadataWidget.
Jul 25 2018, 7:41 PM · KDevelop
volden requested review of D14372: Add IBasicVersionControl and ICentralizedVersionControl to Perforce plugin.
Jul 25 2018, 2:10 PM · KDevelop

Sep 20 2017

volden accepted D7887: cleanup cmake executable preferences.

LGTM!

Sep 20 2017, 4:20 PM · KDevelop

Sep 18 2017

volden accepted D7865: Bring back per-project setting of the cmake executable completely.

Otherwise LGTM

Sep 18 2017, 4:14 PM · KDevelop
volden added inline comments to D7865: Bring back per-project setting of the cmake executable completely.
Sep 18 2017, 4:13 PM · KDevelop

Sep 11 2017

volden committed R32:4ee64bb2cf88: Bring back per project settings of cmake executable (authored by volden).
Bring back per project settings of cmake executable
Sep 11 2017, 3:17 AM
volden closed D7762: Bring back per project settings of cmake executable by committing R32:4ee64bb2cf88: Bring back per project settings of cmake executable.
Sep 11 2017, 3:17 AM · KDevelop
volden committed R32:3ca27e73b931: First step bring back save cmake executable (authored by volden).
First step bring back save cmake executable
Sep 11 2017, 3:17 AM

Sep 10 2017

volden added a reviewer for D7762: Bring back per project settings of cmake executable : apol.
Sep 10 2017, 7:30 PM · KDevelop
volden added a comment to D7762: Bring back per project settings of cmake executable .

Sep 10 2017, 7:26 PM · KDevelop
volden created D7762: Bring back per project settings of cmake executable .
Sep 10 2017, 7:23 PM · KDevelop

Sep 6 2017

volden committed R32:f31923b68328: OutputFilteringStrategies: make parsing of cmake output for project directory… (authored by akellermann).
OutputFilteringStrategies: make parsing of cmake output for project directory…
Sep 6 2017, 12:22 PM

Aug 28 2017

volden committed R32:f5ef5b37d40b: Fix for Outoutview CmakeMultiline expression accidentally hits on CMake Error. (authored by volden).
Fix for Outoutview CmakeMultiline expression accidentally hits on CMake Error.
Aug 28 2017, 3:41 PM
volden closed D7554: Outoutview CmakeMultiline expression accidentally hits on CMake Error by committing R32:f5ef5b37d40b: Fix for Outoutview CmakeMultiline expression accidentally hits on CMake Error..
Aug 28 2017, 3:41 PM · KDevelop
volden added a comment to D7554: Outoutview CmakeMultiline expression accidentally hits on CMake Error.

Hey Kevin

Aug 28 2017, 2:52 PM · KDevelop

Aug 26 2017

volden added a comment to D7554: Outoutview CmakeMultiline expression accidentally hits on CMake Error.

The regex now expects there to be a / at the start of the line.

Aug 26 2017, 6:55 AM · KDevelop