Feed Advanced Search

Advanced Search
Use Results
Hide Query

Nov 29 2019

sniperrifle added a comment to D25604: Properly add data root to XDG_DATA_DIRS and only when necessary.

I'm thinking of adding what the intended behaviour is of the function regarding XDG_DATA_DIRS to the function comment and removing the comment in the code. Would that be acceptable?

Nov 29 2019, 9:16 AM · Plasma
sniperrifle updated the diff for D25604: Properly add data root to XDG_DATA_DIRS and only when necessary.

Diff to the proper upstream

Nov 29 2019, 2:43 AM · Plasma
sniperrifle updated the diff for D25604: Properly add data root to XDG_DATA_DIRS and only when necessary.

Condensed the overly verbose comments into a single sentence capturing the essence of the original comments and use splitRef instead of split.

Nov 29 2019, 2:37 AM · Plasma
sniperrifle requested review of D25604: Properly add data root to XDG_DATA_DIRS and only when necessary.
Nov 29 2019, 12:07 AM · Plasma