Feed Advanced Search

Jul 26 2019

mnauwelaerts committed R40:56e7b0f75140: lspclient: add API to servermanager to retrieve synced document revision (authored by mnauwelaerts).
lspclient: add API to servermanager to retrieve synced document revision
Jul 26 2019, 8:18 PM
mnauwelaerts committed R40:603398ad9231: lspclient: cache limited number of outline models (authored by mnauwelaerts).
lspclient: cache limited number of outline models
Jul 26 2019, 8:18 PM
mnauwelaerts committed R40:93b7607e2372: lspclient: avoid symbolview flickering (authored by mnauwelaerts).
lspclient: avoid symbolview flickering
Jul 26 2019, 8:18 PM
mnauwelaerts committed R40:94babe87c65b: lspclient: consider detail column setting (authored by mnauwelaerts).
lspclient: consider detail column setting
Jul 26 2019, 8:18 PM

Jul 25 2019

mnauwelaerts accepted D22710: ensure clangd is started for each project on it's own.

We could indeed optionally (configuration based?) create the symlink later on ...

Jul 25 2019, 6:52 AM · Kate

Jul 24 2019

mnauwelaerts added a comment to D22710: ensure clangd is started for each project on it's own.

There are 2 stages of consideration here. One of (desired) functionality, and then how to implement it.

Jul 24 2019, 7:12 PM · Kate

Jul 22 2019

mnauwelaerts accepted D22633: allow global debug/non-debug setting via env var.

Yeah, I have been slacking a bit in that area ...

Jul 22 2019, 5:47 PM · Kate

Jul 21 2019

mnauwelaerts committed R40:8877a5a78dbc: lspclient: switch to MIT license (authored by mnauwelaerts).
lspclient: switch to MIT license
Jul 21 2019, 9:57 PM
mnauwelaerts committed R40:6db16c40d43a: lspclient: minor optimization in document update (authored by mnauwelaerts).
lspclient: minor optimization in document update
Jul 21 2019, 9:57 PM
mnauwelaerts committed R40:487750305dab: lspclient: align diagnostic type name (authored by mnauwelaerts).
lspclient: align diagnostic type name
Jul 21 2019, 9:57 PM
mnauwelaerts committed R40:029eb24846e5: lspclient: more descriptive member name for highlight action (authored by mnauwelaerts).
lspclient: more descriptive member name for highlight action
Jul 21 2019, 9:57 PM
mnauwelaerts committed R40:420464eb3cf9: lspclient: add format action (authored by mnauwelaerts).
lspclient: add format action
Jul 21 2019, 9:57 PM
mnauwelaerts committed R40:6d090611f8fe: lspclient: add server support for formatting (authored by mnauwelaerts).
lspclient: add server support for formatting
Jul 21 2019, 9:57 PM
mnauwelaerts committed R40:892988138644: lspclient: use snapshot to transform some location ranges (authored by mnauwelaerts).
lspclient: use snapshot to transform some location ranges
Jul 21 2019, 9:57 PM
mnauwelaerts committed R40:cd91f32ef901: lspclient: support snapshot of submitted document revisions (authored by mnauwelaerts).
lspclient: support snapshot of submitted document revisions
Jul 21 2019, 9:57 PM
mnauwelaerts committed R40:9110ba80b37b: lspclient: send meaningful document revision id if available (authored by mnauwelaerts).
lspclient: send meaningful document revision id if available
Jul 21 2019, 9:57 PM
mnauwelaerts committed R40:29596537b2e4: lspclient: minor refactor for cleaner shutdown sequence (authored by mnauwelaerts).
lspclient: minor refactor for cleaner shutdown sequence
Jul 21 2019, 9:57 PM
mnauwelaerts committed R40:e6e3e7f388b2: lspclient: track document changes and sync to server accordingly (authored by mnauwelaerts).
lspclient: track document changes and sync to server accordingly
Jul 21 2019, 9:57 PM
mnauwelaerts added a comment to D22592: port symbols view to model/view concept.

Fine by me to add the missing 'detail' parse, you noticed it ;-)

Jul 21 2019, 2:59 PM · Kate
mnauwelaerts accepted D22592: port symbols view to model/view concept.

The detail field not getting parsed probably started out intentionally and then turned into an oversight :-(
Regarding the sorting, it seems the following is needed (in suitable place);

if (m_sortOn->isChecked()) {
    m_symbols->setSortingEnabled(true);
    m_symbols->sortByColumn(0);
} else {
    m_symbols->sortByColumn(-1);
}

Otherwise, it looks/works fine now!

Jul 21 2019, 1:19 PM · Kate
mnauwelaerts added a comment to D22595: implement text hint interface for automatic hover.

For some of the other files, I copied over some "boilerplate" to get going, so nothing unique in there and (almost surely) already modified by now into other ways and forms ...

Jul 21 2019, 12:34 PM · Kate
mnauwelaerts accepted D22595: implement text hint interface for automatic hover.

Looks nice indeed!

Jul 21 2019, 7:35 AM · Kate
mnauwelaerts added a comment to D22592: port symbols view to model/view concept.

Thanks for the new feature! However, a few regressions and concerns:

  • the "show details" action is no longer enabled/disabled depending on whether useful detail info is available
  • the detail is now in a separate column; if a server decides to present e.g. argument info there, it does not look that good in a separate column with not-so-useful white space in between (others thing probably also not either). While a bit hack-ish, that's why it was previously merged with the "main text".
  • if the symbol view tree is (partially) collapsed, and then the item tracking kicks in to sync with cursor position, the tree is expanded again, rather than showing topmost relevant (visible) item. Previously, it was kept collapsed, as presumably so done by user for a reason.
  • the flat-list option is gone as well as already mentioned (whether or not it may be deemed useful)
Jul 21 2019, 7:23 AM · Kate

Jul 18 2019

mnauwelaerts committed R40:b65a5be45a81: lspclient: additional sanity checks on state (authored by mnauwelaerts).
lspclient: additional sanity checks on state
Jul 18 2019, 7:11 PM
mnauwelaerts committed R40:9c36990fe2f7: lspclient: sync diagnostics list selection with view (authored by mnauwelaerts).
lspclient: sync diagnostics list selection with view
Jul 18 2019, 7:11 PM
mnauwelaerts committed R40:07abe1f39e02: lspclient: avoid tab increase due to definition and declaration results (authored by mnauwelaerts).
lspclient: avoid tab increase due to definition and declaration results
Jul 18 2019, 7:11 PM
mnauwelaerts committed R40:d0cdb783f1fd: lspclient: refactor some view tracking to a separate helper (authored by mnauwelaerts).
lspclient: refactor some view tracking to a separate helper
Jul 18 2019, 7:11 PM
mnauwelaerts committed R40:406acf7c6b32: lspclient: sane interpretation of empty server command (authored by mnauwelaerts).
lspclient: sane interpretation of empty server command
Jul 18 2019, 7:11 PM
mnauwelaerts committed R40:25222ed7596d: lspclient: tweak setup of toolviews (authored by mnauwelaerts).
lspclient: tweak setup of toolviews
Jul 18 2019, 7:11 PM

Jul 14 2019

mnauwelaerts committed R40:38d1ec1e3849: lspclient: make diagnostics presentation aspects configurable (authored by mnauwelaerts).
lspclient: make diagnostics presentation aspects configurable
Jul 14 2019, 10:14 AM
mnauwelaerts committed R40:4dfa3127f330: lspclient: add tab and marking for diagnostics (authored by mnauwelaerts).
lspclient: add tab and marking for diagnostics
Jul 14 2019, 10:14 AM
mnauwelaerts committed R40:34217cf8fabc: lspclient: add server support for diagnostics notification (authored by mnauwelaerts).
lspclient: add server support for diagnostics notification
Jul 14 2019, 10:14 AM
mnauwelaerts committed R40:1577295cb495: lspclient: add highlight call to testapp (authored by mnauwelaerts).
lspclient: add highlight call to testapp
Jul 14 2019, 10:14 AM
mnauwelaerts committed R40:b6a278a58607: lspclient: apply utils namespace properly (authored by mnauwelaerts).
lspclient: apply utils namespace properly
Jul 14 2019, 10:14 AM

Jul 10 2019

mnauwelaerts accepted D22349: lspclient: Don't send the Content-Type header.
Jul 10 2019, 5:53 PM · Kate
mnauwelaerts committed R40:24bd4c5011f4: lspclient: make location treeview more informative (authored by mnauwelaerts).
lspclient: make location treeview more informative
Jul 10 2019, 5:02 PM
mnauwelaerts committed R40:6e778a71fc76: lspclient: extend highlighting and marks to handle highlight as well (authored by mnauwelaerts).
lspclient: extend highlighting and marks to handle highlight as well
Jul 10 2019, 5:02 PM
mnauwelaerts committed R40:3f71d62eb99a: lspclient: extend and namespace some helpers (authored by mnauwelaerts).
lspclient: extend and namespace some helpers
Jul 10 2019, 5:02 PM
mnauwelaerts committed R40:a8aaef8b51e6: lspclient: make include declaration in reference configurable (authored by mnauwelaerts).
lspclient: make include declaration in reference configurable
Jul 10 2019, 5:02 PM
mnauwelaerts committed R40:aedab44511dd: lspclient: add toolview to display some call results (authored by mnauwelaerts).
lspclient: add toolview to display some call results
Jul 10 2019, 5:02 PM
mnauwelaerts committed R40:df48489bb2c8: lspclient: add server support for references (authored by mnauwelaerts).
lspclient: add server support for references
Jul 10 2019, 5:02 PM
mnauwelaerts committed R40:fdcf9b3d1fd0: lspclient: normalize file URL while parsing (authored by mnauwelaerts).
lspclient: normalize file URL while parsing
Jul 10 2019, 5:02 PM
mnauwelaerts accepted D22348: lspclient: Use the label when insertText or sortText is missing.

Oops, missed that part, but by the spec indeed.

Jul 10 2019, 4:58 PM · Kate
mnauwelaerts accepted D22349: lspclient: Don't send the Content-Type header.
Jul 10 2019, 4:55 PM · Kate