Feed Advanced Search

Aug 6 2019

cblack updated the diff for D22844: [kcm-colors] Export colorscheme to GTK color definitions.

Rebase properly now?

Aug 6 2019, 2:03 PM · Plasma
cblack updated the diff for D22844: [kcm-colors] Export colorscheme to GTK color definitions.

Update to match master.

Aug 6 2019, 1:57 PM · Plasma
cblack updated the diff for D22844: [kcm-colors] Export colorscheme to GTK color definitions.

Fix GtkColors flag

Aug 6 2019, 1:53 PM · Plasma

Aug 5 2019

cblack updated the diff for D22844: [kcm-colors] Export colorscheme to GTK color definitions.

Add KRdbExportGtkColors flag to kcminit_style()

Aug 5 2019, 2:01 PM · Plasma

Aug 3 2019

cblack updated the diff for D22844: [kcm-colors] Export colorscheme to GTK color definitions.

Deduplicate colors exporting code

Aug 3 2019, 2:12 PM · Plasma
cblack updated the diff for D22844: [kcm-colors] Export colorscheme to GTK color definitions.

Fix WM colors on first go round

Aug 3 2019, 12:42 AM · Plasma
cblack updated the diff for D22844: [kcm-colors] Export colorscheme to GTK color definitions.

Colors are now applied from the active colorscheme every time

Aug 3 2019, 12:19 AM · Plasma

Aug 2 2019

cblack updated the diff for D22877: Convert colors into GTK colordefs.

Typos, begone

Aug 2 2019, 8:43 PM · Plasma
cblack updated the diff for D22844: [kcm-colors] Export colorscheme to GTK color definitions.

Make GTK colors its own KRDB flag

Aug 2 2019, 7:57 PM · Plasma
cblack updated the diff for D22877: Convert colors into GTK colordefs.

Hopefully it should be properly working now. Hopefully.

Aug 2 2019, 6:26 PM · Plasma
cblack updated the diff for D22877: Convert colors into GTK colordefs.

Probably not going to work, but here's another attempt at rebasing

Aug 2 2019, 5:52 PM · Plasma
cblack updated the diff for D22877: Convert colors into GTK colordefs.

Resolve merge conflicts?

Aug 2 2019, 5:43 PM · Plasma
cblack updated the diff for D22877: Convert colors into GTK colordefs.

Hopefully that should rebase onto master properly now

Aug 2 2019, 5:35 PM · Plasma
cblack updated the diff for D22877: Convert colors into GTK colordefs.

Perhaps git is more cooperative now?

Aug 2 2019, 5:17 PM · Plasma
cblack updated the diff for D22877: Convert colors into GTK colordefs.

Hoped that rebase worked

Aug 2 2019, 5:07 PM · Plasma

Aug 1 2019

cblack updated the summary of D22876: Merge gtk320 and gtk318 into gtk3.
Aug 1 2019, 8:11 PM · Plasma
cblack added a dependent revision for D22876: Merge gtk320 and gtk318 into gtk3: D22881: [GTK3] Give checkboxes and radiobuttons a pressed appearance.
Aug 1 2019, 8:04 PM · Plasma
cblack added a dependency for D22881: [GTK3] Give checkboxes and radiobuttons a pressed appearance: D22876: Merge gtk320 and gtk318 into gtk3.
Aug 1 2019, 8:04 PM · Plasma
cblack updated the diff for D22877: Convert colors into GTK colordefs.

Spin out pressed buttons into own diff

Aug 1 2019, 8:04 PM · Plasma
cblack requested review of D22881: [GTK3] Give checkboxes and radiobuttons a pressed appearance.
Aug 1 2019, 8:03 PM · Plasma
cblack added a dependency for D22844: [kcm-colors] Export colorscheme to GTK color definitions: D22877: Convert colors into GTK colordefs.
Aug 1 2019, 3:33 PM · Plasma
cblack added a dependent revision for D22877: Convert colors into GTK colordefs: D22844: [kcm-colors] Export colorscheme to GTK color definitions.
Aug 1 2019, 3:33 PM · Plasma
cblack updated the summary of D22844: [kcm-colors] Export colorscheme to GTK color definitions.
Aug 1 2019, 3:32 PM · Plasma
cblack added a dependency for D22877: Convert colors into GTK colordefs: D22876: Merge gtk320 and gtk318 into gtk3.
Aug 1 2019, 3:31 PM · Plasma
cblack added a dependent revision for D22876: Merge gtk320 and gtk318 into gtk3: D22877: Convert colors into GTK colordefs.
Aug 1 2019, 3:31 PM · Plasma
cblack requested review of D22877: Convert colors into GTK colordefs.
Aug 1 2019, 3:31 PM · Plasma
cblack abandoned D22845: [GTK3] Convert all colors to use GTK color definitions.
Aug 1 2019, 3:29 PM · Plasma
cblack added a comment to D22845: [GTK3] Convert all colors to use GTK color definitions.

Hmm, now you've removed the 3.18 and 3.20 versions entirely in favor of a single 3.0 version. This change seems like it should be done in a separate patch.

Aug 1 2019, 3:28 PM · Plasma
cblack requested review of D22876: Merge gtk320 and gtk318 into gtk3.
Aug 1 2019, 3:27 PM · Plasma
cblack updated the summary of D22845: [GTK3] Convert all colors to use GTK color definitions.
Aug 1 2019, 1:21 AM · Plasma
cblack added a comment to D22845: [GTK3] Convert all colors to use GTK color definitions.

Neato mosquito!

Unfortunately, it doesn't build:

[ 75%] Building CXX object kconf_update/CMakeFiles/gtkbreeze5.5.dir/main.cpp.o
Installing into /home/nate/kde/build/breeze-gtk/Breeze-Dark
[ 75%] Built target Breeze-Dark
Installing into /home/nate/kde/build/breeze-gtk/Breeze
cp: cannot stat 'gtk-dark-3.18.css': No such file or directory

Looks like your change in build_theme.sh had some unintended consequences. I guess we still need the 3.18 dirs for compatibility, or else we need to formally deprecate 3.18 and remove all traces of it.

Aug 1 2019, 1:16 AM · Plasma
cblack updated the diff for D22845: [GTK3] Convert all colors to use GTK color definitions.

Forgot to add you

Aug 1 2019, 1:07 AM · Plasma
cblack updated the diff for D22845: [GTK3] Convert all colors to use GTK color definitions.

Fix CMakeLists.txt

Aug 1 2019, 1:06 AM · Plasma

Jul 31 2019

cblack updated the summary of D22844: [kcm-colors] Export colorscheme to GTK color definitions.
Jul 31 2019, 2:52 PM · Plasma
cblack updated the diff for D22844: [kcm-colors] Export colorscheme to GTK color definitions.

Dump the rest of the colors.

Jul 31 2019, 2:46 PM · Plasma
cblack updated the diff for D22845: [GTK3] Convert all colors to use GTK color definitions.

Fix some issues with incorrect colors being used

Jul 31 2019, 2:46 PM · Plasma
cblack added a comment to D22844: [kcm-colors] Export colorscheme to GTK color definitions.

It seems the header with the new flag is missing from the diff.

Jul 31 2019, 1:58 PM · Plasma
ognarb awarded D22844: [kcm-colors] Export colorscheme to GTK color definitions a Party Time token.
Jul 31 2019, 1:22 PM · Plasma
cblack updated the diff for D22844: [kcm-colors] Export colorscheme to GTK color definitions.

Incorporate feedback

Jul 31 2019, 1:13 PM · Plasma
cblack updated the diff for D22845: [GTK3] Convert all colors to use GTK color definitions.

Good job at picking up that change, arc. See previous change.

Jul 31 2019, 12:37 AM · Plasma
cblack updated the diff for D22845: [GTK3] Convert all colors to use GTK color definitions.

Forgot about changing the build_theme.sh to export to my home directory under the name Breeze-Dev, reversed that

Jul 31 2019, 12:36 AM · Plasma
cblack updated the summary of D22844: [kcm-colors] Export colorscheme to GTK color definitions.
Jul 31 2019, 12:33 AM · Plasma
cblack requested review of D22845: [GTK3] Convert all colors to use GTK color definitions.
Jul 31 2019, 12:32 AM · Plasma
cblack requested review of D22844: [kcm-colors] Export colorscheme to GTK color definitions.
Jul 31 2019, 12:08 AM · Plasma

Jul 18 2019

cblack added a comment to T11227: Loading Look and Feel.

-snip-
That means instead of the loading bar we should then just have the spinning indicator. While it may remove some detail in terms of how much a program has left to load, we can either move that into their window list item's progress bar ala Spectacle's timer or we could just take into account the fact that once it starts progressing it'll most likely be finished doing whatever it does on most of these applications anyway in a few seconds (therefore making having a progress bar redundant anyway).

Jul 18 2019, 7:56 PM · Goal: Consistency, VDG

Jul 17 2019

cblack added a comment to T11227: Loading Look and Feel.

GNOME does something pretty nice: they draw a blank/white background with a monochrome desaturated version of the app's icon in the middle. It looks really classy IMO. We could do the same, maybe also with a monochrome desaturated indeterminate progress bar below the icon.

Jul 17 2019, 5:07 PM · Goal: Consistency, VDG
cblack updated the diff for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

Hide logo by default

Jul 17 2019, 2:05 PM · Plasma

Jul 16 2019

cblack edited projects for T11227: Loading Look and Feel, added: VDG; removed Goal Setting 2019.
Jul 16 2019, 6:18 PM · Goal: Consistency, VDG
cblack added a comment to T11227: Loading Look and Feel.

It just inherited the goal setting tag from its parent task. Guess I should probably change it to something more appropriate.

Jul 16 2019, 6:18 PM · Goal: Consistency, VDG
cblack added a comment to D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

Doesn't really matter to me ¯\_(ツ)_/¯
If other people want it off by default, I'll update the default theme.conf

Jul 16 2019, 4:52 PM · Plasma
cblack updated the summary of D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.
Jul 16 2019, 1:58 PM · Plasma
cblack updated the diff for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

Remove sourceSize.width

Jul 16 2019, 1:57 PM · Plasma

Jul 15 2019

cblack created T11227: Loading Look and Feel.
Jul 15 2019, 11:25 PM · Goal: Consistency, VDG
cblack updated the task description for T11093: Improve Consistency across the Board.
Jul 15 2019, 10:03 PM · Goal: Consistency, Goal Setting 2019
cblack added a comment to T10891: Breeze theme evolution.

There's something I've noticed that's inconsistent between applications - how loading is represented. There's not really any consistency at all, excluding Kirigami applications.

Jul 15 2019, 8:05 PM · Plasma, VDG, Breeze
cblack updated the test plan for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.
Jul 15 2019, 7:26 PM · Plasma
cblack updated the diff for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

More sizing tweaks

Jul 15 2019, 7:25 PM · Plasma
cblack updated the test plan for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.
Jul 15 2019, 6:40 PM · Plasma
cblack updated the diff for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

Sizing tweaks

Jul 15 2019, 6:12 PM · Plasma
cblack updated the diff for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

Add sourceSize.width to the party

Jul 15 2019, 5:42 PM · Plasma
cblack updated the diff for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

Define sourceSize.height

Jul 15 2019, 5:35 PM · Plasma
cblack added inline comments to D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.
Jul 15 2019, 5:33 PM · Plasma
cblack added inline comments to D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.
Jul 15 2019, 5:21 PM · Plasma
cblack updated the diff for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

Rename config file properties to not say "distro"
Use gridunit
Use opacityanimator

Jul 15 2019, 5:20 PM · Plasma
cblack added inline comments to D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.
Jul 15 2019, 4:54 PM · Plasma
cblack updated the diff for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

Use units.longDuration

Jul 15 2019, 1:46 AM · Plasma

Jul 14 2019

cblack updated the test plan for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.
Jul 14 2019, 10:09 PM · Plasma
cblack updated the diff for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

Logo has text now

Jul 14 2019, 10:09 PM · Plasma
cblack added a comment to D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

An interesting idea. Are you in contact with any distros that have requested this or would make use of it?

Jul 14 2019, 8:42 PM · Plasma
cblack updated the test plan for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.
Jul 14 2019, 8:24 PM · Plasma
cblack updated the diff for D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.

This is why you shouldn't forget to test - default logo is now no longer pitifully small

Jul 14 2019, 8:21 PM · Plasma
cblack requested review of D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen.
Jul 14 2019, 8:14 PM · Plasma
cblack added a comment to D22452: Fix text color in non-selected tabs in Firefox.

I would probably replace
color: #eff0f1; -> color: t_color(text);
background-color: #475057; -> background-color: t_color(background);
in _firefox.scss to not hardcode the colors

Jul 14 2019, 1:29 PM · Plasma

Jun 22 2019

cblack updated the diff for D21815: [sddm-theme] Start moving from QQC1 to QQC2.
  • Change toolBtn to be more descriptive based on file the id was in
  • Styling changes on menus (they now have shadows)
  • Menu item highlight is tweaked as per T11124 (can revert if shouldn't be here)
Jun 22 2019, 4:40 PM · Plasma
cblack added a comment to D21815: [sddm-theme] Start moving from QQC1 to QQC2.

For positioning the menu maybe you could have a look at how it was done in Kickoff config window: https://github.com/KDE/plasma-desktop/blob/master/applets/kickoff/package/contents/ui/ConfigGeneral.qml

Jun 22 2019, 4:13 PM · Plasma

Jun 21 2019

cblack added a comment to T11124: Unify highlight effect style.

Would probably be a good idea to look for all the irregular highlights that don't match either effect 1 or effect 2 and gather a list of them all here.
The few I know of are the highlights on the networks applet pointed out by @ngraham and the highlights on the task managers which resemble a vertical version of the filing width highlight @filipf mentioned.


The highlights used in Kirigami (style=org.kde.desktop) are essentially effect 1 with variable transparency based on state.

Jun 21 2019, 7:23 PM · Plasma, Breeze, Goal: Consistency, VDG
cblack added a comment to T11124: Unify highlight effect style.


Would menus get lumped under Effect 1? How would they look with the newer highlight style?

Jun 21 2019, 2:32 AM · Plasma, Breeze, Goal: Consistency, VDG

Jun 20 2019

cblack updated the diff for D21815: [sddm-theme] Start moving from QQC1 to QQC2.
  • Remove Item {} root and embed QQC2.Menu {} in PlasmaComponents.ToolButton{}
  • If toolbutton is larger than largest menu item, resize menu to size of toolbutton
  • Other minor things
Jun 20 2019, 2:45 PM · Plasma
cblack added inline comments to D21815: [sddm-theme] Start moving from QQC1 to QQC2.
Jun 20 2019, 2:44 PM · Plasma

Jun 18 2019

cblack added a comment to T10201: Window titlebars.

What do you think of: (opaque on the left, transparent on the right)

-snip-

TBH, I can't tell the difference between both sides.

It's subtle, but it looks a bit nicer. I feel like a bit less opacity would improve the effect.

Jun 18 2019, 2:00 AM · KDE Applications, VDG

Jun 17 2019

cblack requested review of D21877: Hide tooltip when PrivateActionToolButton is pressed.
Jun 17 2019, 8:21 PM · Kirigami

Jun 15 2019

cblack updated the diff for D21815: [sddm-theme] Start moving from QQC1 to QQC2.

Use PC3 components in the kb & session buttons instead of PC2 components

Jun 15 2019, 4:54 PM · Plasma
cblack added inline comments to D21815: [sddm-theme] Start moving from QQC1 to QQC2.
Jun 15 2019, 4:48 PM · Plasma
cblack added inline comments to D21815: [sddm-theme] Start moving from QQC1 to QQC2.
Jun 15 2019, 4:43 PM · Plasma
cblack added inline comments to D21815: [sddm-theme] Start moving from QQC1 to QQC2.
Jun 15 2019, 3:22 PM · Plasma
cblack updated the diff for D21815: [sddm-theme] Start moving from QQC1 to QQC2.

Updates based off of feedback, and adding the standard menu fade animation to the QQC2 menus.

Jun 15 2019, 3:20 PM · Plasma
cblack updated the summary of D21815: [sddm-theme] Start moving from QQC1 to QQC2.
Jun 15 2019, 2:36 AM · Plasma
cblack updated the diff for D21815: [sddm-theme] Start moving from QQC1 to QQC2.

Looks like this change managed to hide from Arcanist's gaze. Should have been there in the first place.

Jun 15 2019, 2:34 AM · Plasma
cblack requested review of D21815: [sddm-theme] Start moving from QQC1 to QQC2.
Jun 15 2019, 2:33 AM · Plasma

Jun 14 2019

cblack added a comment to D21794: [sddm-theme] Style the session and keyboard layout selectors to be more Breeze.

@filipf Don't know but the answer is probably a no.

Jun 14 2019, 6:02 PM · Plasma
cblack updated the diff for D21794: [sddm-theme] Style the session and keyboard layout selectors to be more Breeze.

Remove unneeded property.

Jun 14 2019, 6:00 PM · Plasma
cblack updated the diff for D21794: [sddm-theme] Style the session and keyboard layout selectors to be more Breeze.

Tweak border coloration (steal it from Kirigami) and remove whitespace

Jun 14 2019, 5:52 PM · Plasma
cblack updated the diff for D21794: [sddm-theme] Style the session and keyboard layout selectors to be more Breeze.

Menu border, less hardcoding, and moving the menu style into a seperate file to reduce duplicated code.

Jun 14 2019, 5:34 PM · Plasma
cblack added a comment to D21794: [sddm-theme] Style the session and keyboard layout selectors to be more Breeze.

As requested by @apol, here is a screenshot of the menu with the new styling (I'm using a custom colorscheme currently, which is why the menu appears black in this screenshot).

Jun 14 2019, 4:52 PM · Plasma
cblack updated the diff for D21794: [sddm-theme] Style the session and keyboard layout selectors to be more Breeze.

Less harcoding & style keyboard button as well

Jun 14 2019, 4:47 PM · Plasma

Jun 13 2019

cblack requested review of D21794: [sddm-theme] Style the session and keyboard layout selectors to be more Breeze.
Jun 13 2019, 11:36 PM · Plasma

Jun 7 2019

cblack added a comment to T10891: Breeze theme evolution.

Not sure if this is the right thread, but here goes.

Jun 7 2019, 12:10 AM · Plasma, VDG, Breeze

Apr 23 2019

cblack added a comment to D20746: Remove disable for showing only minimized tasks on Icons only task manager.

-snip-
Can you describe what it is that makes you want this functionality in the IOTM rather than just using the regular task manager and enabling this feature?

Apr 23 2019, 9:26 PM · Plasma

Apr 22 2019

cblack added a reviewer for D20746: Remove disable for showing only minimized tasks on Icons only task manager: Plasma.
Apr 22 2019, 8:50 PM · Plasma
cblack requested review of D20746: Remove disable for showing only minimized tasks on Icons only task manager.
Apr 22 2019, 8:26 PM · Plasma