Superseded by D25877

Sorry about the delay, got caught up in things.

Thanks for picking this up again!
I'm definitely interested to resume but I've been a little busy this week. I can take a look again this weekend.

I understand

• Update with requested changes

Should that really prompt the user? I expect clicking Cancel to close the dialog

I was not aware there were patches that already did this.
I only found https://git.reviewboard.kde.org/r/129043/ on the bug report which was abandoned, otherwise I would not have created another one!

But these actions are disabled until I open any scratch in the editor.

For example, I have 2 scratches: scr1.cpp and scr2.cpp. I left-click on first one and open it, then right-click on second one and select Run. The 2nd scratch gets executed.

In D17569#391807, @arrowd wrote:

I found the following minor issue:

When I just started KDevelop and open "Scratchpad" toolview, any action except "New Scratch" are greyed out. Even "Remove Scratch", as well as "Run Scratch". When I open any scratch, it turns back to normal, even if I again close all Sratchpad windows.

Any objections for pushing this to 5.3 ?

• Fix some edge cases, cleanup and add more test cases

That is strange..
I bumped the version, so it should update it, I tried re-installing and it works for me.
Can you try deleting ~/.local/share/kxmlgui5/kdevclangsupport/kdevclangsupport.rc ?

Before: https://i.imgur.com/GhGdOBV.png
After: https://i.imgur.com/ygDEnpw.png

• Remove dependency on clang 7.0.0 functions

• Add tests for HeaderGuardAssistant

• QStringLiteral -> i18n

• Save scratch when run
• Fix scratch removal bug
• Invalidate actions when list is emptied

Will push with your version, looks better.
Thanks for the review :)

How should I proceed with this ?
As suggested on IRC, should I try to release it independently because of the size ?

ping ?

• Change test case and convert octal literal to decimal

• Add a message when the scratch list is empty

Would something like this be worth adding ?

cpp
index 5c193432c9..1b5fb57352 100644
--- a/plugins/scratchpad/scratchpadview.cpp
+++ b/plugins/scratchpad/scratchpadview.cpp
@@ -37,6 +37,7 @@
 #include <QWidgetAction>
 #include <QLineEdit>
 #include <QInputDialog>
+#include <QPainter>

Marking inline comments done.

• Make commands per-config and new scratches use command set last for suffix. I could not use mime types, as I was having some problems with detecting them,
• Removed dependency of a compiler
• Some other minor improvements

Thanks for the feedback, I've updated with some of the requested changes.

One thing comes to mind: you kind of require that there is a compiler, while 3 of the 4 languages KDevelop officially supports (PHP, Python and JS) do not use one. I think it would be nice if this plugin would also easily work for e.g. Python snippets.

That's one of the problems I've had, the command box coupled with your suggestion to have per-scratch config could help somewhat. Is there some kdev interface that would help here or some other solution ?

Some improvements

kcolorschemedemo.cpp does not actually seem to build an executable.

Fixed error in colorschemedemo test.
Sorry about that, I must've forgotton to commit it.

Thanks!

Yes, seems that way.
I also remember seeing that on bugzilla, but can't find now.

I do have push rights, I can land this tomorrow as I'll be travelling a bit today.
Which branch should this be landed against ?

Should I land this on master or 5.3 ?

Created new test case for whitespace mismatch.

Updated to use QChar overload as suggested.

I actually changed the last test to also test for this. Should I split it to a new one ?

I've changed the implementation to accomodate for whitespace, by comparing
a whitespace-stripped version of the signature and the leading text.

Added tests in testCompleteFunction, which already has some implements-completion
tests. Should I move them to a different test, something like testImplementExecute
in a different patch or this one ?

Ping. Can someone please review ?

The simple example

namespace A
{
    void foo();
}

Added a test.
But, as I've mentioned before, the tests for code completion crash,
So I haven't been able to run all tests, though you can run a single test case
before it crashes.