• Ui elements names changed.

@elvisangelaccio Can I rename to buttonCancel/buttonOk instead of cancelButton/okButton? If variable name starts with UI element it's easier to use code completion.

In D29788#672176, @meven wrote:

canceling svn process leaves a repository in inconsistent state: need to call 'svn cleanup' manually.

Make you plugin inform the user then ? Or automatically cleanup ? or Optionaly cleanup ?

• Update in response to review comments.
• Added new svn commands to cleanup and find repository working copy by a file.
• Added auto 'svn cleanup'.
• Fixed names, added comments.

In D29488#671698, @meven wrote:

Commit message should be updated with latest changes.

Update in response to review.

Update in response to review comments.

Update in response to review.

ping

Moved from QObject::connect to connect.

Update in response to review comments.

Improved URL checks.

More appropriate repo URL validation.

Update in response to review comments: added more reuse of 'stripped' variable.

In D29345#662670, @meven wrote:

I wonder is the issue is that F4 was available in the first place.

Removed unnecessary 'else' keyword.

ping
can i push this?

ping
can i push this?

@meven i pushed this myself as everyone accepted it but commit is missing at the github mirror https://github.com/KDE/dolphin-plugins
i did something wrong?

• Update variable names.

• Update in response to review comments.

• Update in response to review comments.

In D29041#653835, @meven wrote:

All is nice.
Just naming is hard and I'd like to keep it the least confusing possible.
I hope this is not annoying for you.

• Name change: versionedActions() -> versionControlActions()

• Name change: versionedActions() -> versionControlActions()
• Name change: isVersioned() -> isVersionControlled()
• Added comment changes in response to review comments

• Name changed: unversionedActions() -> outOfVersionControlActions().

• Name changed: unversionedActions() -> outOfVersionControlActions().

In D29043#653471, @meven wrote:

In D29043#653435, @nikolaik wrote:

In D29043#653429, @meven wrote:

I would have updated static QSharedPointer< QVector<logEntry> > getLog(const QString& filePath, uint maxEntries = 255, ulong fromRevision = 0); to match its documentation instead

Can you please explain what do you mean? The documentation is also fixed and i think is correct now.

Returning an empty QVector instead of null in getLog would have sufficed and would be somewhat safer as the documentation suggested it did, but didn't.
Anyway that's not very important.

@meven
I am agree this names might be confusing.
Let's figure out more appropriate names for functions: if we will accept revision this would be for long, lets make it clear.
What do you say about 'actions()' (as it was) and 'additionalActions()' (for any additional actions outside versioned directory, we will mark it in the documentation: the function name itself will be not very meaningful though)?

In D29043#653429, @meven wrote:

I would have updated static QSharedPointer< QVector<logEntry> > getLog(const QString& filePath, uint maxEntries = 255, ulong fromRevision = 0); to match its documentation instead

Thanks for comments!
Update done.

Update in response to comments.

Update in response to review comments.

Update in response to comments.

SVNCommands -> SvnCommands

In D28102#629533, @elvisangelaccio wrote:

From a quick look it seems there is a lot of refactored code, this could be done separately in another commit, right?

Update in response to comments: fixed CMakeLists.txt and other code problems.

In D28102#629437, @anthonyfieroni wrote:

Dialog looks and behaves similar to a TortoiseSVN one.

Don't make dialogs to looks like 3-th party software, we have log in git, you can make like that, also it pretty simple.