• Add Messages.sh file for extraction translations
• Separate the KF includes into own group with camelcase forward versions
• Use "= default" for deconstructors
• Add globalconfigpage.ui, projectconfigpage.ui
• Misc fixes
• Add commandlinewidget.ui
• Protected-private class fixes
• Tests fixes
• Small UI fixes
• Add "Verbose output" global setting
• Markdown converter fixes
• Use QPlainTextEdit for CommandLineWidget
• Add clazy icon
• Fix ui files with "fixuifiles"
• Fix clazy homepage url
• kdevclazy.json cleanup
• Fix "string puzzles"
• ChecksWidget UI update

• Markdown converter fixes

• Small UI fixes
• Add "Verbose output" global setting

It seems that I've fixed your comments. Review the new version as soon as you will have time for this.

• Add Messages.sh file for extraction translations
• Separate the KF includes into own group with camelcase forward versions
• Use "= default" for deconstructors
• Add globalconfigpage.ui, projectconfigpage.ui
• Misc fixes
• Add commandlinewidget.ui
• Protected-private class fixes
• Tests fixes

In D14288#296167, @kossebau wrote:

Oh, and then another code-style request, while at it :)

Could you make any members private, unless they really need to be accessable by subclasses?

And also split member variables off into an own section with own "private:" at the end of the class declaration, separate from any method declarations?
That should follow existing KDevelop conventions as well.

Motivation would be (besides consistency):

• by default only expose what really needs to be exposed
• keeping member variables grouped helps to more quickly understand the class design

• Add globalconfigpage.ui, projectconfigpage.ui

In D14288#296131, @kossebau wrote:

And one more request (from me personally, no idea about current kdevelop maintainers' POV): could you consider doing the UI in ui files?

Myself used to write all QWidget UI setup also directly in code, though big projects like also KDevelop have teached me that it improves maintainability if concerns are separated where possible, including moving the declaration of (static) UI into the prepared infrastructure, i.e. the UI files. While it adds to build time, it does not add that much to runtime/codesize, if at all.

And even if done for consistency with code of (most) existing plugins :)

• Add Messages.sh file for extraction translations
• Separate the KF includes into own group with camelcase forward versions
• Use "= default" for deconstructors

> does that work as excuse? :)

Hi, Friedrich. Sorry, but this commit completely broke my KDevelop :) Now it always crashes on start.

In D11081#226751, @kfunk wrote:

New version also allows us to add mechanism for temporarily blocking (disabling) some widgets for example "Full Update" button when model reset is started. This now done with using ProblemModel::featuresChanged signal which emitted by cppcheck plugin at start and at the end of analysis.

This part of the Diff can be pushed I think. I guess that's separate commit anyway, correct?

It looks a bit weird that there's a big empty space where it clearly should be a button.

ping?

Could that be a candidate for KWidgetsAddons? Though, perhaps if it turns out to be useful elsewhere it can still be moved there.

Small fixes

LGTM Can you make sure it doesn't overflow on the right?

So I cannot start the checker for two files concurrently (assuming both takes a longer time)?

but what if the analysis completed for multiple files and no errors where found there?

@mwolff:

I still don't understand what this location would point to. it's a placeholder, nothing has been found yet, so there cannot be any location?

Fix comments

Fix comments

Update to master

Update to master

I still have the bug on my KDE neon User Edition 5.12 system with last heaptrack:

Thanks for the fix!