Thanks, Nikita! After asking in the krusader-users mailing list, no objections were made since Aug . 19. The commit will be made.

"application/vnd.rar" was incorporated to krArc/krarc.protocol, as suggested by N. Higa. Two reminders were also added.

In D23476#520060, @nhiga wrote:

Should we also add application/vnd.rar to krArc/krarc.protocol?

Note: The krarc.protocol file is also being talked about by N. Higa in https://phabricator.kde.org/D23476

P.S.: Some steps still have to be done, like the ones that Nikita commented "It will be great to have starting steps for each type of work (for example, want to do Bug Triaging - go to the specific bugzilla link showing the list of not triaged bugs and try to repro bugs one by one, and then post your comments in the bugs)" or mentioning that a linked page is in English.

I suppose that today you have received a "Invitation to participate in a survey" mail from Lydia Pintscher. It reminds of when she wrote in https://phabricator.kde.org/T9581 about Krusader on Windows and "have you thought about using this as an opportunity to recruit someone new? Maybe a blog post or mailing list post asking if there is someone with the will and knowledge to drive this forward?", which has something to do with the subject of the present code review.

Changes that were suggested.

In D23309#515717, @pino wrote:

TBH I'd just add the instructions to https://krusader.org/get-involved/, and not to the user documentation.

Some spaces were added, as Yuri suggested.

How do you think a person is going to search whether kde4 version of krusader is getting updates? Will she likely go to a search engine and type something like "krusader kde4" where the mentioned repo will be in top positions due to good naming?

It looks OK for me, thanks for it, Nikita!

It looks OK for me, thanks for it, Nikita!

For example, you can fork krusader on github or other platform [...]. What do you think about this idea, Toni?

For my part, I accept the proposal, Thanks for it, Nikita!

Well, some months have passed since Davide's commit :-( , let's see when normal Krusader users can take profit.

In D22957#513827, @nmel wrote:

This is a very serious change because now #ifndef Q_OS_WIN or #else block after #ifdef Q_OS_WIN will include the code that previously was ignored. We must look at all those code paths and test features it affects. BTW, does it mean that some of those code paths do not work correctly in the current state?

Thanks, Nikita! Because it's very handy, and it has been already tried a lot, it looks like a good idea to add the "Shortcuts to move tab" commit to the stable branch, and add to the ChangeLog file:

FIXED: [ 328937 ] Shortcuts for move tab

Ok. Thanks, Alex and Davide!

Thanks, Nikita!

An article about it has been published recently:

About deprecation of QFontMetrics::width()
https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/

by @cfeck (Christoph Feck, who has commited some changes to the repository of Krusader).

Please also add the versioning data to the appdata file (maybe also add the information for the previous version this time):

Hi, Luigi! Well, I was referring to the virtual machines running prior operating systems (and physical machines, I remember that the LTS support of Ubuntu 14.04 ended at the end of April and I still saw some of those machines). Sometimes the reason is that some programs do not run in recent versions of operating systems, other causes may exist.
There's also the case of Lliurex 16, an operating system installed in thousands of computers, I had to work with it and there I could only build the "kde4" version of Krusader.

The new code works using Kubuntu 18.04 and 19.04. Krusader behaves as expected when it's asked to be closed:

• when its internal editor is not used,
• when its internal editor has a file that is not saved,
• when its internal editor has a file that is not saved and the computer is asked to reboot.

the target audience of Krusader are more advanced users

If any developer is reading this, he'll probably know that those developments end up being a very complex subject. Thank you for all the source code, Alex!

Minor changes were performed.

I think the same, Nikita, and thanks for testing and informing!

I agree with you, Nikita. Thanks for testing and all the information!

The new files were updated (copyright years were changed).

This is the new version of the source code, after some minor improvements, having updated it because of the changes to the source code that have happened since the last time (like in krsearchdialog.cpp), and having used daily the classes meanwhile.

(optional) I'd use QFontMetrics::horizontalAdvance(A) and QFontMetrics::width(A) for additional type check.

It's an improvement. Thanks!

The new code works using Kubuntu 18.04. Although the final behavior of Synchronizer is not perfect, the patch improves the current situation, therefore: thanks, Alex! (and Yuri :-) )

The new code works as expected using Kubuntu 18.04. Thanks, Alex! (and Yuri and Nikita :-) )

The new code works using Kubuntu 19.04. Other people can do their checks. Davide, using the same keys as Chromium, Firefox, Libreoffice Calc, etc. is a advantage. Thanks, Davide! (and Nikita :-) )

Maybe a visual hint would be good so that the users know this feature exists.

Some changes were made after Alex Bikadorov made some propositions.

Some changes were made after Alex Bikadorov made some propositions.

Since INSERT becomes kind of "global" macro, I suggest we rename it to UDS_ENTRY_INSERT, since the insert word is too generic while the implementation is not. Thanks!

Another address was updated

An address was updated