Check if anything else should be updated.

The commit is available for viewing at https://commits.kde.org/websites/krusader-org/3d5726caeedc4fd544751202eb9e0f5930cfb218

Indeed. Maybe something like "Updated descriptions, author and thanks lists". This is what you did, isn't it?

Thank you, Alex! For my part, my performed tests using Kubuntu 18.04 went alright, and I find it easier now to filter, to search, and to select. Great!

Some changes (proposed by Nikita Melnichenko) were made:

Closed because of https://commits.kde.org/krusader/6e9de699d94414dd58d0ffe1aec3dc142705eb1b

Ok!

A reference to KDE Plasma 4 was changed.

Some specifics were removed, in order to improve e.g. the maintainability.

Two texts were changed to save time to some readers.

Two pages were created, and information was moved to those pages.

Still giving a +1 for moving this into KIO so Gwenview and Krusader can use it too if they'd like.

Thanks for the improvements, Nikita!

In D12524#254087, @nmel wrote:

Nice catch, Toni. [...]
[Do I recall correctly that Totcmd doesn't have any of these shortcuts: Rename, Terminal, Multirename? I don't remember exactly because I probably had defined them a long time ago as I use F2 and F9 without hassle. :) ]

The commit message was updated accordingly.

Some related changes were made, including one in a docbook file.

(independent of the patch) IMO, what a bad name scheme is picked for the actions. Names shouldn't contain default values. A better naming could be` FN_Rename` if one would like to denote these belong to the functional keys bar.

Thanks for the work you put on it!

Thanks Nikita!

Toni, please accept this revision if you think it's good to merge with master.

Pinging @asensi on whether this would be a good addition to the Krusader project so then we can consider moving it to KIO).

To reproduce this issue: set a dark colours theme and oxygen icons, close all tabs in one panel and observe disabled icon in Window menu's Close Current Tab action. Try this with master
branch and with fix-missing-icons branch.

More screenshots, using included icons in Kubuntu 17.10:

Using Ubuntu 18.04 daily build: I could reproduce the problem, and it was solved by the patch made by Nikita. Thanks, Nikita!

Hello! I can't reproduce the "fixed invisible column" issue, so I attach some screenshots and "krusaderrc" files, if it may help:

With the latest improvements made by Nikita, In an Ubuntu 18.04 daily build virtual machine, and in a Kubuntu 17.10 virtual machine, the icons were shown as it was expected:

Regarding the greyed out icons in Krusader: I believe this is because "breeze" is set
as system theme (not "breeze-dark") and fallback is also set as "breeze", so
there is no "breeze-dark" to fallback to.

With the proposed changes:

Note: That "icon-missing.svgz" file can be downloaded from https://phabricator.kde.org/file/download/ieoxfxmcslybdhrcwkhf/PHID-FILE-zues6xeejyrafgjglyel/icon-missing.svgz

Thanks, Nikita! A lot of work! I also wanted to say that, after applying the diff file, using Ubuntu 18.04 daily build, I saw that error message when building Krusader (because the "icon-missing.svgz" file was not found):

[ 84%] Built target krusader_autogen
make[2]: *** No hay ninguna regla para construir el objetivo '/home/user/krusader/krusader/icons/icon-missing.svgz', necesario para 'krusader/qrc_resources.cpp'.  Alto.
CMakeFiles/Makefile2:222: recipe for target 'krusader/CMakeFiles/krusader.dir/all' failed
make[1]: *** [krusader/CMakeFiles/krusader.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

I'm fine with "emblem-unreadable" although my preference would rather be "image-missing" :).

When using Kubuntu 17.10:

It worked as it is expected, OK!

Hi! I'm using the "bookmark-quicksearch" branch, and I have applied the present diff, which is:

diff --git a/krusader/BookMan/krbookmarkhandler.cpp b/krusader/BookMan/krbookmarkhandler.cpp
--- a/krusader/BookMan/krbookmarkhandler.cpp
+++ b/krusader/BookMan/krbookmarkhandler.cpp
@@ -592,12 +592,12 @@
            return true;
        }

Thanks for improving consistency!

I propose we add CHANGED: ... to commit message, so it goes to the ChangeLog.

Toni, thanks a lot for testing this! Quick question: is Breeze installed in both of these cases or not?

In the same Ubuntu 18.04 daily build virtual machine, after applying the present differential:

Thank you all!

I also added a "tag" named "Krusader" and so:

My upgrade looks like this:
Qt: 5.7.1 -> 5.9.4
KF: 5.40 -> 5.43
kde-apps: 17.08.3 -> 17.12.3

BTW, it's not just my compiler settings, Toni also confirmed this earlier [...]

Thank you, Martin! For my part, my performed tests (using Kubuntu 17.10) went alright:

Thank you, Martin! For my part, my performed tests (using Kubuntu 17.10) went alright, including those tests that were already mentioned:

• go up in standard local FS
• go up outside an archive (with krarc protocol)
• go up outside an archive (with tar protocol)

Thank you, Martin! (and Nikita :-)! For my part, my performed tests (using Kubuntu 17.10) went alright, including those already mentioned tests:

• pin a tab, browse in it, activate another tab in the same panel, reactivate pinned tab -> it should return to the pinned address
• pin a tab, restart Krusader -> pinning should still be active, same for saved profiles
• pin a tab, change directory in it, duplicate it -> check that original tab stays pinned and its title is not changed, check that duplicated tab is not pinned and its path is correct (meaning - not the pinned one)

Other people can do their checks :-)

Thank you, Martin! (and Nikita :-)! For my part, my performed tests (using Kubuntu 17.04) went alright. Other people can do their checks.

Just to confirm, do you guys see the other 3 warnings with gcc < 7?

It also works using gcc 5.4.0 under Ubuntu 16.04 LTS (its latest Long Term Service version). Thanks!

I've changed delimiter to space and used KShell::splitArgs() method to allow using

• quoted folder names
• folder names with escaped spaces

Now the names of Jakub Buczak (Jakkubu) and Nate Graham are mentioned in the commit.

For more consistency, I'm thinking that, if in the "Search for:" text field, Krusader users space as a delimiter... maybe it would also use it in the same window, in the proposed «Exclude Folder Names» text field.

Thank you! For my part, I accept this because I performed some tests and the new patch worked correctly (items inside the specified folders are excluded, files and folders that are shown are the expected ones, etc.), although when there was a folder with a ":" inside its name then the folder couldn't be excluded.

Thanks Davide! The changes that Nikita (nmel) wrote are also improvements. For my part, I accept this because my performed tests (using Kubuntu 17.10) seemed to work correctly.

Application specific icons should be provided by the application.

Thanks, Toni, for trying it out! :-)

My favourite is 2A :).

Hi! I tried the patch, using Kubuntu 17.10, and everything seems to work correctly.

Note: This is related to

https://bugs.kde.org/show_bug.cgi?id=389869

As Andreas Kainz has updated Oxygen icons (very good!), now Breeze and Oxygen have all the icons that Krusader needs, there are more details in:

https://bugs.kde.org/show_bug.cgi?id=388691
https://commits.kde.org/oxygen-icons5/857400cb1a51f2287e4b6b285bba0f897066a6f7

Because you added this

For my part, I accept this because my performed tests (using Kubuntu 17.04) went alright.

For my part, I accept this because my performed tests went alright. Other people can do their checks.

For my part, I accept this because every of my performed tests has been successful, even the "selected characters" test :-). Other people can do their checks.

I've found one other issue myself today - zooming out would cause that there are too many characters on one line
not fitting the viewport width. This should now be fixed, too.

With the latest improvements, at least using Kubuntu 17.04, not everything was perfect :-) :

• if the user utilizes Lister to see a file like the "bashrc" attached one and then presses PgDown a lot of times: the scroll doesn't stop at the end of the file.
• if the user utilizes Lister to see a file like the "profile" attached one and then presses PgDown: the cursor does not move.
• if the user utilizes Lister to see a file like the "profile" attached one and then presses Ctrl+End: the cursor does not move.

Marked as "Closed, Resolved". Thanks for the good work!

Marked as "Closed, Resolved". Thanks for the good work!

After the changes:
This is the beginning of the README file as it's seen in https://phabricator.kde.org/source/krusader/: