Feed Advanced Search

Sun, Sep 15

iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

Thanks for the review and the hints @elvisangelaccio.
Those were some issues I tried to explore when starting the patch but didn't get to work, so I went the hardcoded way.
I hope it is in a better shape now.

Sun, Sep 15, 3:17 PMDolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Remove unrelated changes
  • Reuse QMovie instance
  • Check supported formats instead of hardcoded mimetypes
Sun, Sep 15, 3:07 PMDolphin

Fri, Sep 13

iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

Ugh, those kinds of if/else blocks are always confusing. I would (in another patch) re-arrange it so everything currently in the else block comes first (if (!usePhonon) { blabla) to get that small bit out of the way first so the more complex logic can come next without an else block after it.

Fri, Sep 13, 5:08 PMDolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Move isAnimatedImage block for clarity
Fri, Sep 13, 4:40 PMDolphin

Wed, Sep 11

iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

I think we are having a misunderstanding, maybe due to the unlucky coincidence of line 278 having a different else on different branches 馃槂

Wed, Sep 11, 3:32 PMDolphin

Wed, Sep 4

iasensio added a watcher for Dolphin: iasensio.
Wed, Sep 4, 9:20 PM

Sun, Sep 1

iasensio added inline comments to D23538: [dolphin] Animate gifs on preview.
Sun, Sep 1, 7:33 PMDolphin
iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • reorder disconnect
Sun, Sep 1, 7:10 PMDolphin
iasensio added inline comments to D23538: [dolphin] Animate gifs on preview.
Sun, Sep 1, 4:58 PMDolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Small optimization
Sun, Sep 1, 4:58 PMDolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Correct indentation
Sun, Sep 1, 4:19 PMDolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Rebased to master after D22183
Sun, Sep 1, 4:00 PMDolphin

Sat, Aug 31

iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

Yeah, I see now that you're right.

This looks great to me now. @elvisangelaccio?

Sat, Aug 31, 12:49 PMDolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Fix refresh on resizing event
Sat, Aug 31, 12:30 PMDolphin

Fri, Aug 30

iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

Yes, I was reluctant to move this line inside the condition, but it will actually refresh the preview less, that is, no refreshing when the item to be shown is the same as the current one. In fact, this change is not needed to avoid the animation restarting, but to avoid the following flickering:

.

Fri, Aug 30, 6:25 PMDolphin

Thu, Aug 29

iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

I've finally moved it to a separate function, and directly harcoded the mimetypes, as it seems cleaner.
I've not been able to test if the preview of mngfiles actually animates or not, but the mimetype check is now correct.

Thu, Aug 29, 10:36 PMDolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Fix animated mimetypes (harcoded)
Thu, Aug 29, 10:18 PMDolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Avoid restarting animation on hover+select
Thu, Aug 29, 8:57 PMDolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Check if same file or already running
Thu, Aug 29, 8:07 PMDolphin
iasensio updated the diff for D23475: [baloo-widgets] Apply condensed date to file metadata properties.
  • Add also QVariant::Date
Thu, Aug 29, 7:11 PMDolphin, Baloo
iasensio added a comment to D23475: [baloo-widgets] Apply condensed date to file metadata properties.

I agree with you both, but I found some problems on that path.

Thu, Aug 29, 6:58 PMDolphin, Baloo
iasensio updated the diff for D23475: [baloo-widgets] Apply condensed date to file metadata properties.
  • Making formatDateTime a non-member function
  • Simplify
Thu, Aug 29, 6:39 PMDolphin, Baloo
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Fix bugs when hovering and selecting
Thu, Aug 29, 5:50 PMDolphin
iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

I've reviewed your test cases and now all of them are (hopefully) gone. Also another one when selecting multiple files.
Finally I had to go deleting the QMovieobject, because it doesn't provide a way to deactivate it, other than setting an empty FileName (which shows a log error message).

Thu, Aug 29, 5:49 PMDolphin
iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

About checking for m_animatedImage

Thu, Aug 29, 4:29 PMDolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Return QSring() instead of QString::null
Thu, Aug 29, 4:29 PMDolphin
iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

I also added stopAnimatedImage() because stopping it by passing an empty filename was kind of hacky

Thu, Aug 29, 2:58 PMDolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Change name to animatedImage
  • Create QMovie object only on first use
Thu, Aug 29, 2:56 PMDolphin

Wed, Aug 28

iasensio added inline comments to D23538: [dolphin] Animate gifs on preview.
Wed, Aug 28, 7:21 PMDolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Remove extra line
Wed, Aug 28, 7:20 PMDolphin
iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

Inline comment about supported formats

Wed, Aug 28, 5:29 PMDolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Clean includes and delete
Wed, Aug 28, 5:16 PMDolphin
iasensio updated the summary of D23538: [dolphin] Animate gifs on preview.
Wed, Aug 28, 4:00 PMDolphin
iasensio requested review of D23538: [dolphin] Animate gifs on preview.
Wed, Aug 28, 3:58 PMDolphin

Tue, Aug 27

iasensio added a comment to D23103: Add decibel power units (dBW and multiples).

Friendly ping

Tue, Aug 27, 1:51 PMFrameworks

Mon, Aug 26

iasensio added a project to D23475: [baloo-widgets] Apply condensed date to file metadata properties: Dolphin.
Mon, Aug 26, 8:41 PMDolphin, Baloo
iasensio requested review of D23475: [baloo-widgets] Apply condensed date to file metadata properties.
Mon, Aug 26, 8:39 PMDolphin, Baloo

Sun, Aug 25

iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Address inline comments
  • Use setSearchModeEnabled as a public slot
  • Capitalize action text
Sun, Aug 25, 11:04 PMDolphin

Aug 19 2019

iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Set toggle_search as default toolbar action
Aug 19 2019, 11:34 AMDolphin
iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Set toggle_search as default toolbar action (on top of D23075)
Aug 19 2019, 11:15 AMDolphin
iasensio added a comment to D23232: [dolphin] Add an action to toggle the searchbar.

Looks like you incorporated changes in D23075 rather than rebasing on top of it.

Aug 19 2019, 2:12 AMDolphin
iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Update dolphinui.rc to use toggle_search instead of edit_find
Aug 19 2019, 12:30 AMDolphin

Aug 18 2019

iasensio updated the test plan for D23232: [dolphin] Add an action to toggle the searchbar.
Aug 18 2019, 12:37 AMDolphin
iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Add an independent toggle_search action
Aug 18 2019, 12:30 AMDolphin

Aug 17 2019

iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Update search action on view changes
Aug 17 2019, 11:14 PMDolphin
iasensio added a comment to D23232: [dolphin] Add an action to toggle the searchbar.

Wow, I did a little search through the bug tracker but I didn't find that it had been already addresed.
Those other two patches seem more detailed, as I haven't dealt with the filter bar, only the search bar. I have already seen some inconsistencies in mine when using tabs or split view.

Aug 17 2019, 11:02 PMDolphin
iasensio added reviewers for D23232: [dolphin] Add an action to toggle the searchbar: Dolphin, ngraham.
Aug 17 2019, 10:20 PMDolphin
iasensio requested review of D23232: [dolphin] Add an action to toggle the searchbar.
Aug 17 2019, 10:18 PMDolphin

Aug 14 2019

iasensio added a comment to D23103: Add decibel power units (dBW and multiples).

Well, in my field of work (telephony, radar and radio signal transmission) it makes totally sense (altought Terawatts would be major words 馃槃). It is a non trivial conversion that we make quite frequently.

Aug 14 2019, 1:47 PMFrameworks

Aug 11 2019

iasensio updated the diff for D23103: Add decibel power units (dBW and multiples).
  • Set frameworks version
Aug 11 2019, 9:42 PMFrameworks
iasensio added a reviewer for D23103: Add decibel power units (dBW and multiples): broulik.
Aug 11 2019, 9:05 PMFrameworks
iasensio updated the test plan for D23103: Add decibel power units (dBW and multiples).
Aug 11 2019, 8:29 PMFrameworks
iasensio requested review of D23103: Add decibel power units (dBW and multiples).
Aug 11 2019, 8:24 PMFrameworks

Aug 10 2019

iasensio added a comment to D23064: Fix duplicate results when a 2nd unit is partially written in krunner.

Sure about the email. Thanks!

Aug 10 2019, 2:32 PMPlasma
iasensio requested review of D23064: Fix duplicate results when a 2nd unit is partially written in krunner.
Aug 10 2019, 8:22 AMPlasma