Feed Advanced Search

Mar 8 2020

axionl added a comment to D27926: Add flameshot tray icons.

Nice!

Do you think you could also make 16px versions?

Mar 8 2020, 5:06 PM · Frameworks
axionl updated the diff for D27926: Add flameshot tray icons.

Update flameshot tray icon.

Mar 8 2020, 4:35 PM · Frameworks
axionl retitled D27926: Add flameshot tray icons from Add flameshot tray icons to [breeze-icons] Add flameshot tray icons.
Mar 8 2020, 4:57 AM · Frameworks
axionl requested review of D27926: Add flameshot tray icons.
Mar 8 2020, 4:48 AM · Frameworks

Feb 28 2019

axionl updated the diff for D19324: Add code-oss icon.
  • Setting my username to pass the automated audit.
Feb 28 2019, 1:39 PM · Frameworks
axionl updated the test plan for D19324: Add code-oss icon.
Feb 28 2019, 1:37 AM · Frameworks
axionl added a comment to D19324: Add code-oss icon.

Great. Now you just need to get rid of the invisible rectangle. You can do that quickly with sed -i 's|<rect x="9.5367e-8" y="284.3" width="12.7" height="12.7" fill="none" opacity=".35"/>||' code.svg. After you've done that, I can accept and land this.

BTW, you're meant to put the comment for the diff update at the top, but it's not a huge deal. That's why you keep getting this text in all of your update comments:

  - Merge branch 'master' into code-oss

# Updating D19324: Add code-oss icon
#
# Enter a brief description of the changes included in this update.
# The first line is used as subject, next lines as comment.
#
# If you intended to create a new revision, use:
#  $ arc diff --create

The stuff to the left of the # characters is ignored if you put the comment at the top.

Feb 28 2019, 1:32 AM · Frameworks
axionl updated the diff for D19324: Add code-oss icon.
  • Merge branch 'master' into code-oss

Remove the invisible rectangle.

Feb 28 2019, 1:30 AM · Frameworks

Feb 27 2019

axionl updated the diff for D19324: Add code-oss icon.
  • Merge branch 'master' into code-oss
Feb 27 2019, 11:59 AM · Frameworks
axionl updated the diff for D19324: Add code-oss icon.
  • Merge branch 'master' into code-oss
Feb 27 2019, 11:57 AM · Frameworks
axionl added a comment to D19324: Add code-oss icon.

I see you've kept the green on the light theme version instead of using the same icon for both versions. Is there a reason for this or do you just prefer it?

This looks just about ready to land on the master branch, there are just a few more things you need to do.

Feb 27 2019, 8:38 AM · Frameworks
axionl updated the test plan for D19324: Add code-oss icon.
Feb 27 2019, 1:34 AM · Frameworks
axionl updated the diff for D19324: Add code-oss icon.
  • Merge branch 'master' into code-oss
Feb 27 2019, 1:29 AM · Frameworks
axionl abandoned D19380: # Enter a commit message. # # Changes: # # icons-dark/apps/48/code.svg # icons/apps/48/code.svg.
Feb 27 2019, 1:28 AM · Frameworks
axionl added a comment to D19380: # Enter a commit message. # # Changes: # # icons-dark/apps/48/code.svg # icons/apps/48/code.svg.

I make a mistake to create a new revision, please delete this one.

Feb 27 2019, 12:17 AM · Frameworks
axionl requested review of D19380: # Enter a commit message. # # Changes: # # icons-dark/apps/48/code.svg # icons/apps/48/code.svg.
Feb 27 2019, 12:02 AM · Frameworks

Feb 26 2019

axionl updated the diff for D19324: Add code-oss icon.
  • Merge branch 'master' into code-oss
Feb 26 2019, 9:18 AM · Frameworks
axionl updated the test plan for D19324: Add code-oss icon.
Feb 26 2019, 9:15 AM · Frameworks
axionl updated the test plan for D19324: Add code-oss icon.
Feb 26 2019, 9:06 AM · Frameworks
axionl updated the diff for D19324: Add code-oss icon.
  • Merge branch 'master' into code-oss
Feb 26 2019, 8:48 AM · Frameworks
axionl added a comment to D19324: Add code-oss icon.

I use the Gravit Designer (https://designer.io/) to design this icon, not the inkscape, but I think I can redraw it by inkscape.

Please do. KDE software is only made with free and open source software. If you need help with Inkscape, let us know. We would be glad to help.

For the filename, because I'm using archlinux and the icon name is code-oss.svg on /usr/share/pixmaps.

In that case, run ln -sr code-oss.svg code.svg in the same directory as code-oss.svg to made a symlink so that the icon works for Arch Linux and any other distro.

Feb 26 2019, 7:41 AM · Frameworks
axionl added a comment to D19324: Add code-oss icon.

Weird. In Inkscape, the logo looks like raster graphics, but in Dolphin and Gwenview it looks like vector graphics. Something is seriously screwed up in this SVG. Did you use Inkscape? Can you explain what process you used to make this icon?


code-oss-dark.svg

Is this the correct name?

I don't think so. The Code-OSS flatpak and the VS Code RPM use code.png, so I think the name needs to be code.svg for light and dark Breeze icons. It would be a good idea to test if using icon themes actually works though, because code.png installs to /usr/share/code/resources/app/resources/linux/code.png and /usr/share/pixmaps/code.png instead of hicolor.

Feb 26 2019, 7:30 AM · Frameworks
axionl updated the diff for D19324: Add code-oss icon.
  • Merge branch 'master' into code-oss
Feb 26 2019, 7:23 AM · Frameworks
axionl added a comment to D19324: Add code-oss icon.

There are commands/aliases here for how to take quick screenshots https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow

I ran montage-breeze and I got


which looks really nice.

However, is there some reason that it looks different from a Dolphin generated thumbnail?

EDIT: And yes the dark version should have the same name as the regular version (code-oss.svg).

Feb 26 2019, 7:20 AM · Frameworks
axionl requested review of D19324: Add code-oss icon.
Feb 26 2019, 3:59 AM · Frameworks