Feed Advanced Search

Jan 11 2019

dkazakov committed R37:71da92eab6b2: Revert "Disable the option of choosing p2019-pq surface type (it doesn't work… (authored by dkazakov).
Revert "Disable the option of choosing p2019-pq surface type (it doesn't work…
Jan 11 2019, 8:37 PM
dkazakov added a reverting change for R37:f6fdc1317e24: Disable the option of choosing p2020-pq surface type (it doesn't work correctly…: R37:71da92eab6b2: Revert "Disable the option of choosing p2019-pq surface type (it doesn't work….
Jan 11 2019, 8:37 PM
dkazakov closed D18098: Add "hasKeyframeAtTime" function for Node Python API.

Closed by Scott :)

Jan 11 2019, 10:30 AM · Krita

Jan 10 2019

dkazakov added a task to R37:90825b9f0690: Fix clone brush to show outline even when it is globally hidden: Unknown Object (Maniphest Task).
Jan 10 2019, 8:44 PM
dkazakov added a task to R37:9c6a9241d451: [FEATURE] Add on-canvas preview of current color: Unknown Object (Maniphest Task).
Jan 10 2019, 8:44 PM
dkazakov added a task to R37:2393cc3502b2: Fix updated of the group layer when changing visibility/pass through: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:a11be9dc7abf: [FEATURE] Implemented Pass-through mode for Group Layers!: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:9a8a9e09ef17: Fix Layer Styles and Inherit Alpha coupling: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:6625b674201e: [FEATURE] Add Layer Styles icons to the layers docker: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:ec43272f749a: Fixed an update problem when undoing layer removal: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:2040fe4b22ed: [FEATURE] Lightness curve for per-channel filter: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:604a4a70f7c8: Fix loading PSD files saved in OpenCanvas: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:174e78c4823d: [FEATURE] Implemented a composite RGB curve for Curves filter: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:52943ae8fb9c: Fixed a bug when the tools became disabled after new document creation: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:269d20f4f9de: Fix projection leaf order when the passthrough groups are nested: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:3a0a3960f104: Fix visibility of nested pass-through nodes: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:7cae024d8dbb: Make Group Layer return correct extent and exact bounds when in pass-through…: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:996ca02504af: Fix crash/problem when saving a pattern to a .kra file: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:4450d6539b9d: Fixed Flatten Layer and Merge Down actions for layer with layer styles: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:f47b96c3a98c: [FEATURE] Multiple layers merge with layer styles on Ctrl+E: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:2cc675d78368: KisGeneratorLayer should use channel flags when composition but not generation: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:d5bd36e21000: Transform invisible layers if they are part of the group: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:b45e78e1d8c6: Don't add new layers to the group if it is locked: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:0be0f828c3a1: Fix crash when activating Passthrough mode for a group with transparency mask: T567: Infinite loop in collectRects.
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:a4f550b68e37: [FEATURE] Keep Selection Masks while merging layers: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a commit to T567: Infinite loop in collectRects: R37:0be0f828c3a1: Fix crash when activating Passthrough mode for a group with transparency mask.
Jan 10 2019, 8:43 PM · Krita: Old Dmitry's Workboard (not used anymore)
dkazakov added a commit to T568: Local selections are all active upon loading file: R37:71cb40b04f7c: Fix loading of selection masks.
Jan 10 2019, 8:43 PM · Krita: Old Dmitry's Workboard (not used anymore)
dkazakov added a task to R37:71cb40b04f7c: Fix loading of selection masks: T568: Local selections are all active upon loading file.
Jan 10 2019, 8:43 PM
dkazakov added a task to R37:7b87cee123ff: [FEATURE] Implement 'Scalable smoothness' feature for Stabilizer smoother: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM
dkazakov added a commit to T590: Default projection color is not saved to PSD: R37:7117580f2632: Fix saving PSD when the image has a non-transparent background.
Jan 10 2019, 8:42 PM · Krita: Old Dmitry's Workboard (not used anymore)
dkazakov added a task to R37:7117580f2632: Fix saving PSD when the image has a non-transparent background: T590: Default projection color is not saved to PSD.
Jan 10 2019, 8:42 PM
dkazakov added a task to R37:277e3405dabf: Add caching of the random-generator device in layer styles: Unknown Object (Maniphest Task).
Jan 10 2019, 8:42 PM
dkazakov added a task to R37:b246708328b6: Implemented projections for layer styles: Unknown Object (Maniphest Task).
Jan 10 2019, 8:42 PM
dkazakov added a commit to T858: Gradient in LoD -> assert: R37:8b95ee894b8d: Make KisImaage::isIdle() less strict.
Jan 10 2019, 8:42 PM · Krita: Old Dmitry's Workboard (not used anymore)
dkazakov added a task to R37:8b95ee894b8d: Make KisImaage::isIdle() less strict: T858: Gradient in LoD -> assert.
Jan 10 2019, 8:42 PM
dkazakov added a task to R37:951efdf5744e: Fix alignment bugs in genericComposite() in 128bit mode: T862: 32bit float + colosmudge | Thorsten.
Jan 10 2019, 8:42 PM
dkazakov added a commit to T862: 32bit float + colosmudge | Thorsten: R37:951efdf5744e: Fix alignment bugs in genericComposite() in 128bit mode.
Jan 10 2019, 8:42 PM · Krita: Old Dmitry's Workboard (not used anymore)
dkazakov committed R37:c3a8b83aafb5: Implemented a unittest for saving HDR PNG files (authored by dkazakov).
Implemented a unittest for saving HDR PNG files
Jan 10 2019, 3:43 PM
dkazakov committed R37:76a6ad092be3: Implement a unittest for Rec. 2020 PQ conversions (authored by dkazakov).
Implement a unittest for Rec. 2020 PQ conversions
Jan 10 2019, 3:43 PM
dkazakov accepted D18098: Add "hasKeyframeAtTime" function for Node Python API.

Now it should be perfectly fine to push! :)

Jan 10 2019, 1:18 PM · Krita

Jan 9 2019

dkazakov committed R37:69392e7bd7cd: Revert "Add a CMake option for ASAN address sanitizer" (authored by dkazakov).
Revert "Add a CMake option for ASAN address sanitizer"
Jan 9 2019, 3:02 PM
dkazakov added a reverting change for R37:05762b6eb3b2: Add a CMake option for ASAN address sanitizer: R37:69392e7bd7cd: Revert "Add a CMake option for ASAN address sanitizer".
Jan 9 2019, 3:02 PM
dkazakov added a comment to D18098: Add "hasKeyframeAtTime" function for Node Python API.

Just a comment

Jan 9 2019, 1:31 PM · Krita

Jan 8 2019

dkazakov requested changes to D16833: [WIP] Further Color Picker Upgrades, Fixes and Refactors..

I have tested your patch and found the following issues:

Jan 8 2019, 11:26 AM · Krita
dkazakov accepted D15590: [WIP] Refactor KisNodeDelegate and support RTL.

The patch seem to cause no regressions in LTR mode, so it is safe to push it! :)

Jan 8 2019, 10:43 AM · Krita
dkazakov added a comment to D17853: Add a CMake option for ASAN address sanitizer.
In D17853#388885, @pino wrote:

Just noticed this... note that ECM already provides it: https://api.kde.org/ecm/module/ECMEnableSanitizers.html

Jan 8 2019, 10:12 AM · Krita
dkazakov committed R37:05762b6eb3b2: Add a CMake option for ASAN address sanitizer (authored by dkazakov).
Add a CMake option for ASAN address sanitizer
Jan 8 2019, 10:07 AM
dkazakov closed D17853: Add a CMake option for ASAN address sanitizer.
Jan 8 2019, 10:07 AM · Krita
dkazakov requested changes to D17793: Support Extra Mouse Buttons in Shortcuts.

There is still some weird problem with assigning these extra buttons to the shortcuts. Please see the attached video:

Jan 8 2019, 9:59 AM · Krita

Jan 7 2019

dkazakov added a comment to T863: Gradient Dithering | NotAssigned.

I guess it just wasn't finished and worked only in few cases... and caused regressions in other cases

Jan 7 2019, 9:44 AM · Krita: Dmitry's TODO, Krita: Abyss

Dec 29 2018

dkazakov updated the summary of D17853: Add a CMake option for ASAN address sanitizer.
Dec 29 2018, 12:59 PM · Krita
dkazakov updated the summary of D17853: Add a CMake option for ASAN address sanitizer.
Dec 29 2018, 12:59 PM · Krita
dkazakov requested review of D17853: Add a CMake option for ASAN address sanitizer.
Dec 29 2018, 12:57 PM · Krita
dkazakov requested changes to D15590: [WIP] Refactor KisNodeDelegate and support RTL.

Thank you for sharing the screenshots! It looks like the problem is really serious. I would say that alignment is almost "not-a-problem" in comparison to the main part of the patch :)

Dec 29 2018, 11:28 AM · Krita
dkazakov requested changes to D17807: Added a QComboBox to adjust preview granularity while doing transforms.

I still have an assert when trying to change the values :(

Dec 29 2018, 11:01 AM · Krita

Dec 28 2018

dkazakov added a comment to D17695: overview docker: preserve aspect ratio and don't stretch when some layers are hidden.
In D17695#382476, @Beuc wrote:

By the way this patch was intended to the 4.1 branch, you'll want to replicate it there.

Dec 28 2018, 8:30 PM · Krita
dkazakov added a comment to D17708: Deref image shared pointers before calling ~KisDocument (#396985).
In D17708#382477, @Beuc wrote:

By the way this patch was intended to the 4.1 branch, you'll want to replicate it there.

Dec 28 2018, 8:30 PM · Krita
dkazakov committed R37:931179e99722: Deref image shared pointers before calling ~KisDocument (#396985) (authored by dkazakov).
Deref image shared pointers before calling ~KisDocument (#396985)
Dec 28 2018, 8:29 PM
dkazakov committed R37:8004cc32e681: overview docker: preserve aspect ratio and don't stretch when some layers are… (authored by dkazakov).
overview docker: preserve aspect ratio and don't stretch when some layers are…
Dec 28 2018, 8:29 PM
dkazakov requested changes to D17793: Support Extra Mouse Buttons in Shortcuts.

There are two issues with the current version of the patch:

Dec 28 2018, 11:43 AM · Krita
dkazakov requested changes to D17807: Added a QComboBox to adjust preview granularity while doing transforms.

It looks like your option gets uninitialized somehow, so it tries to pass random numbers to the processing code. Therefore causing it to crash :(

Dec 28 2018, 11:27 AM · Krita
dkazakov updated the title for P286 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Dec 28 2018, 11:23 AM
dkazakov added a comment to D16234: Save current color with brush preset.

I am sorry, I could not continue to edit this revision.

Dec 28 2018, 9:59 AM · Krita
dkazakov added a comment to D6619: Brush menu pattern rotation option.

I've been thinking about this lately and I think we can implement this another way that wouldn't lower the performance. The problem with this implementation is that the pattern gets rotated for each dab placement. So there's two ways I can think of improving this, either apply the rotation and store it somewhere else outside of the paint operation or rotate it once at the beginning of the paint stroke and cache it somehow.

Dec 28 2018, 9:46 AM · Krita

Dec 26 2018

dkazakov committed R37:16203f979dc8: Remove ad-hoc implementation of converting to p2020-pq in PNG saving code (authored by dkazakov).
Remove ad-hoc implementation of converting to p2020-pq in PNG saving code
Dec 26 2018, 5:23 PM
dkazakov committed R37:3f31062e10f1: Implement proper conversions to Rec. 2020 PQ color space (authored by dkazakov).
Implement proper conversions to Rec. 2020 PQ color space
Dec 26 2018, 5:23 PM

Dec 25 2018

dkazakov added a comment to D15590: [WIP] Refactor KisNodeDelegate and support RTL.

Could you please make a screenshot and a bit of explanation of what this patch is expected to do? I tried to add RTL text to the layer name and it seem to be rendered kind of fine with and without your patch. The only problem I have found is the alignment of the text (it is left-aligned), but I'm not sure it is what you are trying to solve.

Dec 25 2018, 3:10 PM · Krita
dkazakov committed R37:ea51095a4be8: Added a QSpinBox to adjust granularity while doing transforms (authored by hellozee).
Added a QSpinBox to adjust granularity while doing transforms
Dec 25 2018, 2:06 PM
dkazakov closed D17660: Added a QSpinBox to adjust granularity while doing transforms.
Dec 25 2018, 2:06 PM · Krita
dkazakov accepted D17660: Added a QSpinBox to adjust granularity while doing transforms.

The patch looks fine! Now you should add one more option for the preview granularity, but that is for the next patch :)

Dec 25 2018, 1:47 PM · Krita
dkazakov closed D15533: Fix race condition on getTileLazy.

The patch has been pushed in a879aa5107955ef1ee260ec5468a42b5965eb59d

Dec 25 2018, 9:57 AM · Krita
dkazakov committed R37:b56a0362497d: Less KisCanvasUpdatesCompressor contention (authored by poke1024).
Less KisCanvasUpdatesCompressor contention
Dec 25 2018, 9:49 AM
dkazakov closed D8022: Less KisCanvasUpdatesCompressor contention.
Dec 25 2018, 9:49 AM · Krita
dkazakov closed D13739: Port lock free map into Krita instead of KisTileHashTableTraits. .

The patch has been pushed in 24975f889a7a219d7dd9729d03e34048669dae73

Dec 25 2018, 8:29 AM · Krita
dkazakov closed D14114: Lock fixing in Krita's tile manager..

The patch has been committed in 5d82f8e3cf88e402ab2a6991826fc9847e9947c8

Dec 25 2018, 8:28 AM · Krita
dkazakov closed D14660: Krita's work scheduler internal lock fixes.

The patch has been pushed in 5311b66754f2651cc16a96f2cba1789a1f0b7165

Dec 25 2018, 8:26 AM · Krita
dkazakov closed D13668: Make the UI for the warp tool points a bit cleaner.

As far as I can tell, the patch has been committed in a8ca98974df7c96e2ff564797f2e3aa534d194f0, so let's close it :)

Dec 25 2018, 8:25 AM · Krita
dkazakov committed R37:5f819ec9830f: Insert new layer above selected group layer (authored by dkazakov).
Insert new layer above selected group layer
Dec 25 2018, 8:20 AM
dkazakov closed D15523: Insert new layer above selected group layer.
Dec 25 2018, 8:20 AM · Krita
dkazakov committed R37:51ea7b37d5a7: Add copyright notice for Mehmet Salih Çalışkan (authored by mscaliskan).
Add copyright notice for Mehmet Salih Çalışkan
Dec 25 2018, 8:11 AM
dkazakov closed D16119: Paste plain text as selected text style on SVG text tool.
Dec 25 2018, 8:11 AM · Krita
dkazakov requested changes to D16184: Fix compilation on compilers which do not have Atomic built-in.

Since the patch was reverted and breaks something, I'm marking it as Needs Changes

Dec 25 2018, 7:50 AM · Krita
dkazakov committed R37:0c150e26151e: add exportConfiguration InfoObject to Node.save for predictable batchmode (authored by dkazakov).
add exportConfiguration InfoObject to Node.save for predictable batchmode
Dec 25 2018, 7:49 AM
dkazakov closed D17639: add exportConfiguration InfoObject to Node.save for predictable batchmode.
Dec 25 2018, 7:49 AM · Krita
dkazakov requested changes to D17793: Support Extra Mouse Buttons in Shortcuts.

The patch looks good codewise. I especially like the boost's macros for doing all the boilerplate.

Dec 25 2018, 7:42 AM · Krita
dkazakov committed R37:9cee1d464135: overview docker: preserve aspect ratio and don't stretch when some layers are… (authored by dkazakov).
overview docker: preserve aspect ratio and don't stretch when some layers are…
Dec 25 2018, 6:50 AM
dkazakov closed D17695: overview docker: preserve aspect ratio and don't stretch when some layers are hidden.
Dec 25 2018, 6:50 AM · Krita
dkazakov committed R37:1f14ab955e22: Deref image shared pointers before calling ~KisDocument (#396985) (authored by dkazakov).
Deref image shared pointers before calling ~KisDocument (#396985)
Dec 25 2018, 6:40 AM
dkazakov closed D17708: Deref image shared pointers before calling ~KisDocument (#396985).
Dec 25 2018, 6:40 AM · Krita
dkazakov requested changes to D17660: Added a QSpinBox to adjust granularity while doing transforms.

The patch looks basically correct, except that the option is related to cage transform only, so it is logical to put it into the "cage" page, but not to the free transform page. Right now it looks very confusing :)

Dec 25 2018, 6:31 AM · Krita
dkazakov added a comment to D17793: Support Extra Mouse Buttons in Shortcuts.

Thank you for the patch, I'll test it now!

Dec 25 2018, 6:11 AM · Krita
dkazakov requested changes to D16234: Save current color with brush preset.

I will mark the patch as "needs changes", otherwise its status is confusing...

Dec 25 2018, 6:06 AM · Krita

Dec 24 2018

dkazakov committed R37:498f54d0c7bf: Implement loading of HDR PND images (authored by dkazakov).
Implement loading of HDR PND images
Dec 24 2018, 8:44 PM
dkazakov committed R37:f1f47914fca5: Implement saving of HDR PNG files (authored by dkazakov).
Implement saving of HDR PNG files
Dec 24 2018, 3:31 PM

Dec 21 2018

dkazakov committed R37:87248a2ac222: Fix rendering of the textures in a few cases: (authored by dkazakov).
Fix rendering of the textures in a few cases:
Dec 21 2018, 7:20 PM
dkazakov committed R37:81da62cf34d3: Fix moving the cursor in the small color selector when dynamic range changes (authored by dkazakov).
Fix moving the cursor in the small color selector when dynamic range changes
Dec 21 2018, 7:20 PM
dkazakov committed R37:86a112b5443d: Remove extra warnings (authored by dkazakov).
Remove extra warnings
Dec 21 2018, 7:20 PM
dkazakov committed R37:d1440c669ae7: Reactivate color management of openGL texture tiles (authored by dkazakov).
Reactivate color management of openGL texture tiles
Dec 21 2018, 7:20 PM
dkazakov committed R37:9fdf930a3955: Save OCIO settings to the Krita configuration file (authored by dkazakov).
Save OCIO settings to the Krita configuration file
Dec 21 2018, 7:20 PM
dkazakov committed R37:427ad1526626: Fix rendering of KisGLImageWidget in HiDPI mode (authored by dkazakov).
Fix rendering of KisGLImageWidget in HiDPI mode
Dec 21 2018, 7:20 PM