Feed Advanced Search

Advanced Search
Use Results
Hide Query

Feb 8 2019

patrickelectric committed R871:c850a7c8180c: mingw_generator: Fix argument type (authored by patrickelectric).
mingw_generator: Fix argument type
Feb 8 2019, 9:45 PM
patrickelectric committed R871:35eba45f1ec4: mingw_generator: Fix iterator type (authored by patrickelectric).
mingw_generator: Fix iterator type
Feb 8 2019, 9:45 PM
patrickelectric added a reviewer for D18802: Fix pragma once problem with process class: ngraham.
Feb 8 2019, 9:33 PM · Plasma
patrickelectric added a reviewer for D18801: CMakeLists: Fix bfd.h include path on windows: ngraham.
Feb 8 2019, 9:33 PM · Plasma
patrickelectric retitled D18859: cdb: First working version from msvc: First commit to [WIP] msvc: First commit.
Feb 8 2019, 9:16 PM · Plasma
patrickelectric added a comment to D18859: cdb: First working version.

thank you @ngraham, but this is not ready to review yet.
But be free to review D18801 and D18802

Feb 8 2019, 9:14 PM · Plasma
patrickelectric updated the diff for D18859: cdb: First working version.
  • msvc: Add cdb configuration
Feb 8 2019, 7:00 PM · Plasma
patrickelectric requested review of D18859: cdb: First working version.
Feb 8 2019, 6:35 PM · Plasma
patrickelectric committed R871:aac1c1067eb5: msvc_gnerator: Fix PCHAR cast to QString (authored by patrickelectric).
msvc_gnerator: Fix PCHAR cast to QString
Feb 8 2019, 1:02 PM
patrickelectric committed R871:64b91d5c3f0c: QtCore is common between MINGW and MSVC (authored by patrickelectric).
QtCore is common between MINGW and MSVC
Feb 8 2019, 1:02 PM

Feb 7 2019

patrickelectric added a reviewer for D18832: runtime: Add error message about env variables: vonreth.
Feb 7 2019, 11:04 PM
patrickelectric requested review of D18832: runtime: Add error message about env variables.
Feb 7 2019, 11:02 PM

Feb 6 2019

patrickelectric added reviewers for D18802: Fix pragma once problem with process class: davidedmundson, tcanabrava.
Feb 6 2019, 11:40 PM · Plasma
patrickelectric requested review of D18802: Fix pragma once problem with process class.
Feb 6 2019, 11:39 PM · Plasma
patrickelectric retitled D18801: CMakeLists: Fix bfd.h include path on windows from CMakeLists: Fix bgd.h include path on windows to CMakeLists: Fix bfd.h include path on windows.
Feb 6 2019, 11:35 PM · Plasma
patrickelectric updated the diff for D18801: CMakeLists: Fix bfd.h include path on windows.

Fix commit message

Feb 6 2019, 11:35 PM · Plasma
patrickelectric added reviewers for D18801: CMakeLists: Fix bfd.h include path on windows: davidedmundson, tcanabrava.
Feb 6 2019, 11:33 PM · Plasma
patrickelectric requested review of D18801: CMakeLists: Fix bfd.h include path on windows.
Feb 6 2019, 11:31 PM · Plasma
patrickelectric committed R877:cc41362f429d: drkonqi: Add blueprint (authored by patrickelectric).
drkonqi: Add blueprint
Feb 6 2019, 11:18 PM
patrickelectric closed D17513: drkonqi: Add blueprint.
Feb 6 2019, 11:18 PM

Feb 3 2019

patrickelectric added inline comments to D18586: Fix Failed Sprinter Test by capturing temperature with or with out decimal.
Feb 3 2019, 1:53 PM · Atelier: AtCore

Jan 28 2019

patrickelectric added inline comments to D18472: Create Bed Deform Object.
Jan 28 2019, 2:11 PM · Atelier: AtCore

Jan 27 2019

patrickelectric accepted D18350: Add support for auto temperature reporting.
Jan 27 2019, 11:46 PM · Atelier: AtCore
patrickelectric added inline comments to D18472: Create Bed Deform Object.
Jan 27 2019, 11:43 PM · Atelier: AtCore

Jan 26 2019

patrickelectric accepted D18459: Add CONSTENT to constant Q_Properties to avoid warning when used via qml.

Great

Jan 26 2019, 5:00 PM · Atelier: AtCore
patrickelectric accepted D18468: Track the lastCommand set to the printer.
Jan 26 2019, 5:00 PM · Atelier: AtCore
patrickelectric accepted D18469: Add return for GCode::toCommand for G29.
Jan 26 2019, 5:00 PM · Atelier: AtCore
patrickelectric accepted D18525: Only force G and M codes toUpper.
Jan 26 2019, 4:59 PM · Atelier: AtCore
patrickelectric requested changes to D18472: Create Bed Deform Object.
Jan 26 2019, 2:21 PM · Atelier: AtCore
patrickelectric requested changes to D18350: Add support for auto temperature reporting.
Jan 26 2019, 1:52 PM · Atelier: AtCore

Jan 19 2019

patrickelectric requested changes to D18350: Add support for auto temperature reporting.
Jan 19 2019, 12:39 PM · Atelier: AtCore
patrickelectric accepted D18334: Add Support for M155 command.
Jan 19 2019, 12:34 PM · Atelier: AtCore
patrickelectric accepted D18349: Ensure that when we request firmware info nothing else is in the queue.
Jan 19 2019, 12:34 PM · Atelier: AtCore

Jan 16 2019

patrickelectric requested changes to D18265: Retry for resend requests.
Jan 16 2019, 1:16 PM · Atelier: AtCore

Jan 15 2019

patrickelectric accepted D18268: Adjust our Timer Fix.
Jan 15 2019, 10:11 PM · Atelier: AtCore
patrickelectric requested changes to D18268: Adjust our Timer Fix.
Jan 15 2019, 10:08 PM · Atelier: AtCore
patrickelectric accepted D18268: Adjust our Timer Fix.
Jan 15 2019, 10:08 PM · Atelier: AtCore
patrickelectric requested changes to D18268: Adjust our Timer Fix.
Jan 15 2019, 9:12 PM · Atelier: AtCore

Dec 28 2018

patrickelectric added a comment to D17588: MainWindow: Add Frameless option.

@sandsmark Corrections done.

Dec 28 2018, 3:54 PM · Konsole
patrickelectric updated the diff for D17588: MainWindow: Add Frameless option.

Add ui correction and remove tooltip

Dec 28 2018, 3:50 PM · Konsole
patrickelectric added a comment to D17759: Correct includes.

@hindenburg corrections done.

Dec 28 2018, 2:45 PM · Konsole
patrickelectric updated the diff for D17759: Correct includes.

Add missing QList

Dec 28 2018, 2:44 PM · Konsole

Dec 27 2018

patrickelectric accepted D17819: Reset post list on refresh.
Dec 27 2018, 2:54 PM · Atelier

Dec 24 2018

patrickelectric committed R232:69512133b160: mainwindow: Remove unused QSerialPort (authored by patrickelectric).
mainwindow: Remove unused QSerialPort
Dec 24 2018, 1:38 PM
patrickelectric committed R232:ffd2d72867c3: Correct QtTest include (authored by patrickelectric).
Correct QtTest include
Dec 24 2018, 1:38 PM
patrickelectric committed R232:9c464acff040: mainwindow: Remove unused QSerialPort (authored by patrickelectric).
mainwindow: Remove unused QSerialPort
Dec 24 2018, 1:38 PM
patrickelectric closed D17761: mainwindow: Remove unused QSerialPort.
Dec 24 2018, 1:38 PM
patrickelectric added a comment to D17759: Correct includes.
In D17759#381437, @hindenburg wrote:

Are you using a tool to determine this?

Dec 24 2018, 1:29 PM · Konsole

Dec 23 2018

patrickelectric added reviewers for D17761: mainwindow: Remove unused QSerialPort: rizzitello, tcanabrava.
Dec 23 2018, 1:52 PM
patrickelectric requested review of D17761: mainwindow: Remove unused QSerialPort.
Dec 23 2018, 1:52 PM
patrickelectric added reviewers for D17759: Correct includes: tcanabrava, hindenburg.
Dec 23 2018, 1:46 PM · Konsole
patrickelectric requested review of D17759: Correct includes.
Dec 23 2018, 1:45 PM · Konsole

Dec 22 2018

patrickelectric added a comment to D17588: MainWindow: Add Frameless option.

@hindenburg can you take a look ?

Dec 22 2018, 2:20 PM · Konsole

Dec 18 2018

patrickelectric added a reviewer for D17513: drkonqi: Add blueprint: vonreth.
Dec 18 2018, 11:53 AM

Dec 17 2018

patrickelectric accepted D17106: Atelier Clazy-tidy.
Dec 17 2018, 1:30 PM · Atelier

Dec 16 2018

patrickelectric added a comment to D17588: MainWindow: Add Frameless option.

@hindenburg @tcanabrava this PR is ready to review.
There is a problem with visibility if the windows is in a "opening state" when it's starting.


This only happens if I call show() or setVisibility(true) when the application is not visible yet.
That's why we have oldVisibility variable in this PR.

Dec 16 2018, 9:56 PM · Konsole
patrickelectric updated the diff for D17588: MainWindow: Add Frameless option.

Try to make Tomaz happy

Dec 16 2018, 9:42 PM · Konsole

Dec 14 2018

patrickelectric updated the diff for D17588: MainWindow: Add Frameless option.

remove debug message

Dec 14 2018, 10:09 PM · Konsole
patrickelectric requested review of D17588: MainWindow: Add Frameless option.
Dec 14 2018, 10:08 PM · Konsole

Dec 13 2018

patrickelectric accepted D17520: Add options to set Temperature Timer.
Dec 13 2018, 4:46 PM · Atelier: AtCore
patrickelectric accepted D17566: Prevent Empty commands or messages from being sent.
Dec 13 2018, 4:42 PM · Atelier: AtCore
patrickelectric accepted D17541: Replace deprecated QChart calls..
Dec 13 2018, 11:35 AM · Atelier: AtCore
patrickelectric accepted D17540: Replace QTimer pointer with QTimer.
Dec 13 2018, 11:02 AM · Atelier: AtCore

Dec 12 2018

patrickelectric accepted D17519: Connect z_delta_dimensionSB to delta height.
Dec 12 2018, 1:37 AM · Atelier: General Development

Dec 11 2018

patrickelectric committed R877:482bda20650e: libbfd: Update lib to 2.31 (authored by patrickelectric).
libbfd: Update lib to 2.31
Dec 11 2018, 11:33 PM
patrickelectric closed D17512: libbfd: Update lib to 2.31.
Dec 11 2018, 11:33 PM
patrickelectric added a comment to D17512: libbfd: Update lib to 2.31.

@vonreth Corrections done.

Dec 11 2018, 10:20 PM
patrickelectric updated the diff for D17512: libbfd: Update lib to 2.31.

Add sha256 and libz

Dec 11 2018, 10:20 PM
patrickelectric added a comment to D17513: drkonqi: Add blueprint.

This is in WIP, right now is failing to build.
edit: The problem was drkonqi, new patchs for drkonqi will be done.

Dec 11 2018, 9:06 PM
patrickelectric requested review of D17513: drkonqi: Add blueprint.
Dec 11 2018, 9:05 PM
patrickelectric requested review of D17512: libbfd: Update lib to 2.31.
Dec 11 2018, 9:03 PM
patrickelectric requested changes to D17106: Atelier Clazy-tidy.
Dec 11 2018, 7:37 PM · Atelier

Nov 26 2018

patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

@rjvbb I got it to work here ! Took some time to figure out the problems with relative paths and KConfig, I am working to bundle kcrash in a .dmg :)

Nov 26 2018, 11:50 PM · Plasma
patrickelectric accepted D17146: Private Static consts.
Nov 26 2018, 11:16 PM · Atelier: AtCore

Nov 25 2018

patrickelectric requested changes to D17146: Private Static consts.
Nov 25 2018, 4:38 PM · Atelier: AtCore

Nov 24 2018

patrickelectric accepted D17117: Prevent Canceled FileChooser from calling print.
Nov 24 2018, 8:36 PM · Atelier
patrickelectric accepted D17142: Further Improve asktoSave.
Nov 24 2018, 8:36 PM · Atelier
patrickelectric accepted D17116: Improve the UI for MainWindow::askToSave.
Nov 24 2018, 5:56 PM · Atelier
patrickelectric accepted D17101: Make atcore Clazy tidy.
Nov 24 2018, 3:50 PM · Atelier: AtCore
patrickelectric requested changes to D17117: Prevent Canceled FileChooser from calling print.
Nov 24 2018, 3:48 PM · Atelier
patrickelectric added inline comments to D17117: Prevent Canceled FileChooser from calling print.
Nov 24 2018, 12:03 AM · Atelier

Nov 23 2018

patrickelectric requested changes to D17101: Make atcore Clazy tidy.
Nov 23 2018, 9:51 AM · Atelier: AtCore
patrickelectric accepted D16976: Temperature Object Improvements.
Nov 23 2018, 9:48 AM · Atelier: AtCore
patrickelectric requested changes to D17117: Prevent Canceled FileChooser from calling print.
Nov 23 2018, 9:48 AM · Atelier

Nov 22 2018

patrickelectric committed R871:4210953618ee: Debugger: Add missing include (authored by patrickelectric).
Debugger: Add missing include
Nov 22 2018, 8:34 PM
patrickelectric added a reviewer for D4929: DrKonqi : lldb and Mac support: davidedmundson.
Nov 22 2018, 8:11 PM · Plasma
patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

a find_packge for KF5::WindowSystem is missing in the root CMakeLists file.

CMake Error at src/CMakeLists.txt:84 (add_executable):
  Target "drkonqi" links to target "KF5::WindowSystem" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Nov 22 2018, 8:02 PM · Plasma
patrickelectric committed R871:515425143cb3: debugger: DataLocation is deprecated, move to AppDataLocation (authored by patrickelectric).
debugger: DataLocation is deprecated, move to AppDataLocation
Nov 22 2018, 7:42 PM
patrickelectric closed D17024: debugger: DataLocation is deprecated, move to AppDataLocation.
Nov 22 2018, 7:42 PM · Plasma
patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

After taking a second look on it, I was able to merge the patch from the srcfolder and not from the repository root folder, weird..
Will do the tests here and now !

Nov 22 2018, 7:06 PM · Plasma
patrickelectric added inline comments to D17101: Make atcore Clazy tidy.
Nov 22 2018, 6:33 PM · Atelier: AtCore
patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

Can you rebase it over the last master branch ?

Nov 22 2018, 5:07 PM · Plasma
patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

I agree, with your points.
About the mac compatibility, kcrash and drkonqi (It was merged yesterday) are already in KDE-mac brew repository, looking forward for this to be accepted !
I'll try to do some tests with your patch here today.

Nov 22 2018, 4:57 PM · Plasma
patrickelectric requested changes to D17101: Make atcore Clazy tidy.

A great patch, thank you for cleaning this stuff.

Nov 22 2018, 2:23 PM · Atelier: AtCore
D4929: DrKonqi : lldb and Mac support now requires changes to proceed.

What is the actual state of this patch ?

Nov 22 2018, 2:00 PM · Plasma

Nov 19 2018

patrickelectric added a reviewer for D17024: debugger: DataLocation is deprecated, move to AppDataLocation: mart.
Nov 19 2018, 5:56 PM · Plasma
patrickelectric updated the diff for D17024: debugger: DataLocation is deprecated, move to AppDataLocation.
  • debugger: Use c++11 for
Nov 19 2018, 5:49 PM · Plasma
patrickelectric updated the diff for D17024: debugger: DataLocation is deprecated, move to AppDataLocation.

Typo

Nov 19 2018, 5:46 PM · Plasma
patrickelectric requested review of D17024: debugger: DataLocation is deprecated, move to AppDataLocation.
Nov 19 2018, 5:43 PM · Plasma

Nov 18 2018

patrickelectric requested changes to D16976: Temperature Object Improvements.
Nov 18 2018, 2:28 PM · Atelier: AtCore
First
Prev
Next