Feed Advanced Search

Dec 14 2018

patrickelectric updated the diff for D17588: MainWindow: Add Frameless option.

remove debug message

Dec 14 2018, 10:09 PM · Konsole
patrickelectric requested review of D17588: MainWindow: Add Frameless option.
Dec 14 2018, 10:08 PM · Konsole

Dec 13 2018

patrickelectric accepted D17520: Add options to set Temperature Timer.
Dec 13 2018, 4:46 PM · Atelier: AtCore
patrickelectric accepted D17566: Prevent Empty commands or messages from being sent.
Dec 13 2018, 4:42 PM · Atelier: AtCore
patrickelectric accepted D17541: Replace deprecated QChart calls..
Dec 13 2018, 11:35 AM · Atelier: AtCore
patrickelectric accepted D17540: Replace QTimer pointer with QTimer.
Dec 13 2018, 11:02 AM · Atelier: AtCore

Dec 12 2018

patrickelectric accepted D17519: Connect z_delta_dimensionSB to delta height.
Dec 12 2018, 1:37 AM · Atelier: General Development

Dec 11 2018

patrickelectric committed R877:482bda20650e: libbfd: Update lib to 2.31 (authored by patrickelectric).
libbfd: Update lib to 2.31
Dec 11 2018, 11:33 PM
patrickelectric closed D17512: libbfd: Update lib to 2.31.
Dec 11 2018, 11:33 PM
patrickelectric added a comment to D17512: libbfd: Update lib to 2.31.

@vonreth Corrections done.

Dec 11 2018, 10:20 PM
patrickelectric updated the diff for D17512: libbfd: Update lib to 2.31.

Add sha256 and libz

Dec 11 2018, 10:20 PM
patrickelectric added a comment to D17513: drkonqi: Add blueprint.

This is in WIP, right now is failing to build.
edit: The problem was drkonqi, new patchs for drkonqi will be done.

Dec 11 2018, 9:06 PM
patrickelectric requested review of D17513: drkonqi: Add blueprint.
Dec 11 2018, 9:05 PM
patrickelectric requested review of D17512: libbfd: Update lib to 2.31.
Dec 11 2018, 9:03 PM
patrickelectric requested changes to D17106: Atelier Clazy-tidy.
Dec 11 2018, 7:37 PM · Atelier

Nov 26 2018

patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

@rjvbb I got it to work here ! Took some time to figure out the problems with relative paths and KConfig, I am working to bundle kcrash in a .dmg :)

Nov 26 2018, 11:50 PM · Plasma
patrickelectric accepted D17146: Private Static consts.
Nov 26 2018, 11:16 PM · Atelier: AtCore

Nov 25 2018

patrickelectric requested changes to D17146: Private Static consts.
Nov 25 2018, 4:38 PM · Atelier: AtCore

Nov 24 2018

patrickelectric accepted D17117: Prevent Canceled FileChooser from calling print.
Nov 24 2018, 8:36 PM · Atelier
patrickelectric accepted D17142: Further Improve asktoSave.
Nov 24 2018, 8:36 PM · Atelier
patrickelectric accepted D17116: Improve the UI for MainWindow::askToSave.
Nov 24 2018, 5:56 PM · Atelier
patrickelectric accepted D17101: Make atcore Clazy tidy.
Nov 24 2018, 3:50 PM · Atelier: AtCore
patrickelectric requested changes to D17117: Prevent Canceled FileChooser from calling print.
Nov 24 2018, 3:48 PM · Atelier
patrickelectric added inline comments to D17117: Prevent Canceled FileChooser from calling print.
Nov 24 2018, 12:03 AM · Atelier

Nov 23 2018

patrickelectric requested changes to D17101: Make atcore Clazy tidy.
Nov 23 2018, 9:51 AM · Atelier: AtCore
patrickelectric accepted D16976: Temperature Object Improvements.
Nov 23 2018, 9:48 AM · Atelier: AtCore
patrickelectric requested changes to D17117: Prevent Canceled FileChooser from calling print.
Nov 23 2018, 9:48 AM · Atelier

Nov 22 2018

patrickelectric committed R871:4210953618ee: Debugger: Add missing include (authored by patrickelectric).
Debugger: Add missing include
Nov 22 2018, 8:34 PM
patrickelectric added a reviewer for D4929: DrKonqi : lldb and Mac support: davidedmundson.
Nov 22 2018, 8:11 PM · Plasma
patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

a find_packge for KF5::WindowSystem is missing in the root CMakeLists file.

CMake Error at src/CMakeLists.txt:84 (add_executable):
  Target "drkonqi" links to target "KF5::WindowSystem" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Nov 22 2018, 8:02 PM · Plasma
patrickelectric committed R871:515425143cb3: debugger: DataLocation is deprecated, move to AppDataLocation (authored by patrickelectric).
debugger: DataLocation is deprecated, move to AppDataLocation
Nov 22 2018, 7:42 PM
patrickelectric closed D17024: debugger: DataLocation is deprecated, move to AppDataLocation.
Nov 22 2018, 7:42 PM · Plasma
patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

After taking a second look on it, I was able to merge the patch from the srcfolder and not from the repository root folder, weird..
Will do the tests here and now !

Nov 22 2018, 7:06 PM · Plasma
patrickelectric added inline comments to D17101: Make atcore Clazy tidy.
Nov 22 2018, 6:33 PM · Atelier: AtCore
patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

Can you rebase it over the last master branch ?

Nov 22 2018, 5:07 PM · Plasma
patrickelectric added a comment to D4929: DrKonqi : lldb and Mac support.

I agree, with your points.
About the mac compatibility, kcrash and drkonqi (It was merged yesterday) are already in KDE-mac brew repository, looking forward for this to be accepted !
I'll try to do some tests with your patch here today.

Nov 22 2018, 4:57 PM · Plasma
patrickelectric requested changes to D17101: Make atcore Clazy tidy.

A great patch, thank you for cleaning this stuff.

Nov 22 2018, 2:23 PM · Atelier: AtCore
D4929: DrKonqi : lldb and Mac support now requires changes to proceed.

What is the actual state of this patch ?

Nov 22 2018, 2:00 PM · Plasma

Nov 19 2018

patrickelectric added a reviewer for D17024: debugger: DataLocation is deprecated, move to AppDataLocation: mart.
Nov 19 2018, 5:56 PM · Plasma
patrickelectric updated the diff for D17024: debugger: DataLocation is deprecated, move to AppDataLocation.
  • debugger: Use c++11 for
Nov 19 2018, 5:49 PM · Plasma
patrickelectric updated the diff for D17024: debugger: DataLocation is deprecated, move to AppDataLocation.

Typo

Nov 19 2018, 5:46 PM · Plasma
patrickelectric requested review of D17024: debugger: DataLocation is deprecated, move to AppDataLocation.
Nov 19 2018, 5:43 PM · Plasma

Nov 18 2018

patrickelectric requested changes to D16976: Temperature Object Improvements.
Nov 18 2018, 2:28 PM · Atelier: AtCore
patrickelectric accepted D16855: Adjust formula for lateral area's icon size.
Nov 18 2018, 12:28 PM · Atelier: General Development
patrickelectric accepted D16853: Remove Unaccelerated &s from LateralArea button text.
Nov 18 2018, 12:19 PM · Atelier: General Development
patrickelectric accepted D16854: Set the parent of the newly created instance in Atelier::newAtCoreInstance.
Nov 18 2018, 12:19 PM · Atelier: General Development

Oct 23 2018

patrickelectric accepted D14136: [WIP]Basic SD Write Support.
Oct 23 2018, 1:40 PM · Atelier: AtCore
patrickelectric accepted D16200: Use SerialLayer()->pushCommand in only in processQueue.
Oct 23 2018, 1:37 PM · Atelier: AtCore

Oct 15 2018

patrickelectric accepted D16205: Cleanup warning replace deprecated call to serialLayer.
Oct 15 2018, 11:35 PM · Atelier: General Development
patrickelectric added a comment to D16206: Use AtCore::pushedCommand.

Why this is in a different review if needs D16199 ?

Oct 15 2018, 11:34 PM · Atelier: General Development
patrickelectric requested changes to D16200: Use SerialLayer()->pushCommand in only in processQueue.
Oct 15 2018, 11:33 PM · Atelier: AtCore
patrickelectric added a comment to D16199: Make SerialLayer completely private.

What is the logic behind this change ?

Oct 15 2018, 11:32 PM · Atelier: AtCore

Oct 14 2018

patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 14 2018, 1:35 PM

Oct 13 2018

patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 10:39 PM
patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 10:09 PM
patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 10:07 PM
patrickelectric added a comment to D16181: Move final terminator in firmware plugin side.

How do we send commands now before connected to a firmware?

There is a generic function when a plugin is not loaded.

M115 has to be sent before any firmware connection.

Yes, you can use the default function like I said before.

Oct 13 2018, 9:25 PM
patrickelectric updated the diff for D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 8:10 PM
patrickelectric added a comment to D16181: Move final terminator in firmware plugin side.

Can you please "fix" the other plugins with \r\n so this does not break them

Oct 13 2018, 7:25 PM
patrickelectric accepted D15858: Warning Roundup.
Oct 13 2018, 7:23 PM · Atelier: General Development
patrickelectric accepted D16002: QUrl.toString() is not a valid local file.
Oct 13 2018, 6:59 PM
patrickelectric requested changes to D14136: [WIP]Basic SD Write Support.
Oct 13 2018, 6:36 PM · Atelier: AtCore
patrickelectric requested changes to D15858: Warning Roundup.
Oct 13 2018, 6:23 PM · Atelier: General Development
patrickelectric accepted D15861: Warning Clean.
Oct 13 2018, 6:03 PM · Atelier: AtCore
patrickelectric requested review of D16181: Move final terminator in firmware plugin side.
Oct 13 2018, 5:53 PM
patrickelectric accepted D16180: Switch to C++11 scoped enums.

I'm ok with it.
Wait @tcanabrava and @rizzitello to review as well.

Oct 13 2018, 5:46 PM
patrickelectric added reviewers for D16180: Switch to C++11 scoped enums: rizzitello, tcanabrava.
Oct 13 2018, 5:45 PM

Oct 12 2018

patrickelectric updated subscribers of T9542: Atelier QML Interface - Discussion.
Oct 12 2018, 11:59 AM · Atelier, VDG
patrickelectric updated subscribers of T9542: Atelier QML Interface - Discussion.
Oct 12 2018, 11:42 AM · Atelier, VDG

Oct 10 2018

patrickelectric requested changes to D15858: Warning Roundup.
Oct 10 2018, 12:00 PM · Atelier: General Development
patrickelectric added inline comments to D15861: Warning Clean.
Oct 10 2018, 11:44 AM · Atelier: AtCore

Sep 30 2018

patrickelectric requested changes to D15861: Warning Clean.
Sep 30 2018, 3:55 PM · Atelier: AtCore

Sep 25 2018

patrickelectric accepted D15701: More Cleanup.
Sep 25 2018, 1:42 PM · Atelier: AtCore

Sep 23 2018

patrickelectric requested changes to D15701: More Cleanup.
Sep 23 2018, 1:09 AM · Atelier: AtCore
patrickelectric accepted D15700: Use bit percentage for fan speed.
Sep 23 2018, 12:24 AM · Atelier: AtCore

Sep 18 2018

patrickelectric accepted D15547: Add Connect for new Movement Widget.
Sep 18 2018, 2:27 PM · Atelier
patrickelectric accepted D15224: Allow for fractional Movement.
Sep 18 2018, 2:20 PM · Atelier: AtCore

Sep 10 2018

patrickelectric added inline comments to D15281: New AxisControl Widget.
Sep 10 2018, 3:01 PM · Atelier: AtCore
patrickelectric added inline comments to D15281: New AxisControl Widget.
Sep 10 2018, 2:45 PM · Atelier: AtCore

Sep 9 2018

patrickelectric added inline comments to D14136: [WIP]Basic SD Write Support.
Sep 9 2018, 5:44 PM · Atelier: AtCore
patrickelectric added inline comments to D14136: [WIP]Basic SD Write Support.
Sep 9 2018, 2:38 PM · Atelier: AtCore
patrickelectric added inline comments to D14136: [WIP]Basic SD Write Support.
Sep 9 2018, 2:36 PM · Atelier: AtCore
patrickelectric accepted D15281: New AxisControl Widget.

I think that need the unit showing in the textbox, like mm, cm, m.

Sep 9 2018, 1:28 AM · Atelier: AtCore
patrickelectric accepted D12456: Enable a notification system.
Sep 9 2018, 1:00 AM
patrickelectric requested changes to D15281: New AxisControl Widget.
Sep 9 2018, 12:58 AM · Atelier: AtCore
patrickelectric requested changes to D14136: [WIP]Basic SD Write Support.
Sep 9 2018, 12:54 AM · Atelier: AtCore

Sep 7 2018

patrickelectric accepted D15122: Check if file exists before print.
Sep 7 2018, 9:01 PM

Sep 5 2018

patrickelectric accepted D15280: Code Cleanup.
Sep 5 2018, 12:10 PM · Atelier: AtCore
patrickelectric added a comment to D15280: Code Cleanup.

int32_t

Sep 5 2018, 11:40 AM · Atelier: AtCore
patrickelectric requested changes to D15122: Check if file exists before print.
Sep 5 2018, 1:51 AM
patrickelectric requested changes to D15280: Code Cleanup.
Sep 5 2018, 12:44 AM · Atelier: AtCore

Sep 3 2018

patrickelectric edited projects for T9542: Atelier QML Interface - Discussion, added: Atelier; removed Atelier: AtCore.
Sep 3 2018, 3:15 PM · Atelier, VDG
patrickelectric edited projects for T9542: Atelier QML Interface - Discussion, added: Atelier: AtCore; removed Atelier.
Sep 3 2018, 3:15 PM · Atelier, VDG
patrickelectric added a comment to T9542: Atelier QML Interface - Discussion.

@abetts One of the most important things in a 3D printer are:

  • 4 Axis control
    • To control X, Y, Z, and E (the extruder, the guy that extrude plastic to create the 3D object)
    • The control need to be able to move with steps from 10cm to 0.01mm. (This values can change from printer to printer).
    • The extruder control should have a extruder multiplier that changes the extrusion quantity from 0.5x to 2x.
  • Temperature control
    • This sets the temperature in the extruder and the heated bed. The max values should be set by the user.
  • Command mode
    • The user should be able to send machine code to the printer, allowing some personalization.
    • This command code should output data from the printer and show to the user as well, like a normal terminal.
Sep 3 2018, 3:14 PM · Atelier, VDG

Sep 2 2018

patrickelectric added a comment to T9542: Atelier QML Interface - Discussion.

Hello Andres, Thank you for your first mockup.
But I would like to comment some points.

Sep 2 2018, 11:02 PM · Atelier, VDG
patrickelectric added inline comments to D15214: axiscontrol: Add spindle in text.
Sep 2 2018, 9:58 PM · Atelier: AtCore
patrickelectric updated the diff for D15214: axiscontrol: Add spindle in text.
  • WIP
Sep 2 2018, 9:44 PM · Atelier: AtCore
patrickelectric added a comment to D15224: Allow for fractional Movement.

If you want to put a scale, we should remove the intern circles and only let one xyz control without 0.1,1,10 buttons, only 1x.

This is a way to allow fractional movement on the pie controller. do u think i should just change the defaults to 0.1 1 10 and drop the scale completely ?

Sep 2 2018, 9:40 PM · Atelier: AtCore
patrickelectric added a comment to D15224: Allow for fractional Movement.

If you want to put a scale, we should remove the intern circles and only let one xyz control without 0.1,1,10 buttons, only 1x.

Sep 2 2018, 9:11 PM · Atelier: AtCore
patrickelectric added inline comments to D15214: axiscontrol: Add spindle in text.
Sep 2 2018, 1:51 PM · Atelier: AtCore