I talked with 4-5 people and they all said that giving real time feedback in the slider is useless and bad, so here's that, the feedback is given on mouse release, and every problem is automatically solved.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Aug 2 2019
Aug 1 2019
In D22316#505466, @ngraham wrote:With this change, if I press the volume up and volume down key on my keyboard, feedback only plays every second or third time I hit the button (depending on how fast I press it).
Jul 31 2019
Should it queue up a sound so that it plays one sound at the final volume when you've stopped dragging?
In D22316#503998, @filipf wrote:Removed VDG as the reviewer, seems like a technical issue all together.
Sorry
Jul 8 2019
Thanks @davidedmundson for the feedback,
I fixed what you suggested, but thinking about this again, the 50ms timer fixed the audio garbling but the sounds felt "too frequent", increasing the timer gave the same exact result as disabling the function altogether, so here's that.
It wasn't worth the extra complexity of the timer
I don't know why it is not showing the context of the patch 🤷♂️
I selected the plasma-pa project
Jul 6 2019
May 22 2019
Thanks everybody
May 20 2019
@aacid ping?
May 7 2019
@aacid I put myself in the kde dev script relicense thing, so please look at the patch without getting tainted
Apr 11 2019
In D20437#448397, @ngraham wrote:1000/60 yields a floating-point value. Is it acceptable that std::chrono::milliseconds can be a non-integer value?
Even more clear
Oh, and by the way, the _actual_ speed of the page is set by how far you move the mouse outside the viewport, that constant is a multiplicative factor, it really doesn't matter, it's only set to a nice value
As requested I explain what the "arbitrary constant" does
Well, before my patch the hardcoded constant was "100", (the time between each page update)
Now I put an universal constant there (16, as in milliseconds to create a 60fps animation), and moved the hardcoded constant elsewhere
In D20437#448163, @sander wrote:How did you determine the value of the damping variable? You write
With this patch this automatic scrolling goes at 60 fps instead of 10, I made it so that the speed of the scroll is the same.If somebody in the future changes the scroll speed, will you have to update your patch? Wouldn't it be better to have only one constant that determines the speed of both regular scrolling and automatic scrolling?
It's the first time after years and dozen of contributions to dozen of projects that I see such a fuss about my internet name
Apr 10 2019
Apr 6 2019
Apr 5 2019
In D16519#443979, @ngraham wrote:I had to do "Kezi Olio" to pass the commit filters which demand a two-part name, hope you don't mind.
In D16519#443932, @ngraham wrote:Works better for me too on my HP Spectre x360, and I couldn't find any regressions in behavior.
@kezik can you provide your full name and email address so we can land this patch with correct authorship information? Thanks!
Ping
Mar 24 2019
Hi, thanks for the feedback.
This is the correct fix for this issue, disregard the past patch
Nov 4 2018
hello?
Oct 30 2018
Waste less cpu cycles