Oct 18 2019
Oct 13 2019
I'm fixing the problem differently in D24609
Looks fine to me, thanks for the patch.
Feb 26 2019
I've sent a patch upstream with a more general approach: https://sourceforge.net/p/libpgf/patches/12/
Feb 24 2019
I don't think this should be a FreeBSD-specific check; even on other systems where the build is not currently broken we shouldn't be redefining nullptr anyway. I've sent a patch upstream with a more general approach: https://sourceforge.net/p/libpgf/patches/12/
Jan 4 2019
Jan 2 2019
Dec 30 2018
Maybe we could just get rid of the optional in this agent until we can switch to C++17 proper. I hate not having it, but it's just one or two occurrences here and probably not worth the magic to satisfy all compilers.
Jul 15 2018
I've finally posted a more comprehensive patch in D14146 -- so much time passed that I lost my original branch and did something similar in spirit :-)
Apr 29 2018
Feb 18 2018
I agree this can be abandoned -- whatever solution we agree upon should probably be done in plasma-desktop.
Feb 17 2018
This isn't just a problem on KDE Neon though, is it? I thought FreeBSD is also affected?
Per my previous comment, I still don't see how changing this to a target would solve anything.
Feb 14 2018
Feb 13 2018
Feb 12 2018
@kossebau's right: the problem lies in lookandfeeltool depending on kcm.cpp, while the kcoreaddons_desktop_to_json() call makes the kcm_lookandfeel target depend on the generation of the json file. It's pretty easy to reproduce this bug by running make lookandfeeltool_autogen with a fresh build directory.
Oct 6 2017
Sep 30 2017
FindGraphviz.cmake uses DOT as well for finding the version of GraphViz that is installed -- not that the current module or code supports checking hthat version, but it's there.
Sep 29 2017
Aug 8 2017
Jul 28 2017
Given the amount of commits to the repository in the past years I'm not sure you'll be able to review this patch. Perhaps someone with a KDE Multimedia hat?
Jun 3 2017
Apr 24 2017
Note that at least glibc defines strtod_l in stdlib.h, I think it's safer to include both stdlib.h for glibc and xlocale.h for OSX and the BSDs.
Mar 27 2017
Dec 29 2016
Isn't it better to use check_cxx_compiler_flag to see if the flag is supported and enable it in case it is?
Sep 10 2016
Aug 21 2016
Mar 29 2016
Looks great to me now; I'll leave it to Martin to accept the diff.
Mar 28 2016
Mar 25 2016
Looks good to me, but @cordlandwehr should probably take a look at this too.
The patch makes sense to me. Since QTGSTREAMER_INCLUDES already contains QTGSTREAMER_INCLUDE_DIR, you can probably remove the latter from include_directories().
Mar 23 2016
How about using the same calls present in Modules/memory/memory_fbsd.cpp (basically read the contents of the hw.physmem sysctl)?
Mar 17 2016
I've committed this to the 1.7 branch, with the required changes. Will you guys merge it to 5.0 or should I take care of it?