• Got rid of the signal+slot that emits KNewStuff changes since wallpaperComboBox is automagically updated.
• Reordered the command arguments so the variable is last in wallpaperplugin.knsrc.
• Put the plasmoids.knsrc and wallpaperplugin.knsrc filepaths on separate lines in the CMakeList.txt

Finally got around to updating this patch and formally testing with kdesrc-build (sort of) in Neon Unstable which has Frameworks 5.51.

I confirmed that contentItem()->childItems() did indeed send it to mainItem. It also sends it to the FrameSvgItem too. It no longer sends it to the mysterious ColorScope.

I noticed this in https://phabricator.kde.org/D12249#247452, but didn't realize that it was missing the code for loading the effects in the KCM like D15372 adds. Nice work on D15372!

Nice thinking on using repeater.count instead of the hardcoded 7!

The KPackage patch will end up in... Frameworks 5.51?
And the Plasma 5.14.0 release is set to depend on Frameworks... 5.45 (according to plasma-workspace's CMakeList.txt).
So we'll need to wait for the 5.14 tag to appear (Oct 4th), but to be safe, wait for the 5.14 release on Oct 9th.
Frameworks 5.51 is released Oct 13th, so it'll be easier to test after that (though I'll try to build kpackage with the patch and test it in a sec).
Alright, I'll set a reminder on Oct 17 (just after 5.14.1) to merge my 2 patches.

I tested the x: -main.x % 1 code.

Should the context menu also use this icon?

Thanks @apol for merging it. Thanks @ngraham for testing it and the link and @davidedmundson for explaining how bugfixes are merged.

Would the TextField.readOnly property be useful here?

No prob.

That would complicate shadow rendering code too much.

Would it be possible to draw rounded corners with the compositor as a Desktop Effect? All we need to do is translate a the shadow pixels ontop of the the client rect. Maybe making a few pixels semi transparent.

Remove unrelated brace formatting.

I guess apol's +1 = patch accepted? I'll merge it then.

Use connect(m_newStuffDialog.data(), ...) to support gcc 4.8.
Add license headers.

In D12040#257170, @mart wrote:

so, if the qpointer is used in a connect, it needs to have .data() to work on gcc 4.8.
if accessed normally, it doesn't need it

I use gcc --version 5.4.0, so I've no idea. I assume that is a QPointer feature though? We can always check the other DownloadDialog initializations:

Remove .data() since it seems to work without it.

Yeah, I can't figure out how to get it to recognize kwineffect.desktop, I'll submit another diff if I figure it out.

Doesn't work...

In D12041#247352, @abetts wrote:

Why not save the room on the right of the KCM and instead blur the actual image in the list? Move the controls closer to that list item? The arrangement looks off the way it shows in the screenshots.

I'm still unsure how to update the dropdown after you download a new plugin.

Move open GHNS window function from Wallpaper.Image to ShellPrivate.WallpaperPlugin

Change from Wallpaper.Image to the ShellPrivate.WallpaperPlugin

So you're proposing that folders show the Open With... entry, but omit the recently added additional entry that shows the first app?

• Open with "Sublime Text" / "Atom"
• Open with "K4DirStat"
• Open with "Clementine"

rather on the refactoring_timeline

Thanks for accepting it! I think I'll try having it preview a the text next. Need to replace the %s in the preview with the QTextEdit text.

Remove commented code.
Add " New " to button label.

Um, if (immutability() != Plasma::Types::SystemImmutable) { return; } was pushed.

Yep, D4751 was used instead.

Forgot to add reviewers.

I noticed you pruned kdeplasma-addons as well. Figured I'd list the other repos/widgets that still have these keys:

I remember having trouble binding to stuff in the ___Representation in the main.qml too, but don't remember the specifics. Why not just define it in the ColumnLayout { id: devicesView } since it's not really needed elsewhere. onlyOne: devicesView.simpleMode, visible: !devicesView.simpleMode.

Hmmm. So if there was 2 sinks (eg: 3.5mm jack + HDMI) and 1 mic (3.5mm jack) it'd show the sink header, but not the source header? Labelling all 3 as a sink?

In D10925#219849, @davidedmundson wrote:

Didn't test it, just double checked the whitespace.

Why not?

You forgot to add StreamRestoreTab.qml to review.

Forgot to add StreamRestoreTab.qml

Typo. You only have 1 "s" in persistent there.

I do have commit access.

No one approved it so I never merged it in time for the Plasma 5.12 beta. So I guess it'll have to wait for 5.12 to be released before I merge it into the master branch?

Is the onVolumeChange call delayed? I'm not sure if it's fired when we set it, or PulseAudio gets back to us.

Yes I do. Sorry I didn't get to push it yesterday. Thanks for approving the change!

one channel is 0%, second is 100% and merged volume now shows 100%

Support touchpad "mousewheel" which is pixel perfect based off plasma-pa's code.

Oh I see, "Commandeer revision" is in the "Add action..." dropdown, not the sidebar.

What are wallpaper plugins?

Would making these 2 new categories ("Plasma 5 Clocks" and "Plasma 5 Menus") subcategory to "Plasma 5 Widgets" work? What I mean is, would it list the menus and clocks in Plasma's "Download New Plasma Widgets" installer?

I don't think I can attach a new diff to your differential, so here's a link to it:

So you removed 2 units from the overall cell height, but only 1 unit from the frameloader height. This means you removed 1 unit from the "leftover" padding at the bottom of the frameloader, and are overlapping the cell below by another 1 unit.