I applied the patch to our openexr package instead.

In D25304#562561, @arojas wrote:

I don't see how that commit is related.
openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so

This is expected afaics.

No, it's not. That line in openexr is supposed to link libXXX-2_4.so (${verlibname}) to libXXX.so (${baselibname}) but it does so in the wrong dir

In D25304#562553, @arojas wrote:

This is a bug in openexr. It does actually try to install the unsuffixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem instead of doing so inside DESTDIR as it should. It is fixed in https://github.com/openexr/openexr/commit/4e54bde78f65c0fef8a9f794aaacea07813fba09

Note: openEXR >= 2.4 provides CMake configuration modules (OpenEXRConfig.cmake and IlmBaseConfig.cmake). We could also look for those and use the current code as a fallback if the modules can't be found

Also tested with CMake 3.1 which is the version required by Qt 5.12. It won't report the component, however.

Note: this is 2 different commits.

In T11933#207937, @jriddell wrote:

• New name for https://community.kde.org/Applications/19.12_Release_Notes
  
  How about https://community.kde.org/19.12_Release_Notes or https://community.kde.org/Releases/19.12_Release_Notes. I think I prefer the first

tested successfully locally. I don't see menus opening on the top left corner when running vlc or hp-systray.

LGTM

Another issue caused by the new CMake 3.5 dependency, some tests fail:

Thanks! tested successfully

In D24841#552577, @dfaure wrote:

Where did -std=gnu++14 come from? The old code above certainly didn't set it.

Maybe some projects were doing set(CMAKE_CXX_STANDARD 14) before including KDECompilerSettings? We could test the var here to avoid overwriting it...

I'm seeing build failures in several repositories seemingly caused by 6e3c794 (eg akonadi, kasync)

I can't test since I don't need these files.

Note: the metainfo file says this framework is tier 3.

Better commit message

Thanks

Tests needed :)

In D22143#526887, @rikmills wrote:

This is installing BOTH /etc/xdg/kactivities-stats.categories AND/usr/share/qlogging-categories5/kactivities-stats.categories which is surely wrong?

I'd do the opposite, remove DESCRIPTION and URL from knotification's CMakeLists.txt and only leave the PURPOSE line.

LGTM

@kossebau @vkrause @apol something else to change?

ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it should be fine.

This shall be compliant with the minimum ECM version set in the project.

+1 LGTM. Probably needs to be rebased

Unless someone has objections, I'll push this tomorrow.

use ${prefix} for the exec line.
For the others, it's a bit trickier since you can use either relative or
absolute paths when calling CMake.

fix path

Note: the ecm_generate_pkgconfig_file macro cannot be used since it doesn't support extra CFLAGS (yet)

LGTM

Good idea

KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS or even the binary installation dir.