Feed Advanced Search

Aug 8 2017

schwarzer committed R32:2a12ef8deb64: fix markup that breaks translations (authored by schwarzer).
fix markup that breaks translations
Aug 8 2017, 4:04 PM
schwarzer committed R32:1d3c5dbb37b9: fix non-breaking space surrounded by usual spaces (authored by schwarzer).
fix non-breaking space surrounded by usual spaces
Aug 8 2017, 4:04 PM
schwarzer committed R32:c9198b8fe2b6: fixuifiles (authored by schwarzer).
fixuifiles
Aug 8 2017, 3:59 PM
schwarzer committed R32:817e7c6d7f39: change layout of the Project configure dialog page (authored by schwarzer).
change layout of the Project configure dialog page
Aug 8 2017, 3:59 PM
schwarzer committed R32:89aad43e7b58: missing colon (authored by schwarzer).
missing colon
Aug 8 2017, 3:59 PM
schwarzer committed R32:e73bb6f011b1: typo (authored by schwarzer).
typo
Aug 8 2017, 3:27 PM
schwarzer committed R32:2803378a09ae: warnings-- (authored by schwarzer).
warnings--
Aug 8 2017, 3:26 PM
schwarzer committed R32:193e8936b439: fix former placeholder commit *coughs* (authored by schwarzer).
fix former placeholder commit *coughs*
Aug 8 2017, 3:26 PM
schwarzer committed R32:f0fcc03d2eda: typos and grammar fixes (authored by schwarzer).
typos and grammar fixes
Aug 8 2017, 3:26 PM
schwarzer committed R32:5c4c77cf36c0: mark placeholders so they are not extracted for translation (authored by schwarzer).
mark placeholders so they are not extracted for translation
Aug 8 2017, 3:26 PM
schwarzer committed R32:5304786bd40b: dashed git commands are deprecated (authored by schwarzer).
dashed git commands are deprecated
Aug 8 2017, 3:26 PM
schwarzer committed R32:4cd94906bfe4: global typo fix (authored by schwarzer).
global typo fix
Aug 8 2017, 3:23 PM
schwarzer committed R32:3d4070051b29: typo: ist -> is (authored by schwarzer).
typo: ist -> is
Aug 8 2017, 3:22 PM
schwarzer committed R32:92efec169e3c: typo: "information" has no plural (authored by schwarzer).
typo: "information" has no plural
Aug 8 2017, 3:22 PM
schwarzer committed R32:82e94be88944: hide placeholder strings from translators (authored by schwarzer).
hide placeholder strings from translators
Aug 8 2017, 3:19 PM
schwarzer committed R32:c6e8248c9693: remove placeholder texts from ui files (authored by schwarzer).
remove placeholder texts from ui files
Aug 8 2017, 3:19 PM
schwarzer committed R32:92af347ebcd8: typos (authored by schwarzer).
typos
Aug 8 2017, 3:14 PM
schwarzer committed R32:43cf5552e031: global typo (authored by schwarzer).
global typo
Aug 8 2017, 3:14 PM
schwarzer committed R32:1744c018cf95: typo singal -> signal (authored by schwarzer).
typo singal -> signal
Aug 8 2017, 3:13 PM
schwarzer committed R32:fdc853e12987: let me introduce: typo of the year "the the" (authored by schwarzer).
let me introduce: typo of the year "the the"
Aug 8 2017, 3:13 PM

Jun 23 2017

schwarzer accepted D5668: Fix the position of the initial popup message.

Sorry, forgot about this one. Thanks for taking action here. :)

Jun 23 2017, 6:19 AM

May 3 2017

schwarzer requested changes to D5668: Fix the position of the initial popup message.

As discussed on IRC, there will be some changes in a future revision...

May 3 2017, 4:39 PM
schwarzer added a comment to D5668: Fix the position of the initial popup message.

After reading https://medium.com/genymobile/how-c-lambda-expressions-can-improve-your-qt-code-8cd524f4ed9f I get the impression that capturing this is common practice.

May 3 2017, 3:57 PM
schwarzer added a comment to D5668: Fix the position of the initial popup message.

OK. :D
I am not very familiar with labdas either and was just wondering. It works well here with =, & and this but I do not know the best practices in this case.

May 3 2017, 3:20 PM
schwarzer added a comment to D5668: Fix the position of the initial popup message.

Just out of curiosity. Why do you pass by value?

May 3 2017, 3:11 PM
schwarzer accepted D5668: Fix the position of the initial popup message.

Although I do not like those "just delay it a bit and it will work" solutions that much, I also think it's a valid workaround here. :)

May 3 2017, 3:01 PM

Apr 25 2017

schwarzer added a comment to D5571: Port statusbar to QStatusBar.

I don't know of any advantage/disadvantage... I can convert it to pointers if you want. Just an example I had was with objects and the code is one line shorter...

Apr 25 2017, 1:27 PM

Apr 24 2017

schwarzer added a comment to D5571: Port statusbar to QStatusBar.

Thanks, looks good to me.
Just curious. Is there (dis)advantages of using the QLabel as pointer vs. value here? I see is used as pointer in other games and used it like that as well.

Apr 24 2017, 5:54 PM
schwarzer added inline comments to D5571: Port statusbar to QStatusBar.
Apr 24 2017, 5:39 PM

Apr 19 2017

schwarzer committed R397:e24d189776cb: Use midRef() for efficiency reasons (authored by schwarzer).
Use midRef() for efficiency reasons
Apr 19 2017, 1:23 PM

Sep 10 2016

schwarzer committed R172:a0ba92a130d6: fix translation hint (authored by schwarzer).
fix translation hint
Sep 10 2016, 6:39 AM
schwarzer committed R173:a0ba92a130d6: fix translation hint (authored by schwarzer).
fix translation hint
Sep 10 2016, 6:33 AM
schwarzer committed R172:70eeef7c6e39: global typo fix (authored by schwarzer).
global typo fix
Sep 10 2016, 6:18 AM
schwarzer committed R172:a6bfe3cfd541: typo (authored by schwarzer).
typo
Sep 10 2016, 6:17 AM
schwarzer committed R172:2abb4ef6eba4: typo: "information" has no plural (authored by schwarzer).
typo: "information" has no plural
Sep 10 2016, 6:17 AM
schwarzer committed R172:fe722290c90c: hide placeholder strings from translators (authored by schwarzer).
hide placeholder strings from translators
Sep 10 2016, 6:16 AM
schwarzer committed R172:54042374716c: remove placeholder texts from ui files (authored by schwarzer).
remove placeholder texts from ui files
Sep 10 2016, 6:16 AM
schwarzer committed R172:1bb70f0a3d57: typo (missing full stop) (authored by schwarzer).
typo (missing full stop)
Sep 10 2016, 6:15 AM
schwarzer committed R172:c99b5b4fc460: typo (authored by schwarzer).
typo
Sep 10 2016, 6:15 AM
schwarzer committed R172:a92aed78d0fa: global typo (authored by schwarzer).
global typo
Sep 10 2016, 6:14 AM
schwarzer committed R172:1b2fd8f672cc: typos (authored by schwarzer).
typos
Sep 10 2016, 6:14 AM
schwarzer committed R172:fd12bb09ec7a: let me introduce: typo of the year "the the" (authored by schwarzer).
let me introduce: typo of the year "the the"
Sep 10 2016, 6:14 AM
schwarzer committed R108:6f33411bf447: String casing fixes. (authored by schwarzer).
String casing fixes.
Sep 10 2016, 6:14 AM
schwarzer committed R108:974d5cf98c61: Replace exclamation marks. (authored by schwarzer).
Replace exclamation marks.
Sep 10 2016, 6:11 AM
schwarzer committed R172:553b4cdb5e45: typo (authored by schwarzer).
typo
Sep 10 2016, 6:10 AM
schwarzer committed R173:70eeef7c6e39: global typo fix (authored by schwarzer).
global typo fix
Sep 10 2016, 6:08 AM
schwarzer committed R173:a6bfe3cfd541: typo (authored by schwarzer).
typo
Sep 10 2016, 6:07 AM
schwarzer committed R173:2abb4ef6eba4: typo: "information" has no plural (authored by schwarzer).
typo: "information" has no plural
Sep 10 2016, 6:07 AM
schwarzer committed R173:fe722290c90c: hide placeholder strings from translators (authored by schwarzer).
hide placeholder strings from translators
Sep 10 2016, 6:06 AM
schwarzer committed R173:54042374716c: remove placeholder texts from ui files (authored by schwarzer).
remove placeholder texts from ui files
Sep 10 2016, 6:06 AM
schwarzer committed R173:1bb70f0a3d57: typo (missing full stop) (authored by schwarzer).
typo (missing full stop)
Sep 10 2016, 6:05 AM
schwarzer committed R173:c99b5b4fc460: typo (authored by schwarzer).
typo
Sep 10 2016, 6:05 AM
schwarzer committed R173:1b2fd8f672cc: typos (authored by schwarzer).
typos
Sep 10 2016, 6:04 AM
schwarzer committed R173:a92aed78d0fa: global typo (authored by schwarzer).
global typo
Sep 10 2016, 6:04 AM
schwarzer committed R173:fd12bb09ec7a: let me introduce: typo of the year "the the" (authored by schwarzer).
let me introduce: typo of the year "the the"
Sep 10 2016, 6:04 AM
schwarzer committed R108:7f243a75c4dc: remove full stop: non of the other kcm comments has one (authored by schwarzer).
remove full stop: non of the other kcm comments has one
Sep 10 2016, 6:00 AM
schwarzer committed R173:553b4cdb5e45: typo (authored by schwarzer).
typo
Sep 10 2016, 6:00 AM
schwarzer committed R108:e69826ab5383: global typo fix (authored by schwarzer).
global typo fix
Sep 10 2016, 5:47 AM
schwarzer committed R108:206bb6f55b3f: Merge branch 'typos' (authored by schwarzer).
Merge branch 'typos'
Sep 10 2016, 5:44 AM
schwarzer committed R106:f661d893fda5: typos (authored by schwarzer).
typos
Sep 10 2016, 3:23 AM

Jun 9 2016

schwarzer committed R81:8da9e0e3977a: Typo. (authored by schwarzer).
Typo.
Jun 9 2016, 9:40 PM
schwarzer committed R7:ea3acd522d15: Fix typo. (authored by schwarzer).
Fix typo.
Jun 9 2016, 8:51 PM

May 18 2016

schwarzer committed R167:0a6167aa8746: Fix HTML markup and one style issue: It's -> It is (authored by schwarzer).
Fix HTML markup and one style issue: It's -> It is
May 18 2016, 5:39 PM

Apr 28 2016

schwarzer committed R60:f42c3c471b44: Fix message: missing space. (authored by schwarzer).
Fix message: missing space.
Apr 28 2016, 7:57 PM

Apr 26 2016

schwarzer closed D1471: Change wording of Directory to Folder for user-visible strings.

I think it's a good idea to folow the kdelibs coding guidelines closely. You are not kdelibs however, so you can define your own rules.

Apr 26 2016, 9:34 AM · Krusader

Apr 25 2016

schwarzer committed R167:9bf786361813: Change wording of Directory to Folder for user-visible strings. (authored by schwarzer).
Change wording of Directory to Folder for user-visible strings.
Apr 25 2016, 10:32 PM
schwarzer added a comment to D1471: Change wording of Directory to Folder for user-visible strings.

BTW: GCC6 warns about misleading "if" indentation in:
krusader/VFS/virtualcopyjob.cpp:261
krusader/DiskUsage/diskusage.cpp:330
and
krusader/DiskUsage/diskusage.cpp:710

Apr 25 2016, 10:31 PM · Krusader
schwarzer added a comment to D1471: Change wording of Directory to Folder for user-visible strings.

Not sure what you mean by "fix".
Usually translators (me included) fix their translations and then on your next release you fetch those translations.

Apr 25 2016, 10:20 PM · Krusader
schwarzer committed R167:2971015a5135: Fix build. (authored by schwarzer).
Fix build.
Apr 25 2016, 10:03 PM
schwarzer closed D1470: Fix build on my machine.

Committed.

Apr 25 2016, 10:03 PM · Krusader
schwarzer committed R136:f9182e662454: Initialize member. (authored by schwarzer).
Initialize member.
Apr 25 2016, 4:50 PM
schwarzer committed R136:50b5d85e592f: Fix wording. (authored by schwarzer).
Fix wording.
Apr 25 2016, 4:45 PM

Apr 24 2016

schwarzer committed R167:75387bcb6cca: Silence CMake warning CMP0063. (authored by schwarzer).
Silence CMake warning CMP0063.
Apr 24 2016, 11:20 AM
schwarzer added a reviewer for D1471: Change wording of Directory to Folder for user-visible strings: martinkostolny.
Apr 24 2016, 11:19 AM · Krusader
schwarzer added a reviewer for D1470: Fix build on my machine: martinkostolny.
Apr 24 2016, 11:19 AM · Krusader
schwarzer closed D1472: Silence CMake warning CMP0063.

Committed.

Apr 24 2016, 11:18 AM · Krusader

Apr 23 2016

schwarzer retitled D1472: Silence CMake warning CMP0063 from to Silence CMake warning CMP0063.
Apr 23 2016, 7:49 PM · Krusader
schwarzer retitled D1471: Change wording of Directory to Folder for user-visible strings from to Change wording of Directory to Folder for user-visible strings.
Apr 23 2016, 7:10 PM · Krusader
schwarzer retitled D1470: Fix build on my machine from to Fix build on my machine.
Apr 23 2016, 7:06 PM · Krusader

Apr 13 2016

schwarzer added a comment to T2232: Add mailing list address to Names of Translators.

Da würde ich den opensuse-Weg gehen.

Apr 13 2016, 6:44 PM

Apr 12 2016

schwarzer added a comment to T2232: Add mailing list address to Names of Translators.

Was wollen wir denn als Namen hinschreiben?
"Deutsche Übersetzer"?
"Deutsche Übersetzer-Mailingliste"?

Apr 12 2016, 11:53 PM
schwarzer created T2232: Add mailing list address to Names of Translators.
Apr 12 2016, 8:59 PM

Apr 10 2016

schwarzer committed R45:6f56fe2c026b: Remove wrong unit. formatByteSize() returns the right one. (authored by schwarzer).
Remove wrong unit. formatByteSize() returns the right one.
Apr 10 2016, 6:11 PM