Added item as a proxy for the devices and applications. This fixed the vertical binding loop.
And made scrollbar touch the top and botoom edges.

Don't see anyone objecting, will commit later.

Accidental patch

Can't have everything. now will cut line again.

Categories touch top and bottom.
Removed 1 unnecessary line.

style restore

Added all the related planned changes.

Will add more related changes here.

Today for 5.18.2 or can wait?
Apol only looked the code for the first change.
And I don't know why vertical margins create bind loop(Solved), or if Item as a proxy is good(found it in others areas too).

I would not call them stylistic choice, the position didn't change. And there are included in description.

Make Header always fit inside the scrollview area.

In D27577#616579, @ngraham wrote:

The changes to labels in Header.qml seem unrelated.

typo

Make scrollbars touch the side of the frame.
Fit speaker test grid inside the scrollview area.
Fix advanced content layout.
Make Header always fit inside the scrollview area.

Changed comment.

Hmm, I don't see that with everything from git master. :/

Wrong alarm, works fine after updating everything. I didn't expect couple days to cause this, sorry.

Fix problem 3

Logged with my main user, and panel does not respond
file:///code/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/ToolTipInstance.qml:115:13: QML Heading: Binding loop detected for property "width"
Without fillWidth in headings, works but with massive bind loops.

I logged with my main account and I get lots of
file:///code/kde/usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderItemDelegate.qml:306:17: QML Label: Binding loop detected for property "width"

After some digging, I found that KBookmarkGroup has more items that the KFilePlacesModel.
It is impossible to make KBookmark move at the end of a BookmarkGroup, if the item is not in the KFilePlacesModel.
I don't see a better solution than the current revision of the patch. (Assuming that my proposed change of using null as first item is acceptable.)

In D26944#614407, @niccolove wrote:

Did this message get centered on another patch, or is it still on the left?

I don't believe so.
https://phabricator.kde.org/source/kdeconnect-kde/history/master/plasmoid/package/contents/ui/

In D27083#614285, @ngraham wrote:

So the test needs to be fixed?

I'm seeing some weird jagginess on radio buttons, slider handles, and combobox shadows:

I cannot replicate this. And I cannot see how I could have created this. Or where to start.

The 2 removed lines were leftovers from 54e87fe879ba.

In D27316#613771, @davidedmundson wrote:

I don't know

You can find

./qml/QtGraphicalEffects/private/DropShadowBase.qml

somewhere in /usr on your local system,

add in some
console.log lines and see what's happening.

The problem is with controls, not with label. QtQuick controls work fine.

Kirigami units.
Remove unnecessary preferred width.

Although this is a general problem, just to be clear. Without Plasma Components I don't get proper scaling.

It was more of a general question...

I use arch's Qt 5.14.1
Any chance I only have this problem? My build is not exactly stable.

Also, why is only PC2 affected?

Just checked again, apparently made a mistake. All the labels are affected.

More style fixes. (indentation restore)

Should I close this patch then?
The only place I've seen this problem is in tests.
I don't know if there is any place that is affected.

I see, so paintedHeight is not exactly perfect above.

Can I close this patch?

Is there any problem with this patch?

@davidedmundson ping

Thanks Nate, both for explaining and taking care of the patches yesterday.

The worst problem I could found, by ignoring the margins.
Theme "Underworld".

1 picture, 1 problem, 2 issues.

TODO from the last update.
Improved comments.
Removed fill anchor from listview.

Rebase

Added comment.

Changes:
Removed some parts that were split into separate patches.
Reintroduce background.
Moved highlight in ListItem.
Removed heading and moved separator in ListItem.

Style

Restore imports.

Remove PlasmaComponents.

avoid i18n puzzles

Remove double space.

Remove unnecessary anchors.

Use PC3 and remove unused imports.

Update Layout

before

...it solves the reporter's problem...

Not exactly. When an available port gets selected(or is active) port option will disappear again. Only enables complete port selection while an unavailable is the default.

If default button can leave, personally I would prefer this layout (ignore the margins).

The network applet can also have "Enable mobile network" (icon network-mobile-on/off). All these 3 buttons are only visible when an applicable device exist.

No need to worry. The flip of the toolbar is was a small proportion of the patch, most of the time I try to solve other problems. And in the end of the line was a team decision.