Feed Advanced Search

May 16 2018

apol committed R224:8dba3898e5a7: Move the dummy conversation model to c++ (authored by apol).
Move the dummy conversation model to c++
May 16 2018, 1:45 AM

May 15 2018

apol committed R134:def520342461: PackageKit: Try harder to find the application desktop file (authored by apol).
PackageKit: Try harder to find the application desktop file
May 15 2018, 11:27 PM
apol added inline comments to D12896: Add Telegram plugin.
May 15 2018, 10:56 PM · Frameworks
apol committed R134:d9d711ff42a6: Snap: make it possible to launch installed applications (authored by apol).
Snap: make it possible to launch installed applications
May 15 2018, 5:18 PM
apol added inline comments to D12896: Add Telegram plugin.
May 15 2018, 4:54 PM · Frameworks
apol committed R134:6ee190414604: Fix crash (authored by apol).
Fix crash
May 15 2018, 3:49 PM
apol added a comment to T8707: Window borders.

+1, I do believe the margins as they are nowadays they are ugly and look unpolished. I personally always remove them when setting up my system.

May 15 2018, 2:06 PM · VDG
apol committed R256:68e44d091df4: Update to KF 5.46.0 (authored by apol).
Update to KF 5.46.0
May 15 2018, 1:57 PM
apol committed R257:f6ecadb05357: Merge branch 'qt5.9lts' (authored by apol).
Merge branch 'qt5.9lts'
May 15 2018, 1:55 PM
apol committed R257:40e97c2efc4a: Update to KF 5.46.0 (authored by apol).
Update to KF 5.46.0
May 15 2018, 1:54 PM
apol accepted D12887: Fix a compilation warning.
May 15 2018, 1:41 PM · KDE Edu

May 14 2018

apol added a comment to T8637: [Junior Job] Open on remote device.

You don't need to touch the SharePlugin, just create a desktop file that specifies the mimetype required that will call "kdeconnect-handler".

May 14 2018, 11:58 PM · Junior Jobs, KDE Connect
apol updated the summary of D12881: Migrate to Oreo and drop support for APIs < 16.
May 14 2018, 11:53 PM · KDE Connect
apol requested review of D12884: Remove the internal file navigation from the global drawer.
May 14 2018, 11:48 PM · Okular
apol committed R223:5931c0de8dd7: Don't pretend to translate "Okular" as an application name (authored by apol).
Don't pretend to translate "Okular" as an application name
May 14 2018, 11:37 PM
apol requested review of D12883: Adopt a more reasonable approach for passing the file to purpose.
May 14 2018, 11:31 PM · Spectacle
apol committed R495:46011e38a1bb: kdeconnect: Notify when the process fails to start (authored by apol).
kdeconnect: Notify when the process fails to start
May 14 2018, 11:16 PM
apol committed R240:73f8256b0deb: Android: fix typo (authored by apol).
Android: fix typo
May 14 2018, 10:14 PM
apol committed R240:98ecb149f595: Android: Don't define qml-import-paths if it's empty (authored by apol).
Android: Don't define qml-import-paths if it's empty
May 14 2018, 8:47 PM
apol committed R134:2eafbe243c1b: Display the transaction speed in the ProgressView (authored by apol).
Display the transaction speed in the ProgressView
May 14 2018, 2:56 PM
apol added a comment to D12870: [SourcesModel] Check changed file name before reloading configuration.

It doesn't look like other files are being added to the KDirWatch, no?

May 14 2018, 12:15 PM · Plasma
apol abandoned D12822: Added null check in OverlayDrawer.
May 14 2018, 10:58 AM · Kirigami
apol commandeered D12822: Added null check in OverlayDrawer.
May 14 2018, 10:58 AM · Kirigami
apol requested changes to D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon.

Looks good to me, please fix the comment Kay mentioned so we can land the change.

May 14 2018, 10:57 AM · Plasma

May 13 2018

apol committed R857:d3e46d6bbe87: Android: kdegraphics-mobipocket builds now (authored by apol).
Android: kdegraphics-mobipocket builds now
May 13 2018, 5:45 PM
apol committed R857:ed0e15973a54: Use the right API for iterating a directory (authored by apol).
Use the right API for iterating a directory
May 13 2018, 5:45 PM
apol closed D12850: Use the right API for iterating a directory.
May 13 2018, 5:45 PM
apol committed R223:ad09cfdcf127: Kirigami: Properly reuse the page when scrolling back (authored by apol).
Kirigami: Properly reuse the page when scrolling back
May 13 2018, 5:45 PM
apol committed R223:9cafd504c0b7: Kirigami: Asynchronous request of pixmaps (authored by apol).
Kirigami: Asynchronous request of pixmaps
May 13 2018, 5:45 PM
apol committed R223:ac53737242f6: Remove dup'ed comment (authored by apol).
Remove dup'ed comment
May 13 2018, 5:45 PM
apol committed R223:1a170e81df1a: Kirigami: set request's normalized rect (authored by apol).
Kirigami: set request's normalized rect
May 13 2018, 5:45 PM
apol committed R223:c92397da88b6: Kirigami: Don't try to render if the item is empty (authored by apol).
Kirigami: Don't try to render if the item is empty
May 13 2018, 5:45 PM
apol updated the diff for D12850: Use the right API for iterating a directory.

actually fix execution

May 13 2018, 11:35 AM
apol committed R499:4af23c281fa3: Itinerary depends on prison (authored by apol).
Itinerary depends on prison
May 13 2018, 11:34 AM
apol requested review of D12850: Use the right API for iterating a directory.
May 13 2018, 11:19 AM
apol added a reverting change for R857:d178bf051ee0: Use the right API for iterating a directory: R857:c49a989ae526: Revert "Use the right API for iterating a directory".
May 13 2018, 11:15 AM
apol committed R857:c49a989ae526: Revert "Use the right API for iterating a directory" (authored by apol).
Revert "Use the right API for iterating a directory"
May 13 2018, 11:15 AM
apol committed R857:d178bf051ee0: Use the right API for iterating a directory (authored by apol).
Use the right API for iterating a directory
May 13 2018, 9:13 AM

May 12 2018

apol added a comment to D12823: Workaround for binding loop in Material Theme.

I've seen this warning, never seen it crash.

May 12 2018, 11:25 AM · Kirigami
apol added a comment to D12822: Added null check in OverlayDrawer.

Already done in https://phabricator.kde.org/D12741.

May 12 2018, 11:21 AM · Kirigami

May 11 2018

apol accepted D12812: Enable desktop2desktop keyboard input.
May 11 2018, 11:29 PM · KDE Connect
apol committed R223:cf4bb5e3b178: Android: Make it possible to associate with files (authored by apol).
Android: Make it possible to associate with files
May 11 2018, 5:28 PM
apol closed D12770: Android: Make it possible to associate with files.
May 11 2018, 5:28 PM · Okular

May 10 2018

apol committed R1007:df7e1b36aa6b: Include .arcconfig file (authored by apol).
Include .arcconfig file
May 10 2018, 11:15 PM
apol added a comment to T7862: `sudo` command takes forever.

Adding 127.0.0.1 localhost.localdomain does the trick.

May 10 2018, 10:35 PM · Plasma: Mobile
apol added a comment to T7862: `sudo` command takes forever.
May 10 2018, 10:29 PM · Plasma: Mobile
apol requested changes to D12811: Update to display the name of the session in the "Delete Session" confirmation dialogue box.
May 10 2018, 7:17 PM · KDevelop
apol committed R1003:687ade380b75: KCalCore isn't a dependency on Android (authored by apol).
KCalCore isn't a dependency on Android
May 10 2018, 6:45 PM
apol committed R993:6a2d14d8cc1e: Add missing coma (authored by apol).
Add missing coma
May 10 2018, 5:58 PM
apol accepted D12810: Do not require Frameworks 5.45.
May 10 2018, 5:06 PM · KDE Connect
apol committed R134:f2d87ea7f3fb: Fix crash when rendering a delegate that extends an unexisting component (authored by apol).
Fix crash when rendering a delegate that extends an unexisting component
May 10 2018, 2:16 PM
apol added a comment to D12793: Reenable navigation inside QtDocumentation.

LGTM. If that's what it takes...

May 10 2018, 1:54 PM · KDevelop
apol committed R857:a04a21cc8557: Android: Include skip file in docker images (authored by apol).
Android: Include skip file in docker images
May 10 2018, 1:48 PM
apol committed R857:bfafcea68341: Android: forgot to add file (authored by apol).
Android: forgot to add file
May 10 2018, 1:47 PM

May 9 2018

apol committed R857:40d53cc2d8a3: Android: Also build EXTRA_PKGS (authored by apol).
Android: Also build EXTRA_PKGS
May 9 2018, 11:00 PM
apol committed R993:ea779d5dd89a: Android: Include itinerary app builds (authored by apol).
Android: Include itinerary app builds
May 9 2018, 6:47 PM
apol committed R857:b9fbc9f265eb: Android: Don't build kcalcore for now (authored by apol).
Android: Don't build kcalcore for now
May 9 2018, 6:46 PM
apol committed R499:7127249d5c0e: Include itinerary dependency information (authored by apol).
Include itinerary dependency information
May 9 2018, 6:29 PM
apol committed R857:07764b4b341a: Android: fix some skipping logic (authored by apol).
Android: fix some skipping logic
May 9 2018, 6:26 PM
apol committed R857:823bffe454ee: Android: write an error if the application name couldn't be inferred (authored by apol).
Android: write an error if the application name couldn't be inferred
May 9 2018, 6:26 PM
apol committed R857:ee2622eb236e: Android: Make it possible to pass arguments to the poppler build (authored by apol).
Android: Make it possible to pass arguments to the poppler build
May 9 2018, 6:26 PM
apol committed R857:ceb56016877f: Android: make sure we don't report the same target twice (authored by apol).
Android: make sure we don't report the same target twice
May 9 2018, 4:23 PM
apol committed R857:45e46fc34849: Android: make it a bit easier to skip modules (authored by apol).
Android: make it a bit easier to skip modules
May 9 2018, 4:23 PM
apol committed R256:cfbea1097a8e: Update to new libical (authored by apol).
Update to new libical
May 9 2018, 3:43 PM
apol committed R134:23d5949390ac: Merge branch 'Plasma/5.12' (authored by apol).
Merge branch 'Plasma/5.12'
May 9 2018, 10:26 AM
apol accepted D12765: Use a more intuitive, user-friendly name for Samba share access.
May 9 2018, 10:10 AM
apol added a comment to D9794: Provide access to data returned by helper even on error replies.

What are you trying to fix?
Why isn't the error text enough?

May 9 2018, 10:09 AM · Frameworks
apol requested review of D12770: Android: Make it possible to associate with files.
May 9 2018, 1:14 AM · Okular

May 8 2018

apol committed R223:90f187e3602a: QtQuick: schedule a texture render when the window changes (authored by apol).
QtQuick: schedule a texture render when the window changes
May 8 2018, 3:59 PM
apol committed R223:a082ace479c2: QtQuick: simplify PageItem (authored by apol).
QtQuick: simplify PageItem
May 8 2018, 3:59 PM
apol committed R223:970e0f2ba9cb: QtQuick: simplify drawing code (authored by apol).
QtQuick: simplify drawing code
May 8 2018, 3:59 PM
apol added a comment to D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays.

Shouldn't we be using a color from the palette/color scheme?

May 8 2018, 3:06 PM · Frameworks
apol committed R169:242b58bfbed8: Fix warnings (authored by apol).
Fix warnings
May 8 2018, 2:34 PM
apol closed D12741: Fix warnings.
May 8 2018, 2:34 PM · Kirigami
apol committed R169:dd45e3328845: Remove wrong warning (authored by apol).
Remove wrong warning
May 8 2018, 2:34 PM
apol closed D12742: Remove wrong warning.
May 8 2018, 2:34 PM · Kirigami
apol abandoned D7182: Load Portals integration as a QPT rather than a QPA.
May 8 2018, 2:32 PM
apol committed R134:5d6593633f02: Don't try to guess the url location (authored by apol).
Don't try to guess the url location
May 8 2018, 1:53 PM
apol committed R256:5bbbc47f6da4: Use https by default for the repository (authored by apol).
Use https by default for the repository
May 8 2018, 1:42 PM
apol placed T2844: neonify KDE Config Driver Manager up for grabs.
May 8 2018, 1:12 PM · Neon
apol accepted D12672: Use a target in FindDiscount (modern cmake) rather than variables.

It's actually fixing the build when discount is in its own prefix.

May 8 2018, 1:28 AM · Okular

May 7 2018

apol committed R32:d352dc68e47f: shell: Display generic project managers again (authored by mschwarz).
shell: Display generic project managers again
May 7 2018, 11:08 PM
apol added a comment to R32:ab2fcd3b2789: shell: Display generic project managers again.

Done

May 7 2018, 11:04 PM
apol accepted D11891: Fix crashes in NotifyByAudio when closing applications.
May 7 2018, 10:51 PM · Frameworks
apol added a comment to D12700: Fix blur on Wayland when scaling is used.

@apol what config do you use?
single monitor?
2x scaling?
wayland?
have you tried relogging or restarting?
did you use "arc patch D12700" to apply the 2 dependent revisions too?
any specific steps or unique setup to reproduce this?

May 7 2018, 8:20 PM · KWin
apol added a comment to D12700: Fix blur on Wayland when scaling is used.

I just tested this, it definitely looks like a step forward but I'm afraid it's not everything that is needed.

May 7 2018, 5:48 PM · KWin
apol committed R134:eae21be8b202: Fix warning (authored by apol).
Fix warning
May 7 2018, 4:43 PM
apol committed R134:0aca22d85f8f: Fix status of flatpak transactions (authored by apol).
Fix status of flatpak transactions
May 7 2018, 4:27 PM
apol committed R134:f5ad3ff0ce40: Hide launch button while uninstalling (authored by apol).
Hide launch button while uninstalling
May 7 2018, 4:21 PM
apol added a comment to T8637: [Junior Job] Open on remote device.

Sure, it's a matter of installing the right desktop file.

May 7 2018, 4:08 PM · Junior Jobs, KDE Connect
apol committed R134:b4ee04e89df4: Fix filtering (authored by apol).
Fix filtering
May 7 2018, 3:53 PM
apol requested review of D12742: Remove wrong warning.
May 7 2018, 3:39 PM · Kirigami
apol requested review of D12741: Fix warnings.
May 7 2018, 3:35 PM · Kirigami
apol committed R134:d9619d9256ac: Don't take a stock icon for good if it wasn't found (authored by apol).
Don't take a stock icon for good if it wasn't found
May 7 2018, 3:17 PM
apol added a comment to D4140: Rework playing of volume feedback.

Could we maybe accept this?

May 7 2018, 1:46 PM · Plasma
apol committed R169:a65e4da24804: Don't allow showing/hiding the drawer when there's no handle (authored by apol).
Don't allow showing/hiding the drawer when there's no handle
May 7 2018, 11:27 AM
apol closed D12699: Don't allow showing/hiding the drawer when there's no handle.
May 7 2018, 11:27 AM · Kirigami

May 4 2018

apol requested review of D12699: Don't allow showing/hiding the drawer when there's no handle.
May 4 2018, 6:09 PM · Kirigami
apol committed R2:38f1204d5f29: Add OARS tags to the appdata (authored by nickrichards).
Add OARS tags to the appdata
May 4 2018, 5:46 PM
apol closed D12688: Add OARS tags to the appdata.
May 4 2018, 5:46 PM · GCompris, KDE Edu