Feed Advanced Search

Jan 14 2018

apol added a comment to D9868: Rename Discover's "Home" page to "Featured".

Why "Apps"?
How about we change it to "Discover" instead of "Home"?

Jan 14 2018, 8:08 PM · Plasma

Jan 13 2018

apol accepted D9858: dont crash when cancelling process.

Note process doesn't need to be captured there. Possibly a nicer fix would be to call waitForFinished on our side, but for now this is fine.

Jan 13 2018, 9:54 PM
apol accepted D9842: Fix FileChooser portal to be able be opened using show() method.
Jan 13 2018, 9:46 PM
apol accepted D9861: Use ellipsis on "Add Source" menu item because it opens a dialog.
Jan 13 2018, 9:45 PM · Plasma
apol committed R134:b28a0756773a: Align Installed title with the delegates (authored by apol).
Align Installed title with the delegates
Jan 13 2018, 7:27 PM
apol committed R134:58a7163139a1: Use the title for the resource name to display if available (authored by apol).
Use the title for the resource name to display if available
Jan 13 2018, 7:27 PM
apol committed R134:d77aa98c31fd: Snap doesn't support filter by extensions (authored by apol).
Snap doesn't support filter by extensions
Jan 13 2018, 7:27 PM
apol committed R134:7bef4c75352e: Improve displayed size (authored by apol).
Improve displayed size
Jan 13 2018, 7:27 PM
apol added a comment to D9842: Fix FileChooser portal to be able be opened using show() method.

Well there must be a better way to test it works at all besides deploying it to our users...

Jan 13 2018, 1:40 AM
apol added a comment to D9816: Ensure DesktopIcon paints with the correct aspect ratio.

You are my hero. Awesome

When you have a really long or wide image will it be croped?

Jan 13 2018, 12:48 AM · Kirigami
apol accepted D9845: Fix source actions in the configuration.
Jan 13 2018, 12:47 AM · Plasma

Jan 12 2018

apol committed R134:8fa12511f078: Adapt to changes in newly released PkQt (authored by apol).
Adapt to changes in newly released PkQt
Jan 12 2018, 11:57 PM
apol committed R134:d60b1345199e: Don't show empty license entries (authored by apol).
Don't show empty license entries
Jan 12 2018, 5:24 PM
apol committed R134:d6dc54942920: Offer the license of the snap (authored by apol).
Offer the license of the snap
Jan 12 2018, 5:22 PM
apol committed R134:ba67d4ecae59: Sort sources page by backend name (authored by apol).
Sort sources page by backend name
Jan 12 2018, 5:20 PM
apol committed R134:7879a5b54373: List snap as a source too (authored by apol).
List snap as a source too
Jan 12 2018, 5:20 PM
apol committed R134:10fab95e3570: List backends without sources in the Sources page (authored by apol).
List backends without sources in the Sources page
Jan 12 2018, 5:20 PM
apol committed R134:d3724cd8ca6b: Disable warning (authored by apol).
Disable warning
Jan 12 2018, 5:20 PM
apol committed R169:69885decbc8e: Get the padding into the header (authored by apol).
Get the padding into the header
Jan 12 2018, 3:23 PM
apol closed D9304: Get the padding into the header.
Jan 12 2018, 3:23 PM · Kirigami
apol accepted D9815: [KFileItem] Use "emblem-shared" for shared files.
Jan 12 2018, 12:46 PM · Frameworks
apol committed R134:cd3b411abbe8: Don't include file that doesn't exist (authored by apol).
Don't include file that doesn't exist
Jan 12 2018, 2:15 AM
apol committed R134:86a6d15ade23: Improve the notification text (authored by apol).
Improve the notification text
Jan 12 2018, 2:14 AM
apol committed R134:40613c2bfd7e: Simplify notifier logic (authored by apol).
Simplify notifier logic
Jan 12 2018, 2:14 AM
apol committed R134:a2be68482cb5: Use Kirigami.Heading instead of hardcoding what a title looks like (authored by apol).
Use Kirigami.Heading instead of hardcoding what a title looks like
Jan 12 2018, 1:32 AM
apol committed R134:c397f5f2f36c: Transactions get deleted alone now (authored by apol).
Transactions get deleted alone now
Jan 12 2018, 1:25 AM
apol committed R134:012a26e528f0: Use mnemonics for the section items Alt+Letter shortcuts (authored by apol).
Use mnemonics for the section items Alt+Letter shortcuts
Jan 12 2018, 1:25 AM
apol committed R134:1943cb974386: Warn if there's a shortcut conflict (authored by apol).
Warn if there's a shortcut conflict
Jan 12 2018, 1:25 AM
apol committed R134:e7048a3593c7: It's a QQC1.Action (authored by apol).
It's a QQC1.Action
Jan 12 2018, 1:25 AM
apol added inline comments to D9803: Apply some C++11 niceties, styling consistency.
Jan 12 2018, 12:50 AM · Plasma

Jan 11 2018

apol accepted D9833: Increase number of Apps you can see at once in list views.

Thanks, agreed by @colomar too.

Jan 11 2018, 11:30 PM · Plasma
apol committed R134:6ea1371c7237: Improve refresh behavior (authored by apol).
Improve refresh behavior
Jan 11 2018, 4:42 PM
apol added a comment to D9823: Optimize: use QMetaObject::invokeMethod with functor.

cleaner, yes. but also much slower. contrary to the other code-paths, the QTimer::singleShot taking a functor is not optimized (yet?) for timeout == 0...

Jan 11 2018, 4:18 PM · Frameworks
apol added a comment to D9823: Optimize: use QMetaObject::invokeMethod with functor.

Maybe it would be cleaner to do QTimer::singleShot(0, c.instance, lambda).

Jan 11 2018, 3:59 PM · Frameworks
apol accepted D9823: Optimize: use QMetaObject::invokeMethod with functor.
Jan 11 2018, 3:19 PM · Frameworks
apol accepted D9819: Verify that the path is valid and writable.
Jan 11 2018, 3:17 PM · Frameworks
apol accepted D9820: Verify that the file was opened.
Jan 11 2018, 3:17 PM · Frameworks
apol accepted D9609: Explicitly pass iconNameForUrl when dropping places entry.

LGTM

Jan 11 2018, 3:07 PM
apol added a comment to D9815: [KFileItem] Use "emblem-shared" for shared files.

+1, definitely a step forward, although it seems a bit weird that a shared emblem and action is the same icon, no?

Jan 11 2018, 2:45 PM · Frameworks
apol added a comment to D9816: Ensure DesktopIcon paints with the correct aspect ratio.

+1 tested, seems to work for me, bug seems fixed.

Jan 11 2018, 2:40 PM · Kirigami
apol added inline comments to D9803: Apply some C++11 niceties, styling consistency.
Jan 11 2018, 2:15 AM · Plasma

Jan 10 2018

apol committed R134:204467d49e83: Add some extra checks to improve the keyboard scrolling (authored by apol).
Add some extra checks to improve the keyboard scrolling
Jan 10 2018, 5:49 PM
apol committed R134:763235f483ac: Fix warnings (authored by apol).
Fix warnings
Jan 10 2018, 3:08 PM
apol committed R134:931ae4536d16: Fix automoc warnings (authored by apol).
Fix automoc warnings
Jan 10 2018, 3:08 PM
apol accepted D9781: do not incorrectly split spaces in paths of duplicate results.
Jan 10 2018, 2:58 PM · Frameworks
apol committed R134:17c61127db1d: Don't scroll up if on top, don't scroll down if at the bottom (authored by apol).
Don't scroll up if on top, don't scroll down if at the bottom
Jan 10 2018, 2:44 AM
apol committed R134:f0dc351a2605: Make the sources page header a page header rather than a list header (authored by apol).
Make the sources page header a page header rather than a list header
Jan 10 2018, 2:44 AM
apol committed R134:ca1ac7cfd338: Improve UpdatePage resource delegate (authored by apol).
Improve UpdatePage resource delegate
Jan 10 2018, 2:37 AM
apol committed R134:2e492a69a9fe: Use a toolbar instead of a header for the installed page (authored by apol).
Use a toolbar instead of a header for the installed page
Jan 10 2018, 1:55 AM
apol committed R134:1f9ed386e5ce: Expose global actions again (authored by apol).
Expose global actions again
Jan 10 2018, 1:51 AM
apol committed R134:535575f3e97c: Make sense of the ActionsModel (authored by apol).
Make sense of the ActionsModel
Jan 10 2018, 1:51 AM
apol committed R134:a4c06f0f175e: Remove unused concept of message actions (authored by apol).
Remove unused concept of message actions
Jan 10 2018, 1:51 AM

Jan 9 2018

apol committed R134:8f6233abe265: List uninstalled Discover extensions (authored by apol).
List uninstalled Discover extensions
Jan 9 2018, 11:30 PM
apol committed R134:9b1881507bec: Properly search for extensions (authored by apol).
Properly search for extensions
Jan 9 2018, 11:30 PM
apol committed R134:0f7a7628d871: extends is a weird keyword in js, use extending instead (authored by apol).
extends is a weird keyword in js, use extending instead
Jan 9 2018, 11:30 PM
apol committed R134:1652b5e72450: Fix Filters operator<<(QDebug) (authored by apol).
Fix Filters operator<<(QDebug)
Jan 9 2018, 11:30 PM
apol accepted D9769: Remove double margin in KCM UI.

It's not like QWidgets have changed much since 2007...

Jan 9 2018, 7:39 PM · Plasma
apol committed R134:2d9fb83a216d: Make sure the categories are sorted from the start (authored by apol).
Make sure the categories are sorted from the start
Jan 9 2018, 6:53 PM
apol committed R134:69c2d24a0a71: No need to manage these pointers anymore (authored by apol).
No need to manage these pointers anymore
Jan 9 2018, 6:44 PM
apol committed R134:c66379dad2d2: Include appstream information for backends (authored by apol).
Include appstream information for backends
Jan 9 2018, 5:22 PM
apol committed R858:89760fddd4cb: Cache KColorScheme instances (authored by apol).
Cache KColorScheme instances
Jan 9 2018, 4:57 PM
apol closed D9768: Cache KColorScheme instances.
Jan 9 2018, 4:57 PM · Plasma
apol committed R134:243ad65f82e0: Fix build with PKQt 1.0.0 (authored by apol).
Fix build with PKQt 1.0.0
Jan 9 2018, 4:28 PM
apol accepted D9759: Get rid of ProcessRunner.
Jan 9 2018, 3:24 PM
apol committed R134:d10709516bad: Remove unused deprecated signal (authored by apol).
Remove unused deprecated signal
Jan 9 2018, 2:06 PM
apol added a reverting change for R134:675e9d9de187: Remove workaround: R134:d1881419fd0b: Revert "Remove workaround".
Jan 9 2018, 1:41 AM
apol committed R134:d1881419fd0b: Revert "Remove workaround" (authored by apol).
Revert "Remove workaround"
Jan 9 2018, 1:41 AM
apol committed R134:675e9d9de187: Remove workaround (authored by apol).
Remove workaround
Jan 9 2018, 1:03 AM
apol committed R134:2359fe4adb70: Make sure we don't treat a non-sorted vector as sorted (authored by apol).
Make sure we don't treat a non-sorted vector as sorted
Jan 9 2018, 12:04 AM
apol committed R134:704ea2a7ecaa: Remove unused variable (authored by apol).
Remove unused variable
Jan 9 2018, 12:04 AM
apol committed R134:98ec68d3a74a: Set category name as object name (authored by apol).
Set category name as object name
Jan 9 2018, 12:04 AM

Jan 8 2018

apol committed R134:71107c2d4b3a: Merge branch 'Plasma/5.11' (authored by apol).
Merge branch 'Plasma/5.11'
Jan 8 2018, 7:32 PM
apol committed R134:dd6ac1eeea8f: Use the right component name (authored by apol).
Use the right component name
Jan 8 2018, 7:32 PM
apol committed R134:50cbb53afdac: Make sure pk updates don't go out of sync (authored by apol).
Make sure pk updates don't go out of sync
Jan 8 2018, 6:09 PM
apol committed R134:99b204afd534: Remove unneeded query (authored by apol).
Remove unneeded query
Jan 8 2018, 6:09 PM
apol committed R134:0c1c5a16a7d6: Use update-high as the updates page icon if there's security updates (authored by apol).
Use update-high as the updates page icon if there's security updates
Jan 8 2018, 5:41 PM
apol committed R134:91fa023160a6: Improve display of the updates page header (authored by apol).
Improve display of the updates page header
Jan 8 2018, 5:21 PM
apol committed R134:08d19bc89338: Simplify search UX on non-application lists (authored by apol).
Simplify search UX on non-application lists
Jan 8 2018, 5:10 PM
apol committed R134:61f822a2f2db: Issue an empty search when there is an empty query (authored by apol).
Issue an empty search when there is an empty query
Jan 8 2018, 5:10 PM
apol committed R134:6f09f357d83f: Don't compile in images we are not using (authored by apol).
Don't compile in images we are not using
Jan 8 2018, 3:06 PM
apol committed R134:2189a1261cd2: Enable qml debugging when in a devel build (authored by apol).
Enable qml debugging when in a devel build
Jan 8 2018, 3:03 PM
apol committed R134:94889545aa50: Move appstream metadata parsing into a separate async thread (authored by apol).
Move appstream metadata parsing into a separate async thread
Jan 8 2018, 3:03 PM
apol committed R134:14dc698e9fff: Share code-path between added and listed remotes (authored by apol).
Share code-path between added and listed remotes
Jan 8 2018, 12:28 PM
apol committed R134:cd72d6a12e2a: Fix pedantic warnign (authored by apol).
Fix pedantic warnign
Jan 8 2018, 12:28 PM
apol committed R134:069a201469e4: Refresh action list upon action change as the filter gets potentially wrong (authored by apol).
Refresh action list upon action change as the filter gets potentially wrong
Jan 8 2018, 12:28 PM
apol accepted D9727: Fix support for flatpak FileChooser portal.
Jan 8 2018, 11:40 AM
apol accepted D9724: Fix: correct order of QCOMPARE(actual, expected).
Jan 8 2018, 12:36 AM
apol accepted D9721: Cleanup: use auto and remove explicit KDevelop:: qualification from identifiers.
Jan 8 2018, 12:36 AM
apol accepted D9720: Cleanup: Reduce amount of ifdefs.
Jan 8 2018, 12:35 AM

Jan 5 2018

apol accepted D9481: Set toolbar/toolbutton font on quickopen line edit.

Makes sense, cheers!

Jan 5 2018, 1:56 PM

Jan 4 2018

apol added a comment to D9478: Drop use of qtpaths in startkde.

Other than that, it looks good to me.

Jan 4 2018, 5:15 PM · Plasma
apol added inline comments to D9478: Drop use of qtpaths in startkde.
Jan 4 2018, 5:14 PM · Plasma
apol committed R134:acf8cb94f932: Fix search label when on the main page (authored by apol).
Fix search label when on the main page
Jan 4 2018, 4:00 PM
apol committed R290:fb4d5496fbeb: Fix typo (authored by apol).
Fix typo
Jan 4 2018, 3:35 PM
apol committed R134:5e240b137ea6: Remove weird state where no category was being listed (authored by apol).
Remove weird state where no category was being listed
Jan 4 2018, 3:32 PM
apol committed R134:913afb06b277: Don't allow empty searches in debug mode (authored by apol).
Don't allow empty searches in debug mode
Jan 4 2018, 3:32 PM
apol committed R134:f9cc7a4e3613: Properly allocate streams (authored by apol).
Properly allocate streams
Jan 4 2018, 3:32 PM
apol committed R134:13d53ae92291: Fix text now that we need to actually accept searches (authored by apol).
Fix text now that we need to actually accept searches
Jan 4 2018, 3:32 PM
apol added a comment to D7008: Don't export internal helper executables.

Or as @dfaure says, don't install at all, because I don't see who uses this. Or remove altogether?🔥

Jan 4 2018, 12:17 PM · Frameworks
apol accepted D7008: Don't export internal helper executables.

This patch is correct, EXPORT is only useful if the target is used within cmake, AFAIU.

Jan 4 2018, 12:12 PM · Frameworks