Why "Apps"?
How about we change it to "Discover" instead of "Home"?
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Jan 14 2018
Jan 13 2018
Note process doesn't need to be captured there. Possibly a nicer fix would be to call waitForFinished on our side, but for now this is fine.
Well there must be a better way to test it works at all besides deploying it to our users...
In D9816#190075, @andreaska wrote:You are my hero. Awesome
When you have a really long or wide image will it be croped?
Jan 12 2018
Jan 11 2018
Thanks, agreed by @colomar too.
In D9823#189491, @mwolff wrote:cleaner, yes. but also much slower. contrary to the other code-paths, the QTimer::singleShot taking a functor is not optimized (yet?) for timeout == 0...
Maybe it would be cleaner to do QTimer::singleShot(0, c.instance, lambda).
LGTM
+1, definitely a step forward, although it seems a bit weird that a shared emblem and action is the same icon, no?
+1 tested, seems to work for me, bug seems fixed.
Jan 10 2018
Jan 9 2018
It's not like QWidgets have changed much since 2007...
Jan 8 2018
Jan 5 2018
Makes sense, cheers!
Jan 4 2018
Other than that, it looks good to me.
Or as @dfaure says, don't install at all, because I don't see who uses this. Or remove altogether?🔥
This patch is correct, EXPORT is only useful if the target is used within cmake, AFAIU.