- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Nov 13 2017
Yes, let's close this, needs work but what doesn't? :)
Just cherry-pick the commit into the right branch and git push it.
Thanks! Please submit to 5.11 if it doesn't bump the dependency.
Nov 12 2017
Won't un/locking already change the fact that they can be dragged? Or what is it going to become draggable?
Nov 11 2017
Why does the user need to know about the indexing? isn't it an implementation detail?
Nov 10 2017
Where would we submit them?
Are you sure it's the right way to go? Last time I tried to do something like this, I was yelled at ^^'.
Nov 9 2017
+1 I can see the same issue in my bootchart.
Qt has this kind of changes all the time and I've never seen a complaint.
Nov 8 2017
LGTM. I assume the hover information stays the same?
Here's an alternative: https://codereview.qt-project.org/210716
Submitted both to Plasma/5.11 and master.
remote: https://commits.kde.org/plasma-workspace/ad130ff3bb1fc046713aee6190a9ce3d9c474e9a
remote: https://commits.kde.org/plasma-workspace/9f7d482172ae0c1e3260cba0ba470bd16d0178f5
Nov 7 2017
In D8161#153854, @nicolasfella wrote:Since it's only an optional Permission IMHO it would be okay to ask for it and provide an explanation. The user can still decline it if unwanted.
Waiting for Milian's issues to be addressed
Sorry I missed your update, I'll apply it now.
Looks good!