Feed Advanced Search

Nov 13 2017

apol accepted D8789: Set platform theme globally in runtime.
Nov 13 2017, 6:34 PM
apol created D8797: Build examples by default for Kirigami.
Nov 13 2017, 6:05 PM
apol committed R499:f074e21964ff: KIO depends on KConfig (authored by apol).
KIO depends on KConfig
Nov 13 2017, 5:59 PM
apol created D8795: Make it possible to crosscompile sonnet.
Nov 13 2017, 5:43 PM · Frameworks
apol committed R169:ef782d629eac: Replace the library name in the source (authored by apol).
Replace the library name in the source
Nov 13 2017, 3:14 PM
apol closed D8792: Replace the library name in the source.
Nov 13 2017, 3:14 PM · Kirigami
apol created D8792: Replace the library name in the source.
Nov 13 2017, 3:09 PM · Kirigami
apol committed R240:9993337d0c8d: Only pass the ARGS thing when doing Makefiles (authored by apol).
Only pass the ARGS thing when doing Makefiles
Nov 13 2017, 3:01 PM
apol committed R169:891dabdf9ae3: Remove duplicated code (authored by apol).
Remove duplicated code
Nov 13 2017, 2:31 PM
apol committed R857:c5b8a968b8cb: Include KCoreAddons tooling in the SDK (authored by apol).
Include KCoreAddons tooling in the SDK
Nov 13 2017, 1:31 PM
apol committed R857:317c68b8e3e8: Android CI: Improve parallelization, don't make twice (authored by apol).
Android CI: Improve parallelization, don't make twice
Nov 13 2017, 1:31 PM
apol committed R244:60e80116809c: Keep widgets optional, as it's a test (authored by apol).
Keep widgets optional, as it's a test
Nov 13 2017, 1:26 PM
apol committed R244:421a27b43516: Look for Qt5 rather than Qt5Widgets (authored by apol).
Look for Qt5 rather than Qt5Widgets
Nov 13 2017, 1:20 PM
apol committed R244:2778bf7deea1: Remove unused code (authored by apol).
Remove unused code
Nov 13 2017, 1:13 PM
apol closed T441: CI: Android: Support. as Resolved.

Yes, let's close this, needs work but what doesn't? :)

Nov 13 2017, 12:57 PM · build.kde.org
apol closed T441: CI: Android: Support., a subtask of T2248: CI: DSL Revamp, as Resolved.
Nov 13 2017, 12:57 PM · build.kde.org
apol added a comment to D8784: Install related ref instead attempting to upgrade it.

Just cherry-pick the commit into the right branch and git push it.

Nov 13 2017, 12:52 PM · Plasma
apol added inline comments to D8784: Install related ref instead attempting to upgrade it.
Nov 13 2017, 11:55 AM · Plasma
apol accepted D8784: Install related ref instead attempting to upgrade it.

Thanks! Please submit to 5.11 if it doesn't bump the dependency.

Nov 13 2017, 11:54 AM · Plasma

Nov 12 2017

apol accepted D8759: Implement SH_Widget_Animation_Duration style hint.
Nov 12 2017, 7:37 PM · Plasma
apol committed R256:1e9cd8836fa2: Update to KF5 5.40.0 (authored by apol).
Update to KF5 5.40.0
Nov 12 2017, 7:33 PM
apol committed R257:f4c0990c7a73: Update to KF 5.40.0 (authored by apol).
Update to KF 5.40.0
Nov 12 2017, 7:33 PM
apol accepted D8767: Fix translation of toolbar name when it has i18n context.
Nov 12 2017, 6:32 PM · Frameworks
apol accepted D7274: Allow to only build the kauth-policy-gen code generator.
Nov 12 2017, 6:29 PM · Frameworks
apol added a comment to D8773: Improve discoverability of drag-and-drop of toolbar actions.

Won't un/locking already change the fact that they can be dragged? Or what is it going to become draggable?

Nov 12 2017, 11:32 AM · Frameworks
apol committed R499:a2897a2758ed: KConfigWidgets aren't also mandatory for KAlgebra (authored by apol).
KConfigWidgets aren't also mandatory for KAlgebra
Nov 12 2017, 12:50 AM
apol added inline comments to D7274: Allow to only build the kauth-policy-gen code generator.
Nov 12 2017, 12:43 AM · Frameworks
apol accepted D8766: In action title use "Revision Id" when talking about revision number etc..
Nov 12 2017, 12:38 AM
apol added a reverting change for R499:32f467b8b605: KAlgebra wants KIO as well: R499:523fcc9f0d97: Revert "KAlgebra wants KIO as well".
Nov 12 2017, 12:32 AM
apol committed R499:523fcc9f0d97: Revert "KAlgebra wants KIO as well" (authored by apol).
Revert "KAlgebra wants KIO as well"
Nov 12 2017, 12:32 AM
apol committed R325:761964594cc2: Improve logic to build the desktop version (authored by apol).
Improve logic to build the desktop version
Nov 12 2017, 12:29 AM

Nov 11 2017

apol committed R857:46dea486d37d: Don't look for scripts in /scripts, use the source directory (authored by apol).
Don't look for scripts in /scripts, use the source directory
Nov 11 2017, 3:25 AM
apol accepted D8755: User Manager KCM text changes and UI modernization.
Nov 11 2017, 1:05 AM · Plasma
apol added a comment to D8754: Baloo KCM text improvements.

Why does the user need to know about the indexing? isn't it an implementation detail?

Nov 11 2017, 1:03 AM · Plasma
apol accepted D8746: Install mimetype definitions for .gitignore & .gitattributes.
Nov 11 2017, 12:47 AM
apol committed R857:79e6c88c32b9: Actually put the new files in the Android docker image (authored by apol).
Actually put the new files in the Android docker image
Nov 11 2017, 12:20 AM

Nov 10 2017

apol committed R857:89dd3164bc4b: Introduce build-generic for Android CI (authored by apol).
Introduce build-generic for Android CI
Nov 10 2017, 9:37 PM
apol added a comment to D8746: Install mimetype definitions for .gitignore & .gitattributes.

Where would we submit them?

Nov 10 2017, 4:56 PM
apol committed R499:38a0b9d90a16: Only specify the needed dependencies for kalgebra mobile (authored by apol).
Only specify the needed dependencies for kalgebra mobile
Nov 10 2017, 4:35 PM
apol updated subscribers of D8746: Install mimetype definitions for .gitignore & .gitattributes.

Are you sure it's the right way to go? Last time I tried to do something like this, I was yelled at ^^'.

Nov 10 2017, 4:25 PM
apol committed R495:62ffedd0ccae: Extend API documentation (authored by apol).
Extend API documentation
Nov 10 2017, 3:58 PM
apol committed R499:61196a2e76f0: Port to python3 (authored by apol).
Port to python3
Nov 10 2017, 3:27 PM
apol closed D8737: Port to python3.
Nov 10 2017, 3:27 PM
apol committed R627:4f4799ae8024: Add missing nl (authored by apol).
Add missing nl
Nov 10 2017, 1:36 PM
apol committed R627:6c32beb0dc2c: Properly identify guest mounts (authored by apol).
Properly identify guest mounts
Nov 10 2017, 1:36 PM

Nov 9 2017

apol committed R495:80ffc7b4001b: Fix import line in the docs (authored by apol).
Fix import line in the docs
Nov 9 2017, 11:44 PM
apol created D8737: Port to python3.
Nov 9 2017, 4:42 PM
apol committed R499:ce7cbd4b4f71: Add arcconfig (authored by apol).
Add arcconfig
Nov 9 2017, 4:39 PM
apol committed R499:b7d369843c3f: KAlgebra depends on kirigami (authored by apol).
KAlgebra depends on kirigami
Nov 9 2017, 4:34 PM
apol accepted D8735: revise the tab upload dialog to direct people at the kde store.
Nov 9 2017, 12:21 PM · Plasma
apol accepted D8734: use OCS to retrieve Tabs from the KDE store.
Nov 9 2017, 12:19 PM · Plasma
apol committed R134:4fc2782a3d5d: Fix test run (authored by apol).
Fix test run
Nov 9 2017, 12:08 PM
apol committed R134:bf3812d340ef: Link to a url that still exists (authored by apol).
Link to a url that still exists
Nov 9 2017, 11:42 AM
apol added a comment to D8732: Fix race that starts kactivitymanagerd multiple times.

+1 I can see the same issue in my bootchart.

Nov 9 2017, 11:20 AM · Frameworks
apol added a comment to D8705: Remove Qt5::Widgets as a dependency.

Qt has this kind of changes all the time and I've never seen a complaint.

Nov 9 2017, 11:18 AM · Frameworks

Nov 8 2017

apol committed R134:8ce81b2a8e46: Improve displaying very long names on the application page header (authored by apol).
Improve displaying very long names on the application page header
Nov 8 2017, 6:19 PM
apol committed R134:75be774910ab: Don't fetch updates while the updater is working (authored by apol).
Don't fetch updates while the updater is working
Nov 8 2017, 4:21 PM
apol added inline comments to D8709: Add VcsAnnotationItemDelegate, for control of rendering and tooltip.
Nov 8 2017, 3:27 PM
apol committed R134:0cc8edb1c977: Include the number of dependencies an application will have to install (authored by apol).
Include the number of dependencies an application will have to install
Nov 8 2017, 3:24 PM
apol committed R134:8576e9335164: Remove weirdly long timer to display notifications (authored by apol).
Remove weirdly long timer to display notifications
Nov 8 2017, 3:02 PM
apol committed R134:32ced8ea8a0a: Simplify notifier logic (authored by apol).
Simplify notifier logic
Nov 8 2017, 3:02 PM
apol accepted D8712: Extend KTextEditor-plugin integration to activate VI-Mode commands.
Nov 8 2017, 1:08 PM
apol committed R134:63fbc9bf5ef1: Don't crash if we get into a weird state (authored by apol).
Don't crash if we get into a weird state
Nov 8 2017, 12:29 PM
apol committed R134:be4e1e4cc728: Remove unneeded declaration (authored by apol).
Remove unneeded declaration
Nov 8 2017, 12:29 PM
apol committed R134:11d121cc8271: Make sure we never search on an invalid KNS backend (authored by apol).
Make sure we never search on an invalid KNS backend
Nov 8 2017, 12:29 PM
apol added a comment to D8709: Add VcsAnnotationItemDelegate, for control of rendering and tooltip.

LGTM. I assume the hover information stays the same?

Nov 8 2017, 11:30 AM
apol added a comment to D8697: Don't check whether an empty filename exists.

Here's an alternative: https://codereview.qt-project.org/210716

Nov 8 2017, 11:18 AM · Frameworks
apol committed R119:1436ce4c23f8: Be more explicit about Qt5::Widgets dependencies (authored by apol).
Be more explicit about Qt5::Widgets dependencies
Nov 8 2017, 11:07 AM
apol closed D8707: Adapt to changes in KWindowSystem.

Submitted both to Plasma/5.11 and master.
remote: https://commits.kde.org/plasma-workspace/ad130ff3bb1fc046713aee6190a9ce3d9c474e9a
remote: https://commits.kde.org/plasma-workspace/9f7d482172ae0c1e3260cba0ba470bd16d0178f5

Nov 8 2017, 11:05 AM · Plasma
apol committed R119:457ad0d630aa: Be more explicit about Qt5::Widgets dependencies (authored by apol).
Be more explicit about Qt5::Widgets dependencies
Nov 8 2017, 11:04 AM
apol committed R119:fde9daf34679: Merge branch 'Plasma/5.11' (authored by apol).
Merge branch 'Plasma/5.11'
Nov 8 2017, 11:04 AM
apol committed R120:9f7d482172ae: Merge branch 'Plasma/5.11' (authored by apol).
Merge branch 'Plasma/5.11'
Nov 8 2017, 11:02 AM
apol committed R120:ad130ff3bb1f: Be more explicit about Qt5::Widgets dependencies (authored by apol).
Be more explicit about Qt5::Widgets dependencies
Nov 8 2017, 11:02 AM
apol abandoned D8622: Mark required Qt modules as required.
Nov 8 2017, 10:54 AM
apol committed R241:1a7d545c4040: Only prevent the name to update if it's empty (authored by apol).
Only prevent the name to update if it's empty
Nov 8 2017, 10:44 AM
apol closed D8683: Only prevent the name to update if it's empty.
Nov 8 2017, 10:44 AM · Frameworks
apol abandoned D8711: Possibly no need to have klipper executed by default.
Nov 8 2017, 10:16 AM · Plasma
apol created D8711: Possibly no need to have klipper executed by default.
Nov 8 2017, 12:41 AM · Plasma

Nov 7 2017

apol created D8707: Adapt to changes in KWindowSystem.
Nov 7 2017, 11:41 PM · Plasma
apol created D8706: Fix build with a KWindowSystem framework that doesn't pull QWidget.
Nov 7 2017, 11:38 PM · KWin
apol created D8705: Remove Qt5::Widgets as a dependency.
Nov 7 2017, 11:36 PM · Frameworks
apol committed R242:ceca6ffa01df: Don't rely in includes of includes (authored by apol).
Don't rely in includes of includes
Nov 7 2017, 8:19 PM
apol committed R36:4abf6649be21: Update libzip version (authored by apol).
Update libzip version
Nov 7 2017, 3:03 PM
apol committed R134:c236e27cd840: Merge branch 'Plasma/5.11' (authored by apol).
Merge branch 'Plasma/5.11'
Nov 7 2017, 2:46 PM
apol added a comment to D8161: findmyphone: Turn on camera flash as well.

Since it's only an optional Permission IMHO it would be okay to ask for it and provide an explanation. The user can still decline it if unwanted.

Nov 7 2017, 12:01 PM
apol added a reviewer for D8281: Allow to use IcoTool for Windows icons: Windows.
Nov 7 2017, 11:59 AM · Build System, Frameworks
apol requested changes to D8634: Custom defines/includes: Improve handling of parser arguments.

Waiting for Milian's issues to be addressed

Nov 7 2017, 11:58 AM
apol committed R256:5321abba1221: Update permissions and fix app icons for multiple KDE apps (authored by nickrichards).
Update permissions and fix app icons for multiple KDE apps
Nov 7 2017, 11:46 AM
apol closed D8384: Update permissions and fix app icons for multiple KDE apps.
Nov 7 2017, 11:46 AM
apol committed R256:bd51a4b88e76: Add arcconfig file (authored by apol).
Add arcconfig file
Nov 7 2017, 11:39 AM
apol added a comment to D8384: Update permissions and fix app icons for multiple KDE apps.

Sorry I missed your update, I'll apply it now.

Nov 7 2017, 11:38 AM
apol accepted D8384: Update permissions and fix app icons for multiple KDE apps.
Nov 7 2017, 11:38 AM
apol added a comment to D8058: don't redefine output dirs on android.

https://phabricator.kde.org/D8173

Nov 7 2017, 1:00 AM · Build System, Frameworks
apol committed R134:785a1bb0ed14: Don't refresh invalid backends (authored by apol).
Don't refresh invalid backends
Nov 7 2017, 12:52 AM
apol accepted D8684: text improvements for Colors, Icons, Style, and Workspace KCMs.

Looks good!

Nov 7 2017, 12:33 AM · Plasma
apol added inline comments to D8686: Screenlocker KCM text improvements.
Nov 7 2017, 12:32 AM · Plasma

Nov 6 2017

apol added inline comments to D8643: Fix display of remote:/ in the qfiledialog.
Nov 6 2017, 4:29 PM · Frameworks
apol created D8683: Only prevent the name to update if it's empty.
Nov 6 2017, 4:28 PM · Frameworks
apol committed R134:014553f8c158: Adopt new icons in breeze-icons for install/uninstall (authored by apol).
Adopt new icons in breeze-icons for install/uninstall
Nov 6 2017, 1:56 PM
apol committed R134:6e7152880117: Use the main action for updating (authored by apol).
Use the main action for updating
Nov 6 2017, 12:44 PM