Feed Advanced Search

Oct 23 2019

sitter abandoned D23537: extend state verification to open connection commands.

Replaced by D24887 which instead creates a more generic system to verify slave behavior.

Oct 23 2019, 12:45 PM · Frameworks
sitter requested review of D24887: WIP slave command behavior assertion system.
Oct 23 2019, 12:44 PM · Frameworks

Oct 22 2019

sitter updated the summary of D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds.
Oct 22 2019, 10:34 AM · Frameworks
sitter updated the diff for D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds.

remove warning

Oct 22 2019, 10:33 AM · Frameworks
sitter added inline comments to D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds.
Oct 22 2019, 9:54 AM · Frameworks

Oct 21 2019

sitter committed R971:65ebfb01567e: point filelight to new windows store version (authored by sitter).
point filelight to new windows store version
Oct 21 2019, 3:21 PM
sitter planned changes to D23537: extend state verification to open connection commands.
Oct 21 2019, 2:56 PM · Frameworks
sitter added a comment to D23537: extend state verification to open connection commands.

I've actually started work on a more general system for this. Will update soon.

Oct 21 2019, 2:56 PM · Frameworks
sitter committed R241:ecb39f191560: typo-- (authored by sitter).
typo--
Oct 21 2019, 1:23 PM
sitter requested review of D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds.
Oct 21 2019, 11:38 AM · Frameworks
sitter committed R223:568f11b0678e: don't crash on nullptr pdfOptionsPage (authored by sitter).
don't crash on nullptr pdfOptionsPage
Oct 21 2019, 9:39 AM
sitter committed R223:596b2d3019e3: Merge branch 'Applications/19.08' (authored by sitter).
Merge branch 'Applications/19.08'
Oct 21 2019, 9:39 AM
sitter closed D24696: don't crash on nullptr pdfOptionsPage.
Oct 21 2019, 9:39 AM · Okular
sitter committed R223:235164b264f7: don't crahs on nullptr pdfOptionsPage (authored by sitter).
don't crahs on nullptr pdfOptionsPage
Oct 21 2019, 9:39 AM

Oct 18 2019

sitter accepted D24727: Fix NOAA picture of the day provider.

works well enough it seems

Oct 18 2019, 2:08 PM · Plasma
sitter added a comment to D24727: Fix NOAA picture of the day provider.

When I put the code in a minimal standalone program I can confirm that the code works just fine. Are you sure your testing methodology is sound @ngraham ?

Oct 18 2019, 10:24 AM · Plasma

Oct 17 2019

sitter added inline comments to D24568: Provide clang-format target with a KDE Frameworks style file.
Oct 17 2019, 9:33 AM · Build System, Frameworks
sitter committed R320:4197683e7e33: Merge branch 'Applications/19.08' (authored by sitter).
Merge branch 'Applications/19.08'
Oct 17 2019, 9:05 AM
sitter committed R320:45b1327a6dac: fix password error condition handling of smb mount (authored by sitter).
fix password error condition handling of smb mount
Oct 17 2019, 9:05 AM
sitter closed D24487: fix password error condition handling of smb mount.
Oct 17 2019, 9:05 AM · Frameworks, Dolphin
sitter committed R106:726e7b6d1815: fix nvidia line part count (authored by sitter).
fix nvidia line part count
Oct 17 2019, 9:04 AM
sitter closed D24694: fix part count.
Oct 17 2019, 9:04 AM · Plasma

Oct 16 2019

sitter added a reviewer for D24696: don't crash on nullptr pdfOptionsPage: aacid.
Oct 16 2019, 12:50 PM · Okular
sitter requested review of D24696: don't crash on nullptr pdfOptionsPage.
Oct 16 2019, 12:50 PM · Okular
sitter added reviewers for D24694: fix part count: davidedmundson, ahiemstra.
Oct 16 2019, 11:40 AM · Plasma
sitter requested review of D24694: fix part count.
Oct 16 2019, 11:39 AM · Plasma
sitter committed R883:1553901: remove mention of nvidia stats support.
remove mention of nvidia stats support
Oct 16 2019, 10:20 AM

Oct 15 2019

sitter committed R241:c2bd18f17e61: give all pointers in slavebase a default init to nullptr (authored by sitter).
give all pointers in slavebase a default init to nullptr
Oct 15 2019, 9:14 AM
sitter closed D24655: give all pointers in slavebase a default init to nullptr.
Oct 15 2019, 9:14 AM · Frameworks
sitter requested review of D24655: give all pointers in slavebase a default init to nullptr.
Oct 15 2019, 8:52 AM · Frameworks
sitter accepted D24639: Update link to the impressum. It was broken since at least 9 years.

Thanks!

Oct 15 2019, 8:42 AM
sitter added a comment to D24641: Collect more information from version control systems.

Do we have a request for this outside kbibtex? My attitude towards adding things to ECM is always "is there more than one user".

Oct 15 2019, 8:24 AM · Build System, Frameworks
sitter committed R241:5f66badc6e7a: ftptest: replace logger-colors with logger (authored by sitter).
ftptest: replace logger-colors with logger
Oct 15 2019, 7:44 AM

Oct 14 2019

sitter closed D24631: exclude ioslaves directory from api docs.
Oct 14 2019, 1:58 PM · Frameworks
sitter committed R241:d05d03f2f13e: exclude ioslaves directory from api docs (authored by sitter).
exclude ioslaves directory from api docs
Oct 14 2019, 1:58 PM
sitter committed R241:c847c2c79b0e: ftptest: refactor the daemon startup into its own helper function (authored by sitter).
ftptest: refactor the daemon startup into its own helper function
Oct 14 2019, 12:09 PM
sitter committed R241:3ac354ea8e6c: ftptest: mark overwrite without overwrite flag no longer failing (authored by sitter).
ftptest: mark overwrite without overwrite flag no longer failing
Oct 14 2019, 12:09 PM
sitter requested review of D24631: exclude ioslaves directory from api docs.
Oct 14 2019, 11:48 AM · Frameworks
sitter added a comment to D24626: install ftpd gem for KIO ftp tests.

Thanks for this - i'll get this integrated soon.

Please note that Ruby is totally unavailable on our Windows builders - will you be making the presence of this gem optional (just disabling the unit tests when it is unavailable) in KIO?

Oct 14 2019, 11:36 AM
sitter added a reviewer for D24626: install ftpd gem for KIO ftp tests: Sysadmin.
Oct 14 2019, 10:15 AM
sitter requested review of D24626: install ftpd gem for KIO ftp tests.
Oct 14 2019, 10:15 AM
sitter committed R241:a92123d8b0dd: consider ftpd not required for the time being (authored by sitter).
consider ftpd not required for the time being
Oct 14 2019, 10:11 AM
sitter committed R241:c86eedf0f92d: port ftp slave to new error reporting system (authored by sitter).
port ftp slave to new error reporting system
Oct 14 2019, 10:06 AM
sitter closed D23579: port ftp slave to new error reporting system.
Oct 14 2019, 10:06 AM · Frameworks
sitter committed R241:c372fa3c4236: remove legacy space handling code (authored by sitter).
remove legacy space handling code
Oct 14 2019, 10:06 AM
sitter closed D24560: remove legacy space handling code.
Oct 14 2019, 10:06 AM · Frameworks
sitter committed R241:c904cbcb9876: simplify the url parsing (authored by sitter).
simplify the url parsing
Oct 14 2019, 10:06 AM
sitter closed D24559: simplify the url parsing.
Oct 14 2019, 10:06 AM · Frameworks
sitter closed D24558: fix proxy setting loading.
Oct 14 2019, 10:06 AM · Frameworks
sitter committed R241:d1a3b9d08158: fix proxy setting loading (authored by sitter).
fix proxy setting loading
Oct 14 2019, 10:06 AM

Oct 11 2019

sitter updated the summary of D23579: port ftp slave to new error reporting system.
Oct 11 2019, 1:35 PM · Frameworks
sitter requested review of D24560: remove legacy space handling code.
Oct 11 2019, 12:59 PM · Frameworks
sitter requested review of D24559: simplify the url parsing.
Oct 11 2019, 12:58 PM · Frameworks
sitter added a reviewer for D24558: fix proxy setting loading: dfaure.
Oct 11 2019, 12:57 PM · Frameworks
sitter requested review of D24558: fix proxy setting loading.
Oct 11 2019, 12:57 PM · Frameworks
sitter updated the diff for D23579: port ftp slave to new error reporting system.

move away from helper functions to redirect to q-> and instaed call via q-> directly

Oct 11 2019, 11:39 AM · Frameworks
sitter updated the summary of D23579: port ftp slave to new error reporting system.
Oct 11 2019, 11:31 AM · Frameworks
sitter updated the diff for D23579: port ftp slave to new error reporting system.
  • rebase
  • ftpSendCmd now returns a bool (continues to require_result)
  • openConnection now emits opened()
  • listDir now finalize()s
  • debug--
  • ftpSendCmd's lazy login now checks the return value of the recrusive cmd call
Oct 11 2019, 11:30 AM · Frameworks

Oct 10 2019

sitter updated subscribers of D24407: Increase UI commonality between KCM and applet.

@nicolasfella do you have thoughts?

Oct 10 2019, 8:49 AM · Plasma

Oct 8 2019

sitter requested review of D24487: fix password error condition handling of smb mount.
Oct 8 2019, 10:03 AM · Frameworks, Dolphin
sitter committed R320:5a8705548fae: improve error reporting for when kpasswdserver is unreachable (authored by sitter).
improve error reporting for when kpasswdserver is unreachable
Oct 8 2019, 9:36 AM
sitter committed R320:ba97fc48a0fa: Merge branch 'Applications/19.08' (authored by sitter).
Merge branch 'Applications/19.08'
Oct 8 2019, 9:36 AM
sitter closed D24387: improve error reporting for when kpasswdserver is unreachable.
Oct 8 2019, 9:36 AM · Frameworks, Dolphin
sitter added inline comments to D24387: improve error reporting for when kpasswdserver is unreachable.
Oct 8 2019, 9:27 AM · Frameworks, Dolphin

Oct 4 2019

sitter updated the test plan for D24387: improve error reporting for when kpasswdserver is unreachable.
Oct 4 2019, 12:21 PM · Frameworks, Dolphin

Oct 3 2019

sitter added a comment to D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.

My point is that your lamentations have nothing to do with this class but with Q*Animation on your system. So you need to find out what's wrong and talk to Qt. I am 100% against a workaround that degrades the user experience when the bug isn't even in this class.

Oct 3 2019, 1:41 PM · Frameworks
sitter requested review of D24387: improve error reporting for when kpasswdserver is unreachable.
Oct 3 2019, 1:22 PM · Frameworks, Dolphin
sitter added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

^ The diff for people not fluent in reverse-markdown ;)

Oct 3 2019, 12:37 PM
sitter added a comment to D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.

The demo doesn't even use this widget

Oct 3 2019, 11:48 AM · Frameworks
sitter added a reverting change for R487:43e612f1fd2d: Port deprecated qVariantFromValue method: R487:f0465a4370ed: Revert "Port deprecated qVariantFromValue method".
Oct 3 2019, 10:32 AM
sitter committed R487:f0465a4370ed: Revert "Port deprecated qVariantFromValue method" (authored by sitter).
Revert "Port deprecated qVariantFromValue method"
Oct 3 2019, 10:32 AM
sitter added a reverting change for R489:b9a2bee52857: Port deprecated QLatin1Literal -> QLatin1String: R489:caa78d56689f: Revert "Port deprecated QLatin1Literal -> QLatin1String".
Oct 3 2019, 10:31 AM
sitter committed R489:caa78d56689f: Revert "Port deprecated QLatin1Literal -> QLatin1String" (authored by sitter).
Revert "Port deprecated QLatin1Literal -> QLatin1String"
Oct 3 2019, 10:31 AM
sitter added a comment to D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.

Oct 3 2019, 10:25 AM · Frameworks

Oct 1 2019

sitter committed R240:f3f4893b5bd2: new module ECMSourceVersionControl (authored by sitter).
new module ECMSourceVersionControl
Oct 1 2019, 10:30 AM
sitter closed D24159: new module ECMSourceVersionControl.
Oct 1 2019, 10:30 AM · Build System, Frameworks

Sep 30 2019

sitter committed R247:aa82b36fa415: move elisa from extragear to kdemultimedia (authored by sitter).
move elisa from extragear to kdemultimedia
Sep 30 2019, 8:28 AM
sitter added a comment to T9594: Publish Filelight in the Microsoft Store.

Sep 30 2019, 8:13 AM · Windows

Sep 27 2019

sitter added a comment to T9594: Publish Filelight in the Microsoft Store.

I meant the svg from breeze-icons. The one in the repo would be from kde4 or even 3 times.

Sep 27 2019, 3:33 PM · Windows
sitter added a comment to T9594: Publish Filelight in the Microsoft Store.

Feel free to update the pngs. I haven't looked but I'm certain the PNGs are ancient icons from before breeze, so go with what breeze has.

Sep 27 2019, 2:34 PM · Windows
sitter added a comment to T11675: Create Discourse Setup.

Yeah, we used Jonathan's test instance basically like a mailing list. It works very well.

Sep 27 2019, 10:44 AM · Goal: All About the Apps, Sysadmin
sitter edited projects for T9240: Split kirigami-gallery from kirigami, added: Neon2Debian; removed Neon.
Sep 27 2019, 9:44 AM · Neon2Debian
sitter moved T10478: document snap tech from Doing to Review on the Neon board.
Sep 27 2019, 9:40 AM · Neon
sitter added a comment to T11716: Sort out kdeedu-data.

Is this done then from our side?

Sep 27 2019, 9:37 AM · Neon
sitter closed T11722: fix appstream for unstable/stable as Resolved.

looks good

Sep 27 2019, 9:27 AM · Neon

Sep 26 2019

sitter committed R572:46154c610b61: fix ruby 2.3 support (authored by sitter).
fix ruby 2.3 support
Sep 26 2019, 10:22 AM
sitter committed R572:10b4708b8e3b: fix a reentrancy bug in svn.run (authored by sitter).
fix a reentrancy bug in svn.run
Sep 26 2019, 10:22 AM
sitter committed R572:fd4357da64bc: be more assertive about setup success (authored by sitter).
be more assertive about setup success
Sep 26 2019, 10:21 AM
sitter committed R572:40b4282eeeff: rescue threaderror on queue pops (authored by sitter).
rescue threaderror on queue pops
Sep 26 2019, 10:21 AM
sitter committed R572:c22b9048557b: print l10nstatistics and use stats to drop 0-coverage l10n (authored by sitter).
print l10nstatistics and use stats to drop 0-coverage l10n
Sep 26 2019, 10:21 AM

Sep 25 2019

sitter committed R487:f8f3e8ce6e43: bump to 4.11.1 for release (authored by sitter).
bump to 4.11.1 for release
Sep 25 2019, 12:17 PM
sitter committed R487:e3d01fe75dc4: bump to 4.11.1 for release (authored by sitter).
bump to 4.11.1 for release
Sep 25 2019, 12:17 PM
sitter committed R489:4e3a8182d5c1: Merge branch '0.11' (authored by sitter).
Merge branch '0.11'
Sep 25 2019, 11:40 AM
sitter committed R489:b49ba0cefe87: only set xwindow when the qt platform actually is xcb (on unix) (authored by sitter).
only set xwindow when the qt platform actually is xcb (on unix)
Sep 25 2019, 11:40 AM
sitter committed R489:56158407df56: bump to 0.11.1 for release (authored by sitter).
bump to 0.11.1 for release
Sep 25 2019, 11:40 AM
sitter committed R871:b769764b4727: fix default version selection to allow for renamed "unspecified" versions (authored by sitter).
fix default version selection to allow for renamed "unspecified" versions
Sep 25 2019, 11:26 AM
sitter committed R871:6bef88403fe9: Merge branch 'Plasma/5.17' (authored by sitter).
Merge branch 'Plasma/5.17'
Sep 25 2019, 11:26 AM
sitter committed R871:871ed0a975a5: use KBusyIndicatorWidget for all busy indication uses (authored by sitter).
use KBusyIndicatorWidget for all busy indication uses
Sep 25 2019, 11:26 AM
sitter closed D24214: fix default version selection to allow for renamed "unspecified" versions.
Sep 25 2019, 11:26 AM · Plasma
sitter closed D24158: use KBusyIndicatorWidget for all busy indication uses.
Sep 25 2019, 11:25 AM · Plasma