Feed Advanced Search

Sep 16 2019

guoyunhe added a comment to D23998: Fix HiDPI rendering issues with Dual Screen.

If I know how to fix it in Konsole, I will definitely do it. But I cannot find the cause in KonsolePart. Dolphin took the same solution, instead of call the function, they send cd command. I also pushed it to GitLab/Invent https://invent.kde.org/kde/kate/merge_requests/19/diffs

Sep 16 2019, 5:39 PM · Kate
guoyunhe added a reviewer for D23998: Fix HiDPI rendering issues with Dual Screen: Kate.
Sep 16 2019, 4:54 PM · Kate
guoyunhe requested review of D23998: Fix HiDPI rendering issues with Dual Screen.
Sep 16 2019, 4:54 PM · Kate
guoyunhe updated the diff for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Rename and move the find duplicate button

Sep 16 2019, 2:38 PM · Plasma
guoyunhe abandoned D23775: HiDPI rendering improvement.

Noticed that someone has changed width() to boundingRect() in master branch. I really hope someone can inform me to change the patch. Otherwise, we can never push it forward... Please review D23993

Sep 16 2019, 1:24 PM
guoyunhe requested review of D23993: HiDPI rendering improvement.
Sep 16 2019, 1:20 PM · KDE Applications
guoyunhe abandoned D6813: Use customized font size for Digital Clock applet.

It seems not possible to set font size because others insist the font size should grow with panel. Another alternative widget might be better way to push forward.

Sep 16 2019, 12:05 PM · Plasma
guoyunhe abandoned D17704: Copy to clipboard always copy English texts.
Sep 16 2019, 11:59 AM · Plasma
guoyunhe added a comment to D17704: Copy to clipboard always copy English texts.

Yes, this can be closed because another approach is more useful.

Sep 16 2019, 11:59 AM · Plasma
guoyunhe added a reviewer for D23987: Enable HiDPI rendering for rules dialog and killer dialog.: KWin.
Sep 16 2019, 11:55 AM · KWin
guoyunhe requested review of D23987: Enable HiDPI rendering for rules dialog and killer dialog..
Sep 16 2019, 11:55 AM · KWin
guoyunhe updated the diff for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Fix size policy

Sep 16 2019, 8:22 AM · Plasma
guoyunhe updated the diff for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Avoid scrollbar. Put progressbar and font status to another row.

Sep 16 2019, 7:47 AM · Plasma

Sep 15 2019

guoyunhe updated the diff for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Similar filter layout as Colors KCM. Move "Scan Duplicates..." button to the bottom button group.

Sep 15 2019, 8:49 PM · Plasma
guoyunhe added a comment to D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Now I can get something like this (the QLineEdit and QPushButton still have different height):

Sep 15 2019, 8:34 PM · Plasma
guoyunhe added a comment to D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Maybe in the interests of Goal: Consistency, let's make the filter feature look the same way that it does in the Colors KCM:

Sep 15 2019, 7:55 PM · Plasma
guoyunhe updated the diff for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Unify button look

Sep 15 2019, 6:28 AM · Plasma

Sep 14 2019

guoyunhe added a comment to D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

I changed it to QToolButton, but it still look different:

Sep 14 2019, 9:15 PM · Plasma
guoyunhe updated the summary of D23949: Pixel perfect splash art rendering.
Sep 14 2019, 8:34 PM · Krita
guoyunhe updated the summary of D23949: Pixel perfect splash art rendering.
Sep 14 2019, 8:33 PM · Krita
guoyunhe requested review of D23949: Pixel perfect splash art rendering.
Sep 14 2019, 8:32 PM · Krita
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

@ndavis can you give review? thanks!

Sep 14 2019, 7:26 PM · Frameworks
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

Changed to currentColor

Sep 14 2019, 7:18 PM · Frameworks
guoyunhe updated the diff for D23942: Add enablefont and disablefont icon for kfontinst KCM.

Remove hardcoded colors

Sep 14 2019, 7:16 PM · Frameworks
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

@GB_2 is it correct now?

Sep 14 2019, 6:59 PM · Frameworks
guoyunhe updated the diff for D23942: Add enablefont and disablefont icon for kfontinst KCM.

Add inline styles

Sep 14 2019, 6:59 PM · Frameworks
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

I was asked to remove the hard code color like: fill="currentColor" and fill="#da4453". But I see other icons have something like style="fill:currentColor". Can anyone tell me correct way of applying colors?

Sep 14 2019, 6:53 PM · Frameworks
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

@ndavis it looks strange when I removed the inline style

Sep 14 2019, 6:37 PM · Frameworks
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

I just followed the email icons' color: check mark is black/white, disable mark is red.

Sep 14 2019, 6:24 PM · Frameworks
guoyunhe updated the diff for D23942: Add enablefont and disablefont icon for kfontinst KCM.

Remove hardcoded colors

Sep 14 2019, 5:54 PM · Frameworks
guoyunhe updated the diff for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Change icon name. To match patch D23942

Sep 14 2019, 5:43 PM · Plasma
guoyunhe added a comment to D6764: Use a smaller font size for digital clock plasmoid.

I think we can make another applet called Small Digital Clock, which can be an alternative of Digital Clock. Just like we have different alternatives for launcher and task bar.

Sep 14 2019, 5:35 PM · Plasma
guoyunhe added a comment to D7946: CSV characters should not be translated.

How can we push this forward?

Sep 14 2019, 5:30 PM · Calligra: 3.0
guoyunhe abandoned D17246: Unify height of message editor and nickname selector.

There should be a fix for Breeze theme, not individual applications.

Sep 14 2019, 5:29 PM
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

@ndavis, @broulik, @ngraham, I made some change. Can you have another look?

Sep 14 2019, 5:26 PM · Frameworks
guoyunhe updated the diff for D23942: Add enablefont and disablefont icon for kfontinst KCM.

Add 16px icons for font-enable and font-disable

Sep 14 2019, 5:25 PM · Frameworks
guoyunhe updated the diff for D23942: Add enablefont and disablefont icon for kfontinst KCM.

Reduce space between A and marks

Sep 14 2019, 5:00 PM · Frameworks
guoyunhe updated the diff for D23942: Add enablefont and disablefont icon for kfontinst KCM.

Rename enablefont and disablefont icons

Sep 14 2019, 2:18 PM · Frameworks
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

Please use a more hierarchical name, e.g. "font-enable" and "font-disable", to match the other font icons we have such as "font-size-up" and "font-face"

Sep 14 2019, 2:14 PM · Frameworks
guoyunhe added a reviewer for D23943: HiDPI support: Frameworks.
Sep 14 2019, 1:59 PM · Frameworks
guoyunhe requested review of D23943: HiDPI support.
Sep 14 2019, 1:58 PM · Frameworks
guoyunhe added a reviewer for D23942: Add enablefont and disablefont icon for kfontinst KCM: Breeze.
Sep 14 2019, 12:48 PM · Frameworks
guoyunhe requested review of D23942: Add enablefont and disablefont icon for kfontinst KCM.
Sep 14 2019, 12:41 PM · Frameworks

Sep 11 2019

guoyunhe abandoned D16734: HiDPI: make icons sharp and smooth.

Has been merged by other developers a long time ago.

Sep 11 2019, 10:50 AM
guoyunhe updated the diff for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Fix the font preview size in HiDPI

Sep 11 2019, 10:15 AM · Plasma
guoyunhe added a comment to D23775: HiDPI rendering improvement.

According to Qt's source code, horizontalAdvance() is the exact replacement of width(), while boundingRect() is a different function. So I prefer to have horizontalAdvanced() if it doesn't cause any issues. https://github.com/qt/qtbase/commit/4d88d79aa507777bce40740b21747f656efc074d

Sep 11 2019, 9:14 AM
guoyunhe added a reviewer for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware: Plasma.
Sep 11 2019, 9:01 AM · Plasma
guoyunhe requested review of D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.
Sep 11 2019, 9:01 AM · Plasma

Sep 10 2019

guoyunhe added a comment to D23840: Enable HiDPI rendering for systemmonitor.

Fixed in https://phabricator.kde.org/D23846

Sep 10 2019, 7:18 PM · Plasma
guoyunhe added a reviewer for D23846: Fix build error of wrong function reference: Plasma.
Sep 10 2019, 7:17 PM · Plasma
guoyunhe requested review of D23846: Fix build error of wrong function reference.
Sep 10 2019, 7:16 PM · Plasma
guoyunhe added a reviewer for D23840: Enable HiDPI rendering for systemmonitor: Plasma.
Sep 10 2019, 3:33 PM · Plasma
guoyunhe requested review of D23840: Enable HiDPI rendering for systemmonitor.
Sep 10 2019, 3:33 PM · Plasma
guoyunhe added inline comments to D23775: HiDPI rendering improvement.
Sep 10 2019, 3:19 PM
guoyunhe updated the diff for D23775: HiDPI rendering improvement.

Update Qt version requirement

Sep 10 2019, 3:16 PM
guoyunhe updated the summary of D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display.
Sep 10 2019, 2:51 PM · Plasma
guoyunhe updated the diff for D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display.

continue trying

Sep 10 2019, 2:49 PM · Plasma
guoyunhe added a reviewer for D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display: Plasma.
Sep 10 2019, 1:22 PM · Plasma
guoyunhe requested review of D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display.
Sep 10 2019, 1:22 PM · Plasma

Sep 9 2019

guoyunhe added a comment to T11070: Better (online) localization.

One of the requirement is to allow people to still do changes on SVN. If I, as administrator, need to directly change a po file (for several languages), I must be able to do it, and the online translation tool should cope with that.

Can you give a more detailed description of what kind of change you need to do with po files? When the context is clear, we can support it in the Weblate workflow.

Any kind of change in both strings (for example, fixing mistakes in tags which prevent the po file - from documentation - from being compiled) and headers (license details, missing tags, etc). And also renaming of files, and other operations that are probably not problematic from this workflow (copy with a different name and removal).

Sep 9 2019, 4:31 PM · Localization, Goal Setting 2019
guoyunhe added a comment to T11070: Better (online) localization.

How does manage the case when a file is renamed but there are new proposed translations for it? Does crowdin recognize the rename and reassign the pending changes?

Sep 9 2019, 4:17 PM · Localization, Goal Setting 2019
guoyunhe added a comment to T11070: Better (online) localization.

One of the requirement is to allow people to still do changes on SVN. If I, as administrator, need to directly change a po file (for several languages), I must be able to do it, and the online translation tool should cope with that.

Sep 9 2019, 3:53 PM · Localization, Goal Setting 2019
guoyunhe added a comment to T11070: Better (online) localization.

SVN submit and Weblate can work together. I have made a workflow with SVN+Crowdin. New translation submitted to SVN will also be uploaded to Crowdin. So both Lokalize and Weblate/Crowdin lovers can still contribute in their preferred way. This is totally possible.

Sep 9 2019, 3:42 PM · Localization, Goal Setting 2019
guoyunhe added a comment to T11070: Better (online) localization.

flattening directory structure will be a very good idea. since here a lot of file moving from one folder to another. Weblate doesn't support folder structure. But we can also use a script to map current folder structure to a flatten structure.

Sep 9 2019, 9:57 AM · Localization, Goal Setting 2019
guoyunhe added a comment to T11070: Better (online) localization.

If KDE can't provide a test Weblate server, I can front one on my own dime. A server on Linode that meets the 2 core + 2 GB recommended specs goes for $20/month.

The other thing we'd need to know is who we could contact to connect the test Weblate instance to whatever integration/pre-prod infrastrucutre KDE has to make sure the seamless SVN integration bits all check out. In particular I believe some KDE sysadmin would need to provide some faceless account that would handle the automated pushes/pulls between integration/pre-prod Summit and Weblate.

Sep 9 2019, 8:45 AM · Localization, Goal Setting 2019
guoyunhe added a comment to T11070: Better (online) localization.

Can we get a server to start testing with Weblate? It only takes one or two weeks to set up a test instance of Weblate + scripts for synchronization.

Sep 9 2019, 8:27 AM · Localization, Goal Setting 2019
guoyunhe added a comment to D23775: HiDPI rendering improvement.

Are you sure horizontalAdvance() is the correct thing here? boundingRect().width() seems more appropriate to me.

Sep 9 2019, 7:56 AM

Sep 8 2019

guoyunhe added a reviewer for D23795: HiDPI icon in buttons and menus: Plasma.
Sep 8 2019, 7:37 PM · Plasma
guoyunhe requested review of D23795: HiDPI icon in buttons and menus.
Sep 8 2019, 7:37 PM · Plasma
guoyunhe updated the summary of D23794: HiDPI icon pixmap.
Sep 8 2019, 7:32 PM · Plasma
guoyunhe requested review of D23794: HiDPI icon pixmap.
Sep 8 2019, 7:27 PM · Plasma

Sep 7 2019

guoyunhe updated the diff for D23775: HiDPI rendering improvement.

Replace QFontMetrics::width() (obsolete) with QFontMetrics::horizontalAdvance()

Sep 7 2019, 4:50 PM
guoyunhe updated the summary of D23775: HiDPI rendering improvement.
Sep 7 2019, 4:41 PM
guoyunhe requested review of D23775: HiDPI rendering improvement.
Sep 7 2019, 4:39 PM

Sep 5 2019

guoyunhe committed R883:1551114: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Sep 5 2019, 10:41 AM
guoyunhe committed R883:1551113: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Sep 5 2019, 10:41 AM

Aug 26 2019

guoyunhe updated the task description for T11070: Better (online) localization.
Aug 26 2019, 7:23 PM · Localization, Goal Setting 2019
guoyunhe added a comment to T11070: Better (online) localization.

Simplified Chinese team moved to Crowdin workflow since 2017. We have seen a boost of contributors in the last two years, from around 5 to a list of 30+.

Aug 26 2019, 7:20 PM · Localization, Goal Setting 2019

Aug 16 2019

guoyunhe committed R883:1549819: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Aug 16 2019, 5:30 PM
guoyunhe committed R883:1549818: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Aug 16 2019, 5:30 PM

Aug 14 2019

guoyunhe added a comment to D23161: Make media control icons outline style instead of solid style.

Yes, I did a search on the internet and almost all popular music app use solid play/pause/stop icon.

Aug 14 2019, 8:45 PM · Frameworks
guoyunhe updated the diff for D23161: Make media control icons outline style instead of solid style.

22px icons

Aug 14 2019, 8:42 PM · Frameworks
guoyunhe updated the diff for D23161: Make media control icons outline style instead of solid style.

Correct SVG format

Aug 14 2019, 8:13 PM · Frameworks
guoyunhe updated the summary of D23161: Make media control icons outline style instead of solid style.
Aug 14 2019, 8:00 PM · Frameworks
guoyunhe requested review of D23161: Make media control icons outline style instead of solid style.
Aug 14 2019, 7:57 PM · Frameworks

Aug 11 2019

guoyunhe updated the diff for D22535: Make kimpanel a system tray applet.
  • avoid state jumping. lock state when opening kimpanel.
Aug 11 2019, 8:51 PM · Plasma
guoyunhe added a comment to D22535: Make kimpanel a system tray applet.

Uploaded latest code. It is unfinished. Just for anyone who may accidentally be interested.

Aug 11 2019, 7:01 PM · Plasma
guoyunhe abandoned D22535: Make kimpanel a system tray applet.
Aug 11 2019, 6:26 PM · Plasma
guoyunhe updated the diff for D22535: Make kimpanel a system tray applet.
  • UNFINISHED: show icon of current input method in system tray
Aug 11 2019, 6:25 PM · Plasma
guoyunhe abandoned D22535: Make kimpanel a system tray applet.
Aug 11 2019, 6:17 PM · Plasma
guoyunhe added a comment to D22535: Make kimpanel a system tray applet.

Added context menu actions to configure keyboard and fcitx. @ngraham do we KCM of ibus or scim?

Aug 11 2019, 3:38 PM · Plasma
guoyunhe updated the summary of D22535: Make kimpanel a system tray applet.
Aug 11 2019, 2:48 PM · Plasma

Aug 10 2019

guoyunhe added a comment to D22535: Make kimpanel a system tray applet.

Making the layout of status panel:

Aug 10 2019, 8:34 PM · Plasma
guoyunhe added a comment to D22535: Make kimpanel a system tray applet.

Did you delete the old KCM first? If not, it will take precedence and you won't see the new one. The old one is located in the following location:

  • Ubuntu-based distros: [install prefix]/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_keyboard.so
  • Other distros: [install prefix]/usr/lib/qt/plugins/kcm_keyboard.so

    Regardless, I'm super excited to see @gpark's work get revived!
Aug 10 2019, 7:34 PM · Plasma
guoyunhe added a comment to D22535: Make kimpanel a system tray applet.

I tried to merge @gpark 's branch. It is compiled but I cannot reproduce the UI as shown in demo video. I am not sure how it is connected. So I leave that part untouched for now. I hope I can get in touch with @gpark to understand how the code works. Then we can make another patch for KCM and OSD modules.

Aug 10 2019, 10:23 AM · Plasma

Aug 9 2019

guoyunhe added a comment to D22535: Make kimpanel a system tray applet.

@gpark I am trying to pull all your changes into this patch. If I understand correctly, your work is in new_keyboard_kcm branch of repo https://cgit.kde.org/clones/plasma-desktop/gpark/gsoc-kcm-keyboard-revamp.git ?

Aug 9 2019, 6:07 PM · Plasma
guoyunhe updated the summary of D22535: Make kimpanel a system tray applet.
Aug 9 2019, 5:28 PM · Plasma
guoyunhe requested review of D23051: Make file bookmark names consistent.
Aug 9 2019, 4:34 PM · Frameworks

Aug 8 2019

guoyunhe added a comment to D22925: Fix Unsplash POTD not updating.

It works now. Tested with several different POTD providers.

Aug 8 2019, 10:55 AM · Plasma

Aug 7 2019

guoyunhe updated the diff for D22925: Fix Unsplash POTD not updating.

Add import

Aug 7 2019, 4:55 PM · Plasma