I checked all KCM modules, the bottom row of buttons are all in same height (like the smaller button in your screenshot). Have you tried reboot?
@ngraham which applications are they? I didn't see similar thing in my system.
Force height consistency
The remaining 1px difference between QPushButton and QLineEdit is caused by content. QLineEdit directly expands from its content size, while QPushButton calculate size of text metrics and icons.
Tue, Nov 19
Left: JuK (Qt Widgets), Right: Elisa (Qt QML)
In QML applications, buttons and line edits are already same height, the same height as QLineEdit in Qt Widgets applications. If we increase the height of QLineEdit, we have to change QML components' height, too. The amount of work will be bigger. If a view contains a lot of QLineEdit/QComboBox rows (like many KCM views), the content might overflow. So it is safer to make button height shorter.
If we do make flat toolbuttons buttons (autoRaise == true) and non-flat buttons the same size, we will need to change the default icon size for all buttons to 22px, or we will have a ton of UI regressions. Any non-flat button with a fixed icon size is going to have a regression. Anyone who was using non-flat buttons with 22px icons to get a bigger clickable area will need to switch to 32px icons. This also means that breeze-icons' problem with 32px icon style consistency will show itself more often.
Mon, Nov 18
+1 conceptually, this will be nice to finally have fixed.
But might the opposite make more sense? If we make buttons shorter, we're slightly reducing their click targets, but if we make line edits taller, all we're doing it reducing unused whitespace.
Plus in the screenshot it looks like it's still not quite the same height.
Thanks! Can you add an explanation in the description section of this patch as to why you're removing the Description strings?
Keep old translations
Move string changes to another patch
Shorten POTD provider names and remove descriptions that are never used anywhere.
Another approach is to shorten the texts:
Sun, Nov 17
Fri, Nov 15
Thu, Nov 14
I also tried to not use ScrollView but enable ListView's scrollbar:
Thanks for the tip. It seems added the border, but when scrolling, the top border or bottom border disappear. It cannot show full border at all sides.
Enable keyboard navigation and proper highlight
Maybe the border of ScrollView is missing in breeze theme. I checked some other widgets, like network manager:
Wed, Nov 13
Add QQC2 namespace
Fri, Oct 25
Merge kmaterka's patch D24853
Oct 20 2019
Oct 18 2019
Validate QUrl of image
Oct 17 2019
Still broken, I'm afraid. Among the console output is the following, which may be helpful:kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg")
Change back to the original page URL
Oct 16 2019
kf5-network.directory has been added to plasma-workspace.
Oct 12 2019
*.exe should be normal executable in Windows
Oct 9 2019
Oct 7 2019
It is now working. The condition is so complex. Please help test this patch!
Fix *.exe execution condition
"openAsExecute" parameter for ExecutableFileOpenDialog
I just realized that this patch might be unfinished. In the pop up, you usually have "Open", "Execute" and "Cancel". But for *.exe, "Open" is actually to be executed by Wine? "Execute" will do nothing because it isn't a native executable for Linux/BSD.
Maybe can we check to see if WINE is installed or if there's a handler for application/x-ms-dos-executable? Otherwise if you don't have WINE installed, won't you see a dialog that gives you the option to execute it when that doesn't work?
Oct 6 2019
They can easily rename/link the icon. Correct semantic naming can improve the icon design. In a long view, having the same naming from the freedestop.org specification, to KDE categories, to icons, can reduce confusion.
Change icon name to applications-network
Oct 5 2019
Oct 4 2019
If I install amor, it would be shown in both Games and Games > Toys. This patch will let it only shows in Games.
In case Amusement is under other primary category, let it be placed in its actually primary category, rather than force it in Games.
In RPM package groups, Amusement is a top level category and Game is its child category. So a game can be categorized as Amusement/Game/Other.
Oct 3 2019
Have you contacted Valve to tell them amusement is the wrong category for Steam?
Because the spec says Amusement - > a simple amusement
And that's not what steam is
IMHO this patch is wrong and steam is what needs fixing.
Sep 27 2019
I track down the issue and the source is this line in konsole:
Sep 19 2019
I submitted it to GitLab/Invent. Close this.
Sep 18 2019
This really needs to be fixed in Qt. 5.13.1 has an overhaul of the system, please make sure that the patch is still required there and does not make things worse.
And please report positioning issues that you can reproduce in https://bugreports.qt.io/browse/QTBUG-77086
Sep 17 2019
Better code style
What happens if e.g. vi or another text editor is open? Do we send the cd... command then to the editor?
I think send terminal input this way is inherently flawed.