Feed Advanced Search

Yesterday

guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

I checked all KCM modules, the bottom row of buttons are all in same height (like the smaller button in your screenshot). Have you tried reboot?

Wed, Nov 20, 7:19 PM · Plasma
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

@ngraham which applications are they? I didn't see similar thing in my system.

Wed, Nov 20, 6:27 PM · Plasma
guoyunhe updated the summary of D25381: Make QPushButton/QToolButton the same height as QLineEdit.
Wed, Nov 20, 4:30 PM · Plasma
guoyunhe updated the diff for D25381: Make QPushButton/QToolButton the same height as QLineEdit.

Force height consistency

Wed, Nov 20, 4:30 PM · Plasma
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

The remaining 1px difference between QPushButton and QLineEdit is caused by content. QLineEdit directly expands from its content size, while QPushButton calculate size of text metrics and icons.

Wed, Nov 20, 12:54 PM · Plasma
guoyunhe updated the summary of D25381: Make QPushButton/QToolButton the same height as QLineEdit.
Wed, Nov 20, 12:49 PM · Plasma

Tue, Nov 19

guoyunhe committed R883:1556584: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Tue, Nov 19, 11:25 PM
guoyunhe committed R883:1556583: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Tue, Nov 19, 11:24 PM
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

Left: JuK (Qt Widgets), Right: Elisa (Qt QML)

Tue, Nov 19, 2:57 PM · Plasma
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

In QML applications, buttons and line edits are already same height, the same height as QLineEdit in Qt Widgets applications. If we increase the height of QLineEdit, we have to change QML components' height, too. The amount of work will be bigger. If a view contains a lot of QLineEdit/QComboBox rows (like many KCM views), the content might overflow. So it is safer to make button height shorter.

Tue, Nov 19, 12:02 PM · Plasma
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

If we do make flat toolbuttons buttons (autoRaise == true) and non-flat buttons the same size, we will need to change the default icon size for all buttons to 22px, or we will have a ton of UI regressions. Any non-flat button with a fixed icon size is going to have a regression. Anyone who was using non-flat buttons with 22px icons to get a bigger clickable area will need to switch to 32px icons. This also means that breeze-icons' problem with 32px icon style consistency will show itself more often.

Tue, Nov 19, 9:00 AM · Plasma

Mon, Nov 18

guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

+1 conceptually, this will be nice to finally have fixed.

But might the opposite make more sense? If we make buttons shorter, we're slightly reducing their click targets, but if we make line edits taller, all we're doing it reducing unused whitespace.

Mon, Nov 18, 9:39 PM · Plasma
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.
In D25381#564378, @GB_2 wrote:

Plus in the screenshot it looks like it's still not quite the same height.

Mon, Nov 18, 9:09 PM · Plasma
guoyunhe added reviewers for D25381: Make QPushButton/QToolButton the same height as QLineEdit: Breeze, Plasma.
Mon, Nov 18, 9:08 PM · Plasma
guoyunhe updated the test plan for D25381: Make QPushButton/QToolButton the same height as QLineEdit.
Mon, Nov 18, 9:07 PM · Plasma
guoyunhe requested review of D25381: Make QPushButton/QToolButton the same height as QLineEdit.
Mon, Nov 18, 9:04 PM · Plasma
guoyunhe added a comment to D25354: Fix POTD config ComboBox display issue in Lock Screen KCM.

5.17 branch please.

Mon, Nov 18, 4:39 PM · Plasma
guoyunhe updated the diff for D25369: Shorten POTD provider names and remove description that is not used anywhere.

Fix typo

Mon, Nov 18, 3:58 PM · Plasma
guoyunhe added a comment to D25369: Shorten POTD provider names and remove description that is not used anywhere.

Thanks! Can you add an explanation in the description section of this patch as to why you're removing the Description strings?

Mon, Nov 18, 3:54 PM · Plasma
guoyunhe updated the summary of D25369: Shorten POTD provider names and remove description that is not used anywhere.
Mon, Nov 18, 3:54 PM · Plasma
guoyunhe updated the diff for D25369: Shorten POTD provider names and remove description that is not used anywhere.

Keep old translations

Mon, Nov 18, 3:49 PM · Plasma
guoyunhe updated the diff for D25354: Fix POTD config ComboBox display issue in Lock Screen KCM.

Move string changes to another patch

Mon, Nov 18, 3:24 PM · Plasma
guoyunhe updated the summary of D25369: Shorten POTD provider names and remove description that is not used anywhere.
Mon, Nov 18, 3:23 PM · Plasma
guoyunhe added reviewers for D25369: Shorten POTD provider names and remove description that is not used anywhere: Plasma, ngraham.
Mon, Nov 18, 3:22 PM · Plasma
guoyunhe requested review of D25369: Shorten POTD provider names and remove description that is not used anywhere.
Mon, Nov 18, 3:21 PM · Plasma
guoyunhe updated the diff for D25354: Fix POTD config ComboBox display issue in Lock Screen KCM.

Shorten POTD provider names and remove descriptions that are never used anywhere.

Mon, Nov 18, 1:09 PM · Plasma
guoyunhe added a comment to D25354: Fix POTD config ComboBox display issue in Lock Screen KCM.

Another approach is to shorten the texts:

Mon, Nov 18, 12:58 PM · Plasma

Sun, Nov 17

guoyunhe updated the summary of D25354: Fix POTD config ComboBox display issue in Lock Screen KCM.
Sun, Nov 17, 2:05 PM · Plasma
guoyunhe added a reviewer for D25354: Fix POTD config ComboBox display issue in Lock Screen KCM: Plasma.
Sun, Nov 17, 2:04 PM · Plasma
guoyunhe requested review of D25354: Fix POTD config ComboBox display issue in Lock Screen KCM.
Sun, Nov 17, 2:03 PM · Plasma

Fri, Nov 15

guoyunhe added reviewers for D25319: Fix issues from D24798 comments by @davidedmundson: Plasma, davidedmundson.
Fri, Nov 15, 9:21 AM · Plasma
guoyunhe requested review of D25319: Fix issues from D24798 comments by @davidedmundson.
Fri, Nov 15, 9:21 AM · Plasma

Thu, Nov 14

guoyunhe added a comment to D24798: Migrate QQC1 to QQC2.

I also tried to not use ScrollView but enable ListView's scrollbar:

Thu, Nov 14, 1:16 PM · Plasma
guoyunhe updated the diff for D24798: Migrate QQC1 to QQC2.

Thanks for the tip. It seems added the border, but when scrolling, the top border or bottom border disappear. It cannot show full border at all sides.

Thu, Nov 14, 12:32 PM · Plasma
guoyunhe updated the diff for D24798: Migrate QQC1 to QQC2.

Enable keyboard navigation and proper highlight

Thu, Nov 14, 9:16 AM · Plasma
guoyunhe added a comment to D24798: Migrate QQC1 to QQC2.

Maybe the border of ScrollView is missing in breeze theme. I checked some other widgets, like network manager:

Thu, Nov 14, 8:21 AM · Plasma

Wed, Nov 13

guoyunhe updated the diff for D24798: Migrate QQC1 to QQC2.

Prefix QQC2

Wed, Nov 13, 8:56 PM · Plasma
guoyunhe updated the diff for D24798: Migrate QQC1 to QQC2.

Rebase

Wed, Nov 13, 8:23 PM · Plasma
guoyunhe updated the diff for D24798: Migrate QQC1 to QQC2.

Add QQC2 namespace

Wed, Nov 13, 8:08 PM · Plasma

Fri, Oct 25

guoyunhe updated the diff for D24798: Migrate QQC1 to QQC2.

Merge kmaterka's patch D24853

Fri, Oct 25, 8:19 AM · Plasma

Oct 20 2019

guoyunhe updated the summary of D24798: Migrate QQC1 to QQC2.
Oct 20 2019, 10:41 AM · Plasma
guoyunhe added reviewers for D24798: Migrate QQC1 to QQC2: Plasma, Plasma: Workspaces.
Oct 20 2019, 10:40 AM · Plasma
guoyunhe requested review of D24798: Migrate QQC1 to QQC2.
Oct 20 2019, 10:39 AM · Plasma

Oct 18 2019

guoyunhe updated the diff for D24727: Fix NOAA picture of the day provider.

Validate QUrl of image

Oct 18 2019, 10:57 AM · Plasma

Oct 17 2019

guoyunhe added a comment to D24727: Fix NOAA picture of the day provider.

Still broken, I'm afraid. Among the console output is the following, which may be helpful:

kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg")
Oct 17 2019, 6:36 PM · Plasma
guoyunhe updated the diff for D24727: Fix NOAA picture of the day provider.

Change back to the original page URL

Oct 17 2019, 6:29 PM · Plasma
guoyunhe added a comment to D24727: Fix NOAA picture of the day provider.

This doesn't fix the problem for me. :(

Oct 17 2019, 6:26 PM · Plasma
guoyunhe added a reviewer for D24727: Fix NOAA picture of the day provider: Plasma.
Oct 17 2019, 12:50 PM · Plasma
guoyunhe requested review of D24727: Fix NOAA picture of the day provider.
Oct 17 2019, 12:48 PM · Plasma

Oct 16 2019

guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

kf5-network.directory has been added to plasma-workspace.

Oct 16 2019, 10:11 AM · Frameworks

Oct 12 2019

guoyunhe added inline comments to D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Oct 12 2019, 7:16 AM · Frameworks
guoyunhe updated the diff for D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

*.exe should be normal executable in Windows

Oct 12 2019, 7:15 AM · Frameworks

Oct 9 2019

guoyunhe committed R883:1553404: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Oct 9 2019, 8:24 PM
guoyunhe committed R883:1553403: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Oct 9 2019, 8:23 PM

Oct 7 2019

guoyunhe updated the summary of D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Oct 7 2019, 9:16 PM · Frameworks
guoyunhe updated the summary of D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Oct 7 2019, 9:11 PM · Frameworks
guoyunhe added a comment to D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

It is now working. The condition is so complex. Please help test this patch!

Oct 7 2019, 8:41 PM · Frameworks
guoyunhe updated the diff for D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

Fix *.exe execution condition

Oct 7 2019, 8:30 PM · Frameworks
guoyunhe updated the summary of D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Oct 7 2019, 5:34 PM · Frameworks
guoyunhe updated the diff for D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

"openAsExecute" parameter for ExecutableFileOpenDialog

Oct 7 2019, 5:22 PM · Frameworks
guoyunhe added a comment to D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

I just realized that this patch might be unfinished. In the pop up, you usually have "Open", "Execute" and "Cancel". But for *.exe, "Open" is actually to be executed by Wine? "Execute" will do nothing because it isn't a native executable for Linux/BSD.

Oct 7 2019, 3:39 PM · Frameworks
guoyunhe added a comment to D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

Maybe can we check to see if WINE is installed or if there's a handler for application/x-ms-dos-executable? Otherwise if you don't have WINE installed, won't you see a dialog that gives you the option to execute it when that doesn't work?

Oct 7 2019, 3:34 PM · Frameworks
guoyunhe added a reviewer for D24463: Treat "application/x-ms-dos-executable" as executable on all platforms: Frameworks.
Oct 7 2019, 11:12 AM · Frameworks
guoyunhe requested review of D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Oct 7 2019, 11:11 AM · Frameworks

Oct 6 2019

guoyunhe added a comment to D24436: Add applications-network icon for renaming Internet category to Network.

They can easily rename/link the icon. Correct semantic naming can improve the icon design. In a long view, having the same naming from the freedestop.org specification, to KDE categories, to icons, can reduce confusion.

Oct 6 2019, 7:20 PM · Frameworks
guoyunhe updated the diff for D24424: Create kf5-network.directory.

Change icon name to applications-network

Oct 6 2019, 9:41 AM · Plasma
guoyunhe added a dependency for D24424: Create kf5-network.directory: D24436: Add applications-network icon for renaming Internet category to Network.
Oct 6 2019, 9:40 AM · Plasma
guoyunhe added a dependent revision for D24436: Add applications-network icon for renaming Internet category to Network: D24424: Create kf5-network.directory.
Oct 6 2019, 9:40 AM · Frameworks
guoyunhe added a reviewer for D24436: Add applications-network icon for renaming Internet category to Network: Breeze.
Oct 6 2019, 9:39 AM · Frameworks
guoyunhe requested review of D24436: Add applications-network icon for renaming Internet category to Network.
Oct 6 2019, 9:39 AM · Frameworks

Oct 5 2019

guoyunhe added a dependency for D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category: D24424: Create kf5-network.directory.
Oct 5 2019, 2:45 PM · Frameworks
guoyunhe added a dependent revision for D24424: Create kf5-network.directory: D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.
Oct 5 2019, 2:45 PM · Plasma
guoyunhe updated the summary of D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.
Oct 5 2019, 2:44 PM · Frameworks
guoyunhe added a reviewer for D24424: Create kf5-network.directory: Plasma.
Oct 5 2019, 2:44 PM · Plasma
guoyunhe requested review of D24424: Create kf5-network.directory.
Oct 5 2019, 2:43 PM · Plasma
guoyunhe added a reviewer for D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category: Frameworks.
Oct 5 2019, 2:40 PM · Frameworks
guoyunhe requested review of D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.
Oct 5 2019, 2:39 PM · Frameworks
guoyunhe added a comment to D24409: Remove kf5-toys.directory because it will not be used by other packages.

Reverted https://cgit.kde.org/plasma-workspace.git/commit/?id=0e14429e7355e07913ea21ab03abde6dc1ae8a1f

Oct 5 2019, 2:29 PM · Plasma
guoyunhe added a comment to D24409: Remove kf5-toys.directory because it will not be used by other packages.

D24384 has been accepted and seems no one strongly against it... So I landed it. Can you give this patch an approval? @davidedmundson

Oct 5 2019, 12:21 PM · Plasma

Oct 4 2019

guoyunhe updated subscribers of D24409: Remove kf5-toys.directory because it will not be used by other packages.

Ship it (if and only if the other patch is also accepted)

Oct 4 2019, 10:26 AM · Plasma
guoyunhe added a reviewer for D24409: Remove kf5-toys.directory because it will not be used by other packages: Plasma: Workspaces.
Oct 4 2019, 10:22 AM · Plasma
guoyunhe requested review of D24409: Remove kf5-toys.directory because it will not be used by other packages.
Oct 4 2019, 10:22 AM · Plasma
guoyunhe added a comment to D24384: Move Amusement to Games directory instead of Games > Toys.

If I install amor, it would be shown in both Games and Games > Toys. This patch will let it only shows in Games.

Oct 4 2019, 10:05 AM · Frameworks
guoyunhe updated the diff for D24384: Move Amusement to Games directory instead of Games > Toys.

In case Amusement is under other primary category, let it be placed in its actually primary category, rather than force it in Games.

Oct 4 2019, 10:01 AM · Frameworks
guoyunhe added a comment to D24384: Move Amusement to Games directory instead of Games > Toys.

In RPM package groups, Amusement is a top level category and Game is its child category. So a game can be categorized as Amusement/Game/Other.

Oct 4 2019, 9:15 AM · Frameworks
guoyunhe updated the summary of D24384: Move Amusement to Games directory instead of Games > Toys.
Oct 4 2019, 8:30 AM · Frameworks
guoyunhe updated the diff for D24384: Move Amusement to Games directory instead of Games > Toys.

Update description

Oct 4 2019, 8:29 AM · Frameworks

Oct 3 2019

guoyunhe added a comment to D24384: Move Amusement to Games directory instead of Games > Toys.

Have you contacted Valve to tell them amusement is the wrong category for Steam?

Because the spec says Amusement - > a simple amusement

And that's not what steam is

IMHO this patch is wrong and steam is what needs fixing.

Oct 3 2019, 5:22 PM · Frameworks
guoyunhe updated the diff for D24384: Move Amusement to Games directory instead of Games > Toys.

Fix tabs

Oct 3 2019, 11:17 AM · Frameworks
guoyunhe added a reviewer for D24384: Move Amusement to Games directory instead of Games > Toys: Frameworks.
Oct 3 2019, 11:16 AM · Frameworks
guoyunhe requested review of D24384: Move Amusement to Games directory instead of Games > Toys.
Oct 3 2019, 11:15 AM · Frameworks

Sep 27 2019

guoyunhe added a comment to D23998: Fix HiDPI rendering issues with Dual Screen.

I track down the issue and the source is this line in konsole:

Sep 27 2019, 7:11 PM · Kate

Sep 19 2019

guoyunhe added a comment to D23949: Pixel perfect splash art rendering.

I submitted it to GitLab/Invent. Close this.

Sep 19 2019, 12:44 PM · Krita

Sep 18 2019

guoyunhe added a comment to D24034: Fix offset issue in dual hidpi screen.

This really needs to be fixed in Qt. 5.13.1 has an overhaul of the system, please make sure that the patch is still required there and does not make things worse.

And please report positioning issues that you can reproduce in https://bugreports.qt.io/browse/QTBUG-77086

Sep 18 2019, 8:03 AM · Spectacle

Sep 17 2019

guoyunhe updated the diff for D24034: Fix offset issue in dual hidpi screen.

Better code style

Sep 17 2019, 8:54 PM · Spectacle
guoyunhe updated the summary of D24034: Fix offset issue in dual hidpi screen.
Sep 17 2019, 8:14 PM · Spectacle
guoyunhe added a reviewer for D24034: Fix offset issue in dual hidpi screen: Spectacle.
Sep 17 2019, 8:11 PM · Spectacle
guoyunhe updated the summary of D24034: Fix offset issue in dual hidpi screen.
Sep 17 2019, 8:10 PM · Spectacle
guoyunhe requested review of D24034: Fix offset issue in dual hidpi screen.
Sep 17 2019, 8:09 PM · Spectacle
guoyunhe added a comment to D23998: Fix HiDPI rendering issues with Dual Screen.

What happens if e.g. vi or another text editor is open? Do we send the cd... command then to the editor?

I think send terminal input this way is inherently flawed.

Sep 17 2019, 7:18 AM · Kate