I'll wait kurt's comments as I'm sure this is a hack and not a proper fix.

I’ll look the warnings, none of them appear on Gcc. Should be a clazy
warning

@ngraham as this needs input from the VDG
I personally love the idea, I would change the half of the page dimm effect by a thin line on the side (like kdevelop shows for edited lines)

Seriously much. As the splits in master are in no way near what they where
before. But you might consider trying master, you might like the current
split behavior.
(It actually splits).
For the old behavior there was just 2 complaints, your and someone that
talked to me on email, and I’ll ask you the same thing I asked him. Try to
help with patches to have the old behavior back as a mirror tabs feature.
I’m trying to solve as many bugs as I can, but I can’t do that alone :)

can you put a screenshoot of the before / after ? I can't really read math.

ping?

ping?

@pino ping?

The proces of creation / destructiion / management of the views is a bit more complex. I'll gladly accept a patch but one that actually helps to clean the current behavior. This one just hides complexity.

O don’t really get it. Why this code needs to go to MainWindow and not to
TabbedContainer ?
Seems to me that the class that should have knowledge on how to create the
tabs is not mainwindow.

Mind you guys that the internal implementation without a profile is kinda
broken, so this patch makes sense to me.

None, I’m ok with it

In D20466#448806, @mglb wrote:

After thinking about scrollback a bit more I think history file path AND scrollback size should go to global settings. Does anyone use different profiles with different history sizes, or change size just for current session?

In D20466#448705, @ngraham wrote:

In D20466#448704, @hindenburg wrote:

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

Did you mean -1? :P Hiding part of an UI depending on selected option is bad UX. Moving another elements around because something appears is probably even worse.
It is also against KDE HIG: https://hig.kde.org/patterns/content/settings.html#implementation (last point)

About changes:

• Maybe putting custom path field below radio button (and indenting it) would be better? Path which appear here will probably be longer than current field width (at least I think so), and it will not be needed to align it with fixed size field
• All radio buttons had equal vertical spacing, and the left label was aligned to the first radio button
  
• Button group instead of frame
• Maybe kmessagebox instead of label?

Ok, I'll update the code for that.

In D20466#448704, @hindenburg wrote:

A quick test of picking the other 2 save locations ,it doesn't seem to work. The location settings are still stored in konsolerc. Aren't they suppose to be in the .profile file now?

Another way to display this would be to only show the "info box" when unlimited is selected.

In D20466#448705, @ngraham wrote:

In D20466#448704, @hindenburg wrote:

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

• Remove useless lambda

• Add missing label, Add tooltips

Only because I’m forbidden to remove configuration options that exist, for
me this is one of those niche cases that shouldn’t exist.

I tougth about showing the paths but my first tougth was “why do the user
cares where this is being stored”?

This is more future proof as if we change the type of the function we don’t
need to change that return.

We set this variable in two or three different files and in a few different
methods. I remember that one of the first things that I tried to do for
konsole was to simplify the creation of sessions (and this broke a lot of
code and you where not happy) but it seems that we do need to make some
compromise and align that.

I beg your pardon? (How do I test the new session? konsole is working
for me so maybe it's something I missed)

I forgot this for quite a while, I'll update today.

In D20115#447125, @hindenburg wrote:

In D20115#447119, @hindenburg wrote:

The one issue I have, if you open just one tab and press the move left/right I get C for 'move right' and D for 'move left" echoed on the terminal. They go away when I open another terminal and don't appear to return even if I close all but one.

ON master w/o this patch, I still get the CD echoing on all the tabs when I try the shortcuts. So maybe it is something else. Is anyone else seeing this issue?

I'll add a backtrace as soon as I test this again. since I'm succeeding in my konsole code cleanup I'll get this back on track.

too many things to fix here and there. :)

we don't have a clangformat file specified for kde projects, maybe this is
something good to add. I voted for global .editoconfigfiles but I was
outvoted. :)

• Further simplify code

When we have multiple tabs / splits this is not confusing?

this should fix most of the issues. I have another patch to go related to actions, but this one needs to land first.

• Fix action identifiers

@ngraham can you accept even with the shortcut issue that you are having? I have other reviews that depend on this one. I promise you to fix the shortcut bug <3

• Use reference with range for loops

ping?

ping?

the adition of the phabricator configuration file is unrelated to a clean, please split in two patches.

the specific warning is https://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

I believe that he builds in clang and clang 8 added quite a bunch of new
warnings

true, but then the instance is there anyway. what we gain from this?

Hm? This doesn’t touches that.