• Use reference with range for loops

ping?

ping?

the adition of the phabricator configuration file is unrelated to a clean, please split in two patches.

the specific warning is https://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

I believe that he builds in clang and clang 8 added quite a bunch of new
warnings

true, but then the instance is there anyway. what we gain from this?

Hm? This doesn’t touches that.

waiting for @hindenburg ok before landing. :)

• Better variable name

• Whitespace / Todos removal

In D20224#445957, @ngraham wrote:

This seems to fix the issue I started having recently where Konsole crashes at logout and then opens as a big white window on login after session restoration.

sorry, my mistake. this is correct.
https://en.cppreference.com/w/cpp/language/initializer_list#Delegating_constructor

that looks factually wrong. what are you trying to accomplish here?

Session Save / Restore

OpenMP is missing, Andre is working on it.

This code can load sessions, it has a better behavior than the old session load code, but still has bugs. I'll finish this luckly today / tomorrow.

• Sessions partially working
• Code cleanup

I'll remove the debugs / message handlers as soon as everything is working. but it's one of the fastest ways for me to keep the debug messages between runs so I can understand what's wrong.
the session is correctly saved, and the SessionManager correctly loads all the sessions back, the ViewManager however is broken on load. that's what I'm debugging now. so even tougth we don't display any terminal, they are up and running.

• messageHandler + tons of debug
• Sabe json correctly in the configuration

Well, I finally managed to discover something:
when MainWindow::saveProperties is triggered we already destroyed the sessions and tabs, and that's the reason it's not saving anything.
I'm trying to debug the destructor order now to see if I can change something.

• Implement the Load of Sessions
• Solve crash while quitting konsole via Session End
• Still Broken, do not review unless you can help. :)

The code for sessions is commented out, in the original review you said
that you would help me see the saving the session code as now we have to
deal with splits.

• Remove empty line

This is mostly working, but I will not merge this untill we fix the current state of the shortcuts (that I'm preparing in a separate patch).
after the shortcuts are correct, there will be a follow up patch here to use the switcher style *or* the next-prev-tab style (as we have today) selectable by the user, defaulting to the current behavior.

• Simplify handling of code
• Handle list with the shortcut selected
• Mostly working
• Remove mnemonics from text

I’m in a konsole spree this week so expect patches.

how that the splits are merged, I'm preparing a round of patches that where rotting in my pc.

• Use one liners where appropriate.
• Remove sender() and QVariant() conversions
• Declare + initialize, instead of setting the value later
• Don't create unecessary temporaries
• Extract code from huge function into a smaller one

-1 gettext is c code, should not use c++ includes.

I'm using this now for months without problems, I know that people have different usecases but I belive that this is stable enough to land in master, giving us enough time to kill all the bugs for the next release.
and also to minimize the amount of possible breaks.

• Remove deprecated code
• Refactor to reduce the number of boilerplate
• Fix updating the detach menus
• Fix creation of splits in the middle of the grid
• Properly count the number of Terminals
• Remove unused function - a findChildren is what it's needed
• Call directly, lambda is uneeded here.
• don't copy the map
• Fix rebase
• Fix rebase
• Update Konsole Rc version
• Connect signals directly without lambdas
• Resize instead of setting the geometry

not dead, just crazy at life.

omp is a new dependency, so it should be added to cmake.
https://cliutils.gitlab.io/modern-cmake/chapters/packages/OpenMP.html

pushed the revert to both master / applications 19.04

I'll revert and reply on a dev branch

Pino, it doesn't. If you enabled the debug messages the code wouldn't
compile as the code that happened with the debug messages where actually
broken.

Will do that today

• Remove deprecated code
• Refactor to reduce the number of boilerplate
• Fix updating the detach menus
• Fix creation of splits in the middle of the grid
• Properly count the number of Terminals
• Remove unused function - a findChildren is what it's needed
• Call directly, lambda is uneeded here.
• don't copy the map
• Fix rebase
• Fix rebase
• Update Konsole Rc version
• Connect signals directly without lambdas

In D19645#428711, @apol wrote:

That's not how we deprecate in C++.

You'll want to use ANALITZAPLOT_DEPRECATED_EXPORT on the method declaration.

Sorry for the abscense, I was in vacations in brazil for three weeks
without a computer.
I just got back home (like, yesterday), and I also just bougth a new
computer (after 10 years, yey). What I'm doing right now is to setup my KDE
dev environment and compile everything.

thats Easy to fix but I’d say that the current way is more “expected”. Nate?

Em ter, 5 de mar de 2019 às 18:36, Dāvis Mosāns <noreply@phabricator.kde.org>
escreveu:

• Remove deprecated code
• Refactor to reduce the number of boilerplate
• Fix updating the detach menus
• Fix creation of splits in the middle of the grid
• Properly count the number of Terminals
• Remove unused function - a findChildren is what it's needed
• Call directly, lambda is uneeded here.
• don't copy the map
• Fix rebase
• Fix rebase

I’m ok with it.

• More guards removed.
• Remove unused include

• Fix compilation

already merged and a followup was also merged fixing the issues related by @broulik

@hindenburg ping?

• Fix code style
• re-add assert
• Fix code style

In D18575#401418, @ngraham wrote:

No other KDE app does this

That's not true. Kate and Gwenview do this too, and for good reason: without this warning, there's no way to know how to get the menu bar back again if you remove it by accident and/or don't know about the ctrl+m shortcut.

Konsole doesn't show a warning because it's a power user app; presumably the user knows what he/she is doing. Dolphin doesn't have this warning because it automatically creates a menu-like toolbar button when the menubar is hidden, which is an acceptable alternative. But for apps that don't do this or something else (e.g. putting the menubar in the titlebar instead) we need to show an ugly warning like this.

There are two different patches for that, one from myself that adds a dim
effect (that Kurt asked to remove from this change set) and another one
that implements a header, also in a different review (but not from myself
and I don’t have the review number on my head).

Be my guest