Can you please commit on my behalf?
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Sep 15 2019
Jun 2 2019
Opened distinct PR D21547.
I failed to request changes for D16648#inline-121014.
This is bound to randomly exhibit strange behaviour.
I was about to suggest about the same, but ngraham beat me to it.
If it is easy to find out which Activity/VD a Dolphin window belongs to, then additionally filtering for those values in
Dolphin::attachToExistingInstance
should do the trick.
Reopening because I believe this is broken in combination with activities.
Jan 13 2019
What is the default protocol when not set explicitly? Does the default allow SslV2 and/or SslV3?
I liked TlsV1_0OrLater better...
Nov 30 2017
I can not. Maybe you can ping @apol.
Nov 29 2017
MprisPlayer.Seek() is the only one starting with a capital.
Then ship it.
More suggestions:
MprisPlugin.sendAction(), MprisPlugin.setVolume(), MprisPlugin.setPosition(), MprisPlugin.seek() look quite alike and could be collapsed.
Add MprisPlayer.next(), MprisPlayer.previous() and MprisPlayer.playPause() in favour of sendAction("MAGIC").
Nov 28 2017
I think you should give MprisPlayer a reference to MprisPlugin and move the setters into MprisPlayer too.
Then change MprisActivity.targetPlayer to be a MprisPlayer.
Nov 7 2017
Oct 16 2017
Sep 24 2017
Sep 22 2017
In D7922#147893, @nicolasfella wrote:I would be ok with keeping the KMix codepath, but I think its quite a corner-case since most people use pulseaudio anyway. If we keep it we should make sure people are aware that they need pactl OR kmix for that feature. I am not aware that Kmix is a dependency on any distro (I wasn't even aware that we have this feature until yesterday :D)
I am totally fine with kmix support being removed. Please disable the option in the UI when it will not work if at all possible. It will prevent grieve for the dying breed of pulseaudio deniers.
I took a quick look on how to do this with ALSA:
- amixer set Master mute
- amixer set Master unmute
Sorry for the fuss. I do not have this option enabled. Just got scared there for a second.
I know I am in the minority, but pulseaudio just does not work with dolby digital and dts on my system.
Please retain the functionality with kmix.
Can you maybe #ifdef it with a PULSEAUDIO_ENABLED option or check on ${PACMD} STREQUAL "PACMD-NOTFOUND"?
Sep 5 2017
Please commit.
Thank you!
Sep 4 2017
Aug 7 2017
Aug 5 2017
Jul 17 2017
fixes the problem for me on gentoo using ocaml-4.04.2
Feb 12 2017
Alternative tokens [lex.digraph] are standard c++ and have been since it's was standardized (and I don't know of any plan to deprecate them). They are a accessibility feature, since not every keyboard has those keys.
Disabling operator names makes it impossible to include a header file which uses them in an template, inline or constexpr function. Since it is also not possible to re-enable operator names in icc and clang this seems less like a 'discouragement' than a force.
Making three(!) compilers diverge from the standard and forcing users of ECM to diverge too because MSVC needs a switch to follow the standard is in my opinion a bad idea.
A standards conformant compiler is a requirement for portability, not a limit.