Thanks Toni, I missed that.

@gengisdave , I don't see this merged. Forgotten?

@asensi , would you like to rebase the change in your fork and create a pull request on GitLab? My VM is working now and it's a useful change - I could help to review and test it.

This is a right thing to do (connect before calling the emitting method). I just have a request to simplify the comment - something like "don't rely on return value of openUrl as the call is async in general". Thanks!

In T10827#213556, @adiaux wrote:

@nmel @gengisdave Could you give me some pointers on where to start with the revamp.

3rd opinion. I agree it should be shown only if the file is actually going to be hidden (Show Hidden is off in settings), otherwise Krusader looks dumb. I agree that users should be able to disable the warning, because for us it may look like an uncommon operation, however some users may work with dot files extensively. This kind of attention to small details make a huge difference in user experience.

Works great and the code looks clean and neat! Thanks for working on this.

In D22957#514005, @asensi wrote:

a) Under non-Windows operating systems: The "#ifndef Q_OS_WIN or #else block after #ifdef Q_OS_WIN" code paths have to work (as they did before this commit), because Q_OS_WIN is not defined there now, nor Q_WS_WIN was defined there previously.
b) Under Windows operating systems is where the behavior has to change (the Q_OS_WIN code paths are aimed to work, because Q_OS_WIN is defined there).

This diff contains combined changes on two separate repositories. Phabricator will have a problem with this kind of change. Please split into two reviews. I'm ok with the content.

Reviewed and tested (I'm using Plasma) - works good. Thanks for the fix, Alex!

Reviewed and tested - works good. Thanks for the fix, Toni!

The first screenshot looks better than others, IMO.

It can be restored from git history in case it's needed. It's your call.

I also have seen it when I tested published changelog files and wanted to remove it. Thanks for bringing my thoughts to live. :)

Reviewed and tested - all good! Thanks for the fix, Toni!

• updated SHA256 checksum

In D23309#516339, @pino wrote:

In D23309#516337, @yurchor wrote:

The only problem with https://krusader.org/get-involved/ is that it is even more conservative than our user docs

https://cgit.kde.org/websites/krusader-org.git/
Just open a review request for that repository (or commit directly), it is not complicated...

Please always open a review! Committed and pushed changes are deployed directly to live site. People make mistakes, it's normal, and reviews reduce the likelihood of a mistake.

Thanks everyone!

For example, you can fork krusader on github or other platform [...]. What do you think about this idea, Toni?

I don't think people would find it, Nikita.

When I see the usage of the method, like

const float fontWidth = (fm.QFONTMETRICS_WIDTH("WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW") - fm.QFONTMETRICS_WIDTH("W")) / 99.0;

or

headerView->resizeSection(KrViewProperties::Ext, QFontMetrics(_viewFont).QFONTMETRICS_WIDTH("tar.bz2  "));
headerView->resizeSection(KrViewProperties::KrPermissions, QFontMetrics(_viewFont).QFONTMETRICS_WIDTH("rwx  "));
headerView->resizeSection(KrViewProperties::Size, QFontMetrics(_viewFont).QFONTMETRICS_WIDTH("9") * 10);

which are all dirty hacks, I doubt we need to care too much about the differences mentioned. This code needs to be refactored properly but it's not a goal of this change. QFONTMETRICS_WIDTH will actually become a good marker of the places that need review if someone will find time and courage to make it right one day...

This is a very serious change because now #ifndef Q_OS_WIN or #else block after #ifdef Q_OS_WIN will include the code that previously was ignored. We must look at all those code paths and test features it affects. BTW, does it mean that some of those code paths do not work correctly in the current state?

Good catch, Toni! No objections for the new shortcut. Please look into

1. Making the commit headline shorter. Something like "Changed shortcut for the embedded terminal emulator". It's easier to read in the graph view. Please keep everything else, it's very good to have a detailed explanation in the commit message!
2. Specifying CHANGED: tag, so this is not missed in the ChangeLog on the next release.

I have no problem when someone is trying to improve a dead branch. If the person finds this useful and wants to share their changes to others — he or she is welcome to do so. It's an Open Source after all. In the same time, I understand what Luigi is saying that it might send a wrong signal to users. In addition, commits we push to the official repo are reviewed and tested, and should be only pushed when approved by at least another dev and no objections from others (unfortunately, it's not enforced due to a weak infrastructure). It means someone needs to test the changes you propose in 10 code reviews. Personally, I have no interest in kde4 commits anymore and even have no environment to test it. I doubt you'll find another dev who has.

Related review: D23197 (same changelog)

Hi Toni,

Updated AppStream files. Thanks Luigi and Toni!

• Updated AppStream files with previous and upcoming release info

@yurchor, this was fast! Thanks!

Please review by August 10, EOD. Thanks!

It's a useful feature for people that like to keep their environment clean. Thanks for working on this, Toni!

If you'd like this fix to be included in v2.7.2, please push it to master by Aug 4 and I'll backport to stable. Please don't forget to specify BUG, FIXED, Differential Revision tags in the commit message.

If you'd like this fix to be included in v2.7.2, please push it to master by Aug 4 and I'll backport to stable. Please don't forget to specify BUG, FIXED, Differential Revision tags in the commit message.

It works properly now - thanks!
I checked the commit you mentioned in the bug. Before it the checkbox was still ignored but the links were always not followed.

It works and I'm fine with the proposed fix. Thanks Toni!