In D26599#615844, @hindenburg wrote:Thanks, if you can in the future do gitlab merge requests. We can still do these phabricator until they shut it down.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Feb 23 2020
Feb 23 2020
Jan 12 2020
Jan 12 2020
Jul 15 2019
Jul 15 2019
knambiar added a comment to D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami.
The Scale slider UI position is different in X11 and Wayland. Is this intentional?
Jun 20 2019
Jun 20 2019
In D21915#482145, @aacid wrote:The other question is if "enabled" was ever the correct atom to check for
libinput Tapping Enabled
May 29 2019
May 29 2019
Tested, LGTM.
May 27 2019
May 27 2019
Super!
May 25 2019
May 25 2019
Would be easier to test this change if it is rebased against current master, as many changes landed in annotationwidgets.{h,cpp} recently.
This change doesn't cleanly apply on the current master branch. Would you rebase the changes, or is there a branch it could be built against (I don't see annotation-toolbar branch yet)?
knambiar updated the diff for D21332: Okular Annotation: add line start/end style config only for Straight Line tool.
Add Q_ASSERT for the configs.
May 24 2019
May 24 2019
knambiar added inline comments to D21332: Okular Annotation: add line start/end style config only for Straight Line tool.
knambiar updated the diff for D21332: Okular Annotation: add line start/end style config only for Straight Line tool.
Fix crash, m_{start,end}StyleCombo are guarded by m_lineType == 0 check for Straight Line tool.
May 23 2019
May 23 2019
knambiar added a comment to D21332: Okular Annotation: add line start/end style config only for Straight Line tool.
In D21332#468893, @tobiasdeiminger wrote:Btw., can we do polylines yet? The only way I found was to tweak engine points attribute for tool type straight-line in ~/.config/okularpartrc.
knambiar updated the diff for D21332: Okular Annotation: add line start/end style config only for Straight Line tool.
Rebase against current master
May 22 2019
May 22 2019
knambiar added a comment to D21238: Okular Annotation: add support for line start style for Straight Line tool.
In D21238#468127, @tobiasdeiminger wrote:@knambiar The config dialog for polygon annotations has seemingly regressed with recent changes:
May 18 2019
May 18 2019
knambiar updated the diff for D21238: Okular Annotation: add support for line start style for Straight Line tool.
Whitespace fix
knambiar updated the diff for D21238: Okular Annotation: add support for line start style for Straight Line tool.
Use const QString & instead of auto in range loop
May 16 2019
May 16 2019
Review D21238 created for the line start style.
May 14 2019
May 14 2019
In D21092#464202, @tobiasdeiminger wrote:@knambiar
Rajeesh, would you be around for another patch? PDF / poppler allow to draw arrows on both ends of a line (aka start style, end style). Your patches currently target only the line end. Would you implement "start style" in the UI too?
May 11 2019
May 11 2019
Drop the combobox change
May 10 2019
May 10 2019
Use QOverload instead of static_cast
May 9 2019
May 9 2019
knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.
In D20760#462808, @tobiasdeiminger wrote:There's another problem we haven't discussed yet: Line endings work only if you have poppler >= 0.72 installed, else they will be silently ignored. Version 0.72 is quite recent, a lot of people won't have it because their distro ships an older version. Should we try to handle this? If yes, how? We can use cmake to detect poppler version, but I don't see an easy way to propagate the information from generator to UI at runtime.
knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.
In D20760#462747, @aacid wrote:Please fix the connect to use the new connect syntax,
May 7 2019
May 7 2019
knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.
In D20760#462025, @sander wrote:I committed the patch, but without any icons at all. Even without them I think the patch is very helpful. The icons can now be added at ease in a separate patch.
Rajeesh, thanks for the patch. I'd be happy to see more of your patches in the future.
May 4 2019
May 4 2019
knambiar updated the diff for D20760: Okular Annotation: add support for line ending style for Straight Line tool.
Use QStringLiteral with Unicode code points for line ending symbols.
Apr 26 2019
Apr 26 2019
knambiar updated the diff for D20760: Okular Annotation: add support for line ending style for Straight Line tool.
Add tooltips to clarify the line ending style works only for PDF documents.
Apr 25 2019
Apr 25 2019
knambiar updated the diff for D20760: Okular Annotation: add support for line ending style for Straight Line tool.
Place the symbols to left of ending style description for better alignment.
Apr 24 2019
Apr 24 2019
knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.
In D20760#455351, @tobiasdeiminger wrote:So your drop down selection will currently be ignored for EPUB, DjVu, ..., only PDF works. @ngraham: Do you think the patch could land as PDF-only, or do we need multi-format support from the beginning?
knambiar updated the diff for D20760: Okular Annotation: add support for line ending style for Straight Line tool.
Merge the two commits (previous revision update had only the second change).
knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.
In D20760#455290, @tobiasdeiminger wrote:Nice patch! Guess unicode symbols are good for a start.
knambiar updated the diff for D20760: Okular Annotation: add support for line ending style for Straight Line tool.
Add Unicode symbols to the line ending style. Didn’t find suitable symbols for ‘Right Closed Arrow’ and ‘Slash’.
knambiar added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.
In D20760#455010, @ngraham wrote:Hey, that's pretty cool! Any chance you could include a little icon/preview of the visual style for each item in the combobox?
Apr 23 2019
Apr 23 2019
knambiar updated the summary of D20760: Okular Annotation: add support for line ending style for Straight Line tool.
Apr 5 2019
Apr 5 2019
knambiar added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee for bugs to the Touchpad-KCM product.
Apr 4 2019
Apr 4 2019
knambiar updated subscribers of D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D
Hey, I would be happy to take that responsibility.
Apr 2 2019
Apr 2 2019
knambiar added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
Got to Know a lot about how X works with input handling. XD
Feb 23 2019
Feb 23 2019
How about "Trusted" for remembered devices that are authorized, and "Prohibited" for remembered devices that are not authorized?
"Remembered" would work only if it's clear what's being remembered (i.e. the settings). Maybe it could say "Settings remembered" or something?
Feb 10 2019
Feb 10 2019
knambiar committed R436:8b0d28aa8eec: Add the default (Ctrl+n) shortcut to open new connection in KRDC (authored by knambiar).
Add the default (Ctrl+n) shortcut to open new connection in KRDC
D17327: KRDC: add default shortcut to open new connection now requires review to proceed.
In D17327#408625, @alexeymin wrote:I tested, compiles and works, does not open any new windows for me, just focuses address input (I don't have any connections configured). Looks harmless overall, +1
Feb 9 2019
Feb 9 2019
Sorry about the wrong path in previous diff. Please find the updated one.
knambiar added a reviewer for D17327: KRDC: add default shortcut to open new connection: KDE Applications.
Dec 3 2018
Dec 3 2018
Sep 26 2018
Sep 26 2018
Jul 14 2018
Jul 14 2018
May 27 2018
May 27 2018
- "Two tap right, three middle" -> "Tap twice for right-click; three times for middle-click"
- "Two tap middle, three right" -> "Tap twice for middle-click; three times for right-click"
May 14 2018
May 14 2018
I don't have commit access (or so I believe), would you commit the changes? Thanks.
May 11 2018
May 11 2018
May 2 2018
May 2 2018
Apr 28 2018
Apr 28 2018
Feb 14 2018
Feb 14 2018
+1.
I've also spent some time debugging this issue, and was perplexed why the property change event doesn't propagate. This fix should be backported if possible.
Sep 8 2017
Sep 8 2017
In D2754#143319, @aacid wrote:So what's the status of this? needs landing? needs help?
Dec 28 2016
Dec 28 2016
knambiar added a comment to D3829: [touchpad] Use a separate X11 Display to monitor the XInput event..
Might this change fix this issue? https://bugs.kde.org/show_bug.cgi?id=370588
Dec 8 2016
Dec 8 2016
A query about the dbus calls in findTouchpads().
Sep 13 2016
Sep 13 2016
Thanks for the review, but actually I am not convinced that this gets rid of the warning message. Sifting through the KF5 porting notes, I am not sure how this should be handled -- kded tries to load the plugin with just "name" and if not found it looks for "kded_name", which succeeds and emits this warning.
Any suggestions what should be the right approach with KPluginLoader? Should it be always fed with JSON plugin metadata?
Sep 12 2016
Sep 12 2016
knambiar retitled D2754: Touchpad KDED: fix metadata warning from to Touchpad KDED: fix metadata warning.
Apr 29 2016
Apr 29 2016
knambiar committed R120:0e2af335dcd1: [Media Controller[: Fix playing next/previous song seeking (authored by knambiar).
[Media Controller[: Fix playing next/previous song seeking
Mar 9 2016
Mar 9 2016
Merge branch 'Plasma/5.6'
knambiar committed R119:86b59198f1c6: Touchpad KCM: Fix synaptics driver issues Fixes couple of issues: 1. Remove… (authored by knambiar).
Touchpad KCM: Fix synaptics driver issues Fixes couple of issues: 1. Remove…