Feed Advanced Search

Feb 8 2019

davidedmundson added a comment to D18810: [platforms/hwcomposer] Add scaling support.

I also want to generalize initial output description to being setup with a list of parameters and reading in config files in json format (and falling back to KScreen config files; that way we wouldn't have ugly mode switches on startup

Feb 8 2019, 3:42 PM · KWin
davidedmundson committed R295:ab33762a6a60: Sync QML module padding to reflect system setting pages (authored by davidedmundson).
Sync QML module padding to reflect system setting pages
Feb 8 2019, 2:40 PM
davidedmundson closed D18739: Sync QML module padding to reflect system setting pages.
Feb 8 2019, 2:40 PM · Frameworks
davidedmundson accepted D18850: [kcmkwin/compositing] Delete unused config headers.
Feb 8 2019, 2:16 PM · KWin
davidedmundson added a comment to D18810: [platforms/hwcomposer] Add scaling support.

I can do, but I'll explain my rationale for this first.

Feb 8 2019, 1:53 PM · KWin
davidedmundson added a comment to D18376: Fix software cursors with drm backend.

Instead of emitting cursorChanged from DrmBackend, modify SceneOpenGL to connect Platform::cursorChanged as opposed to Cursor::cursorChanged to the cursor texture update function.

Feb 8 2019, 1:19 PM · KWin
davidedmundson accepted D18768: Extend Open Document thumbnailer to Open Packaging Conventions format.
Feb 8 2019, 12:20 PM · Frameworks, Dolphin
davidedmundson updated the diff for D18739: Sync QML module padding to reflect system setting pages.

more hacks

Feb 8 2019, 12:04 PM · Frameworks
davidedmundson requested changes to D18768: Extend Open Document thumbnailer to Open Packaging Conventions format.

It seems we can get the correct path via the _rels file as per
https://en.wikipedia.org/wiki/Open_Packaging_Conventions

Feb 8 2019, 11:47 AM · Frameworks, Dolphin
davidedmundson added a comment to D18739: Sync QML module padding to reflect system setting pages.

Running kcmshell5 icons style was a good suggestion.

Feb 8 2019, 11:26 AM · Frameworks
davidedmundson updated the diff for D18739: Sync QML module padding to reflect system setting pages.

remove hardcoded value

Feb 8 2019, 11:26 AM · Frameworks
davidedmundson updated the diff for D18739: Sync QML module padding to reflect system setting pages.

update

Feb 8 2019, 11:21 AM · Frameworks
davidedmundson added a comment to D18844: Fix opening toolbox button.

That framework change is released tomorrow, right? Is it worth reverting?
Including this, that's at least the second regression it's caused, which makes me worry there's even more we haven't found.

Feb 8 2019, 10:39 AM · Plasma
davidedmundson accepted D18840: [Containment Actions Configuration] Fix changing plugin.
Feb 8 2019, 9:55 AM · Plasma
davidedmundson added inline comments to D18840: [Containment Actions Configuration] Fix changing plugin.
Feb 8 2019, 9:29 AM · Plasma
davidedmundson accepted D18805: Workaround for the bug 393630 - SystemTray part.
Feb 8 2019, 4:58 AM · Plasma

Feb 7 2019

davidedmundson requested changes to D18805: Workaround for the bug 393630 - SystemTray part.

I really don't know that sharing model between contexts cause a such behavior.

Feb 7 2019, 4:06 PM · Plasma
davidedmundson added inline comments to D18809: Image Wallpaper Slideshow - display the list of images that will be shown.
Feb 7 2019, 3:29 PM · Plasma
davidedmundson accepted D18774: Move lanczos filter away from KWin core.
Feb 7 2019, 3:18 PM · KWin
davidedmundson added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

Maybe change the subject line to start with [kcmkwin/kwindecoration] though we don't have a very good policy on this.

Feb 7 2019, 3:15 PM · KWin
davidedmundson added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

and removed the paddings from this patch's main.qml.

Feb 7 2019, 2:28 PM · KWin
davidedmundson added a comment to D18814: Clarify the label of the Shell KRunner..

What problem are we solving?

Feb 7 2019, 2:07 PM · Plasma
davidedmundson added a comment to D18814: Clarify the label of the Shell KRunner..

It already says "Command line" in the group title on the left a console icon and unlike apps has the prefix "Run "

Feb 7 2019, 2:05 PM · Plasma
davidedmundson retitled D18810: [platforms/hwcomposer] Add scaling support from [plugins/platforms/hwcomposer] Add scaling support to [platforms/hwcomposer] Add scaling support.
Feb 7 2019, 2:00 PM · KWin
davidedmundson retitled D18808: [backends/hwcomposer] Port to AbstractOutput from [backends/hwcomposer] port to AbstractOutput to [backends/hwcomposer] Port to AbstractOutput.
Feb 7 2019, 1:59 PM · KWin
davidedmundson retitled D18808: [backends/hwcomposer] Port to AbstractOutput from [plugins/backends/hwcomposer] port to AbstractOutput to [backends/hwcomposer] port to AbstractOutput.
Feb 7 2019, 1:51 PM · KWin
davidedmundson updated the diff for D18808: [backends/hwcomposer] Port to AbstractOutput.

remove a stray newline

Feb 7 2019, 12:59 PM · KWin
davidedmundson updated the diff for D18810: [platforms/hwcomposer] Add scaling support.

add a const

Feb 7 2019, 12:57 PM · KWin
davidedmundson added a dependent revision for D18808: [backends/hwcomposer] Port to AbstractOutput: D18810: [platforms/hwcomposer] Add scaling support.
Feb 7 2019, 12:56 PM · KWin
davidedmundson added a dependency for D18810: [platforms/hwcomposer] Add scaling support: D18808: [backends/hwcomposer] Port to AbstractOutput.
Feb 7 2019, 12:56 PM · KWin
davidedmundson added a comment to D18763: [client] Fix typos.

Ship it.

Feb 7 2019, 12:49 PM · Frameworks
davidedmundson updated the diff for D18808: [backends/hwcomposer] Port to AbstractOutput.

whitespace

Feb 7 2019, 12:48 PM · KWin
davidedmundson updated the diff for D18810: [platforms/hwcomposer] Add scaling support.

fix obvious typo

Feb 7 2019, 12:43 PM · KWin
davidedmundson requested review of D18810: [platforms/hwcomposer] Add scaling support.
Feb 7 2019, 12:35 PM · KWin
davidedmundson requested review of D18808: [backends/hwcomposer] Port to AbstractOutput.
Feb 7 2019, 12:12 PM · KWin
davidedmundson added a comment to D18465: [platforms/wayland] Multi output support.

Looks good.

Feb 7 2019, 11:42 AM · KWin
davidedmundson added a comment to D18805: Workaround for the bug 393630 - SystemTray part.

If the only usage is the SNI model lets just rebuild the model on the ConfigEntries side.
You're right that sharing objects between contexts seems to cause issues.

Feb 7 2019, 10:16 AM · Plasma
davidedmundson added inline comments to D18646: [Colors KCM] Add search and filter.
Feb 7 2019, 10:04 AM · Plasma
davidedmundson added a comment to D18804: Workaround for the bug 393630 - Framework part.

Can you explain what you're working around?

Feb 7 2019, 9:26 AM · Frameworks
davidedmundson accepted D18803: [effects/screenedge] Use correct blend function.
Feb 7 2019, 12:09 AM · KWin

Feb 6 2019

davidedmundson added a comment to D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter.

Even if it did load MainToolbar icon size, why does that make them invisible as per the bug report?

Feb 6 2019, 10:01 PM · Plasma
davidedmundson updated the title for P305 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Feb 6 2019, 9:58 PM
davidedmundson accepted D17706: Fix lock screen focus.
Feb 6 2019, 12:14 PM · Plasma
davidedmundson committed R119:fa05682cf691: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Feb 6 2019, 11:31 AM
davidedmundson committed R119:3ae6a0eeb478: [kcms/cursortheme] Correctly load m_originalPreferredSize (authored by davidedmundson).
[kcms/cursortheme] Correctly load m_originalPreferredSize
Feb 6 2019, 11:31 AM
davidedmundson closed D18751: [kcms/cursortheme] Correctly load m_originalPreferredSize.
Feb 6 2019, 11:31 AM · Plasma
davidedmundson committed R119:cc90a186bda7: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Feb 6 2019, 11:30 AM
davidedmundson committed R119:e8de7085371f: [kcms/mouse] Load current server settings in kcminit (authored by davidedmundson).
[kcms/mouse] Load current server settings in kcminit
Feb 6 2019, 11:29 AM
davidedmundson committed R119:dcb531861e27: Merge branch 'Plasma/5.14' into Plasma/5.15 (authored by davidedmundson).
Merge branch 'Plasma/5.14' into Plasma/5.15
Feb 6 2019, 11:29 AM
davidedmundson closed D18777: [kcms/mouse] Load current server settings in kcminit.
Feb 6 2019, 11:29 AM · Plasma
davidedmundson updated the diff for D18777: [kcms/mouse] Load current server settings in kcminit.

fix copy pasta out of virtualbox

Feb 6 2019, 1:50 AM · Plasma
davidedmundson updated the summary of D18777: [kcms/mouse] Load current server settings in kcminit.
Feb 6 2019, 1:15 AM · Plasma
davidedmundson requested review of D18777: [kcms/mouse] Load current server settings in kcminit.
Feb 6 2019, 1:14 AM · Plasma
davidedmundson committed R123:c0174ec4a71d: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Feb 6 2019, 12:06 AM
davidedmundson committed R123:63bdea49897b: Merge branch 'Plasma/5.12' into Plasma/5.15 (authored by davidedmundson).
Merge branch 'Plasma/5.12' into Plasma/5.15
Feb 6 2019, 12:06 AM
davidedmundson committed R123:634a2dd1bef5: Fix autologin session loading (authored by davidedmundson).
Fix autologin session loading
Feb 6 2019, 12:05 AM
davidedmundson closed D18765: Fix autologin session loading.
Feb 6 2019, 12:05 AM · Plasma

Feb 5 2019

davidedmundson accepted D18775: Remove ExtraDesktop.sh.
Feb 5 2019, 11:31 PM · KWin
davidedmundson accepted D18771: Move icons to data dir.
Feb 5 2019, 10:34 PM · KWin
davidedmundson updated the title for P302 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Feb 5 2019, 6:07 PM
davidedmundson updated the title for P301 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Feb 5 2019, 5:37 PM
davidedmundson requested review of D18765: Fix autologin session loading.
Feb 5 2019, 5:30 PM · Plasma
davidedmundson planned changes to D18740: [wayland] Set output scale when creating new OutputInterface instances.

Yeah, and now you mention it the entirety of the xdgOutput setting is missing on construction too.

Feb 5 2019, 3:34 PM · KWin
davidedmundson accepted D15910: Implement wl_surface::damage_buffer.
Feb 5 2019, 3:23 PM · Frameworks
davidedmundson added a comment to D18515: Bump to Qt5.12 - Drop kwin's custom ServerSideDecorationManager interface.

CI is now good to go.

Feb 5 2019, 2:54 PM · Plasma
davidedmundson closed D18753: [kcms/keys] Fix double margin.
Feb 5 2019, 2:35 PM · Plasma
davidedmundson committed R119:004ce594feff: [kcms/keys] Fix double margin (authored by davidedmundson).
[kcms/keys] Fix double margin
Feb 5 2019, 2:35 PM
davidedmundson accepted D18756: Save the correct value of noborder property.
Feb 5 2019, 11:51 AM · KWin
davidedmundson committed R119:26f51d6ae756: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Feb 5 2019, 11:49 AM
davidedmundson committed R119:70a0c99d08b5: [kcms/launch] Avoid infinite loop in button handling (authored by davidedmundson).
[kcms/launch] Avoid infinite loop in button handling
Feb 5 2019, 11:48 AM
davidedmundson closed D18748: [kcms/launch] Avoid infinite loop in button handling.
Feb 5 2019, 11:48 AM · Plasma
davidedmundson accepted D18754: [Look and Feel KCM] Write schemeName last.

Is it worth putting this in 5.15?

Feb 5 2019, 11:15 AM · Plasma
davidedmundson added a comment to D18752: Also try untranslated theme name.

Why do we ever need to use a translated version?

Feb 5 2019, 11:04 AM · Plasma
davidedmundson requested review of D18753: [kcms/keys] Fix double margin.
Feb 5 2019, 11:04 AM · Plasma
davidedmundson committed R123:b1ce0d0cd40c: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Feb 5 2019, 10:39 AM
davidedmundson committed R123:dc1922e6aa48: Fix loading of background image preview (authored by davidedmundson).
Fix loading of background image preview
Feb 5 2019, 10:39 AM
davidedmundson committed R123:159e2dcbf935: Fix mime type filter on background selection button (authored by davidedmundson).
Fix mime type filter on background selection button
Feb 5 2019, 10:39 AM
davidedmundson closed D18615: Fix mime type filter on background selection button.
Feb 5 2019, 10:39 AM · Plasma
davidedmundson closed D18614: Fix loading of background image preview.
Feb 5 2019, 10:39 AM · Plasma
davidedmundson requested review of D18751: [kcms/cursortheme] Correctly load m_originalPreferredSize.
Feb 5 2019, 10:31 AM · Plasma
davidedmundson requested review of D18748: [kcms/launch] Avoid infinite loop in button handling.
Feb 5 2019, 10:15 AM · Plasma
davidedmundson accepted D18643: Fix --no-global-shortcuts option.
Feb 5 2019, 9:54 AM · KWin
davidedmundson accepted D18706: [kcmkwin] Simplify EffectModel::save.
Feb 5 2019, 9:53 AM · KWin
davidedmundson accepted D18728: [kcmkwin] Properly load effects.
Feb 5 2019, 9:33 AM · KWin
davidedmundson added a comment to D17706: Fix lock screen focus.

Seems better, but I'm not sure I understand exactly.

Feb 5 2019, 8:45 AM · Plasma
davidedmundson updated the test plan for D18739: Sync QML module padding to reflect system setting pages.
Feb 5 2019, 12:18 AM · Frameworks
davidedmundson requested review of D18740: [wayland] Set output scale when creating new OutputInterface instances.
Feb 5 2019, 12:11 AM · KWin
davidedmundson added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

Is this patch acceptable

Feb 5 2019, 12:01 AM · KWin
davidedmundson requested review of D18739: Sync QML module padding to reflect system setting pages.
Feb 5 2019, 12:00 AM · Frameworks

Feb 4 2019

davidedmundson added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

(but who uses kcmshell anyway?).

Feb 4 2019, 11:09 PM · KWin
davidedmundson added a comment to D18733: With software rendering, use outlines instead of shadows on login & lock screen.

FWIW, currently it'll only affect the lock screen as SDDM doesn't have any code (yet!) to enable software rendering.

Feb 4 2019, 7:45 PM · Plasma
davidedmundson accepted D18733: With software rendering, use outlines instead of shadows on login & lock screen.
Feb 4 2019, 7:11 PM · Plasma
davidedmundson added inline comments to D18727: [Icon Applet] Use libTaskManager for startup feedback.
Feb 4 2019, 6:43 PM · Plasma
davidedmundson accepted D18731: Replace KIconThemes dependency with equivalent QIcon usage.
Feb 4 2019, 6:39 PM · Frameworks
davidedmundson accepted D18720: [kcmkwin/compositing] Fix effect video previews.
Feb 4 2019, 6:36 PM · KWin
davidedmundson accepted D18724: Add a timeout for KNS backends.
Feb 4 2019, 3:45 PM · Discover Software Store, Plasma

Feb 2 2019

davidedmundson accepted D18655: Use correct window for getting ComboBox current icon pixmap.
Feb 2 2019, 8:21 AM · Plasma

Feb 1 2019

davidedmundson added a comment to D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs.

Wait a few days. Frameworks tagging is the first Saturday of the month.

Feb 1 2019, 10:47 AM · Frameworks
davidedmundson accepted D18182: Fix new file creation leading to dupe items on a fresh view.
Feb 1 2019, 10:11 AM · Plasma
davidedmundson added a comment to D18569: Split out a dedicated InternalClient class.

(the panel should be at the bottom of the screen; notifications should appear in the bottom right corner of the screen)

Feb 1 2019, 1:09 AM · KWin