Use the new Kirigami ListSectionHeader.

rebase

updated

I suggested a change. Rest looks good.

[spam comment removed by sysadmin]

the builds are successfully being built on the CI now. We just need to iron out the kinks so it actually works like it should, on all systems.

reference patch : https://phabricator.kde.org/D23209 (merged already)

landing it!

looks good

This task was completed by 779997337179e035a13b277784d40e67d4fe765e and 5dc65ee9094d12d06cbf2f96b68b4d71bebd9142

In T9676#174752, @khanaasif wrote:

Hi. I'd like to work on this one as well. But I'm new to KDE and also am a relative beginner in programming. I had a question - how should I start to dive into the code from on cgit. Thank you.

so we have Jenkins ready to build .Appx packages for us now, thanks to @bcooksley : https://invent.kde.org/sysadmin/binary-factory-tooling/commit/aeddc47b0ca4dcdef64044226b99d9b78a0156a7

I discovered that this is possible using the dbus. At least with KDE applications, you can use a dbus method to 'press' a button on the toolnar / drop down menu.

In D17790#387972, @pino wrote:

Please do not use libcrypto/libssl directly:

• it does not have a stable ABI

In D17790#506460, @sredman wrote:

In D17790#506079, @Inoki wrote:

Is this good to ship?

Since there is a dylib duplicated link error caused by qca-qt5 on macOS(when we use Craft to pack KDE Connect with qml files), this will be helpful for all qml apps we have up to now :)

I think at the sprint we decided we didn't want to use OpenSSL. It has licensing problems when using the library directly and using the binary seems like it could lead to problems with multi-platform packaging and with the potential for the command-line flags to change in the future. We talked about looking at GnuTLS but nobody has done that yet.

What problem are you having? It seems weird that you would only be having a problem with QML applications now since there are already several, like the SMS app and the settings app and since none of them use QCA

In D17790#506079, @Inoki wrote:

Is this good to ship?

Since there is a dylib duplicated link error caused by qca-qt5 on macOS(when we use Craft to pack KDE Connect with qml files), this will be helpful for all qml apps we have up to now :)

Is this good to ship?

We have done a little bit more on mDNS on our Gitlab. Feel free to check it out! Android C++

We have done a little bit more on mDNS on our Gitlab. Feel free to check it out! Android C++

LGTM! I assume you don't have a developer account, so I'll merge it.

• Added space to method bracket

• Added new packet for initial connection sync
• Added missing packet type changes

• Added new packet type for new connection syncs
• Added missing timestamp update

Mostly resolved. The actual conversation shows a nice spinner when waiting for messages. The conversation list still doesn't show anything, but also I have trouble reproducing a case where it loads slowly so I think it will be okay

Just one minor nit, but looks good to me. Thanks for the patch!

LGTM.

Review changes

Added definition for packet

Review changes to clipboard

Now we request a bunch, then check if there are enough and request more until there is

@vikasd We have done this one at the KDE Connect sprint. Check it out!

Clipboard should not sync if the clipboard timestamp is unknown.

In D15399#498358, @sredman wrote:

It needs the dependency on qt5-quickcontrols2

find_package(Qt5QuickControls2 REQUIRED)

It needs the dependency on qt5-quickcontrols2

This can be re-opened when we want to look at this feature again, but I'm closing for now

@jdvr Are you still interested in working on this? We would need some flow to request the permission on newer Android versions. With the runtime permissions, it seems like it would make the most sense to ask for this as soon as the user brings up the settings panel for configuring trusted networks.

Let's merge after it's not colliding with sailfish.

In D22562#498171, @albertvaka wrote:

Should this be merged to master in addition of 1.x?

Should this be merged to master in addition of 1.x?

Rebase

In D22427#494773, @skumblex wrote:

Hi sredman.

Thanks for the information. I did not know that there is a dedicated localization team, but I will contact them as soon as possible. Then, I guess you can close this review request.

Hi sredman.

Hi skumblex. Thank you very much for taking the time to do this!

WIP: https://invent.kde.org/lnj/plasma-integration/tree/feature/mobile-kirigami-ui
WIP fixes by Aleix: https://phabricator.kde.org/P429

I should close this task.

ah, yes I did. It looks like dbus-daemon is used for a lot of plugin interfaces within KDE Connect.

Have you tried building the indicator with -DQSYSTRAY?

Thank you!