Feed Advanced Search

May 25 2019

shubham updated the diff for D21340: [RFC]Add unit test for RAID.

Add check for mdadm tool
I am still working on this revision.
How can the creation of RAID be tested and what do you mean by loop device?

May 25 2019, 2:39 PM · KDE Partition Manager

May 24 2019

stikonas added a comment to D21340: [RFC]Add unit test for RAID.

There are some procedures missing in this test. First, you need to look if mdadm is installed in the system before testing RAID. Then, you need to test the creation of a RAID device and check if it was successfully created. After that, you can try to create partitions on it and test if it exists.

May 24 2019, 5:23 PM · KDE Partition Manager
cjlcarvalho added a comment to D21340: [RFC]Add unit test for RAID.

There are some procedures missing in this test. First, you need to look if mdadm is installed in the system before testing RAID. Then, you need to test the creation of a RAID device and check if it was successfully created. After that, you can try to create partitions on it and test if it exists.

May 24 2019, 2:53 PM · KDE Partition Manager
cjlcarvalho requested changes to D21340: [RFC]Add unit test for RAID.
May 24 2019, 2:52 PM · KDE Partition Manager
shubham added inline comments to D21340: [RFC]Add unit test for RAID.
May 24 2019, 2:53 AM · KDE Partition Manager
shubham added a comment to D21340: [RFC]Add unit test for RAID.

@stikonas Does the rest looks sensible?

May 24 2019, 2:51 AM · KDE Partition Manager

May 23 2019

stikonas requested changes to D21340: [RFC]Add unit test for RAID.
May 23 2019, 11:16 PM · KDE Partition Manager
stikonas accepted D21340: [RFC]Add unit test for RAID.
May 23 2019, 11:16 PM · KDE Partition Manager
shubham updated the diff for D21340: [RFC]Add unit test for RAID.

Add condition in whihc partition size can not be computed

May 23 2019, 11:12 AM · KDE Partition Manager

May 22 2019

shubham updated the diff for D21340: [RFC]Add unit test for RAID.
May 22 2019, 5:06 PM · KDE Partition Manager
shubham updated the diff for D21340: [RFC]Add unit test for RAID.

Remove extra line

May 22 2019, 2:17 PM · KDE Partition Manager
shubham added a project to D21340: [RFC]Add unit test for RAID: KDE Partition Manager.
May 22 2019, 2:16 PM · KDE Partition Manager

May 19 2019

shubham closed D21275: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough.
May 19 2019, 5:23 PM · KDE Partition Manager
stikonas accepted D21275: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough.
May 19 2019, 5:22 PM · KDE Partition Manager
shubham updated the diff for D21275: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough.

Do not remove qca-qt5 from CMakeLists.txt

May 19 2019, 2:38 PM · KDE Partition Manager

May 18 2019

shubham added a project to D21275: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough: KDE Partition Manager.
May 18 2019, 6:53 PM · KDE Partition Manager
shubham closed D21272: Remove superflous variables.
May 18 2019, 1:24 PM · KDE Partition Manager
stikonas accepted D21272: Remove superflous variables.
May 18 2019, 1:20 PM · KDE Partition Manager
shubham added a project to D21272: Remove superflous variables: KDE Partition Manager.
May 18 2019, 1:16 PM · KDE Partition Manager

May 17 2019

shubham updated the diff for D21261: Prevent resizing read-only mounted file systems.

Shift common code to filesystem class

May 17 2019, 7:58 PM · KDE Partition Manager
stikonas added a comment to D21261: Prevent resizing read-only mounted file systems.

Also in general, I think we should create a bool variable where we store data, so that we only run this

May 17 2019, 7:37 PM · KDE Partition Manager
stikonas requested changes to D21261: Prevent resizing read-only mounted file systems.
May 17 2019, 7:31 PM · KDE Partition Manager
shubham added a project to D21261: Prevent resizing read-only mounted file systems: KDE Partition Manager.
May 17 2019, 7:31 PM · KDE Partition Manager
shubham abandoned D21244: Make it a pointer since memory is allocated on heap.

I assume it is not required anymore.

May 17 2019, 5:55 PM · KDE Partition Manager
stikonas added a comment to D21244: Make it a pointer since memory is allocated on heap.

Well, in principle both mean exactly the same thing, so I don't have strong opinion on this. I probably use them interchangeably anyway. Well, it's auto, so we don't care what type it is... So based on that I would say no need to make a commit. Other parts of KDE codebase also don't have unified style here. Just checked kwin, it has both auto and auto *

May 17 2019, 5:52 PM · KDE Partition Manager
shubham added a comment to D21244: Make it a pointer since memory is allocated on heap.

@stikonas any comments?

May 17 2019, 5:42 PM · KDE Partition Manager
shubham closed D21241: Simplify test conditions.
May 17 2019, 5:33 PM · KDE Partition Manager
shubham closed D21251: Remove redundant include.
May 17 2019, 5:31 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

Yesterday I tried for putting theses revisions over gitLab. but could not succeed. I tried doing git push origin master and it said access denied. So what should I do now to push it remote and the merge? Thanks

May 17 2019, 5:14 PM · KDE Partition Manager
shubham added a comment to D21251: Remove redundant include.

Yesterday I tried for putting theses revisions over gitLab. but could not succeed. I tried doing git push origin master and it said access denied. So what should I do now to push it remote and the merge? Thanks

May 17 2019, 5:11 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

I have commit access, but It says access denied. Remember you had said it is hosted on remote server.

May 17 2019, 5:08 PM · KDE Partition Manager
shubham added a comment to D21251: Remove redundant include.

I have commit access, but It says access denied. Remember you had said it is hosted on remote server.

May 17 2019, 5:07 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

Oh, I do by running kdesrc-build script, which takes care of removing old build directory.
Please push this and the other revision on my behalf : )

May 17 2019, 5:06 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

oh ok, that's fine then.

May 17 2019, 5:06 PM · KDE Partition Manager
shubham added a comment to D21251: Remove redundant include.

Oh, I do by running kdesrc-build script, which takes care of removing old build directory.
Please push this and the other revision on my behalf : )

May 17 2019, 5:05 PM · KDE Partition Manager
stikonas accepted D21251: Remove redundant include.
May 17 2019, 5:04 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

please test that it builds in a clean build dir.

I do not know what do you mean? tests?

May 17 2019, 5:04 PM · KDE Partition Manager
shubham added a comment to D21251: Remove redundant include.

please test that it builds in a clean build dir.

I do not know what do you mean? tests?

May 17 2019, 5:02 PM · KDE Partition Manager
shubham updated the diff for D21251: Remove redundant include.

Do not remove <memory>

May 17 2019, 5:01 PM · KDE Partition Manager
shubham abandoned D21258: Move slot under Q_SLOTS.
May 17 2019, 4:57 PM · KDE Partition Manager
stikonas requested changes to D21258: Move slot under Q_SLOTS.
May 17 2019, 4:55 PM · KDE Partition Manager
stikonas added a comment to D21258: Move slot under Q_SLOTS.

We also don't need this. Q_SLOTS are needed with old style Qt syntax where SIGNAL and SLOTS are used. With the new Qt5 connect syntax, you can just connect to any function, so no need to involve moc on this function.

May 17 2019, 4:55 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

The other include (#include "externalcommandhelper.h") I think can still go away but please test that it builds in a clean build dir.

May 17 2019, 4:53 PM · KDE Partition Manager
shubham added a project to D21258: Move slot under Q_SLOTS: KDE Partition Manager.
May 17 2019, 4:52 PM · KDE Partition Manager
stikonas requested changes to D21251: Remove redundant include.

It is needed by std::unique_ptr and std::unordered_set. We shouldn't rely on header being pulled in by some other header.

May 17 2019, 4:45 PM · KDE Partition Manager
shubham updated the diff for D21251: Remove redundant include.

More redundant include

May 17 2019, 3:57 PM · KDE Partition Manager
shubham added a project to D21251: Remove redundant include: KDE Partition Manager.
May 17 2019, 3:33 PM · KDE Partition Manager
shubham added inline comments to D21244: Make it a pointer since memory is allocated on heap.
May 17 2019, 5:18 AM · KDE Partition Manager

May 16 2019

cjlcarvalho added inline comments to D21244: Make it a pointer since memory is allocated on heap.
May 16 2019, 8:13 PM · KDE Partition Manager
shubham added a project to D21244: Make it a pointer since memory is allocated on heap: KDE Partition Manager.
May 16 2019, 7:57 PM · KDE Partition Manager
shubham updated the diff for D21241: Simplify test conditions.

Take few more instances into account.
Please push it on my behalf.

May 16 2019, 7:36 PM · KDE Partition Manager
stikonas accepted D21241: Simplify test conditions.
May 16 2019, 7:23 PM · KDE Partition Manager
shubham added inline comments to D21241: Simplify test conditions.
May 16 2019, 7:17 PM · KDE Partition Manager
shubham added a project to D21241: Simplify test conditions: KDE Partition Manager.
May 16 2019, 7:17 PM · KDE Partition Manager

Apr 29 2019

James added a watcher for KDE Partition Manager: James.
Apr 29 2019, 7:40 PM

Apr 6 2019

shubham added a comment to D20269: Fix typo and constantify arguments.

Looks alright, although I wouldn't call that thing a typo. Variable names in C++ doesn't have to match in function header and implementation, although, it's probably less confusing if they match. But sometimes one can simply omit names in header and just have types.

Apr 6 2019, 4:20 AM · KDE Partition Manager

Apr 5 2019

stikonas added a comment to D20269: Fix typo and constantify arguments.

Looks alright, although I wouldn't call that thing a typo. Variable names in C++ doesn't have to match in function header and implementation, although, it's probably less confusing if they match. But sometimes one can simply omit names in header and just have types.

Apr 5 2019, 11:47 PM · KDE Partition Manager
cjlcarvalho closed D20269: Fix typo and constantify arguments.
Apr 5 2019, 5:45 PM · KDE Partition Manager
cjlcarvalho accepted D20269: Fix typo and constantify arguments.
Apr 5 2019, 5:44 PM · KDE Partition Manager
shubham added a project to D20269: Fix typo and constantify arguments: KDE Partition Manager.
Apr 5 2019, 2:35 PM · KDE Partition Manager

Mar 30 2019

shubham abandoned D20109: Be consistent with rest of coding style.

Abandoned in favour of above comments

Mar 30 2019, 3:41 PM · KDE Partition Manager
pino added a comment to D20109: Be consistent with rest of coding style.

I don't think we should change other lines too here. We pass that percent to KJob, so keep the type the same as KJob expects.

I have not changed the type for percent() signal, I have changed type for emitProgress()

Mar 30 2019, 3:12 PM · KDE Partition Manager
shubham added a comment to D20109: Be consistent with rest of coding style.

I don't think we should change other lines too here. We pass that percent to KJob, so keep the type the same as KJob expects.

Mar 30 2019, 2:16 PM · KDE Partition Manager

Mar 29 2019

stikonas added a comment to D20109: Be consistent with rest of coding style.

We also need to adapt this connect KJob to the Qt5 signals and slots syntax.

Mar 29 2019, 6:06 PM · KDE Partition Manager
cjlcarvalho added a comment to D20109: Be consistent with rest of coding style.

We also need to adapt this connect KJob to the Qt5 signals and slots syntax.

Mar 29 2019, 6:02 PM · KDE Partition Manager
cjlcarvalho requested changes to D20109: Be consistent with rest of coding style.
Mar 29 2019, 6:01 PM · KDE Partition Manager
stikonas requested changes to D20109: Be consistent with rest of coding style.

I don't think we should change other lines too here. We pass that percent to KJob, so keep the type the same as KJob expects.

Mar 29 2019, 6:00 PM · KDE Partition Manager
cjlcarvalho closed D20108: Constantify nonce and some cleanup.
Mar 29 2019, 6:00 PM · KDE Partition Manager
cjlcarvalho accepted D20108: Constantify nonce and some cleanup.
Mar 29 2019, 5:58 PM · KDE Partition Manager
stikonas accepted D20108: Constantify nonce and some cleanup.
Mar 29 2019, 5:56 PM · KDE Partition Manager
cjlcarvalho closed D20110: Fix typo.
Mar 29 2019, 5:55 PM · KDE Partition Manager
cjlcarvalho accepted D20110: Fix typo.
Mar 29 2019, 5:54 PM · KDE Partition Manager
cjlcarvalho closed D20106: Constantify function parameters.
Mar 29 2019, 5:53 PM · KDE Partition Manager
cjlcarvalho accepted D20106: Constantify function parameters.
Mar 29 2019, 5:51 PM · KDE Partition Manager
shubham updated the diff for D20108: Constantify nonce and some cleanup.

Move QCA header outside Qt headers

Mar 29 2019, 10:26 AM · KDE Partition Manager
shubham edited reviewers for D20108: Constantify nonce and some cleanup, added: cjlcarvalho; removed: caiovosilva.
Mar 29 2019, 10:24 AM · KDE Partition Manager
stikonas updated subscribers of D20108: Constantify nonce and some cleanup.

I don't think moving QtCrypto is right. It's not a Qt header, it belongs to QCA.

Mar 29 2019, 10:20 AM · KDE Partition Manager
shubham updated the diff for D20109: Be consistent with rest of coding style.

Do not change argument type for percent(KJob*, unsigned long) signal

Mar 29 2019, 9:49 AM · KDE Partition Manager
shubham added a project to D20110: Fix typo: KDE Partition Manager.
Mar 29 2019, 9:41 AM · KDE Partition Manager
pino requested changes to D20109: Be consistent with rest of coding style.
Mar 29 2019, 8:55 AM · KDE Partition Manager
shubham added a project to D20109: Be consistent with rest of coding style: KDE Partition Manager.
Mar 29 2019, 8:51 AM · KDE Partition Manager
shubham added a project to D20108: Constantify nonce and some cleanup: KDE Partition Manager.
Mar 29 2019, 7:06 AM · KDE Partition Manager
shubham abandoned D20107: Simplify write condition.
Mar 29 2019, 6:52 AM · KDE Partition Manager
pino requested changes to D20107: Simplify write condition.
Mar 29 2019, 6:39 AM · KDE Partition Manager
shubham added a project to D20107: Simplify write condition: KDE Partition Manager.
Mar 29 2019, 6:33 AM · KDE Partition Manager
shubham updated the summary of D20106: Constantify function parameters.
Mar 29 2019, 5:56 AM · KDE Partition Manager
shubham added a project to D20106: Constantify function parameters: KDE Partition Manager.
Mar 29 2019, 5:55 AM · KDE Partition Manager

Mar 27 2019

cjlcarvalho closed D20076: Do not use C data type.
Mar 27 2019, 4:15 PM · KDE Partition Manager
cjlcarvalho accepted D20076: Do not use C data type.
Mar 27 2019, 4:07 PM · KDE Partition Manager
cjlcarvalho added a comment to D20076: Do not use C data type.

If most of our code follows this standard of using quint64, I think that it is reasonable to maintain the other parts of it in this way.

Mar 27 2019, 4:06 PM · KDE Partition Manager
shubham added a comment to D20076: Do not use C data type.

I did not find any other occurrences of unsigned long long, so probably quint64 is the coding style

Mar 27 2019, 1:48 PM · KDE Partition Manager
stikonas added a comment to D20076: Do not use C data type.

Hmm, do we really need this? quint64 is unsigned long long. It's just a typedef, so both can be used interchangeably. And unsigned long long is also C++ data type, not just C... Altgough, obviously this change wouldn't break anything. I guess it's just a question of code style but I didn't find any KDE recommendations. Any other opinions from other reviewers?

Mar 27 2019, 1:22 PM · KDE Partition Manager
shubham added a project to D20076: Do not use C data type: KDE Partition Manager.
Mar 27 2019, 11:10 AM · KDE Partition Manager

Jan 4 2019

cjlcarvalho added a comment to T10090: SMART Status GUI Issues.

Ok, I'm subscribed.

Jan 4 2019, 11:08 AM · KDE Partition Manager

Jan 3 2019

stikonas added a comment to T10090: SMART Status GUI Issues.

@cjlcarvalho Just double checked, it's still an issue.

Jan 3 2019, 10:33 PM · KDE Partition Manager
stikonas added a comment to T10090: SMART Status GUI Issues.

@cjlcarvalho I don't recall any patch that fixed this. I can try to test
later today.

Jan 3 2019, 10:38 AM · KDE Partition Manager
cjlcarvalho added a comment to T10090: SMART Status GUI Issues.

@stikonas Is this solved?

Jan 3 2019, 1:25 AM · KDE Partition Manager

Jan 1 2019

stikonas added a comment to D17129: Updated SMART widget GUI to better display SMART info..

Most of the features in gsmartcontrol look like they have already been transferred to json. I can try to add all of this in the next few months. Is there any timeline on the next release of partitionmanager/kpmcore?

No timeline yet. First of all, there needs to be a new release of smartmontools. But probably best to work in a branch for a while.

Jan 1 2019, 9:40 PM · KDE Partition Manager

Dec 25 2018

stikonas added a comment to D17129: Updated SMART widget GUI to better display SMART info..

Most of the features in gsmartcontrol look like they have already been transferred to json. I can try to add all of this in the next few months. Is there any timeline on the next release of partitionmanager/kpmcore?

Dec 25 2018, 10:14 PM · KDE Partition Manager
varunp added a comment to D17129: Updated SMART widget GUI to better display SMART info..

Most of the features in gsmartcontrol look like they have already been transferred to json. I can try to add all of this in the next few months. Is there any timeline on the next release of partitionmanager/kpmcore?

Dec 25 2018, 10:12 PM · KDE Partition Manager