Fixed with https://invent.kde.org/utilities/ark/-/commit/75ee205a779a13f536186720295cae71f130c4a6

https://invent.kde.org/utilities/ark/-/merge_requests/39

@papoteur
Do you realize your email is already pretty-much public on bugzilla and it contains your name ?

In D27181#676686, @papoteur wrote:

In D27181#676685, @meven wrote:

I am not sure we can use a nickname as author because of licensing.

Why not?
Copyright protects the rights of the author. On one side, patrimonial rights allow to give him money, but with open source licence, the author says that he waives to them.

In D27181#676685, @meven wrote:

I am not sure we can use a nickname as author because of licensing.

In D27181#676663, @papoteur wrote:

Hello all,
Is there someone to commit this change?
Papoteur

Hello all,
Is there someone to commit this change?
Papoteur

In D27181#667237, @rthomsen wrote:

In D27181#666927, @papoteur wrote:

No, I don't have commit credentials. Go for myself.

Can you provide full name for commit message or should I use your nickname? And can you provide email-address?

In D27181#672643, @bugseforuns wrote:

In D27181#672572, @papoteur wrote:

In D27181#672563, @bugseforuns wrote:

My screenshot is showing preview of the compressed file (source) as "destination".

Hi Patrick,
Is it different with the original ark?

Ark 20.04.1 from Arch repos shows the thumbnail of source file twice.

Fixed with https://invent.kde.org/utilities/ark/-/commit/c7764f469021122d487c3c74cf364b751b2d3ae8

Fixed with https://invent.kde.org/utilities/ark/-/merge_requests/4

Hi, can you please submit the patch on gitlab? https://invent.kde.org/utilities/ark

Hi there
The zip_file is not discarded after it is no longer needed
This patch should fix it.

Hi there
this should fix the tests

Hi
The datetime format in qvariant ToString() was changed in 5.11 for QTime and QDateTime

I have done nothing special to enable previews on Arch Linux.
I can confirm missing previews on neon unstable edition despite preview of images in Dolphin is enabled on both systems.

In D27181#672643, @bugseforuns wrote:

Ark 20.04.1 from Arch repos shows the thumbnail of source file twice.

In D27181#672572, @papoteur wrote:

In D27181#672563, @bugseforuns wrote:

My screenshot is showing preview of the compressed file (source) as "destination".

Hi Patrick,
Is it different with the original ark?

In D27181#672563, @bugseforuns wrote:

My screenshot is showing preview of the compressed file (source) as "destination".

Ah right, sorry :P

My screenshot is showing preview of the compressed file (source) as "destination".

That's because the source is still compressed and we can't get a preview out of it.

I have tested this patch myself on Arch Linux.
Previews of jpg flles don't work as expected,
the one below "Source" is not generated and below "Destination"
we see the preview of source file.

In D27181#666927, @papoteur wrote:

No, I don't have commit credentials. Go for myself.

No, I don't have commit credentials. Go for myself.

Great. Nice work :) Do you have commit access or should I commit it for you?

And now?

Some nitpicks. I tested the patch and it works as intended :)

In D27181#663426, @papoteur wrote:

Should be OK now.

Should be OK now.

Almost ready :)

This version modifies the function signature of OverwriteQuery to pass directly data from source file.
Call to the function are adapted in the whole repo. I have tested it with extraction of one single file and a complete archive. Thus I have tested only the call from libarchiveplugin, line 306. I don't know how to test other calls.

I think it makes sense to always require specifying ctime, mtime and size, so please add the three values as arguments to the constructor of OverwriteQuery so we can get rid of setSourceData() and m_from_archive.

In D27181#646523, @papoteur wrote:

This new patch provides data from source by calling setSourceData.

Great. This reduces the loading time to almost half for a large zip archive.

Yes the bug is now marked WORKS FOR ME
And I fear my implementation is not right, given I haven't tested this well and how intricate understanding libarchive build options was.

• Address feedback

Use startsWith

Please change this to use QString::StartsWith() as per dakon's comment so we can get this committed.

This new patch provides data from source by calling setSourceData.
However, from my tests, it is never called.

In D27181#645643, @papoteur wrote:

In D27181#645642, @meven wrote:

ping @papoteur

Hello,
I tried further. I understood how to create a call to add information needed about source file. However, my calls to this function seem to never occur. With a debugger, I see that calls come from jobs, and I don't understand this mechanism.

Is this not needed anymore?

In D27181#645643, @papoteur wrote:

In D27181#645642, @meven wrote:

ping @papoteur

Hello,
I tried further. I understood how to create a call to add information needed about source file. However, my calls to this function seem to never occur. With a debugger, I see that calls come from jobs, and I don't understand this mechanism.

In D27181#645642, @meven wrote:

ping @papoteur

ping @papoteur

Thanks for the patch. This is a good start, but it needs some work.

Thanks, makes a lot of sense. I'll push it for you.

Comparison of result before change and after change:

ping?

In D27181#608097, @meven wrote:

Btw, You can mark the comment you treated as "Done" in phabricator, it it eases the review work.

Btw, You can mark the comment you treated as "Done" in phabricator, it it eases the review work.

Hello,
This patch has corrections for comments.

Nice first patch @papoteur , seems good to me.
Great on you pushing through your patch to phabricator.

See D27181 which keep rename dialog but solve the problem it had.

• Comments

• Comments

@nicolasfella I don't like the hardcoding of 48. If there is no clean way to port IconSize(KIconLoader::Desktop), I'd prefer to port to a different non-hardcoded size.

So you need to increase kf5 dependancy no ?

• Do the rest

• More