Feed Advanced Search

Mar 14 2019

pvuorela requested review of D19761: Remove obsolete syncX() workaround.
Mar 14 2019, 2:49 PM · Calligra: 3.0
pvuorela requested review of D19760: Support Qt <5.7 on KoShape flag usage.
Mar 14 2019, 2:47 PM · Calligra: 3.0
pvuorela requested review of D19759: Remove unsupported attributes from QGraphicsWidgets.
Mar 14 2019, 2:42 PM · Calligra: 3.0

Mar 7 2019

anthonyfieroni added inline comments to D19327: Karbon: Enable multi page capability.
Mar 7 2019, 6:33 PM · Calligra: 3.0
danders added a comment to D19216: Karbon: Enable multi page capability.
That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown.

Heh, I've had the opportunity to work closely with professional infographists so I picked up a thing or two about using applications like Illustrator and InDesign :)

How to indicate a transparent area of an object is yet another subject, with a related but not identical purpose.

That said it might make more sense for this "testing background" to be part of the document and not a general setting - if the use case is as you say then the testing background would also be different for different projects

True. I was reacting to *re*moving a setting completely, not to moving it to a more appropriate context.

Mar 7 2019, 11:32 AM · Calligra: 3.0

Feb 28 2019

rjvbb added a comment to D19216: Karbon: Enable multi page capability.
That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown.
Feb 28 2019, 11:28 AM · Calligra: 3.0
boemann added a comment to D19216: Karbon: Enable multi page capability.
No, the canvas is part of the document and must never be themed. The canvas background is as much part of your drawing as any line you put on it.

This hasn't been sitting right with me and I finally realised why.

That statement is true when you work with a real canvas and draw/paint/whatever directly onto that. If you take a grid paper the grid will become part of your art, but does Karbon print the grid which you can have it show (except possibly via an option)?

In drawing applications, the canvas is NOT part of your art, but simulates the canvas you'll be printing on. It's a backdrop layer that sits behind/below the lowest layer you can draw on. If you plan to print on a coloured piece of paper, or one with a canvassy texture, you'll probably want to adapt your virtual canvas so you can incorporate the physical canvas properties into your design. But you don't want that virtual canvas to print as that would be a waste of toner at best...

That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown.
That said it might make more sense for this "testing background" to be part of the document and not a general setting - if the use case is as you say then the testing background would also be different for different projects

That's not to say that the virtual canvas should not be exportable at all: you'd want to be able to include it when generating a PDF (SVG, JPG, etc) format version for use in on-screen only presentations. Of course you could just add a backdrop layer in that case.

I'm not aware that Karbon has the equivalent of a slide/page design feature where you can define how each page will look. That could look be used to be achieve what I describe here but in Karbon that layer should probably not be printed by default (just like it isn't in presentation apps, IIRC).

Feb 28 2019, 11:18 AM · Calligra: 3.0
rjvbb added a comment to D19216: Karbon: Enable multi page capability.
No, the canvas is part of the document and must never be themed. The canvas background is as much part of your drawing as any line you put on it.
Feb 28 2019, 8:47 AM · Calligra: 3.0

Feb 26 2019

danders requested review of D19327: Karbon: Enable multi page capability.
Feb 26 2019, 7:27 AM · Calligra: 3.0
boemann added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

no

Feb 26 2019, 7:11 AM · Calligra: 3.0

Feb 25 2019

danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Can we get a conclussion to this?
@Camilla Have you come up with any more unit tests?

Feb 25 2019, 12:16 PM · Calligra: 3.0
boemann added a comment to D19216: Karbon: Enable multi page capability.

totally agree about not theme'ing canvas

Feb 25 2019, 11:52 AM · Calligra: 3.0
danders added inline comments to D19216: Karbon: Enable multi page capability.
Feb 25 2019, 11:41 AM · Calligra: 3.0
danders added a comment to D19216: Karbon: Enable multi page capability.

Canvas color:
I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed.

A custom canvas colour feature doesn't strike me as odd, nor that it isn't printed (printing it WITHOUT setting a dedicated option would seem wrong to me).

What about when you use an inversed theme, isn't a custom canvas colour required then if you want to see your black line art on a light (white) canvas?

No, the canvas is part of the document and must never be themed. The canvas background is as much part of your drawing as any line you put on it.

Feb 25 2019, 11:23 AM · Calligra: 3.0

Feb 22 2019

ognarb closed D19132: Update libs/widgets to c++11.
Feb 22 2019, 9:04 PM · Calligra: 3.0
rjvbb added a comment to D19216: Karbon: Enable multi page capability.

Canvas color:
I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed.

Feb 22 2019, 3:30 PM · Calligra: 3.0
anthonyfieroni added inline comments to D19216: Karbon: Enable multi page capability.
Feb 22 2019, 2:53 PM · Calligra: 3.0
danders added inline comments to D19216: Karbon: Enable multi page capability.
Feb 22 2019, 2:18 PM · Calligra: 3.0
anthonyfieroni added inline comments to D19216: Karbon: Enable multi page capability.
Feb 22 2019, 1:46 PM · Calligra: 3.0
danders added a comment to D19216: Karbon: Enable multi page capability.

This would indeed be great to have; even a page selector when importing a multi-page document would be an improvement (the Adobe Illustrator version I've use had that; IIRC it would just leave all other pages of the document alone).

You should also test with PDF documents; in my experience Karbon 3.1 works well enough with them.

Yes, pdf docs work, it is almost 100% handled by poppler.

...

A lot of code was duplicated between pageapp and karbon
and has been removed from karbon:

Shouldn't that be a separate change - or does multi-page support come automatically with this change?

Well, my initial thought, but there was going to be quite a few intermidiate solutions mainly because
the KoPACanvas cannot be subclassed, so I decided to do everything in one go.

Feb 22 2019, 1:22 PM · Calligra: 3.0
rjvbb added a comment to D19216: Karbon: Enable multi page capability.

This would indeed be great to have; even a page selector when importing a multi-page document would be an improvement (the Adobe Illustrator version I've use had that; IIRC it would just leave all other pages of the document alone).

Feb 22 2019, 10:57 AM · Calligra: 3.0
danders requested review of D19216: Karbon: Enable multi page capability.
Feb 22 2019, 10:00 AM · Calligra: 3.0

Feb 21 2019

danders added a comment to D19132: Update libs/widgets to c++11.

Thanks for the review, I will work next on libs/{pigment,version,widgetutils}.

Hmm, maybe wait with pigment, according to rempt, only krita actually used it.
I haven't looked into it, but if that is the case probably we should dump it.

Feb 21 2019, 11:38 AM · Calligra: 3.0
ognarb added a comment to D19132: Update libs/widgets to c++11.

Ok, I can't say I have scrutinized every change, but...
Could you give a heads up when you continue with other parts or else there may be merge problems.
I'm working on karbon and pageapp atm, so please keep off :)

Feb 21 2019, 11:05 AM · Calligra: 3.0
danders accepted D19132: Update libs/widgets to c++11.

Ok, I can't say I have scrutinized every change, but...
Could you give a heads up when you continue with other parts or else there may be merge problems.
I'm working on karbon and pageapp atm, so please keep off :)

Feb 21 2019, 9:53 AM · Calligra: 3.0

Feb 19 2019

ognarb updated the diff for D19132: Update libs/widgets to c++11.

Fix build

Feb 19 2019, 11:25 PM · Calligra: 3.0
ognarb updated the summary of D19132: Update libs/widgets to c++11.
Feb 19 2019, 11:22 PM · Calligra: 3.0
ognarb updated the test plan for D19132: Update libs/widgets to c++11.
Feb 19 2019, 11:16 PM · Calligra: 3.0
ognarb updated the diff for D19132: Update libs/widgets to c++11.
  • Revert foreach modifications
  • Fix some forgotten 0 as nullptr instances
Feb 19 2019, 11:16 PM · Calligra: 3.0
leinir added a comment to D19132: Update libs/widgets to c++11.

There is an issue with Qt's foreach, however if the author would be so nice as to check that this version using C++11 iteration does not break building on Windows, then it can go in... Though, yes, it most certainly wants testing, and i don't currently have a functioning windows build system. 2890f2a929034d613c4b4a8f3e6ad77c23162d41 is one of the commits which did the q_foreach/for loop change previously, to see what actually got changed.

Feb 19 2019, 10:03 AM · Calligra: 3.0
danders added a reviewer for D19132: Update libs/widgets to c++11: leinir.

Hmmm. wasn't it somethng with ms windows and for loops, leinir?
Also, I think there may be detachment issues with them, clazy can tell.
There is a qAsConst() solution but that is not supported in the qt version we need to support.
If there are issues, maybe drop the for loops for now.

Feb 19 2019, 9:55 AM · Calligra: 3.0

Feb 18 2019

ognarb updated the summary of D19132: Update libs/widgets to c++11.
Feb 18 2019, 11:00 PM · Calligra: 3.0
ognarb added a reviewer for D19132: Update libs/widgets to c++11: Calligra: 3.0.
Feb 18 2019, 8:17 PM · Calligra: 3.0
ognarb requested review of D19132: Update libs/widgets to c++11.
Feb 18 2019, 8:16 PM · Calligra: 3.0

Feb 15 2019

niccolove closed D18448: Replaced "distraction free" with "fullscreen" - BUG:378527.
Feb 15 2019, 2:31 PM · Calligra: 3.0
cfeck added a comment to D18448: Replaced "distraction free" with "fullscreen" - BUG:378527.

This was accepted, but was it also committed yet?

Feb 15 2019, 12:36 AM · Calligra: 3.0

Feb 14 2019

ognarb closed D18994: Update screenshots for Calligra sheets 3.1.
Feb 14 2019, 7:03 PM · Documentation, Calligra: 3.0
ognarb added a comment to D18994: Update screenshots for Calligra sheets 3.1.

A quick note that you kind of got the name of the suite wrong in a few places, it's called Calligra, not Callibra :)

Feb 14 2019, 3:40 PM · Documentation, Calligra: 3.0
ognarb updated the summary of D18994: Update screenshots for Calligra sheets 3.1.
Feb 14 2019, 3:37 PM · Documentation, Calligra: 3.0
yurchor accepted D18994: Update screenshots for Calligra sheets 3.1.

Thanks.

Feb 14 2019, 2:48 PM · Documentation, Calligra: 3.0
leinir added a comment to D18994: Update screenshots for Calligra sheets 3.1.

A quick note that you kind of got the name of the suite wrong in a few places, it's called Calligra, not Callibra :)

Feb 14 2019, 1:26 PM · Documentation, Calligra: 3.0
ognarb updated the summary of D18994: Update screenshots for Calligra sheets 3.1.
Feb 14 2019, 1:23 PM · Documentation, Calligra: 3.0
danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Thanks, I'm checking it out now...
Just a couple of things:
Keywords needs to be on a separate line to have effect, see https://community.kde.org/Infrastructure/Git/Hooks
Also FIXED-IN is nice to add.

Feb 14 2019, 10:10 AM · Calligra: 3.0
ognarb updated the test plan for D18994: Update screenshots for Calligra sheets 3.1.
Feb 14 2019, 1:29 AM · Documentation, Calligra: 3.0
ognarb updated the diff for D18994: Update screenshots for Calligra sheets 3.1.

Now compile with checkXML5

Feb 14 2019, 1:28 AM · Documentation, Calligra: 3.0
ognarb added reviewers for D18994: Update screenshots for Calligra sheets 3.1: Calligra: 3.0, Documentation.
Feb 14 2019, 1:26 AM · Documentation, Calligra: 3.0
ognarb requested review of D18994: Update screenshots for Calligra sheets 3.1.
Feb 14 2019, 1:26 AM · Documentation, Calligra: 3.0

Feb 13 2019

ognarb closed D18989: Remove minor duplicate code and fix related bug.
Feb 13 2019, 9:16 PM · Calligra: 3.0
boemann accepted D18989: Remove minor duplicate code and fix related bug.
Feb 13 2019, 9:09 PM · Calligra: 3.0
ognarb added a reviewer for D18989: Remove minor duplicate code and fix related bug: Calligra: 3.0.
Feb 13 2019, 8:50 PM · Calligra: 3.0
ognarb requested review of D18989: Remove minor duplicate code and fix related bug.
Feb 13 2019, 8:42 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

It seems like it landed. Please tell me if I screwed up anything.

Feb 13 2019, 7:00 PM · Calligra: 3.0
niccolove closed D18466: Fixed calligra crashing when opening remote document.
Feb 13 2019, 6:57 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.

BUG:358581

Feb 13 2019, 6:34 PM · Calligra: 3.0
ognarb updated the test plan for D18963: Improve KoModeBox display in horizontal Mode.
Feb 13 2019, 3:15 PM · Calligra: 3.0
ognarb closed D18963: Improve KoModeBox display in horizontal Mode.
Feb 13 2019, 3:13 PM · Calligra: 3.0
ognarb updated the diff for D18963: Improve KoModeBox display in horizontal Mode.

remove more trailing whitespace

Feb 13 2019, 3:10 PM · Calligra: 3.0
ognarb updated the diff for D18963: Improve KoModeBox display in horizontal Mode.

remove trailing whitespace

Feb 13 2019, 2:03 PM · Calligra: 3.0
danders closed D18843: Activate stencils docker in all apps.
Feb 13 2019, 8:51 AM · Calligra: 3.0
danders added a comment to D18963: Improve KoModeBox display in horizontal Mode.

Please remove trailing whitespace.

Feb 13 2019, 8:41 AM · Calligra: 3.0
boemann accepted D18843: Activate stencils docker in all apps.

I definitely don't want this docker default on, but if as you say it's default off then i guess your change is okay - i'll take your word for it

Feb 13 2019, 8:34 AM · Calligra: 3.0
danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Dan can you please reply - I'm fine with the account but I can't reply to Ben as I am not able to send email

Feb 13 2019, 8:22 AM · Calligra: 3.0
boemann added a comment to D18466: Fixed calligra crashing when opening remote document.

Dan can you please reply - I'm fine with the account but I can't reply to Ben as I am not able to send email

Feb 13 2019, 3:55 AM · Calligra: 3.0

Feb 12 2019

ognarb added a comment to D18963: Improve KoModeBox display in horizontal Mode.

Ok thanks for the review, I will retry to compile calligra master and see if it's still work and then land this diff. 😄

Feb 12 2019, 9:04 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

I do not have a developer account. I requested one some days ago with no answer yet.

Feb 12 2019, 8:55 PM · Calligra: 3.0
boemann accepted D18963: Improve KoModeBox display in horizontal Mode.

I like it

Feb 12 2019, 3:57 PM · Calligra: 3.0
anthonyfieroni added a comment to D18963: Improve KoModeBox display in horizontal Mode.

It's good to +1

Feb 12 2019, 3:56 PM · Calligra: 3.0
abetts added a comment to D18963: Improve KoModeBox display in horizontal Mode.

The first image is the new version, not the old version. :)

Feb 12 2019, 3:55 PM · Calligra: 3.0
ngraham added a comment to D18963: Improve KoModeBox display in horizontal Mode.

The first image is the new version, not the old version. :)

Feb 12 2019, 3:54 PM · Calligra: 3.0
abetts added a comment to D18963: Improve KoModeBox display in horizontal Mode.

It is pretty rough. It works, but needs better looks. The toolbar section now takes up almost half of the screen.

Feb 12 2019, 3:53 PM · Calligra: 3.0
ngraham accepted D18963: Improve KoModeBox display in horizontal Mode.

Certainly a visual improvement! +1!

Feb 12 2019, 3:53 PM · Calligra: 3.0
ognarb updated the diff for D18963: Improve KoModeBox display in horizontal Mode.

Remove debug output

Feb 12 2019, 3:51 PM · Calligra: 3.0
ognarb added reviewers for D18963: Improve KoModeBox display in horizontal Mode: Calligra: 3.0, VDG.
Feb 12 2019, 3:50 PM · Calligra: 3.0
ognarb requested review of D18963: Improve KoModeBox display in horizontal Mode.
Feb 12 2019, 3:49 PM · Calligra: 3.0

Feb 11 2019

heikobecker closed D18866: Use check_symbol_exists instead of check_function_exists.
Feb 11 2019, 12:26 PM · Calligra: 3.0
danders accepted D18866: Use check_symbol_exists instead of check_function_exists.
Feb 11 2019, 9:56 AM · Calligra: 3.0

Feb 10 2019

heikobecker updated the diff for D18866: Use check_symbol_exists instead of check_function_exists.

Added missing "h". Thanks for noticing that.

Feb 10 2019, 11:20 AM · Calligra: 3.0
pino added inline comments to D18866: Use check_symbol_exists instead of check_function_exists.
Feb 10 2019, 11:14 AM · Calligra: 3.0
heikobecker added a comment to D18866: Use check_symbol_exists instead of check_function_exists.

What about the other ​check_function_exists, should they also be changed?

Feb 10 2019, 11:08 AM · Calligra: 3.0
heikobecker updated the diff for D18866: Use check_symbol_exists instead of check_function_exists.

Replaced other check_function_exists invocations

Feb 10 2019, 11:04 AM · Calligra: 3.0

Feb 9 2019

danders added a comment to D18866: Use check_symbol_exists instead of check_function_exists.

What about the other ​check_function_exists, should they also be changed?
Also, do you know when ​check_symbol_exists was introduced?
We still use cmake 2.8.12.

Feb 9 2019, 10:04 AM · Calligra: 3.0

Feb 8 2019

heikobecker requested review of D18866: Use check_symbol_exists instead of check_function_exists.
Feb 8 2019, 9:39 PM · Calligra: 3.0
danders requested review of D18843: Activate stencils docker in all apps.
Feb 8 2019, 9:44 AM · Calligra: 3.0
danders abandoned D18841: StencilBoxDocker: Make the docker collapsed by default.

mistake

Feb 8 2019, 9:28 AM · Calligra: 3.0
danders requested review of D18841: StencilBoxDocker: Make the docker collapsed by default.
Feb 8 2019, 9:24 AM · Calligra: 3.0

Feb 5 2019

danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Ok, it's accepted so please commit/push/land

Feb 5 2019, 8:16 AM · Calligra: 3.0

Feb 4 2019

niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • fixed whitespace, sorry
Feb 4 2019, 12:04 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Made windows show even without export-pdf flag
Feb 4 2019, 12:02 PM · Calligra: 3.0

Jan 31 2019

niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Made window show on pdf print and removed trailing spaces
Jan 31 2019, 11:35 AM · Calligra: 3.0
danders accepted D18466: Fixed calligra crashing when opening remote document.

Yes, close.
When export to pdf, the mainwindow is not shown and since we don't exit, the app will hang.
You need to invert the check in KoApplication line 460 so the window is shown.

Jan 31 2019, 10:51 AM · Calligra: 3.0

Jan 30 2019

niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Removed connection between job and exiting; added todo
Jan 30 2019, 2:39 PM · Calligra: 3.0
danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Yeah, well there are some half done designs in here :(

Jan 30 2019, 2:02 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

I have some doubts:

Jan 30 2019, 1:28 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Moved QString pdfFileName to KoApplicationPrivate
Jan 30 2019, 12:59 PM · Calligra: 3.0
danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Regarding the completed slot, the doc says:
--print Only print and exit
--export-pdf Only export to PDF and exit

Jan 30 2019, 12:52 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.
Jan 30 2019, 12:49 PM · Calligra: 3.0
anthonyfieroni added a comment to D18466: Fixed calligra crashing when opening remote document.

This solution is Qt <5.12 friendly

Jan 30 2019, 12:40 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

This solution is Qt <5.12 friendly

Jan 30 2019, 12:16 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Adding pdf filename as propriety of KoApplication
Jan 30 2019, 12:15 PM · Calligra: 3.0
boemann added a comment to D18466: Fixed calligra crashing when opening remote document.

regarding the lambda connection - nice to see that you use the version with a "still alive" argument - but I fear this requires a qt version higher than what we currently support - could you please check

Jan 30 2019, 10:08 AM · Calligra: 3.0