Feed Advanced Search

Feb 14 2019

ognarb updated the summary of D18994: Update screenshots for Calligra sheets 3.1.
Feb 14 2019, 3:37 PM · Documentation, Calligra: 3.0
yurchor accepted D18994: Update screenshots for Calligra sheets 3.1.

Thanks.

Feb 14 2019, 2:48 PM · Documentation, Calligra: 3.0
leinir added a comment to D18994: Update screenshots for Calligra sheets 3.1.

A quick note that you kind of got the name of the suite wrong in a few places, it's called Calligra, not Callibra :)

Feb 14 2019, 1:26 PM · Documentation, Calligra: 3.0
ognarb updated the summary of D18994: Update screenshots for Calligra sheets 3.1.
Feb 14 2019, 1:23 PM · Documentation, Calligra: 3.0
danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Thanks, I'm checking it out now...
Just a couple of things:
Keywords needs to be on a separate line to have effect, see https://community.kde.org/Infrastructure/Git/Hooks
Also FIXED-IN is nice to add.

Feb 14 2019, 10:10 AM · Calligra: 3.0
ognarb updated the test plan for D18994: Update screenshots for Calligra sheets 3.1.
Feb 14 2019, 1:29 AM · Documentation, Calligra: 3.0
ognarb updated the diff for D18994: Update screenshots for Calligra sheets 3.1.

Now compile with checkXML5

Feb 14 2019, 1:28 AM · Documentation, Calligra: 3.0
ognarb added reviewers for D18994: Update screenshots for Calligra sheets 3.1: Calligra: 3.0, Documentation.
Feb 14 2019, 1:26 AM · Documentation, Calligra: 3.0
ognarb requested review of D18994: Update screenshots for Calligra sheets 3.1.
Feb 14 2019, 1:26 AM · Documentation, Calligra: 3.0

Feb 13 2019

ognarb closed D18989: Remove minor duplicate code and fix related bug.
Feb 13 2019, 9:16 PM · Calligra: 3.0
boemann accepted D18989: Remove minor duplicate code and fix related bug.
Feb 13 2019, 9:09 PM · Calligra: 3.0
ognarb added a reviewer for D18989: Remove minor duplicate code and fix related bug: Calligra: 3.0.
Feb 13 2019, 8:50 PM · Calligra: 3.0
ognarb requested review of D18989: Remove minor duplicate code and fix related bug.
Feb 13 2019, 8:42 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

It seems like it landed. Please tell me if I screwed up anything.

Feb 13 2019, 7:00 PM · Calligra: 3.0
niccolove closed D18466: Fixed calligra crashing when opening remote document.
Feb 13 2019, 6:57 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.

BUG:358581

Feb 13 2019, 6:34 PM · Calligra: 3.0
ognarb updated the test plan for D18963: Improve KoModeBox display in horizontal Mode.
Feb 13 2019, 3:15 PM · Calligra: 3.0
ognarb closed D18963: Improve KoModeBox display in horizontal Mode.
Feb 13 2019, 3:13 PM · Calligra: 3.0
ognarb updated the diff for D18963: Improve KoModeBox display in horizontal Mode.

remove more trailing whitespace

Feb 13 2019, 3:10 PM · Calligra: 3.0
ognarb updated the diff for D18963: Improve KoModeBox display in horizontal Mode.

remove trailing whitespace

Feb 13 2019, 2:03 PM · Calligra: 3.0
danders closed D18843: Activate stencils docker in all apps.
Feb 13 2019, 8:51 AM · Calligra: 3.0
danders added a comment to D18963: Improve KoModeBox display in horizontal Mode.

Please remove trailing whitespace.

Feb 13 2019, 8:41 AM · Calligra: 3.0
boemann accepted D18843: Activate stencils docker in all apps.

I definitely don't want this docker default on, but if as you say it's default off then i guess your change is okay - i'll take your word for it

Feb 13 2019, 8:34 AM · Calligra: 3.0
danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Dan can you please reply - I'm fine with the account but I can't reply to Ben as I am not able to send email

Feb 13 2019, 8:22 AM · Calligra: 3.0
boemann added a comment to D18466: Fixed calligra crashing when opening remote document.

Dan can you please reply - I'm fine with the account but I can't reply to Ben as I am not able to send email

Feb 13 2019, 3:55 AM · Calligra: 3.0

Feb 12 2019

ognarb added a comment to D18963: Improve KoModeBox display in horizontal Mode.

Ok thanks for the review, I will retry to compile calligra master and see if it's still work and then land this diff. 😄

Feb 12 2019, 9:04 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

I do not have a developer account. I requested one some days ago with no answer yet.

Feb 12 2019, 8:55 PM · Calligra: 3.0
boemann accepted D18963: Improve KoModeBox display in horizontal Mode.

I like it

Feb 12 2019, 3:57 PM · Calligra: 3.0
anthonyfieroni added a comment to D18963: Improve KoModeBox display in horizontal Mode.

It's good to +1

Feb 12 2019, 3:56 PM · Calligra: 3.0
abetts added a comment to D18963: Improve KoModeBox display in horizontal Mode.

The first image is the new version, not the old version. :)

Feb 12 2019, 3:55 PM · Calligra: 3.0
ngraham added a comment to D18963: Improve KoModeBox display in horizontal Mode.

The first image is the new version, not the old version. :)

Feb 12 2019, 3:54 PM · Calligra: 3.0
abetts added a comment to D18963: Improve KoModeBox display in horizontal Mode.

It is pretty rough. It works, but needs better looks. The toolbar section now takes up almost half of the screen.

Feb 12 2019, 3:53 PM · Calligra: 3.0
ngraham accepted D18963: Improve KoModeBox display in horizontal Mode.

Certainly a visual improvement! +1!

Feb 12 2019, 3:53 PM · Calligra: 3.0
ognarb updated the diff for D18963: Improve KoModeBox display in horizontal Mode.

Remove debug output

Feb 12 2019, 3:51 PM · Calligra: 3.0
ognarb added reviewers for D18963: Improve KoModeBox display in horizontal Mode: Calligra: 3.0, VDG.
Feb 12 2019, 3:50 PM · Calligra: 3.0
ognarb requested review of D18963: Improve KoModeBox display in horizontal Mode.
Feb 12 2019, 3:49 PM · Calligra: 3.0

Feb 11 2019

heikobecker closed D18866: Use check_symbol_exists instead of check_function_exists.
Feb 11 2019, 12:26 PM · Calligra: 3.0
danders accepted D18866: Use check_symbol_exists instead of check_function_exists.
Feb 11 2019, 9:56 AM · Calligra: 3.0

Feb 10 2019

heikobecker updated the diff for D18866: Use check_symbol_exists instead of check_function_exists.

Added missing "h". Thanks for noticing that.

Feb 10 2019, 11:20 AM · Calligra: 3.0
pino added inline comments to D18866: Use check_symbol_exists instead of check_function_exists.
Feb 10 2019, 11:14 AM · Calligra: 3.0
heikobecker added a comment to D18866: Use check_symbol_exists instead of check_function_exists.

What about the other ​check_function_exists, should they also be changed?

Feb 10 2019, 11:08 AM · Calligra: 3.0
heikobecker updated the diff for D18866: Use check_symbol_exists instead of check_function_exists.

Replaced other check_function_exists invocations

Feb 10 2019, 11:04 AM · Calligra: 3.0

Feb 9 2019

danders added a comment to D18866: Use check_symbol_exists instead of check_function_exists.

What about the other ​check_function_exists, should they also be changed?
Also, do you know when ​check_symbol_exists was introduced?
We still use cmake 2.8.12.

Feb 9 2019, 10:04 AM · Calligra: 3.0

Feb 8 2019

heikobecker requested review of D18866: Use check_symbol_exists instead of check_function_exists.
Feb 8 2019, 9:39 PM · Calligra: 3.0
danders requested review of D18843: Activate stencils docker in all apps.
Feb 8 2019, 9:44 AM · Calligra: 3.0
danders abandoned D18841: StencilBoxDocker: Make the docker collapsed by default.

mistake

Feb 8 2019, 9:28 AM · Calligra: 3.0
danders requested review of D18841: StencilBoxDocker: Make the docker collapsed by default.
Feb 8 2019, 9:24 AM · Calligra: 3.0

Feb 5 2019

danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Ok, it's accepted so please commit/push/land

Feb 5 2019, 8:16 AM · Calligra: 3.0

Feb 4 2019

niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • fixed whitespace, sorry
Feb 4 2019, 12:04 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Made windows show even without export-pdf flag
Feb 4 2019, 12:02 PM · Calligra: 3.0

Jan 31 2019

niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Made window show on pdf print and removed trailing spaces
Jan 31 2019, 11:35 AM · Calligra: 3.0
danders accepted D18466: Fixed calligra crashing when opening remote document.

Yes, close.
When export to pdf, the mainwindow is not shown and since we don't exit, the app will hang.
You need to invert the check in KoApplication line 460 so the window is shown.

Jan 31 2019, 10:51 AM · Calligra: 3.0

Jan 30 2019

niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Removed connection between job and exiting; added todo
Jan 30 2019, 2:39 PM · Calligra: 3.0
danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Yeah, well there are some half done designs in here :(

Jan 30 2019, 2:02 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

I have some doubts:

Jan 30 2019, 1:28 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Moved QString pdfFileName to KoApplicationPrivate
Jan 30 2019, 12:59 PM · Calligra: 3.0
danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Regarding the completed slot, the doc says:
--print Only print and exit
--export-pdf Only export to PDF and exit

Jan 30 2019, 12:52 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.
Jan 30 2019, 12:49 PM · Calligra: 3.0
anthonyfieroni added a comment to D18466: Fixed calligra crashing when opening remote document.

This solution is Qt <5.12 friendly

Jan 30 2019, 12:40 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

This solution is Qt <5.12 friendly

Jan 30 2019, 12:16 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Adding pdf filename as propriety of KoApplication
Jan 30 2019, 12:15 PM · Calligra: 3.0
boemann added a comment to D18466: Fixed calligra crashing when opening remote document.

regarding the lambda connection - nice to see that you use the version with a "still alive" argument - but I fear this requires a qt version higher than what we currently support - could you please check

Jan 30 2019, 10:08 AM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

What have I Done:

Jan 30 2019, 9:56 AM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Added slots in KoApplication to handle pdf and print.
Jan 30 2019, 9:38 AM · Calligra: 3.0

Jan 29 2019

niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Removed unnecessary newlines
Jan 29 2019, 9:59 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Made slotFilePrint depend on signal loadCompleted to avoid it running before remote file being complete
Jan 29 2019, 9:58 PM · Calligra: 3.0

Jan 28 2019

danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Well, unit tests has been added that fails without this patch and passes with this patch.
If there are more test cases needed, please add them so that we can get this patch committed soon...

Jan 28 2019, 12:11 PM · Calligra: 3.0

Jan 27 2019

danders added a comment to D18466: Fixed calligra crashing when opening remote document.

I'm not sure on how to do that, do you have any tip?
openDocumentInternal is called by openDocument, which is called in KoApplication just before checking the arguments. When it sees the print argument, it calls slotFilePrint. openDocumentInternal downloads the document in async. Should it be made not async, or is there another way to make it wait until the other process ends? Also, "slotLoadCanceled" is already implemented, or were you talking about something else?

Jan 27 2019, 9:13 AM · Calligra: 3.0

Jan 26 2019

anthonyfieroni added a comment to D18466: Fixed calligra crashing when opening remote document.

So just don't call slotFilePrint connect loadCompleted to slotFilePrint. When openDocumentInternal downloads the document it fires signal of finish, just connect to slot of opened it.

Jan 26 2019, 5:24 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

I'm not sure on how to do that, do you have any tip?
openDocumentInternal is called by openDocument, which is called in KoApplication just before checking the arguments. When it sees the print argument, it calls slotFilePrint. openDocumentInternal downloads the document in async. Should it be made not async, or is there another way to make it wait until the other process ends? Also, "slotLoadCanceled" is already implemented, or were you talking about something else?

Jan 26 2019, 5:13 PM · Calligra: 3.0

Jan 25 2019

anthonyfieroni added a comment to D18466: Fixed calligra crashing when opening remote document.

Probably we need to start printing in a slot connected to KoMainWindow::loadCompleted() instead.
And to be safe, we also need to handle loadCanceled().

Jan 25 2019, 9:04 AM · Calligra: 3.0
danders added a comment to D18466: Fixed calligra crashing when opening remote document.

I think the problem is that slotFilePrint() is called (in KoApplication::start()) before the document is actually loaded.
Probably we need to start printing in a slot connected to KoMainWindow::loadCompleted() instead.
And to be safe, we also need to handle loadCanceled().
And the same for exportToPdf, I think.

Jan 25 2019, 7:17 AM · Calligra: 3.0

Jan 23 2019

niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

I tried differents files (locale and remote, opening and printing), and everything works okay. Other applications work normally, but calligrasheets still crashes when trying to print a remote (odt) file - but I can see the file is downloaded correctly, so it looks like a different problem (calligrasheets manages printing?).
About removing features from slotLoadCompleted, it is important to notice that it is only called by openDocumentInternal itself, so that should not be a problem.

Jan 23 2019, 1:31 PM · Calligra: 3.0
boemann added a comment to D18466: Fixed calligra crashing when opening remote document.

Please check with loading a normal document,. The same concerns now applies to slotLoadCompleted - especially since you have now removed functionality from it.

Jan 23 2019, 1:23 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

I've seen that openDoumentInternal is called every time a remote document is used as input. I'm not sure if it's also used in different scenarios.

Jan 23 2019, 1:19 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Moving the if from slotLoadCompleted to openDocumentInternal.
Jan 23 2019, 1:16 PM · Calligra: 3.0
boemann added a reviewer for D18466: Fixed calligra crashing when opening remote document: danders.
Jan 23 2019, 1:16 PM · Calligra: 3.0
boemann added a comment to D18466: Fixed calligra crashing when opening remote document.

Yes that description helped a lot, and you are doing great. Keep up the good work :)

Jan 23 2019, 1:14 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

At this point my only worry is that the setRootDocument in openDocumentInternal makes the check for opening a new window in slotLoadCompleted useless. Moving the whole if statement from slotLoadCompleted to openDocumentInternal also works, and could avoid to replace the root document instead of opening a new window. It makes more sense, now that I think of it.

Jan 23 2019, 1:13 PM · Calligra: 3.0
niccolove added a comment to D18466: Fixed calligra crashing when opening remote document.

Sure.
Calligra was crashing because the method "slotFilePrint" called "rootView()" that tried to return the first elements of "d->rootViews". The problem is that such list was empitya, as SetRootDocument was never called: that method is called in openDocument but not in openDocumentInternal. I therefore added that function and it now works. But, when slotLoadCompleted is called (that is, after slotFilePrint), there's a check to open a new window if there's already a non-blank document. Since the root document was already set, it opened a new window with the same document. I therefore added the conditions of the two documents being different.
I hope I've been clear, this is one of my first commits here :-/

Jan 23 2019, 1:07 PM · Calligra: 3.0
boemann added a comment to D18466: Fixed calligra crashing when opening remote document.

Could you please describe what you have done and why

Jan 23 2019, 12:54 PM · Calligra: 3.0
niccolove updated the test plan for D18466: Fixed calligra crashing when opening remote document.
Jan 23 2019, 12:53 PM · Calligra: 3.0
niccolove updated the diff for D18466: Fixed calligra crashing when opening remote document.
  • Fixed typos
Jan 23 2019, 12:52 PM · Calligra: 3.0
niccolove requested review of D18466: Fixed calligra crashing when opening remote document.
Jan 23 2019, 12:49 PM · Calligra: 3.0

Jan 22 2019

boemann accepted D18448: Replaced "distraction free" with "fullscreen" - BUG:378527.
Jan 22 2019, 9:10 AM · Calligra: 3.0
danders added a reviewer for D18448: Replaced "distraction free" with "fullscreen" - BUG:378527: boemann.
Jan 22 2019, 8:54 AM · Calligra: 3.0
niccolove retitled D18448: Replaced "distraction free" with "fullscreen" - BUG:378527 from Replaced "distraction free" with "fullscreen"BUG:378527 to Replaced "distraction free" with "fullscreen" - BUG:378527.
Jan 22 2019, 8:37 AM · Calligra: 3.0
niccolove retitled D18448: Replaced "distraction free" with "fullscreen" - BUG:378527 from Replaced "disturb free" with "fullscreen"BUG:378527 to Replaced "distraction free" with "fullscreen"BUG:378527.
Jan 22 2019, 8:36 AM · Calligra: 3.0
niccolove updated the summary of D18448: Replaced "distraction free" with "fullscreen" - BUG:378527.
Jan 22 2019, 8:36 AM · Calligra: 3.0
niccolove requested review of D18448: Replaced "distraction free" with "fullscreen" - BUG:378527.
Jan 22 2019, 8:36 AM · Calligra: 3.0

Jan 17 2019

danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Ran this patch against new unit tests and it fixes all the expected ones, namely those where all cells in first row is merged with cells in second row.
Test results without patch: https://build.kde.org/job/Calligra/job/calligra/job/kf5-qt5%20SUSEQt5.10/lastCompletedBuild/testReport/projectroot.libs.textlayout/tests/libs_kotextlayout_TestTableLayout
See uploaded file for result with patch.

Jan 17 2019, 6:40 AM · Calligra: 3.0

Jan 15 2019

danders closed D18095: Add new table layout unit tests.
Jan 15 2019, 11:06 AM · Calligra: 3.0
boemann added a comment to D18095: Add new table layout unit tests.

absolutely

Jan 15 2019, 11:04 AM · Calligra: 3.0
danders added a comment to D18095: Add new table layout unit tests.

Even if they do not all pass, I think they should be commited if the tests/methods are ok and the reason for not passing are genuin bugs, no?

Jan 15 2019, 11:02 AM · Calligra: 3.0

Jan 10 2019

danders updated the diff for D18095: Add new table layout unit tests.

Add a test that trigger a loop in the table layout

Jan 10 2019, 10:16 AM · Calligra: 3.0

Jan 8 2019

danders added a comment to D18095: Add new table layout unit tests.

No, all do not pass, generally when the first row is merged, layout fails.
(I am trying to provoke problems similar to bug 381341 that we have tried to fix in D15428.)

Jan 8 2019, 1:51 PM · Calligra: 3.0
boemann added a comment to D18095: Add new table layout unit tests.

Looks like a good first start to me - do they pass currently? - if so then i think they should be pushed

Jan 8 2019, 1:29 PM · Calligra: 3.0
danders added a comment to D18095: Add new table layout unit tests.

Not trivial (for me) to get data out of layout so it is hard to create robust tests.
I don't think I have been able to create a test to simulate the loop excactly.
Also, uncertain wether the MockRootAreaProvider is sufficient.
Any ideas/comments wellcome.

Jan 8 2019, 12:41 PM · Calligra: 3.0
danders requested review of D18095: Add new table layout unit tests.
Jan 8 2019, 12:37 PM · Calligra: 3.0

Dec 27 2018

cfeck closed D17352: Made descriptions for DEC2BIN/OCT2BIN/HEX2DEC/HEX2BIN mention input number system.
Dec 27 2018, 6:13 PM · Calligra: 3.0