Feed Advanced Search

Sat, Sep 14

boemann accepted D7946: CSV characters should not be translated.

Looks simple enough to me too - someone please push

Sat, Sep 14, 7:02 PM · Calligra: 3.0
guoyunhe added a comment to D7946: CSV characters should not be translated.

How can we push this forward?

Sat, Sep 14, 5:30 PM · Calligra: 3.0

Sun, Sep 8

anthonyfieroni added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Let's commit this, it's fair small patch but it covers some unwanted crashes.

Sun, Sep 8, 6:46 AM · Calligra: 3.0

Sat, Sep 7

anthonyfieroni closed D23327: [Gemini] Clarify deletion of document.
Sat, Sep 7, 10:18 AM · Calligra: 3.0
anthonyfieroni closed D23617: [gemini] Remove "template://" scheme from file name.
Sat, Sep 7, 10:18 AM · Calligra: 3.0
leinir accepted D23617: [gemini] Remove "template://" scheme from file name.

Long as that works on linux, that ought to do the trick, yes :) (probably ought to have been there to start with anyway)

Sat, Sep 7, 8:11 AM · Calligra: 3.0

Tue, Sep 3

anthonyfieroni updated the diff for D23617: [gemini] Remove "template://" scheme from file name.

I can't test, but it should be fine.

Tue, Sep 3, 6:13 PM · Calligra: 3.0

Mon, Sep 2

leinir requested changes to D23617: [gemini] Remove "template://" scheme from file name.

Something tells me there's going to be problems on windows if this gets done... since that is the precise reason that code exists in the first place: https://phabricator.kde.org/R8:c1866b590bd6103fdf118558834104be2737cca4

Mon, Sep 2, 5:27 PM · Calligra: 3.0
anthonyfieroni updated the diff for D23617: [gemini] Remove "template://" scheme from file name.

Test plan:

Mon, Sep 2, 3:49 PM · Calligra: 3.0
dcaliste closed D23492: Correct anchor detection in QML components..
Mon, Sep 2, 1:57 PM · Calligra: 3.0
dcaliste abandoned D23679: Correct anchor detection in QML components..

Sorry, made a mistake with arc… This differential revision is already D23492.

Mon, Sep 2, 1:36 PM · Calligra: 3.0
dcaliste requested review of D23679: Correct anchor detection in QML components..
Mon, Sep 2, 1:34 PM · Calligra: 3.0
pvuorela added a comment to D23492: Correct anchor detection in QML components..

And even rendering now better, no idea what happened.

Mon, Sep 2, 12:41 PM · Calligra: 3.0
pvuorela accepted D23492: Correct anchor detection in QML components..

Having a bit strange rendering for TextDocumentImpl.cpp changes here, but the raw diff looks good now. Trust all good :)

Mon, Sep 2, 12:40 PM · Calligra: 3.0
leinir added a comment to D23617: [gemini] Remove "template://" scheme from file name.

That makes sense but none handle that schemes or should be responsible for that?

Mon, Sep 2, 8:02 AM · Calligra: 3.0
dcaliste updated the diff for D23492: Correct anchor detection in QML components..

Thank you pvuorela pointing out other places for this construct. I've updated the patch with a fix for the faulty loops for spreadsheets and presentations also.

Mon, Sep 2, 7:00 AM · Calligra: 3.0

Sun, Sep 1

anthonyfieroni added a comment to D23617: [gemini] Remove "template://" scheme from file name.

That makes sense but none handle that schemes or should be responsible for that?

Sun, Sep 1, 11:19 AM · Calligra: 3.0
leinir added a comment to D23617: [gemini] Remove "template://" scheme from file name.

The idea is that the template protocol gets caught by the components, which marks the file as new, resets the filename and so on (the way you would expect a template to work). Doing it this way just opens the template as a file, and requires the user to manually do the save-as thing... Unless you are trying to actually edit the template, this isn't the solution... Create file will be something similar.

Sun, Sep 1, 9:40 AM · Calligra: 3.0

Sat, Aug 31

anthonyfieroni requested review of D23617: [gemini] Remove "template://" scheme from file name.
Sat, Aug 31, 8:14 PM · Calligra: 3.0
anthonyfieroni updated the diff for D23327: [Gemini] Clarify deletion of document.

Fix a bunch of crashes :)

Sat, Aug 31, 7:32 PM · Calligra: 3.0

Fri, Aug 30

leinir accepted D23492: Correct anchor detection in QML components..

Oh dear, yes, took a moment. Well spotted indeed!

Fri, Aug 30, 11:33 AM · Calligra: 3.0
pvuorela added a comment to D23492: Correct anchor detection in QML components..

Indeed that doesn't look like a good loop, if triggered once, nothing affecting the break out condition inside of it. But isn't the same thing happening also at the beginning of this method, and actually same kind of construct being there in spreadsheet and presentation impls too?

Fri, Aug 30, 11:27 AM · Calligra: 3.0

Tue, Aug 27

dcaliste requested review of D23492: Correct anchor detection in QML components..
Tue, Aug 27, 1:32 PM · Calligra: 3.0

Aug 21 2019

leinir accepted D23327: [Gemini] Clarify deletion of document.

Well spotted. Yes, this is frankly from before i quite understood how smart pointer types worked, so... yeah, my bad, and thanks for sorting this :) As you say, there's plenty of more stuff to do, including some semi-basic interaction issues...

Aug 21 2019, 7:15 PM · Calligra: 3.0
anthonyfieroni requested review of D23327: [Gemini] Clarify deletion of document.
Aug 21 2019, 6:41 PM · Calligra: 3.0

Aug 16 2019

asturmlechner abandoned D23202: Fix headers for >=KCalCore-5.12.0.
Aug 16 2019, 4:21 PM · Calligra: 3.0
vkrause added a comment to D23202: Fix headers for >=KCalCore-5.12.0.

Version header backward compatibility addressed in D23204.

Aug 16 2019, 4:02 PM · Calligra: 3.0
vkrause added a comment to D23202: Fix headers for >=KCalCore-5.12.0.

see https://cgit.kde.org/kcalcore.git/tree/src/CMakeLists.txt#n138 - seems to work here

Aug 16 2019, 3:54 PM · Calligra: 3.0
asturmlechner added a comment to D23202: Fix headers for >=KCalCore-5.12.0.

This isn't wrong, but I'm surprised it's needed, we explicitly install headers in the old location too, for compatibility?

Aug 16 2019, 3:49 PM · Calligra: 3.0
vkrause added a comment to D23202: Fix headers for >=KCalCore-5.12.0.

This isn't wrong, but I'm surprised it's needed, we explicitly install headers in the old location too, for compatibility?

Aug 16 2019, 3:47 PM · Calligra: 3.0
dfaure requested changes to D23202: Fix headers for >=KCalCore-5.12.0.
Aug 16 2019, 3:47 PM · Calligra: 3.0
dfaure added a reviewer for D23202: Fix headers for >=KCalCore-5.12.0: vkrause.
Aug 16 2019, 3:46 PM · Calligra: 3.0
asturmlechner requested review of D23202: Fix headers for >=KCalCore-5.12.0.
Aug 16 2019, 2:29 PM · Calligra: 3.0

Jul 24 2019

usta updated subscribers of D22545: Add missing include QDate.

Because i was away for a short vacation i coudnt commit this one but
@dfaure committed same thing :) with 0c5430697bdcf41a45046107b28014e40c49a11a
So i think we need to discard this review

Jul 24 2019, 2:40 AM · Calligra: 3.0

Jul 20 2019

pino added a comment to D22545: Add missing include QDate.
In D22545#498239, @usta wrote:

i will just commit this to master or do i need to xommit to a branch then merge it to master ?

Jul 20 2019, 3:25 AM · Calligra: 3.0

Jul 19 2019

usta added a comment to D22545: Add missing include QDate.

i will just commit this to master or do i need to xommit to a branch then merge it to master ? (i have been away from kde about more then 6 years)

Jul 19 2019, 10:10 PM · Calligra: 3.0
boemann accepted D22545: Add missing include QDate.

btw For such small fixes we don't usually require review

Jul 19 2019, 10:08 AM · Calligra: 3.0

Jul 18 2019

usta requested review of D22545: Add missing include QDate.
Jul 18 2019, 11:35 PM · Calligra: 3.0

Jun 20 2019

anthonyfieroni accepted D20400: Karbon: Enable multi page capability.

I saw filters does not compile when it compiles Karbon only, i should correct that, but i have much time now.
Edit: I investigate and it works correctly, i mislead APP_KARBON and KARBON.

Jun 20 2019, 7:52 AM · Calligra: 3.0

Jun 10 2019

anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

If you mean export to svg here, afaics there are no page element in svg. Have I missed it?

Jun 10 2019, 12:39 PM · Calligra: 3.0

Jun 7 2019

danders added a comment to D20400: Karbon: Enable multi page capability.

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

Jun 7 2019, 8:47 AM · Calligra: 3.0

Jun 6 2019

anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

Jun 6 2019, 7:58 PM · Calligra: 3.0
danders updated the diff for D20400: Karbon: Enable multi page capability.

Add dependence on LIB_KOPAGEAPP

Jun 6 2019, 12:33 PM · Calligra: 3.0

Jun 5 2019

danders added a comment to D20400: Karbon: Enable multi page capability.

I have been pondering why we disagreed so much on the background color, and I *think* I have an answer.
My take is it's because we have not been talking about quite the same thing:
I have looked at karbon as an *odg* editor, since it uses odg as its native file format.
Since odg is wysiwyg nothing outside the doc should in any way affect the way it is presented, hence a background that is not saved to file doesn't make sence.

Jun 5 2019, 8:36 AM · Calligra: 3.0
anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Apparently it has a problem, when we compile only Karbon, as i done now, KoPAView is in pageapp, which is not compile-able in Karbon, right?
Full cmake command

cmake .. -DCMAKE_INSTALL_PREFIX=/usr  -DCMAKE_INSTALL_LIBDIR=lib -DKDE_INSTALL_PLUGINDIR=/usr/lib/qt5/plugins -DKDE_INSTALL_USE_QT_SYS_PATHS=ON -DBUILD_TESTING=FALSE -DPACKAGERS_BUILD=true -DBUILD_UNMAINTAINED=TRUE -DPRODUCTSET=APP_KARBON
Jun 5 2019, 6:30 AM · Calligra: 3.0

Jun 4 2019

rjvbb added a comment to D20400: Karbon: Enable multi page capability.

code wise looks good

Jun 4 2019, 10:34 PM · Calligra: 3.0
anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Someone test it, code wise looks good, i plan to test it soon.

Jun 4 2019, 8:36 PM · Calligra: 3.0
anthonyfieroni abandoned D19327: Karbon: Enable multi page capability.

In flavor of D20400

Jun 4 2019, 8:35 PM · Calligra: 3.0
anthonyfieroni commandeered D19327: Karbon: Enable multi page capability.
Jun 4 2019, 8:35 PM · Calligra: 3.0
anthonyfieroni abandoned D19216: Karbon: Enable multi page capability.

In flavor of D20400

Jun 4 2019, 8:35 PM · Calligra: 3.0
anthonyfieroni commandeered D19216: Karbon: Enable multi page capability.
Jun 4 2019, 8:34 PM · Calligra: 3.0

Jun 3 2019

pshinjo added a comment to D21553: add Korean Hangul jamo code point ranges.

First of all, thanks for the work. Some things are passing through my mind, especially regarding classical Hangul and half-completed Hangul characters.

Jun 3 2019, 5:47 PM · Calligra: 3.0
daehyuns updated subscribers of D21553: add Korean Hangul jamo code point ranges.
Jun 3 2019, 10:47 AM · Calligra: 3.0
daehyuns requested review of D21553: add Korean Hangul jamo code point ranges.
Jun 3 2019, 4:41 AM · Calligra: 3.0

Apr 26 2019

pvuorela added a comment to D19759: Remove unsupported attributes from QGraphicsWidgets.

Second ping for this.

Apr 26 2019, 3:01 PM · Calligra: 3.0

Apr 9 2019

rjvbb added a comment to D20400: Karbon: Enable multi page capability.
(Sorry for the inconvinience, I've never been very friendly with arc/phab)
Apr 9 2019, 8:31 AM · Calligra: 3.0
danders added a comment to D20400: Karbon: Enable multi page capability.

Ooops, this didn't work as expected. This should have been a revision of D19327.
There is only small changes:

  1. Updated commit message.
  2. In karbon/ui/KarbonFactory.cpp: Loading of the calligra/pageapp tools.
  3. In karbon/data/karbon.rc: Removal of the "format" menu (not used) and adding the "format_pagelayout" action to "settings" menu (where it was originally).
Apr 9 2019, 7:05 AM · Calligra: 3.0
danders requested review of D20400: Karbon: Enable multi page capability.
Apr 9 2019, 6:40 AM · Calligra: 3.0

Apr 4 2019

pvuorela closed D19943: Small cleanups for qml components.
Apr 4 2019, 9:48 AM · Calligra: 3.0
pvuorela closed D19944: Migrate away from deprecated interfaces in gemini dropbox parts.
Apr 4 2019, 9:48 AM · Calligra: 3.0
pvuorela added a comment to D19759: Remove unsupported attributes from QGraphicsWidgets.

Ping, how about this one? The behavior change, or lack of it, should be mostly visible around qgraphicswidget_p.h -> attributeToBitIndex() & setAttribute().

Apr 4 2019, 9:18 AM · Calligra: 3.0

Mar 27 2019

leinir accepted D19943: Small cleanups for qml components.
Mar 27 2019, 1:28 PM · Calligra: 3.0
pvuorela added inline comments to D19943: Small cleanups for qml components.
Mar 27 2019, 1:23 PM · Calligra: 3.0
leinir accepted D19944: Migrate away from deprecated interfaces in gemini dropbox parts.

If memory serves, we'll need to do a fair bit of work to get the DropBox code to work properly again. DropBox has turned off the V1 API support, and we'll need to work against the V2 stuff now, which... Well, it might be trivial, but i have no time to look at it, i'm afraid. Be really good to get it back, though.

Mar 27 2019, 12:45 PM · Calligra: 3.0
leinir added inline comments to D19943: Small cleanups for qml components.
Mar 27 2019, 12:40 PM · Calligra: 3.0

Mar 26 2019

dcaliste closed D19973: MsooXmlCommonRead: protect member for double free.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19941: Avoid deprecated setSupportedDragActions.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19938: Avoid deprecated QRegion::subtract().
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19761: Remove obsolete syncX() workaround.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19760: Support Qt <5.7 on KoShape flag usage.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19885: Implement logging category for excel plugins.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19912: Implement logging category for rtf-qt.
Mar 26 2019, 9:47 AM · Calligra: 3.0

Mar 25 2019

danders closed D11971: Use same keyword separator for read and write.
Mar 25 2019, 1:49 PM · Calligra: 3.0
danders added a comment to D11971: Use same keyword separator for read and write.

Yes, looks sane, I'll deal with it.

Mar 25 2019, 9:08 AM · Calligra: 3.0
danders accepted D19884: Avoid deprecated QAbstractItemModel::reset().

I think this should be ok

Mar 25 2019, 8:58 AM · Calligra: 3.0
danders accepted D19973: MsooXmlCommonRead: protect member for double free.
Mar 25 2019, 8:53 AM · Calligra: 3.0

Mar 22 2019

anthonyfieroni added a comment to D11971: Use same keyword separator for read and write.

Ping this looks sane, anyone ?

Mar 22 2019, 1:22 PM · Calligra: 3.0
pvuorela requested review of D19973: MsooXmlCommonRead: protect member for double free.
Mar 22 2019, 1:09 PM · Calligra: 3.0
danders accepted D19941: Avoid deprecated setSupportedDragActions.
Mar 22 2019, 8:14 AM · Calligra: 3.0

Mar 21 2019

pvuorela requested review of D19944: Migrate away from deprecated interfaces in gemini dropbox parts.
Mar 21 2019, 3:27 PM · Calligra: 3.0
pvuorela requested review of D19943: Small cleanups for qml components.
Mar 21 2019, 3:24 PM · Calligra: 3.0
pvuorela requested review of D19941: Avoid deprecated setSupportedDragActions.
Mar 21 2019, 1:33 PM · Calligra: 3.0
danders accepted D19938: Avoid deprecated QRegion::subtract().
Mar 21 2019, 12:22 PM · Calligra: 3.0
pvuorela requested review of D19938: Avoid deprecated QRegion::subtract().
Mar 21 2019, 11:12 AM · Calligra: 3.0

Mar 20 2019

danders added a comment to D19912: Implement logging category for rtf-qt.

Strange indents, could you fix it?

That's what I commented on the summary. On some parts rtf-qt uses plain spaces for indentation and those parts look good. Then in the same file other methods might have a hard tab or a hard tab followed by spaces. If you really want, I can try to retain the old whitespace, but it's indentation-wise more or less broken already anyway :) Alternatively could run astyle for the subdirectory, though maybe best done as separate commit.

Yes, sorry, as you say better done separatly.

The directory README also states "Temporary local copy of Brad Hards' rtf-qt library.", though as upstream hasn't had changes since 2011, it seems like a permanent one by now.

Probably.

Mar 20 2019, 12:39 PM · Calligra: 3.0
pvuorela added a comment to D19912: Implement logging category for rtf-qt.

Strange indents, could you fix it?

Mar 20 2019, 11:54 AM · Calligra: 3.0
danders accepted D19912: Implement logging category for rtf-qt.

Strange indents, could you fix it?
Otherwise ok.

Mar 20 2019, 11:32 AM · Calligra: 3.0
pvuorela requested review of D19912: Implement logging category for rtf-qt.
Mar 20 2019, 11:21 AM · Calligra: 3.0
danders added inline comments to D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 20 2019, 10:57 AM · Calligra: 3.0
danders accepted D19885: Implement logging category for excel plugins.
Mar 20 2019, 10:31 AM · Calligra: 3.0
pvuorela added inline comments to D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 20 2019, 9:59 AM · Calligra: 3.0

Mar 19 2019

dcaliste added inline comments to D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 19 2019, 7:15 PM · Calligra: 3.0
pvuorela updated the diff for D19885: Implement logging category for excel plugins.

Eliminated one unintended #ifdef SWINDER_XLS2RAW removal from the patch.

Mar 19 2019, 4:09 PM · Calligra: 3.0
pvuorela updated the diff for D19759: Remove unsupported attributes from QGraphicsWidgets.

Updated to remove also WA_StaticContents in addition to earlier WA_InputMethodEnabled.

Mar 19 2019, 3:03 PM · Calligra: 3.0
pvuorela requested review of D19885: Implement logging category for excel plugins.
Mar 19 2019, 2:56 PM · Calligra: 3.0
pvuorela requested review of D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 19 2019, 2:51 PM · Calligra: 3.0

Mar 15 2019

danders added a reviewer for D19759: Remove unsupported attributes from QGraphicsWidgets: boemann.
Mar 15 2019, 7:56 AM · Calligra: 3.0
danders accepted D19760: Support Qt <5.7 on KoShape flag usage.
Mar 15 2019, 7:43 AM · Calligra: 3.0
danders accepted D19761: Remove obsolete syncX() workaround.
Mar 15 2019, 7:39 AM · Calligra: 3.0