Feed Advanced Search

Thu, Jun 20

anthonyfieroni accepted D20400: Karbon: Enable multi page capability.

I saw filters does not compile when it compile only Karbon, i should correct that, but i have much time now.

Thu, Jun 20, 7:52 AM · Calligra: 3.0

Mon, Jun 10

anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

If you mean export to svg here, afaics there are no page element in svg. Have I missed it?

Mon, Jun 10, 12:39 PM · Calligra: 3.0

Fri, Jun 7

danders added a comment to D20400: Karbon: Enable multi page capability.

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

Fri, Jun 7, 8:47 AM · Calligra: 3.0

Thu, Jun 6

anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

Thu, Jun 6, 7:58 PM · Calligra: 3.0
danders updated the diff for D20400: Karbon: Enable multi page capability.

Add dependence on LIB_KOPAGEAPP

Thu, Jun 6, 12:33 PM · Calligra: 3.0

Wed, Jun 5

danders added a comment to D20400: Karbon: Enable multi page capability.

I have been pondering why we disagreed so much on the background color, and I *think* I have an answer.
My take is it's because we have not been talking about quite the same thing:
I have looked at karbon as an *odg* editor, since it uses odg as its native file format.
Since odg is wysiwyg nothing outside the doc should in any way affect the way it is presented, hence a background that is not saved to file doesn't make sence.

Wed, Jun 5, 8:36 AM · Calligra: 3.0
anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Apparently it has a problem, when we compile only Karbon, as i done now, KoPAView is in pageapp, which is not compile-able in Karbon, right?
Full cmake command

cmake .. -DCMAKE_INSTALL_PREFIX=/usr  -DCMAKE_INSTALL_LIBDIR=lib -DKDE_INSTALL_PLUGINDIR=/usr/lib/qt5/plugins -DKDE_INSTALL_USE_QT_SYS_PATHS=ON -DBUILD_TESTING=FALSE -DPACKAGERS_BUILD=true -DBUILD_UNMAINTAINED=TRUE -DPRODUCTSET=APP_KARBON
Wed, Jun 5, 6:30 AM · Calligra: 3.0

Tue, Jun 4

rjvbb added a comment to D20400: Karbon: Enable multi page capability.

code wise looks good

Tue, Jun 4, 10:34 PM · Calligra: 3.0
anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Someone test it, code wise looks good, i plan to test it soon.

Tue, Jun 4, 8:36 PM · Calligra: 3.0
anthonyfieroni abandoned D19327: Karbon: Enable multi page capability.

In flavor of D20400

Tue, Jun 4, 8:35 PM · Calligra: 3.0
anthonyfieroni commandeered D19327: Karbon: Enable multi page capability.
Tue, Jun 4, 8:35 PM · Calligra: 3.0
anthonyfieroni abandoned D19216: Karbon: Enable multi page capability.

In flavor of D20400

Tue, Jun 4, 8:35 PM · Calligra: 3.0
anthonyfieroni commandeered D19216: Karbon: Enable multi page capability.
Tue, Jun 4, 8:34 PM · Calligra: 3.0

Mon, Jun 3

pshinjo added a comment to D21553: add Korean Hangul jamo code point ranges.

First of all, thanks for the work. Some things are passing through my mind, especially regarding classical Hangul and half-completed Hangul characters.

Mon, Jun 3, 5:47 PM · Calligra: 3.0
daehyuns updated subscribers of D21553: add Korean Hangul jamo code point ranges.
Mon, Jun 3, 10:47 AM · Calligra: 3.0
daehyuns requested review of D21553: add Korean Hangul jamo code point ranges.
Mon, Jun 3, 4:41 AM · Calligra: 3.0

Apr 26 2019

pvuorela added a comment to D19759: Remove unsupported attributes from QGraphicsWidgets.

Second ping for this.

Apr 26 2019, 3:01 PM · Calligra: 3.0

Apr 9 2019

rjvbb added a comment to D20400: Karbon: Enable multi page capability.
(Sorry for the inconvinience, I've never been very friendly with arc/phab)
Apr 9 2019, 8:31 AM · Calligra: 3.0
danders added a comment to D20400: Karbon: Enable multi page capability.

Ooops, this didn't work as expected. This should have been a revision of D19327.
There is only small changes:

  1. Updated commit message.
  2. In karbon/ui/KarbonFactory.cpp: Loading of the calligra/pageapp tools.
  3. In karbon/data/karbon.rc: Removal of the "format" menu (not used) and adding the "format_pagelayout" action to "settings" menu (where it was originally).
Apr 9 2019, 7:05 AM · Calligra: 3.0
danders requested review of D20400: Karbon: Enable multi page capability.
Apr 9 2019, 6:40 AM · Calligra: 3.0

Apr 4 2019

pvuorela closed D19943: Small cleanups for qml components.
Apr 4 2019, 9:48 AM · Calligra: 3.0
pvuorela closed D19944: Migrate away from deprecated interfaces in gemini dropbox parts.
Apr 4 2019, 9:48 AM · Calligra: 3.0
pvuorela added a comment to D19759: Remove unsupported attributes from QGraphicsWidgets.

Ping, how about this one? The behavior change, or lack of it, should be mostly visible around qgraphicswidget_p.h -> attributeToBitIndex() & setAttribute().

Apr 4 2019, 9:18 AM · Calligra: 3.0

Mar 27 2019

leinir accepted D19943: Small cleanups for qml components.
Mar 27 2019, 1:28 PM · Calligra: 3.0
pvuorela added inline comments to D19943: Small cleanups for qml components.
Mar 27 2019, 1:23 PM · Calligra: 3.0
leinir accepted D19944: Migrate away from deprecated interfaces in gemini dropbox parts.

If memory serves, we'll need to do a fair bit of work to get the DropBox code to work properly again. DropBox has turned off the V1 API support, and we'll need to work against the V2 stuff now, which... Well, it might be trivial, but i have no time to look at it, i'm afraid. Be really good to get it back, though.

Mar 27 2019, 12:45 PM · Calligra: 3.0
leinir added inline comments to D19943: Small cleanups for qml components.
Mar 27 2019, 12:40 PM · Calligra: 3.0

Mar 26 2019

dcaliste closed D19973: MsooXmlCommonRead: protect member for double free.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19941: Avoid deprecated setSupportedDragActions.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19938: Avoid deprecated QRegion::subtract().
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19761: Remove obsolete syncX() workaround.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19760: Support Qt <5.7 on KoShape flag usage.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19885: Implement logging category for excel plugins.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19912: Implement logging category for rtf-qt.
Mar 26 2019, 9:47 AM · Calligra: 3.0

Mar 25 2019

danders closed D11971: Use same keyword separator for read and write.
Mar 25 2019, 1:49 PM · Calligra: 3.0
danders added a comment to D11971: Use same keyword separator for read and write.

Yes, looks sane, I'll deal with it.

Mar 25 2019, 9:08 AM · Calligra: 3.0
danders accepted D19884: Avoid deprecated QAbstractItemModel::reset().

I think this should be ok

Mar 25 2019, 8:58 AM · Calligra: 3.0
danders accepted D19973: MsooXmlCommonRead: protect member for double free.
Mar 25 2019, 8:53 AM · Calligra: 3.0

Mar 22 2019

anthonyfieroni added a comment to D11971: Use same keyword separator for read and write.

Ping this looks sane, anyone ?

Mar 22 2019, 1:22 PM · Calligra: 3.0
pvuorela requested review of D19973: MsooXmlCommonRead: protect member for double free.
Mar 22 2019, 1:09 PM · Calligra: 3.0
danders accepted D19941: Avoid deprecated setSupportedDragActions.
Mar 22 2019, 8:14 AM · Calligra: 3.0

Mar 21 2019

pvuorela requested review of D19944: Migrate away from deprecated interfaces in gemini dropbox parts.
Mar 21 2019, 3:27 PM · Calligra: 3.0
pvuorela requested review of D19943: Small cleanups for qml components.
Mar 21 2019, 3:24 PM · Calligra: 3.0
pvuorela requested review of D19941: Avoid deprecated setSupportedDragActions.
Mar 21 2019, 1:33 PM · Calligra: 3.0
danders accepted D19938: Avoid deprecated QRegion::subtract().
Mar 21 2019, 12:22 PM · Calligra: 3.0
pvuorela requested review of D19938: Avoid deprecated QRegion::subtract().
Mar 21 2019, 11:12 AM · Calligra: 3.0

Mar 20 2019

danders added a comment to D19912: Implement logging category for rtf-qt.

Strange indents, could you fix it?

That's what I commented on the summary. On some parts rtf-qt uses plain spaces for indentation and those parts look good. Then in the same file other methods might have a hard tab or a hard tab followed by spaces. If you really want, I can try to retain the old whitespace, but it's indentation-wise more or less broken already anyway :) Alternatively could run astyle for the subdirectory, though maybe best done as separate commit.

Yes, sorry, as you say better done separatly.

The directory README also states "Temporary local copy of Brad Hards' rtf-qt library.", though as upstream hasn't had changes since 2011, it seems like a permanent one by now.

Probably.

Mar 20 2019, 12:39 PM · Calligra: 3.0
pvuorela added a comment to D19912: Implement logging category for rtf-qt.

Strange indents, could you fix it?

Mar 20 2019, 11:54 AM · Calligra: 3.0
danders accepted D19912: Implement logging category for rtf-qt.

Strange indents, could you fix it?
Otherwise ok.

Mar 20 2019, 11:32 AM · Calligra: 3.0
pvuorela requested review of D19912: Implement logging category for rtf-qt.
Mar 20 2019, 11:21 AM · Calligra: 3.0
danders added inline comments to D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 20 2019, 10:57 AM · Calligra: 3.0
danders accepted D19885: Implement logging category for excel plugins.
Mar 20 2019, 10:31 AM · Calligra: 3.0
pvuorela added inline comments to D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 20 2019, 9:59 AM · Calligra: 3.0

Mar 19 2019

dcaliste added inline comments to D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 19 2019, 7:15 PM · Calligra: 3.0
pvuorela updated the diff for D19885: Implement logging category for excel plugins.

Eliminated one unintended #ifdef SWINDER_XLS2RAW removal from the patch.

Mar 19 2019, 4:09 PM · Calligra: 3.0
pvuorela updated the diff for D19759: Remove unsupported attributes from QGraphicsWidgets.

Updated to remove also WA_StaticContents in addition to earlier WA_InputMethodEnabled.

Mar 19 2019, 3:03 PM · Calligra: 3.0
pvuorela requested review of D19885: Implement logging category for excel plugins.
Mar 19 2019, 2:56 PM · Calligra: 3.0
pvuorela requested review of D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 19 2019, 2:51 PM · Calligra: 3.0

Mar 15 2019

danders added a reviewer for D19759: Remove unsupported attributes from QGraphicsWidgets: boemann.
Mar 15 2019, 7:56 AM · Calligra: 3.0
danders accepted D19760: Support Qt <5.7 on KoShape flag usage.
Mar 15 2019, 7:43 AM · Calligra: 3.0
danders accepted D19761: Remove obsolete syncX() workaround.
Mar 15 2019, 7:39 AM · Calligra: 3.0

Mar 14 2019

pvuorela requested review of D19761: Remove obsolete syncX() workaround.
Mar 14 2019, 2:49 PM · Calligra: 3.0
pvuorela requested review of D19760: Support Qt <5.7 on KoShape flag usage.
Mar 14 2019, 2:47 PM · Calligra: 3.0
pvuorela requested review of D19759: Remove unsupported attributes from QGraphicsWidgets.
Mar 14 2019, 2:42 PM · Calligra: 3.0

Mar 7 2019

anthonyfieroni added inline comments to D19327: Karbon: Enable multi page capability.
Mar 7 2019, 6:33 PM · Calligra: 3.0
danders added a comment to D19216: Karbon: Enable multi page capability.
That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown.

Heh, I've had the opportunity to work closely with professional infographists so I picked up a thing or two about using applications like Illustrator and InDesign :)

How to indicate a transparent area of an object is yet another subject, with a related but not identical purpose.

That said it might make more sense for this "testing background" to be part of the document and not a general setting - if the use case is as you say then the testing background would also be different for different projects

True. I was reacting to *re*moving a setting completely, not to moving it to a more appropriate context.

Mar 7 2019, 11:32 AM · Calligra: 3.0

Feb 28 2019

rjvbb added a comment to D19216: Karbon: Enable multi page capability.
That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown.
Feb 28 2019, 11:28 AM · Calligra: 3.0
boemann added a comment to D19216: Karbon: Enable multi page capability.
No, the canvas is part of the document and must never be themed. The canvas background is as much part of your drawing as any line you put on it.

This hasn't been sitting right with me and I finally realised why.

That statement is true when you work with a real canvas and draw/paint/whatever directly onto that. If you take a grid paper the grid will become part of your art, but does Karbon print the grid which you can have it show (except possibly via an option)?

In drawing applications, the canvas is NOT part of your art, but simulates the canvas you'll be printing on. It's a backdrop layer that sits behind/below the lowest layer you can draw on. If you plan to print on a coloured piece of paper, or one with a canvassy texture, you'll probably want to adapt your virtual canvas so you can incorporate the physical canvas properties into your design. But you don't want that virtual canvas to print as that would be a waste of toner at best...

That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown.
That said it might make more sense for this "testing background" to be part of the document and not a general setting - if the use case is as you say then the testing background would also be different for different projects

That's not to say that the virtual canvas should not be exportable at all: you'd want to be able to include it when generating a PDF (SVG, JPG, etc) format version for use in on-screen only presentations. Of course you could just add a backdrop layer in that case.

I'm not aware that Karbon has the equivalent of a slide/page design feature where you can define how each page will look. That could look be used to be achieve what I describe here but in Karbon that layer should probably not be printed by default (just like it isn't in presentation apps, IIRC).

Feb 28 2019, 11:18 AM · Calligra: 3.0
rjvbb added a comment to D19216: Karbon: Enable multi page capability.
No, the canvas is part of the document and must never be themed. The canvas background is as much part of your drawing as any line you put on it.
Feb 28 2019, 8:47 AM · Calligra: 3.0

Feb 26 2019

danders requested review of D19327: Karbon: Enable multi page capability.
Feb 26 2019, 7:27 AM · Calligra: 3.0
boemann added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

no

Feb 26 2019, 7:11 AM · Calligra: 3.0

Feb 25 2019

danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Can we get a conclussion to this?
@Camilla Have you come up with any more unit tests?

Feb 25 2019, 12:16 PM · Calligra: 3.0
boemann added a comment to D19216: Karbon: Enable multi page capability.

totally agree about not theme'ing canvas

Feb 25 2019, 11:52 AM · Calligra: 3.0
danders added inline comments to D19216: Karbon: Enable multi page capability.
Feb 25 2019, 11:41 AM · Calligra: 3.0
danders added a comment to D19216: Karbon: Enable multi page capability.

Canvas color:
I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed.

A custom canvas colour feature doesn't strike me as odd, nor that it isn't printed (printing it WITHOUT setting a dedicated option would seem wrong to me).

What about when you use an inversed theme, isn't a custom canvas colour required then if you want to see your black line art on a light (white) canvas?

No, the canvas is part of the document and must never be themed. The canvas background is as much part of your drawing as any line you put on it.

Feb 25 2019, 11:23 AM · Calligra: 3.0

Feb 22 2019

ognarb closed D19132: Update libs/widgets to c++11.
Feb 22 2019, 9:04 PM · Calligra: 3.0
rjvbb added a comment to D19216: Karbon: Enable multi page capability.

Canvas color:
I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed.

Feb 22 2019, 3:30 PM · Calligra: 3.0
anthonyfieroni added inline comments to D19216: Karbon: Enable multi page capability.
Feb 22 2019, 2:53 PM · Calligra: 3.0
danders added inline comments to D19216: Karbon: Enable multi page capability.
Feb 22 2019, 2:18 PM · Calligra: 3.0
anthonyfieroni added inline comments to D19216: Karbon: Enable multi page capability.
Feb 22 2019, 1:46 PM · Calligra: 3.0
danders added a comment to D19216: Karbon: Enable multi page capability.

This would indeed be great to have; even a page selector when importing a multi-page document would be an improvement (the Adobe Illustrator version I've use had that; IIRC it would just leave all other pages of the document alone).

You should also test with PDF documents; in my experience Karbon 3.1 works well enough with them.

Yes, pdf docs work, it is almost 100% handled by poppler.

...

A lot of code was duplicated between pageapp and karbon
and has been removed from karbon:

Shouldn't that be a separate change - or does multi-page support come automatically with this change?

Well, my initial thought, but there was going to be quite a few intermidiate solutions mainly because
the KoPACanvas cannot be subclassed, so I decided to do everything in one go.

Feb 22 2019, 1:22 PM · Calligra: 3.0
rjvbb added a comment to D19216: Karbon: Enable multi page capability.

This would indeed be great to have; even a page selector when importing a multi-page document would be an improvement (the Adobe Illustrator version I've use had that; IIRC it would just leave all other pages of the document alone).

Feb 22 2019, 10:57 AM · Calligra: 3.0
danders requested review of D19216: Karbon: Enable multi page capability.
Feb 22 2019, 10:00 AM · Calligra: 3.0

Feb 21 2019

danders added a comment to D19132: Update libs/widgets to c++11.

Thanks for the review, I will work next on libs/{pigment,version,widgetutils}.

Hmm, maybe wait with pigment, according to rempt, only krita actually used it.
I haven't looked into it, but if that is the case probably we should dump it.

Feb 21 2019, 11:38 AM · Calligra: 3.0
ognarb added a comment to D19132: Update libs/widgets to c++11.

Ok, I can't say I have scrutinized every change, but...
Could you give a heads up when you continue with other parts or else there may be merge problems.
I'm working on karbon and pageapp atm, so please keep off :)

Feb 21 2019, 11:05 AM · Calligra: 3.0
danders accepted D19132: Update libs/widgets to c++11.

Ok, I can't say I have scrutinized every change, but...
Could you give a heads up when you continue with other parts or else there may be merge problems.
I'm working on karbon and pageapp atm, so please keep off :)

Feb 21 2019, 9:53 AM · Calligra: 3.0

Feb 19 2019

ognarb updated the diff for D19132: Update libs/widgets to c++11.

Fix build

Feb 19 2019, 11:25 PM · Calligra: 3.0
ognarb updated the summary of D19132: Update libs/widgets to c++11.
Feb 19 2019, 11:22 PM · Calligra: 3.0
ognarb updated the test plan for D19132: Update libs/widgets to c++11.
Feb 19 2019, 11:16 PM · Calligra: 3.0
ognarb updated the diff for D19132: Update libs/widgets to c++11.
  • Revert foreach modifications
  • Fix some forgotten 0 as nullptr instances
Feb 19 2019, 11:16 PM · Calligra: 3.0
leinir added a comment to D19132: Update libs/widgets to c++11.

There is an issue with Qt's foreach, however if the author would be so nice as to check that this version using C++11 iteration does not break building on Windows, then it can go in... Though, yes, it most certainly wants testing, and i don't currently have a functioning windows build system. 2890f2a929034d613c4b4a8f3e6ad77c23162d41 is one of the commits which did the q_foreach/for loop change previously, to see what actually got changed.

Feb 19 2019, 10:03 AM · Calligra: 3.0
danders added a reviewer for D19132: Update libs/widgets to c++11: leinir.

Hmmm. wasn't it somethng with ms windows and for loops, leinir?
Also, I think there may be detachment issues with them, clazy can tell.
There is a qAsConst() solution but that is not supported in the qt version we need to support.
If there are issues, maybe drop the for loops for now.

Feb 19 2019, 9:55 AM · Calligra: 3.0

Feb 18 2019

ognarb updated the summary of D19132: Update libs/widgets to c++11.
Feb 18 2019, 11:00 PM · Calligra: 3.0
ognarb added a reviewer for D19132: Update libs/widgets to c++11: Calligra: 3.0.
Feb 18 2019, 8:17 PM · Calligra: 3.0
ognarb requested review of D19132: Update libs/widgets to c++11.
Feb 18 2019, 8:16 PM · Calligra: 3.0

Feb 15 2019

niccolove closed D18448: Replaced "distraction free" with "fullscreen" - BUG:378527.
Feb 15 2019, 2:31 PM · Calligra: 3.0
cfeck added a comment to D18448: Replaced "distraction free" with "fullscreen" - BUG:378527.

This was accepted, but was it also committed yet?

Feb 15 2019, 12:36 AM · Calligra: 3.0

Feb 14 2019

ognarb closed D18994: Update screenshots for Calligra sheets 3.1.
Feb 14 2019, 7:03 PM · Documentation, Calligra: 3.0
ognarb added a comment to D18994: Update screenshots for Calligra sheets 3.1.

A quick note that you kind of got the name of the suite wrong in a few places, it's called Calligra, not Callibra :)

Feb 14 2019, 3:40 PM · Documentation, Calligra: 3.0