All the modules that use this cmake file, already build fine in debug mode with strict iterators.
This enables the same setting in release mode, for code that already builds fine in debug mode. So unless people have bad code in #ifndef NDEBUG, I don't expect this to break anything at all.

Are we sure we don't break code by introducing this? Or we're just going to play Whac-A-Mole with compile errors until all it's compiling again?

Hmm it looks like we're using ancient code option.

FWIW, I have meanwhile used this patch to build all kube dependencies on linux and osx as well, and it seems like it doesn't break anything.

for generating server files too

LGTM, looks like clang-cl will be missing a few arguments though.

There was already an earlier (abandoned) attempt at this: https://git.reviewboard.kde.org/r/128779

fixing a typo.

make parallel network requests.

complete diff.

now with glob matching and another round of renaming blacklist files.

remove BLACKLSIT for httpcheck

add httpupdate and split out blacklist file

In D19996#436824, @winterz wrote:

this would be a nice addition to Krazy. on my todo list.

this would be a nice addition to Krazy. on my todo list.

search for http://\S

add more excludes.

update http regex

update python script.

Makes sense --> https://phabricator.kde.org/D19538

FWIW, this still results in inproper pc files, from what I heard recently. The prefix variable can be overriden from outside when calling pkg-config (cmp. pkg-config --help) to allow for relocatable installations. Same like CMake Config files also allow relocation by having the install prefix not hardcoded into directory var values.

Thanks.

Update unittests, passes now

In D19506#424301, @cgiboudeaux wrote:

The autotest has to be fixed as well

The autotest has to be fixed as well

Works for me !

In D18943#424041, @kossebau wrote:

In D18943#424029, @vkrause wrote:

What I don't understand though is which FindFontconfig this used to find, there is non in plasma-desktop...

kdelibs4support provides one.

In D18943#424029, @vkrause wrote:

What I don't understand though is which FindFontconfig this used to find, there is non in plasma-desktop...

D19499 fixes that here

In D18943#423969, @matthieugras wrote:

This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst).

This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst).

Add backward compatibility variables.

In D19486#423728, @cgiboudeaux wrote:

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

The warning needs to be removed then. We can't really warn at the time of using a variable.

LGTM

ping?

In D19016#420246, @apol wrote:

Applications can still override it, note it's a default.
Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk

Applications can still override it, note it's a default.
Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk

If anyone hits a cmake error about "/usr/include/EGL/EGL/egl.h" after updating ECM (e.g. in kwayland or plasma-framework), remove the cache in the builddir and rerun cmake. This commit is actually correct, it's just incompatible with existing caches.

Has this been fixed? I haven't seen these warnings

Yep, I'd say let's get it in kstars and if other applications start needing it, we move it to ECM to share.

explicitly set FOUND_VAR so it is camelcase too

Thanks! just a little thing to fix before pushing

In D19005#414313, @apol wrote:

In D19005#412258, @vkrause wrote:

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

no, the value is coming from the cache, so that's the one we're setting. What this patch tries to make sure is that we don't forward an empty value (resetting a proper variable to "").

fix bad copy paste in compat setup

• pkgconfig is now quiet
• variables are now camelcase
  • old variables are still set for compat
• new imported target (also sets pkgconfig's cflags, which I presume is the sane thing to do)
• set package description url & description

If someone could please trigger all of the Dependency Builds for FreeBSD once this has been landed that would be appreciated: https://build.kde.org/view/Failing/

In D19005#412258, @vkrause wrote:

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

Thank you:)

Search for pkgconfig quietly.

In D18952#413454, @aacid wrote:

Yes, imported targets are the future/present :)

Canberra::Canberra sounds good to me as target name

Simply set NAMES EGL/egl.h and fixup the header version check.

In D19075#413462, @hausmann wrote:

I think that it should be NAMES EGL/egl.h

I think that it should be NAMES EGL/egl.h

Yes, imported targets are the future/present :)

Store the path gathered via pkgconfig in COMPLETE_EGL_INCLUDE_DIR and
use its parent directory for EGL_INCLUDE_DIR.

Yeah I think find_path should use the same style as the test program (EGL/egl.h). It is the style of inclusion as per the specification. I think that’s better than the ../ approach.

Possibly the returend EGL_INCLUDE_DIR should possibly be stripped of the suffix too, as most will proably include 'EGL/egl.h', and not 'egl.h', I guess?