Feed Advanced Search

Feb 18 2019

sitter updated the diff for D18952: new find module for Canberra.
  • pkgconfig is now quiet
  • variables are now camelcase
    • old variables are still set for compat
  • new imported target (also sets pkgconfig's cflags, which I presume is the sane thing to do)
  • set package description url & description
Feb 18 2019, 12:36 PM · Build System, Frameworks
bcooksley added a comment to D19075: Fix FindEGL.

If someone could please trigger all of the Dependency Builds for FreeBSD once this has been landed that would be appreciated: https://build.kde.org/view/Failing/

Feb 18 2019, 9:55 AM · Build System, Frameworks
apol added a comment to D19005: android: don't default to gcc anymore.

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

Feb 18 2019, 1:01 AM · Build System, Frameworks
apol accepted D19075: Fix FindEGL.
Feb 18 2019, 12:16 AM · Build System, Frameworks

Feb 17 2019

hausmann accepted D19075: Fix FindEGL.

Thank you:)

Feb 17 2019, 8:47 PM · Build System, Frameworks

Feb 16 2019

vkrause updated the diff for D18943: Add Fontconfig find modudle.

Search for pkgconfig quietly.

Feb 16 2019, 11:30 AM · Build System, Frameworks
krop added inline comments to D18943: Add Fontconfig find modudle.
Feb 16 2019, 11:13 AM · Build System, Frameworks
krop added a comment to D18952: new find module for Canberra.

Yes, imported targets are the future/present :)

Canberra::Canberra sounds good to me as target name

Feb 16 2019, 11:09 AM · Build System, Frameworks
tcberner updated the diff for D19075: Fix FindEGL.

Simply set NAMES EGL/egl.h and fixup the header version check.

Feb 16 2019, 10:51 AM · Build System, Frameworks
tcberner added a comment to D19075: Fix FindEGL.

I think that it should be NAMES EGL/egl.h

Feb 16 2019, 10:47 AM · Build System, Frameworks
hausmann added a comment to D19075: Fix FindEGL.

I think that it should be NAMES EGL/egl.h

Feb 16 2019, 10:20 AM · Build System, Frameworks
aacid added a comment to D18952: new find module for Canberra.

Yes, imported targets are the future/present :)

Feb 16 2019, 9:57 AM · Build System, Frameworks
tcberner updated the diff for D19075: Fix FindEGL.

Store the path gathered via pkgconfig in COMPLETE_EGL_INCLUDE_DIR and
use its parent directory for EGL_INCLUDE_DIR.

Feb 16 2019, 9:57 AM · Build System, Frameworks
hausmann requested changes to D19075: Fix FindEGL.
Feb 16 2019, 8:12 AM · Build System, Frameworks
hausmann added a comment to D19075: Fix FindEGL.

Yeah I think find_path should use the same style as the test program (EGL/egl.h). It is the style of inclusion as per the specification. I think that’s better than the ../ approach.

Feb 16 2019, 8:12 AM · Build System, Frameworks
tcberner added a comment to D19075: Fix FindEGL.

Possibly the returend EGL_INCLUDE_DIR should possibly be stripped of the suffix too, as most will proably include 'EGL/egl.h', and not 'egl.h', I guess?

Feb 16 2019, 7:23 AM · Build System, Frameworks
tcberner added a reviewer for D19075: Fix FindEGL: FreeBSD.
Feb 16 2019, 7:19 AM · Build System, Frameworks
tcberner added a dependency for D19075: Fix FindEGL: D18960: Add compile check to FindEGL.
Feb 16 2019, 7:19 AM · Build System, Frameworks
tcberner added a dependent revision for D18960: Add compile check to FindEGL: D19075: Fix FindEGL.
Feb 16 2019, 7:19 AM · Build System, Frameworks
tcberner requested review of D19075: Fix FindEGL.
Feb 16 2019, 7:18 AM · Build System, Frameworks
bcooksley added a comment to D18960: Add compile check to FindEGL.
/usr/local/bin/gmake -f CMakeFiles/cmTC_fd24d.dir/build.make CMakeFiles/cmTC_fd24d.dir/build
gmake[1]: Entering directory '/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp'
Building CXX object CMakeFiles/cmTC_fd24d.dir/src.cxx.o
/usr/bin/c++   -I/usr/local/include/EGL  -DHAVE_EGL   -o CMakeFiles/cmTC_fd24d.dir/src.cxx.o -c /usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp/src.cxx
/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp/src.cxx:2:10: fatal error: 'EGL/egl.h' file not found
#include <EGL/egl.h>
         ^~~~~~~~~~~
1 error generated.
gmake[1]: *** [CMakeFiles/cmTC_fd24d.dir/build.make:66: CMakeFiles/cmTC_fd24d.dir/src.cxx.o] Error 1
gmake[1]: Leaving directory '/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp'
gmake: *** [Makefile:121: cmTC_fd24d/fast] Error 2
Feb 16 2019, 6:17 AM · Build System, Frameworks

Feb 15 2019

vkrause closed D19016: Update Android toolchain files to reality.
Feb 15 2019, 1:05 PM · Build System, Frameworks
apol accepted D19016: Update Android toolchain files to reality.

Thanks!

Feb 15 2019, 12:41 PM · Build System, Frameworks

Feb 14 2019

vkrause added a comment to D19005: android: don't default to gcc anymore.

In fact none of those seem to work here. D19016 works here though, and I suspect that the 14 -> 21 in there should fix ECM on the CI.

Feb 14 2019, 5:32 PM · Build System, Frameworks
vkrause requested review of D19016: Update Android toolchain files to reality.
Feb 14 2019, 5:30 PM · Build System, Frameworks
vkrause added a comment to D19005: android: don't default to gcc anymore.

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

Feb 14 2019, 5:22 PM · Build System, Frameworks
vkrause accepted D19005: android: don't default to gcc anymore.
Feb 14 2019, 3:35 PM · Build System, Frameworks
apol requested review of D19005: android: don't default to gcc anymore.
Feb 14 2019, 2:36 PM · Build System, Frameworks
hausmann added a comment to D18960: Add compile check to FindEGL.

Ooops. Could you paste the error from the cmake error output? I'm curious which part of the EGL compile test fails.

Feb 14 2019, 7:55 AM · Build System, Frameworks

Feb 13 2019

tcberner added a comment to D18960: Add compile check to FindEGL.

Seems this is sadly breaking something for FreeBSD though, see
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console

Feb 13 2019, 5:24 PM · Build System, Frameworks
kossebau added a comment to D18960: Add compile check to FindEGL.

Seems this is sadly breaking something for FreeBSD though, see
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console

Feb 13 2019, 5:16 PM · Build System, Frameworks
sitter added a comment to D18952: new find module for Canberra.

Good point, I've also noticed that (all?) our finders now also create an IMPORTED target. Should we maybe add that too? If so I guess Canberra::Canberra would be the preferred target name?

Feb 13 2019, 8:59 AM · Build System, Frameworks
sitter updated the diff for D18952: new find module for Canberra.

document in rst syntax

Feb 13 2019, 8:58 AM · Build System, Frameworks
hausmann closed D18960: Add compile check to FindEGL.
Feb 13 2019, 8:47 AM · Build System, Frameworks

Feb 12 2019

apol accepted D18960: Add compile check to FindEGL.
Feb 12 2019, 6:14 PM · Build System, Frameworks
apol added inline comments to D18952: new find module for Canberra.
Feb 12 2019, 5:43 PM · Build System, Frameworks
vkrause updated the diff for D18943: Add Fontconfig find modudle.

Update indentation, add docs link, remove ancient copy from attic.

Feb 12 2019, 3:59 PM · Build System, Frameworks
vkrause added a comment to D18960: Add compile check to FindEGL.

+1 This makes sense to me, considering how broken some vendor [E]GL stacks are.

Feb 12 2019, 3:50 PM · Build System, Frameworks
hausmann requested review of D18960: Add compile check to FindEGL.
Feb 12 2019, 2:53 PM · Build System, Frameworks
kossebau added a comment to D18943: Add Fontconfig find modudle.

Could the indentation perhaps be turned to be 4 spaces while copying it here? While https://community.kde.org/Policies/CMake_Coding_Style#Indentation allows the choice of 2,3, or 4 spaces, using 4 is more in line with the indentation used in C++ sources, so IMHO more expected to read.

Feb 12 2019, 2:21 PM · Build System, Frameworks
lbeltrame added a reviewer for D18952: new find module for Canberra: krop.
Feb 12 2019, 1:09 PM · Build System, Frameworks
sitter requested review of D18952: new find module for Canberra.
Feb 12 2019, 11:55 AM · Build System, Frameworks
apol added inline comments to D18943: Add Fontconfig find modudle.
Feb 12 2019, 10:52 AM · Build System, Frameworks
vkrause added inline comments to D18943: Add Fontconfig find modudle.
Feb 12 2019, 10:47 AM · Build System, Frameworks
apol added inline comments to D18943: Add Fontconfig find modudle.
Feb 12 2019, 10:44 AM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

I just realized there is a much older version of this in attic/modules already, should that be removed as part of adding this?

Feb 12 2019, 9:50 AM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.
In D18943#410391, @cgiboudeaux wrote:

I'm not sure to understand the commit message, does qtbase look for ECM ?

Feb 12 2019, 9:30 AM · Build System, Frameworks
vkrause updated the diff for D18943: Add Fontconfig find modudle.

Add since tag.

Feb 12 2019, 9:21 AM · Build System, Frameworks
krop added a comment to D18943: Add Fontconfig find modudle.

I'm not sure to understand the commit message, does qtbase look for ECM ?

Feb 12 2019, 9:12 AM · Build System, Frameworks
vkrause requested review of D18943: Add Fontconfig find modudle.
Feb 12 2019, 8:57 AM · Build System, Frameworks

Feb 11 2019

kossebau closed D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg.
Feb 11 2019, 4:57 PM · Build System, Frameworks
krop accepted D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg.
Feb 11 2019, 9:12 AM · Build System, Frameworks

Feb 10 2019

kossebau requested review of D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg.
Feb 10 2019, 10:28 PM · Build System, Frameworks

Feb 5 2019

elvisangelaccio closed D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Feb 5 2019, 8:35 PM · Build System, Frameworks

Feb 4 2019

apol accepted D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.

LGTM, thanks!

Feb 4 2019, 11:44 AM · Build System, Frameworks

Feb 3 2019

rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Feb 3 2019, 10:40 PM · Frameworks, Build System
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

Now tested more exhaustively and with unittest.

Feb 3 2019, 10:39 PM · Frameworks, Build System
elvisangelaccio updated the summary of D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Feb 3 2019, 5:19 PM · Build System, Frameworks
elvisangelaccio updated the diff for D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.

Addressed comments

Feb 3 2019, 5:18 PM · Build System, Frameworks

Feb 2 2019

arojas added a comment to D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.

You also need to change '-Xclang -add-plugin -Xclang clang-lazy' to '-Xclang -add-plugin -Xclang clazy' for the plugin to actually be used.

Feb 2 2019, 6:33 PM · Build System, Frameworks
anthonyfieroni added inline comments to D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Feb 2 2019, 6:06 PM · Build System, Frameworks
elvisangelaccio added a comment to D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.

Note: this will break with older clazy versions. I'm not sure how to prevent that.
One could argue that a developer interested in clazy should probably run the latest version anyway...

Feb 2 2019, 5:51 PM · Build System, Frameworks
elvisangelaccio requested review of D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Feb 2 2019, 5:50 PM · Build System, Frameworks

Jan 31 2019

rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
So according to you, this line is useful ? from my point of view, it's needless and just looks like a syntax error.
Jan 31 2019, 7:15 PM · Frameworks, Build System
krop added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

Forget that. The syntax is confusing, please remove this HASFLAG

That I'm not going to do. The goal is to both to have useful feedback like below, and to avoid caching issues that would cause on the first query to be performed (if you were to use a single result variable):

-- Performing Test Clang++_ACCEPTS-Wvla
``
Jan 31 2019, 6:53 PM · Frameworks, Build System
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

Forget that. The syntax is confusing, please remove this HASFLAG

Jan 31 2019, 6:30 PM · Frameworks, Build System
krop added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 31 2019, 3:18 PM · Frameworks, Build System
krop added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 31 2019, 3:12 PM · Frameworks, Build System
krop added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
There are tests for other ECM modules in the **tests** subdir.

That's not the expected answer, so let me rephrase: which existing test can I clone and adapt (which is about the only thing I know how to do in this domain)?

Jan 31 2019, 3:04 PM · Frameworks, Build System
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
There are tests for other ECM modules in the **tests** subdir.
Jan 31 2019, 12:13 PM · Frameworks, Build System
krop added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 31 2019, 10:47 AM · Frameworks, Build System
rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Jan 31 2019, 10:34 AM · Frameworks, Build System
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

Updated as requested.

Jan 31 2019, 10:34 AM · Frameworks, Build System
rjvbb added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 31 2019, 10:30 AM · Frameworks, Build System

Jan 30 2019

rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
Right, but I was saying all this because I think IF_SUPPORTED (the keyword in the arguments) should be SUPPORTED_IF.
Jan 30 2019, 12:39 PM · Frameworks, Build System
dfaure added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
In that sentence, one can read "if supported" for the macro name, ...

That was my idea too, and the reason the macro ends in "_if_supported".

Jan 30 2019, 11:34 AM · Frameworks, Build System
krop added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 30 2019, 9:48 AM · Frameworks, Build System
krop added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

PS: don't forget the unit test for the new module.

Jan 30 2019, 9:03 AM · Frameworks, Build System
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
In that sentence, one can read "if supported" for the macro name, ...
Jan 30 2019, 12:28 AM · Frameworks, Build System

Jan 29 2019

dfaure added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

SUPPORTED_IF : add the flag(s) if the expression is true?

Yes.

Jan 29 2019, 10:53 PM · Frameworks, Build System

Jan 28 2019

rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Jan 28 2019, 9:25 PM · Frameworks, Build System
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

This follows David's suggestion, but using QUERY_IF instead of the suggested TRY_IF to make it clear that this parameter controls the querying of the compiler.
I haven't yet tested the new logic exhaustively but the as far as I can tell the macro behaves as intended as used in the two compiler settings modules.

Jan 28 2019, 9:24 PM · Frameworks, Build System
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

Usually if you have a conditional behaviour the associated condition specifies when to trigger it, no?
You're right that the names don't suggest exactly how the condition is being evaluated (with extra checks or not), but that was also a bit the idea.
Don't bother the user with such details, just provide a macro that will add the flag(s) if they are supported, with an optional conditional expression that can make things faster.

Jan 28 2019, 9:38 AM · Frameworks, Build System
dfaure added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

Ah. You meant an "OR", I thought it was an "AND". (as in our known selection of compilers OR/AND appleclang supports it)
But things are certainly not clearer now with the name CONDITION, which doesn't imply either one.

Jan 28 2019, 9:01 AM · Frameworks, Build System

Jan 27 2019

rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Jan 27 2019, 10:15 PM · Frameworks, Build System
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

Renamed macro and parameter names as announced in my last comment.

Jan 27 2019, 10:14 PM · Frameworks, Build System
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

This makes sense to me. Just the name "SUPPORTED_IF" is strange, when reading that, one thinks "well, if we know the compiler flag is supported, why are we testing that it is?".

Jan 27 2019, 10:13 PM · Frameworks, Build System
rjvbb added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

like René says, this is quite surprising

Hmmm, did I say exactly that? :)

Jan 27 2019, 9:04 PM · Build System, Frameworks
dfaure added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

This makes sense to me. Just the name "SUPPORTED_IF" is strange, when reading that, one thinks "well, if we know the compiler flag is supported, why are we testing that it is?". I think this should be something like TRY_IF.
Then it's clearer that no harm will occur if we set a too low compiler version after TRY_IF, it's just an optimization to avoid e.g. testing all gcc flags on MSVC and vice-versa.

Jan 27 2019, 7:00 PM · Frameworks, Build System
dfaure accepted D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

If it fixes the issue, this can go in, but like René says, this is quite surprising, since the default behavior (CMP0025 off) is that the compiler is called "Clang" on Apple platforms as well.
See cmake --help-policy CMP0025

Jan 27 2019, 6:55 PM · Build System, Frameworks

Jan 26 2019

rjvbb added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

This is in fact cmake's fault, or ECM's for not taking a cmake quirk into account.

Jan 26 2019, 7:18 PM · Build System, Frameworks
aacid added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

Oh, Hannah updated the summary, so an unknown option makes visibility stuff fail?

Jan 26 2019, 6:52 PM · Build System, Frameworks
aacid added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

You sure about that? AFAICS from https://binary-factory.kde.org/view/MacOS/job/Kate_Release_macos/346/console it's just a warning, otherwise, ninja would stop after the first error, and it continues until a linking failure happens

Jan 26 2019, 6:51 PM · Build System, Frameworks
bcooksley added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

This change is somewhat urgent - as can be seen at https://binary-factory.kde.org/view/MacOS/ all Mac builds are currently broken due to this issue.

Jan 26 2019, 6:41 PM · Build System, Frameworks
rjvbb requested changes to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

See also https://phabricator.kde.org/D16894 which (initially) aimed to tackle this in a more general fashion.

Jan 26 2019, 1:13 PM · Build System, Frameworks
vonreth added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

Why?

Jan 26 2019, 12:06 PM · Build System, Frameworks
vonreth added reviewers for D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang: aacid, apol, dfaure, rjvbb, bcooksley.
Jan 26 2019, 11:45 AM · Build System, Frameworks
aacid added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

Why?

Jan 26 2019, 11:43 AM · Build System, Frameworks
vonreth requested review of D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.
Jan 26 2019, 11:41 AM · Build System, Frameworks

Jan 25 2019

kossebau closed D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file.
Jan 25 2019, 7:50 PM · Build System, Frameworks