Feed Advanced Search

Feb 12 2019

hausmann requested review of D18960: Add compile check to FindEGL.
Feb 12 2019, 2:53 PM · Build System, Frameworks
kossebau added a comment to D18943: Add Fontconfig find modudle.

Could the indentation perhaps be turned to be 4 spaces while copying it here? While https://community.kde.org/Policies/CMake_Coding_Style#Indentation allows the choice of 2,3, or 4 spaces, using 4 is more in line with the indentation used in C++ sources, so IMHO more expected to read.

Feb 12 2019, 2:21 PM · Build System, Frameworks
lbeltrame added a reviewer for D18952: new find module for Canberra: cgiboudeaux.
Feb 12 2019, 1:09 PM · Build System, Frameworks
sitter requested review of D18952: new find module for Canberra.
Feb 12 2019, 11:55 AM · Build System, Frameworks
apol added inline comments to D18943: Add Fontconfig find modudle.
Feb 12 2019, 10:52 AM · Build System, Frameworks
vkrause added inline comments to D18943: Add Fontconfig find modudle.
Feb 12 2019, 10:47 AM · Build System, Frameworks
apol added inline comments to D18943: Add Fontconfig find modudle.
Feb 12 2019, 10:44 AM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

I just realized there is a much older version of this in attic/modules already, should that be removed as part of adding this?

Feb 12 2019, 9:50 AM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

I'm not sure to understand the commit message, does qtbase look for ECM ?

Feb 12 2019, 9:30 AM · Build System, Frameworks
vkrause updated the diff for D18943: Add Fontconfig find modudle.

Add since tag.

Feb 12 2019, 9:21 AM · Build System, Frameworks
cgiboudeaux added a comment to D18943: Add Fontconfig find modudle.

I'm not sure to understand the commit message, does qtbase look for ECM ?

Feb 12 2019, 9:12 AM · Build System, Frameworks
vkrause requested review of D18943: Add Fontconfig find modudle.
Feb 12 2019, 8:57 AM · Build System, Frameworks

Feb 11 2019

kossebau closed D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg.
Feb 11 2019, 4:57 PM · Build System, Frameworks
cgiboudeaux accepted D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg.
Feb 11 2019, 9:12 AM · Build System, Frameworks

Feb 10 2019

kossebau requested review of D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg.
Feb 10 2019, 10:28 PM · Build System, Frameworks

Feb 5 2019

elvisangelaccio closed D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Feb 5 2019, 8:35 PM · Build System, Frameworks

Feb 4 2019

apol accepted D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.

LGTM, thanks!

Feb 4 2019, 11:44 AM · Build System, Frameworks

Feb 3 2019

rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Feb 3 2019, 10:40 PM · Frameworks, Build System
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

Now tested more exhaustively and with unittest.

Feb 3 2019, 10:39 PM · Frameworks, Build System
elvisangelaccio updated the summary of D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Feb 3 2019, 5:19 PM · Build System, Frameworks
elvisangelaccio updated the diff for D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.

Addressed comments

Feb 3 2019, 5:18 PM · Build System, Frameworks

Feb 2 2019

arojas added a comment to D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.

You also need to change '-Xclang -add-plugin -Xclang clang-lazy' to '-Xclang -add-plugin -Xclang clazy' for the plugin to actually be used.

Feb 2 2019, 6:33 PM · Build System, Frameworks
anthonyfieroni added inline comments to D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Feb 2 2019, 6:06 PM · Build System, Frameworks
elvisangelaccio added a comment to D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.

Note: this will break with older clazy versions. I'm not sure how to prevent that.
One could argue that a developer interested in clazy should probably run the latest version anyway...

Feb 2 2019, 5:51 PM · Build System, Frameworks
elvisangelaccio requested review of D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Feb 2 2019, 5:50 PM · Build System, Frameworks

Jan 31 2019

rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
So according to you, this line is useful ? from my point of view, it's needless and just looks like a syntax error.
Jan 31 2019, 7:15 PM · Frameworks, Build System
cgiboudeaux added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

Forget that. The syntax is confusing, please remove this HASFLAG

That I'm not going to do. The goal is to both to have useful feedback like below, and to avoid caching issues that would cause on the first query to be performed (if you were to use a single result variable):

-- Performing Test Clang++_ACCEPTS-Wvla
``
Jan 31 2019, 6:53 PM · Frameworks, Build System
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

Forget that. The syntax is confusing, please remove this HASFLAG

Jan 31 2019, 6:30 PM · Frameworks, Build System
cgiboudeaux added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 31 2019, 3:18 PM · Frameworks, Build System
cgiboudeaux added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 31 2019, 3:12 PM · Frameworks, Build System
cgiboudeaux added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
There are tests for other ECM modules in the **tests** subdir.

That's not the expected answer, so let me rephrase: which existing test can I clone and adapt (which is about the only thing I know how to do in this domain)?

Jan 31 2019, 3:04 PM · Frameworks, Build System
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
There are tests for other ECM modules in the **tests** subdir.
Jan 31 2019, 12:13 PM · Frameworks, Build System
cgiboudeaux added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 31 2019, 10:47 AM · Frameworks, Build System
rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Jan 31 2019, 10:34 AM · Frameworks, Build System
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

Updated as requested.

Jan 31 2019, 10:34 AM · Frameworks, Build System
rjvbb added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 31 2019, 10:30 AM · Frameworks, Build System

Jan 30 2019

rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
Right, but I was saying all this because I think IF_SUPPORTED (the keyword in the arguments) should be SUPPORTED_IF.
Jan 30 2019, 12:39 PM · Frameworks, Build System
dfaure added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
In that sentence, one can read "if supported" for the macro name, ...

That was my idea too, and the reason the macro ends in "_if_supported".

Jan 30 2019, 11:34 AM · Frameworks, Build System
cgiboudeaux added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 30 2019, 9:48 AM · Frameworks, Build System
cgiboudeaux added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

PS: don't forget the unit test for the new module.

Jan 30 2019, 9:03 AM · Frameworks, Build System
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
In that sentence, one can read "if supported" for the macro name, ...
Jan 30 2019, 12:28 AM · Frameworks, Build System

Jan 29 2019

dfaure added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

SUPPORTED_IF : add the flag(s) if the expression is true?

Yes.

Jan 29 2019, 10:53 PM · Frameworks, Build System

Jan 28 2019

rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Jan 28 2019, 9:25 PM · Frameworks, Build System
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

This follows David's suggestion, but using QUERY_IF instead of the suggested TRY_IF to make it clear that this parameter controls the querying of the compiler.
I haven't yet tested the new logic exhaustively but the as far as I can tell the macro behaves as intended as used in the two compiler settings modules.

Jan 28 2019, 9:24 PM · Frameworks, Build System
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

Usually if you have a conditional behaviour the associated condition specifies when to trigger it, no?
You're right that the names don't suggest exactly how the condition is being evaluated (with extra checks or not), but that was also a bit the idea.
Don't bother the user with such details, just provide a macro that will add the flag(s) if they are supported, with an optional conditional expression that can make things faster.

Jan 28 2019, 9:38 AM · Frameworks, Build System
dfaure added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

Ah. You meant an "OR", I thought it was an "AND". (as in our known selection of compilers OR/AND appleclang supports it)
But things are certainly not clearer now with the name CONDITION, which doesn't imply either one.

Jan 28 2019, 9:01 AM · Frameworks, Build System

Jan 27 2019

rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Jan 27 2019, 10:15 PM · Frameworks, Build System
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

Renamed macro and parameter names as announced in my last comment.

Jan 27 2019, 10:14 PM · Frameworks, Build System
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

This makes sense to me. Just the name "SUPPORTED_IF" is strange, when reading that, one thinks "well, if we know the compiler flag is supported, why are we testing that it is?".

Jan 27 2019, 10:13 PM · Frameworks, Build System
rjvbb added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

like René says, this is quite surprising

Hmmm, did I say exactly that? :)

Jan 27 2019, 9:04 PM · Build System, Frameworks
dfaure added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

This makes sense to me. Just the name "SUPPORTED_IF" is strange, when reading that, one thinks "well, if we know the compiler flag is supported, why are we testing that it is?". I think this should be something like TRY_IF.
Then it's clearer that no harm will occur if we set a too low compiler version after TRY_IF, it's just an optimization to avoid e.g. testing all gcc flags on MSVC and vice-versa.

Jan 27 2019, 7:00 PM · Frameworks, Build System
dfaure accepted D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

If it fixes the issue, this can go in, but like René says, this is quite surprising, since the default behavior (CMP0025 off) is that the compiler is called "Clang" on Apple platforms as well.
See cmake --help-policy CMP0025

Jan 27 2019, 6:55 PM · Build System, Frameworks

Jan 26 2019

rjvbb added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

This is in fact cmake's fault, or ECM's for not taking a cmake quirk into account.

Jan 26 2019, 7:18 PM · Build System, Frameworks
aacid added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

Oh, Hannah updated the summary, so an unknown option makes visibility stuff fail?

Jan 26 2019, 6:52 PM · Build System, Frameworks
aacid added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

You sure about that? AFAICS from https://binary-factory.kde.org/view/MacOS/job/Kate_Release_macos/346/console it's just a warning, otherwise, ninja would stop after the first error, and it continues until a linking failure happens

Jan 26 2019, 6:51 PM · Build System, Frameworks
bcooksley added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

This change is somewhat urgent - as can be seen at https://binary-factory.kde.org/view/MacOS/ all Mac builds are currently broken due to this issue.

Jan 26 2019, 6:41 PM · Build System, Frameworks
rjvbb requested changes to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

See also https://phabricator.kde.org/D16894 which (initially) aimed to tackle this in a more general fashion.

Jan 26 2019, 1:13 PM · Build System, Frameworks
vonreth added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

Why?

Jan 26 2019, 12:06 PM · Build System, Frameworks
vonreth added reviewers for D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang: aacid, apol, dfaure, rjvbb, bcooksley.
Jan 26 2019, 11:45 AM · Build System, Frameworks
aacid added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

Why?

Jan 26 2019, 11:43 AM · Build System, Frameworks
vonreth requested review of D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.
Jan 26 2019, 11:41 AM · Build System, Frameworks

Jan 25 2019

kossebau closed D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file.
Jan 25 2019, 7:50 PM · Build System, Frameworks

Jan 23 2019

kossebau added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

only 3(?) days between proposal and commit was also a very rushy

Check your dates better please, it's 9 days

Jan 23 2019, 11:12 AM · Build System, Frameworks
aacid added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

The human error exists as long as clang-tidy is not used. What I fear is that someone does a hand porting - we have seen several attempts to do that in KWin from various developers. If devs don't know and now fix the warnings, they can bring in human error.

Jan 23 2019, 10:57 AM · Build System, Frameworks
aacid added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

only 3(?) days between proposal and commit was also a very rushy

Jan 23 2019, 10:56 AM · Build System, Frameworks
kossebau added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

The human error exists as long as clang-tidy is not used. What I fear is that someone does a hand porting - we have seen several attempts to do that in KWin from various developers. If devs don't know and now fix the warnings, they can bring in human error.

Jan 23 2019, 10:04 AM · Build System, Frameworks

Jan 22 2019

zzag added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

The human error exists as long as clang-tidy is not used. What I fear is that someone does a hand porting - we have seen several attempts to do that in KWin from various developers. If devs don't know and now fix the warnings, they can bring in human error.

Jan 22 2019, 9:08 PM · Build System, Frameworks
davidedmundson added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

Almost every project has already been gone over with clang-tidy.
Including kwin which was then force-pushed back by you. This was back in June 2017.
I've got little sympathy if we have a warning after explicitly reverting the fix to the warning.

Jan 22 2019, 7:40 PM · Build System, Frameworks
graesslin added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

The human error exists as long as clang-tidy is not used. What I fear is that someone does a hand porting - we have seen several attempts to do that in KWin from various developers. If devs don't know and now fix the warnings, they can bring in human error.

Jan 22 2019, 4:13 PM · Build System, Frameworks

Jan 21 2019

cgiboudeaux abandoned D17015: Fix the Qt doc creation with Qt 5.12..

qhelpgenerator is back in Qt 5.12.1

Jan 21 2019, 12:06 PM · Build System, Frameworks
kossebau added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

For done code this warning is pointless and negative. I invite you to work with a code base like KWin where it is more important to have a working git blame than protection for theoretical problems. Nobody will be able to guarantee that a 500+ change to add override won't break. Human errors happen, nobody will be able to review something like that. Addressing this warning by adding override all over our legacy code base has a serious risk.

I'm seriously pissed that this is forced on us and we have to change code.

I'm totally fine with this warning for new code and new projects. But let projects opt in for it instead of forcing it on legacy code bases.

Jan 21 2019, 8:42 AM · Build System, Frameworks
graesslin added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

For done code this warning is pointless and negative. I invite you to work with a code base like KWin where it is more important to have a working git blame than protection for theoretical problems. Nobody will be able to guarantee that a 500+ change to add override won't break. Human errors happen, nobody will be able to review something like that. Addressing this warning by adding override all over our legacy code base has a serious risk.

Jan 21 2019, 5:28 AM · Build System, Frameworks

Jan 20 2019

aacid added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

This causes in KWin 500+ new warnings. Do you really think it's a good idea to spam all of KDE with new compiler warnings. KDE has an old code base. We cannot enable warnings for the way you developed C++ for 20 years.

Jan 20 2019, 7:26 PM · Build System, Frameworks
graesslin added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

This causes in KWin 500+ new warnings. Do you really think it's a good idea to spam all of KDE with new compiler warnings. KDE has an old code base. We cannot enable warnings for the way you developed C++ for 20 years.

Jan 20 2019, 5:09 PM · Build System, Frameworks

Jan 19 2019

aacid closed D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.
Jan 19 2019, 11:01 AM · Build System, Frameworks

Jan 18 2019

aacid closed D18345: Fix python binding generation for classes with deleted copy constructors.
Jan 18 2019, 6:17 PM · Build System, Frameworks
lbeltrame accepted D18345: Fix python binding generation for classes with deleted copy constructors.

As far as I understand the logic of the whole thing, it looks sane. At some point we ought to find a way to properly test that the generated code...

Jan 18 2019, 10:58 AM · Build System, Frameworks
cgiboudeaux added a reviewer for D18345: Fix python binding generation for classes with deleted copy constructors: lbeltrame.
Jan 18 2019, 9:30 AM · Build System, Frameworks

Jan 17 2019

aacid updated subscribers of D18345: Fix python binding generation for classes with deleted copy constructors.
Jan 17 2019, 11:50 PM · Build System, Frameworks
aacid requested review of D18345: Fix python binding generation for classes with deleted copy constructors.
Jan 17 2019, 11:48 PM · Build System, Frameworks

Jan 14 2019

vkrause closed D18243: Fix qmake module generation for Qt 5.12.1.
Jan 14 2019, 3:09 PM · Build System, Frameworks
apol accepted D18243: Fix qmake module generation for Qt 5.12.1.
Jan 14 2019, 2:54 PM · Build System, Frameworks
vkrause requested review of D18243: Fix qmake module generation for Qt 5.12.1.
Jan 14 2019, 2:47 PM · Build System, Frameworks

Jan 12 2019

aacid added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

Since i have two +1 i'll commit this next saturday unless someone shouts in disagreement

Jan 12 2019, 5:40 PM · Build System, Frameworks

Jan 10 2019

apol added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

+1 to me too.

Jan 10 2019, 11:23 PM · Build System, Frameworks
vkrause added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

IMHO a good idea, +1.

Jan 10 2019, 7:43 PM · Build System, Frameworks
aacid requested review of D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.
Jan 10 2019, 7:38 PM · Build System, Frameworks

Jan 8 2019

apol accepted D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file.
Jan 8 2019, 12:46 AM · Build System, Frameworks

Jan 7 2019

kossebau added a comment to D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file.

Not sure if there ever s a chance somebody would inject QObject code into such a generated file?

Jan 7 2019, 11:56 PM · Build System, Frameworks
kossebau requested review of D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file.
Jan 7 2019, 11:55 PM · Build System, Frameworks

Dec 31 2018

cgiboudeaux added a comment to D17863: Add ecm_check_linker_flags function.

Why not fixing kstars instead?

include(ECMCheckLinkerFlags)
[...]
# Check for nodump support
SET(NODUMP_FLAGS "-Wl,-z,nodump")
ecm_check_linker_flags("${NODUMP_FLAGS}" NODUMP_SUPPORTED)
if (NODUMP_SUPPORTED)
    SET(SEC_LINK_FLAGS "${SEC_LINK_FLAGS} ${NODUMP_FLAGS}")
endif ()

Of course kstars could also just stop adding nodump ever :)

Dec 31 2018, 12:45 PM · Build System, Frameworks
tcberner added a comment to D17863: Add ecm_check_linker_flags function.

Why not fixing kstars instead?

Dec 31 2018, 6:48 AM · Build System, Frameworks

Dec 30 2018

cgiboudeaux added a comment to D17863: Add ecm_check_linker_flags function.

Why not fixing kstars instead?

Dec 30 2018, 11:10 PM · Build System, Frameworks
lbeltrame added a reviewer for D17863: Add ecm_check_linker_flags function: cgiboudeaux.
Dec 30 2018, 8:47 AM · Build System, Frameworks

Dec 29 2018

tcberner added a comment to D17863: Add ecm_check_linker_flags function.

See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230603

Dec 29 2018, 10:58 PM · Build System, Frameworks
tcberner updated the summary of D17863: Add ecm_check_linker_flags function.
Dec 29 2018, 10:57 PM · Build System, Frameworks
tcberner requested review of D17863: Add ecm_check_linker_flags function.
Dec 29 2018, 10:56 PM · Build System, Frameworks
thiago added a comment to D17015: Fix the Qt doc creation with Qt 5.12..

qhelpgenerator is coming back in 5.12.1. You may simply tell people to skip the .0 release and upgrade.

Dec 29 2018, 6:30 PM · Build System, Frameworks

Dec 21 2018

cgiboudeaux updated the diff for D17015: Fix the Qt doc creation with Qt 5.12..

Try to find qmake if qmake-qt5 is not found

Dec 21 2018, 2:57 PM · Build System, Frameworks

Dec 20 2018

dfaure added a comment to D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0.

Damn, I went too fast. This doesn't fix the issue.

Dec 20 2018, 10:48 PM · Build System, Frameworks