Feed Advanced Search

Aug 13 2018

rkflx added a comment to T9358: "External" tagging for gwenview and other baloo-enabled apps.

Hi, thanks for reaching out.

Aug 13 2018, 10:46 AM · KPhotoAlbum
johanneszarl renamed T9358: "External" tagging for gwenview and other baloo-enabled apps from "External" taggin for gwenview to "External" tagging for gwenview.
Aug 13 2018, 10:27 AM · KPhotoAlbum
johanneszarl created T9358: "External" tagging for gwenview and other baloo-enabled apps.
Aug 13 2018, 10:26 AM · KPhotoAlbum

Jul 13 2018

sdepiets closed D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.
Jul 13 2018, 12:59 AM · KPhotoAlbum
sdepiets requested review of D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.
Jul 13 2018, 12:59 AM · KPhotoAlbum
sdepiets added a comment to D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.

Well I actually didn't see the line above at first. Thanks for the correction

Jul 13 2018, 12:58 AM · KPhotoAlbum

Jul 12 2018

johanneszarl added a comment to D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.

Oh dear, you're right. Should've looked at the whole picture...

Jul 12 2018, 6:14 PM · KPhotoAlbum
pino added a comment to D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.

Also note the big elephant in the room: the typo is not in the British English translation, but in the original text...
I just pushed 812910752712f185e5ef19bf4786346217232475 to fix it, which will invalidate all the translations (so Steve will notice it by tomorrow).

Jul 12 2018, 6:02 PM · KPhotoAlbum
johanneszarl added a comment to D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.

I've forwarded the information to the translator...

Jul 12 2018, 5:49 PM · KPhotoAlbum
johanneszarl added a comment to D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.

@pino Thanks for the hint - I wasn't aware that the translations in git are a one-way street...

Jul 12 2018, 5:46 PM · KPhotoAlbum
pino added a comment to D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.

Note that translations are handled by an automatic system (informally called "scripty") that extracts messages from all the translatable resources, like messages in the applications/libraries, and also strings in .desktop (and alike), and .appdata.xml files.
As such, editing translations directly is not a good idea, and indeed scripty reverted to the string actually in the en_GB translation the day after this commit.
Please contact the British English team, or the translator directly:
https://websvn.kde.org/trunk/l10n-kf5/en_GB/messages/extragear-graphics/org.kde.kphotoalbum.appdata.po?view=markup

Jul 12 2018, 5:38 PM · KPhotoAlbum
johanneszarl accepted D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.

Sure thing - ship it!

Jul 12 2018, 5:22 PM · KPhotoAlbum
sdepiets planned changes to D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.

Can you approve the revision so I can close it ?

Jul 12 2018, 2:20 PM · KPhotoAlbum

Jul 11 2018

johanneszarl moved T7508: Review patch "dont-save-unnecessary-info" by rlk from Backlog to v5.4 on the KPhotoAlbum board.

Merged to master

Jul 11 2018, 11:03 PM · KPhotoAlbum

Jun 15 2018

johanneszarl closed D13329: Fix build with Qt 5.11..
Jun 15 2018, 12:42 PM · KPhotoAlbum
johanneszarl accepted D13329: Fix build with Qt 5.11..

I've merged this to master...

Jun 15 2018, 12:40 PM · KPhotoAlbum

Jun 14 2018

rkrawitz added a comment to D13329: Fix build with Qt 5.11..

Confirmed that this builds with Qt 5.11.

Jun 14 2018, 10:14 PM · KPhotoAlbum
rkrawitz added a watcher for KPhotoAlbum: rkrawitz.
Jun 14 2018, 10:12 PM
johanneszarl added a project to D13329: Fix build with Qt 5.11.: KPhotoAlbum.
Jun 14 2018, 9:06 PM · KPhotoAlbum

Jun 7 2018

sdepiets added 1 commit(s) for D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml: R463:a673ed7142c0: Fixed typo (thanks to Simon Depiets!).
Jun 7 2018, 7:14 AM · KPhotoAlbum

Jun 6 2018

sdepiets added a comment to D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.

Sure, no worries.

Jun 6 2018, 1:14 AM · KPhotoAlbum

Jun 5 2018

tleupold added a comment to D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.

(Due to the fact that we can't see user email addresses here, I could not add you as the author, but wrote it in the commit message. I hope you don't mind …)

Jun 5 2018, 5:25 PM · KPhotoAlbum
tleupold added a comment to D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.

You're right, obviously ;-) I've pushed the patch to master. Thanks :-)

Jun 5 2018, 5:24 PM · KPhotoAlbum
sdepiets requested review of D13351: Fix a typo in the screenshot description of org.kde.kphotoalbum.appdata.xml.
Jun 5 2018, 9:03 AM · KPhotoAlbum

May 20 2018

johanneszarl added a comment to T7508: Review patch "dont-save-unnecessary-info" by rlk.

This is now tracked in branch elide_unnecessary_metadata

May 20 2018, 9:22 PM · KPhotoAlbum

May 7 2018

johanneszarl closed T7507: Review Patch "load-remove-images.patch" by rlk as Resolved.
May 7 2018, 6:50 PM · KPhotoAlbum
johanneszarl moved T7507: Review Patch "load-remove-images.patch" by rlk from Backlog to v5.4 on the KPhotoAlbum board.
May 7 2018, 6:50 PM · KPhotoAlbum

May 6 2018

johanneszarl edited Description on KPhotoAlbum.
May 6 2018, 6:45 PM

Mar 26 2018

tleupold closed D11439: Stop using stdio identifiers for Process method names.

Pushed it finally. Thanks again :-)

Mar 26 2018, 8:08 PM · KPhotoAlbum
tleupold added a comment to D11439: Stop using stdio identifiers for Process method names.

So … I just tried to manually commit your patch (I'm pretty sure this can somehow be done automagically through that Phabricator/Arcanist/Whatever widget, but who knows?! ;-) – but I need your (full?) name and an email address, so that I can set the correct author for the commit. I found neither … would you be so kind to tell me (e. g. via IRC at the kphotoalbum channel on freenode? I'm most of the time logged in as l3u there). Thanks :-)

Mar 26 2018, 7:11 AM · KPhotoAlbum

Mar 18 2018

tleupold accepted D11439: Stop using stdio identifiers for Process method names.

Builds and runs fine here on Gentoo, using GCC 6.4.0.

Mar 18 2018, 9:20 AM · KPhotoAlbum
tleupold added a comment to D11439: Stop using stdio identifiers for Process method names.

The patch seems to be reasonable to me, but I have to ask a dumb question as I'm new to that Phabricator thing: How can I test it? It doesn't live in git, does it? Can I download a patch that I can apply to a local testing branch?

Mar 18 2018, 9:13 AM · KPhotoAlbum
awilcox added a project to D11439: Stop using stdio identifiers for Process method names: KPhotoAlbum.
Mar 18 2018, 7:19 AM · KPhotoAlbum

Mar 16 2018

johanneszarl triaged T8230: Add MPRIS support as Wishlist priority.
Mar 16 2018, 7:48 PM · KPhotoAlbum

Feb 11 2018

johanneszarl closed D10140: Make Android app compilable with C++14 and later.
Feb 11 2018, 8:18 PM · Android, KPhotoAlbum
johanneszarl closed D10138: Android - Change SDK version to work with QT 5.10.
Feb 11 2018, 8:16 PM · Android, KPhotoAlbum

Jan 27 2018

johanneszarl created T7821: Make new android app available.
Jan 27 2018, 9:48 PM · Android, KPhotoAlbum
johanneszarl moved T7580: Review patch "video length extraction and video thumbnails" by as from In Progress to Backlog on the KPhotoAlbum board.
Jan 27 2018, 9:44 PM · KPhotoAlbum
johanneszarl moved T7750: Remove support for mplayer from Backlog to For next release on the KPhotoAlbum board.
Jan 27 2018, 9:43 PM · KPhotoAlbum
johanneszarl edited Description on KPhotoAlbum.
Jan 27 2018, 9:40 PM
johanneszarl accepted D10140: Make Android app compilable with C++14 and later.

KPhotoAlbum should be compatible with both C++11 and C++14. Your change works with both, so: ship it!

Jan 27 2018, 7:57 PM · Android, KPhotoAlbum
johanneszarl accepted D10138: Android - Change SDK version to work with QT 5.10.

Looks fine. Ship it!

Jan 27 2018, 6:25 PM · Android, KPhotoAlbum
jnadal added a project to D10138: Android - Change SDK version to work with QT 5.10: Android.
Jan 27 2018, 11:38 AM · Android, KPhotoAlbum
jnadal added a reviewer for D10138: Android - Change SDK version to work with QT 5.10: KPhotoAlbum.
Jan 27 2018, 11:31 AM · Android, KPhotoAlbum

Jan 14 2018

johanneszarl triaged T7752: Refactor KPhotoAlbum as Normal priority.
Jan 14 2018, 10:06 PM · KPhotoAlbum
johanneszarl triaged T7751: Create cli program for interacting with thumbnail db as Wishlist priority.
Jan 14 2018, 9:57 PM · KPhotoAlbum
johanneszarl triaged T7750: Remove support for mplayer as Normal priority.
Jan 14 2018, 9:47 PM · KPhotoAlbum

Jan 1 2018

johanneszarl moved T7511: Review patch "<shift>-token to tag all stack members" by rlk from For next release to v5.3 on the KPhotoAlbum board.

No surprises during review -> accepted.

Jan 1 2018, 11:43 PM · KPhotoAlbum
johanneszarl moved T7509: Review patch "remove-two-startup-calls.patch" by rlk from For next release to v5.3 on the KPhotoAlbum board.

Patch verified and merged.

Jan 1 2018, 7:48 PM · KPhotoAlbum

Dec 22 2017

johanneszarl added a comment to T7507: Review Patch "load-remove-images.patch" by rlk.

More tricky than I had thought → apply to next release (I don't want to introduce bugs)

Dec 22 2017, 10:53 PM · KPhotoAlbum
johanneszarl triaged T7509: Review patch "remove-two-startup-calls.patch" by rlk as Normal priority.
Dec 22 2017, 10:52 PM · KPhotoAlbum
johanneszarl triaged T7511: Review patch "<shift>-token to tag all stack members" by rlk as Normal priority.
Dec 22 2017, 10:52 PM · KPhotoAlbum
johanneszarl claimed T7509: Review patch "remove-two-startup-calls.patch" by rlk.
Dec 22 2017, 10:48 PM · KPhotoAlbum
johanneszarl claimed T7511: Review patch "<shift>-token to tag all stack members" by rlk.
Dec 22 2017, 10:48 PM · KPhotoAlbum
johanneszarl moved T7507: Review Patch "load-remove-images.patch" by rlk from In Progress to Backlog on the KPhotoAlbum board.
Dec 22 2017, 10:48 PM · KPhotoAlbum
johanneszarl moved T7509: Review patch "remove-two-startup-calls.patch" by rlk from Backlog to For next release on the KPhotoAlbum board.
Dec 22 2017, 10:48 PM · KPhotoAlbum
johanneszarl moved T7511: Review patch "<shift>-token to tag all stack members" by rlk from Backlog to For next release on the KPhotoAlbum board.
Dec 22 2017, 10:44 PM · KPhotoAlbum

Dec 12 2017

johanneszarl edited Description on KPhotoAlbum.
Dec 12 2017, 11:00 PM
johanneszarl triaged T7580: Review patch "video length extraction and video thumbnails" by as as Normal priority.
Dec 12 2017, 10:02 PM · KPhotoAlbum
johanneszarl moved T7580: Review patch "video length extraction and video thumbnails" by as from Backlog to In Progress on the KPhotoAlbum board.
Dec 12 2017, 9:19 PM · KPhotoAlbum
johanneszarl claimed T7507: Review Patch "load-remove-images.patch" by rlk.
Dec 12 2017, 9:19 PM · KPhotoAlbum
johanneszarl created T7580: Review patch "video length extraction and video thumbnails" by as.
Dec 12 2017, 9:19 PM · KPhotoAlbum

Dec 5 2017

johanneszarl edited Description on KPhotoAlbum.
Dec 5 2017, 9:06 PM
johanneszarl closed T7460: Customize project-page for kphotoalbum as Resolved.
Dec 5 2017, 9:02 PM · KPhotoAlbum
johanneszarl moved T7460: Customize project-page for kphotoalbum from In Progress to v5.3 on the KPhotoAlbum board.
Dec 5 2017, 9:01 PM · KPhotoAlbum
johanneszarl added a watcher for KPhotoAlbum: johanneszarl.
Dec 5 2017, 9:01 PM

Nov 29 2017

johanneszarl updated the task description for T7511: Review patch "<shift>-token to tag all stack members" by rlk.
Nov 29 2017, 10:41 PM · KPhotoAlbum
johanneszarl created T7511: Review patch "<shift>-token to tag all stack members" by rlk.
Nov 29 2017, 10:38 PM · KPhotoAlbum
johanneszarl created T7510: Review export-script by samuel kay.
Nov 29 2017, 10:37 PM · KPhotoAlbum
johanneszarl created T7509: Review patch "remove-two-startup-calls.patch" by rlk.
Nov 29 2017, 10:29 PM · KPhotoAlbum
johanneszarl moved T7507: Review Patch "load-remove-images.patch" by rlk from For next release to In Progress on the KPhotoAlbum board.
Nov 29 2017, 10:29 PM · KPhotoAlbum
johanneszarl created T7508: Review patch "dont-save-unnecessary-info" by rlk.
Nov 29 2017, 10:28 PM · KPhotoAlbum
johanneszarl moved T7507: Review Patch "load-remove-images.patch" by rlk from Backlog to For next release on the KPhotoAlbum board.
Nov 29 2017, 10:26 PM · KPhotoAlbum
johanneszarl created T7507: Review Patch "load-remove-images.patch" by rlk.
Nov 29 2017, 10:26 PM · KPhotoAlbum

Nov 17 2017

tleupold added a watcher for KPhotoAlbum: tleupold.
Nov 17 2017, 12:33 PM

Nov 16 2017

johanneszarl edited Description on KPhotoAlbum.
Nov 16 2017, 9:05 PM
johanneszarl edited Description on KPhotoAlbum.
Nov 16 2017, 8:43 PM
johanneszarl moved T7460: Customize project-page for kphotoalbum from Backlog to In Progress on the KPhotoAlbum board.
Nov 16 2017, 8:08 PM · KPhotoAlbum
johanneszarl created T7460: Customize project-page for kphotoalbum.
Nov 16 2017, 8:08 PM · KPhotoAlbum
johanneszarl edited Description on KPhotoAlbum.
Nov 16 2017, 7:47 PM
johanneszarl set the image for KPhotoAlbum to F5494419: profile.
Nov 16 2017, 6:20 PM
bcooksley created KPhotoAlbum.
Nov 16 2017, 7:03 AM